]> Pileus Git - ~andy/linux/commit
checkpatch: more comprehensive split strings warning
authorJoe Perches <joe@perches.com>
Thu, 23 Jan 2014 23:54:40 +0000 (15:54 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 24 Jan 2014 00:36:57 +0000 (16:36 -0800)
commit8c5fcd24a9ea608286816a1508c067c8a512af78
tree6d6e2e1af8034d0ccd22b7eb1370a06bf1783458
parentcf0744021c5d5de54d2c66e2020c6de2fe800264
checkpatch: more comprehensive split strings warning

The current checkpatch test for split strings does not find several
cases that should be found.

For instance:

  /* Else poor success; go back to mode in "active" table */
  } else {
  IWL_DEBUG_RATE(mvm,
-        "LQ: GOING BACK TO THE OLD TABLE suc=%d cur-tpt=%d old-tpt=%d\n",
+        "GOING BACK TO THE OLD TABLE: SR %d "
+        "cur-tpt %d old-tpt %d\n",
         window->success_ratio,
         window->average_tpt,
        lq_sta->last_tpt);

does not currently emit a warning.

Improve the test to find these cases.

Add more exceptions to reduce false positives for assembly and octal/hex
string constants.

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
scripts/checkpatch.pl