]> Pileus Git - ~andy/linux/commit
ath5k: fix regression in tx status processing
authorFelix Fietkau <nbd@openwrt.org>
Mon, 14 Oct 2013 19:18:48 +0000 (21:18 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 18 Oct 2013 17:41:11 +0000 (13:41 -0400)
commit7ede612fd615abcda0cc30e5bef2a70f4cf4f75c
tree7ce5cb444b4da536727c70d6bd5fc1b77275bcf8
parent334300f247abc4f21124ff3ac192df5222ea79bf
ath5k: fix regression in tx status processing

The regression was introduced in the following commit:

0967e01e8e713ed2982fb4eba8ba13794e9a6e89
"ath5k: make use of the new rate control API"

ath5k_tx_frame_completed saves the intended per-rate retry counts before
they are cleared by ieee80211_tx_info_clear_status, however at this
point the information in info->status.rates is incomplete.

This causes significant throughput degradation and excessive packet loss
on links where high bit rates don't work properly.

Move the copy from bf->rates a few lines up to ensure that the saved
retry counts are updated, and that they are really cleared in
info->status.rates after the call to ieee80211_tx_info_clear_status.

Cc: stable@vger.kernel.org # 3.10+
Cc: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Cc: Benjamin Vahl <bvahl@net.t-labs.tu-berlin.de>
Reported-by: Ben West <ben@gowasabi.net>
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Acked-by: Thomas Huehn <thomas@net.t-labs.tu-berlin.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath5k/base.c