]> Pileus Git - ~andy/linux/commit
powerpc: Fix alignment of secondary cpu spin vars
authorOlof Johansson <olof@lixom.net>
Sat, 28 Dec 2013 21:01:47 +0000 (13:01 -0800)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Mon, 30 Dec 2013 03:02:34 +0000 (14:02 +1100)
commit7d4151b5098fb0bf7f6f8d1156e1ab9d83260580
treed13ce35204de1c6e7ac6ce4d1825f0fbfd8ad390
parent286e4f90a72c0b0621dde0294af6ed4b0baddabb
powerpc: Fix alignment of secondary cpu spin vars

Commit 5c0484e25ec0 ('powerpc: Endian safe trampoline') resulted in
losing proper alignment of the spinlock variables used when booting
secondary CPUs, causing some quite odd issues with failing to boot on
PA Semi-based systems.

This showed itself on ppc64_defconfig, but not on pasemi_defconfig,
so it had gone unnoticed when I initially tested the LE patch set.

Fix is to add explicit alignment instead of relying on good luck. :)

[ It appears that there is a different issue with PA Semi systems
  however this fix is definitely correct so applying anyway -- BenH
]

Fixes: 5c0484e25ec0 ('powerpc: Endian safe trampoline')
Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=67811
Signed-off-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/head_64.S