]> Pileus Git - ~andy/linux/commit
tg3: 5715 does not link up when autoneg off
authorNithin Sujir <nsujir@broadcom.com>
Tue, 12 Mar 2013 15:32:48 +0000 (15:32 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Mar 2013 13:54:05 +0000 (09:54 -0400)
commit7c6cdead7cc9a99650d15497aae47d7472217eb1
tree38362391265043629b5bc626ec6ceb08dbea923e
parent6f08158de9e5a15a2f2b25ed651b5120a2ec7b5b
tg3: 5715 does not link up when autoneg off

Commit d13ba512cbba7de5d55d7a3b2aae7d83c8921457 ("tg3: Remove
SPEED_UNKNOWN checks") cleaned up the autoneg advertisement by
removing some dead code. One effect of this change was that the
advertisement register would not be updated if autoneg is turned off.

This exposed a bug on the 5715 device w.r.t linking. The 5715 defaults
to advertise only 10Mb Full duplex. But with autoneg disabled, it needs
the configured speed enabled in the advertisement register to link up.

This patch adds the work around to advertise all speeds on the 5715 when
autoneg is disabled.

Reported-by: Marcin Miotk <marcinmiotk81@gmail.com>
Reviewed-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c