]> Pileus Git - ~andy/linux/commit
tcp: remove invalid __rcu annotation
authorEric Dumazet <edumazet@google.com>
Tue, 25 Jun 2013 08:21:06 +0000 (01:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Jun 2013 09:44:05 +0000 (02:44 -0700)
commit7ae8639c9d6d5aba7990b4fad3506ff7b4667a45
treee48b9fbaac8312e53bb49a7bd0f4c41020ec3f3e
parente4fc408e0e99fd2e009c8b3702d9637f5554fd5c
tcp: remove invalid __rcu annotation

struct tcp_fastopen_context has a field named tfm, which is a pointer
to a crypto_cipher structure.

It currently has a __rcu annotation, which is not needed at all.

tcp_fastopen_ctx is the pointer fetched by rcu_dereference(), but once
we have a pointer to current tcp_fastopen_context, we do not use/need
rcu_dereference() to access tfm.

This fixes a lot of sparse errors like the following :

net/ipv4/tcp_fastopen.c:21:31: warning: incorrect type in argument 1 (different address spaces)
net/ipv4/tcp_fastopen.c:21:31:    expected struct crypto_cipher *tfm
net/ipv4/tcp_fastopen.c:21:31:    got struct crypto_cipher [noderef] <asn:4>*tfm

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jerry Chu <hkchu@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/tcp.h