]> Pileus Git - ~andy/linux/commit
time: Improve sanity checking of timekeeping inputs
authorJohn Stultz <john.stultz@linaro.org>
Wed, 8 Aug 2012 19:36:20 +0000 (15:36 -0400)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 15 Aug 2012 13:54:01 +0000 (15:54 +0200)
commit4e8b14526ca7fb046a81c94002c1c43b6fdf0e9b
treed0681e8e99fe2fbae1bfa574a8a68320ae5c7c1f
parent3bf671af14d591ede9251acb0085e8017f3705e7
time: Improve sanity checking of timekeeping inputs

Unexpected behavior could occur if the time is set to a value large
enough to overflow a 64bit ktime_t (which is something larger then the
year 2262).

Also unexpected behavior could occur if large negative offsets are
injected via adjtimex.

So this patch improves the sanity check timekeeping inputs by
improving the timespec_valid() check, and then makes better use of
timespec_valid() to make sure we don't set the time to an invalid
negative value or one that overflows ktime_t.

Note: This does not protect from setting the time close to overflowing
ktime_t and then letting natural accumulation cause the overflow.

Reported-by: CAI Qian <caiqian@redhat.com>
Reported-by: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Zhouping Liu <zliu@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1344454580-17031-1-git-send-email-john.stultz@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
include/linux/ktime.h
include/linux/time.h
kernel/time/timekeeping.c