]> Pileus Git - ~andy/linux/commit
nilfs2: fix issue with counting number of bio requests for BIO_EOPNOTSUPP error detection
authorVyacheslav Dubeyko <slava@dubeyko.com>
Thu, 22 Aug 2013 23:35:45 +0000 (16:35 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 23 Aug 2013 16:51:22 +0000 (09:51 -0700)
commit4bf93b50fd04118ac7f33a3c2b8a0a1f9fa80bc9
tree46da4b4982c9b6cca343b25c3869bf93a23cbed7
parent2df37a19c686c2d7c4e9b4ce1505b5141e3e5552
nilfs2: fix issue with counting number of bio requests for BIO_EOPNOTSUPP error detection

Fix the issue with improper counting number of flying bio requests for
BIO_EOPNOTSUPP error detection case.

The sb_nbio must be incremented exactly the same number of times as
complete() function was called (or will be called) because
nilfs_segbuf_wait() will call wail_for_completion() for the number of
times set to sb_nbio:

  do {
      wait_for_completion(&segbuf->sb_bio_event);
  } while (--segbuf->sb_nbio > 0);

Two functions complete() and wait_for_completion() must be called the
same number of times for the same sb_bio_event.  Otherwise,
wait_for_completion() will hang or leak.

Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Tested-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nilfs2/segbuf.c