]> Pileus Git - ~andy/linux/commit
projects / ~andy / linux / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d038880) | patch
dell-laptop: Don't set sw_state from the query callback
authorHans de Goede <hdegoede@redhat.com>
Sun, 17 Nov 2013 13:00:20 +0000 (14:00 +0100)
committerMatthew Garrett <matthew.garrett@nebula.com>
Wed, 20 Nov 2013 23:50:48 +0000 (18:50 -0500)
commit33f9359abb9f6ded3e7b6dc98b1468c83404af49
tree44a4f50491278c06965e4f26b2731aba4d31e949tree | snapshot
parentd038880efd9dd222c67fd31fbfca3440d0db3a06commit | diff
dell-laptop: Don't set sw_state from the query callback

The query callback should only update the hw_state, see the comment in
net/rfkill/core.c in rfkill_set_block, which is its only caller.

rfkill_set_block will modify the sw_state directly after calling query so
calling set_sw_state is an expensive NOP.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
drivers/platform/x86/dell-laptop.c diff | blob | history
Andy's Linux Kernel repo