]> Pileus Git - ~andy/linux/commit
[media] drivers/media/dvb-frontends/lg2160.c: Removes useless kfree()
authorPeter Senna Tschudin <peter.senna@gmail.com>
Wed, 12 Sep 2012 11:56:03 +0000 (08:56 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 6 Oct 2012 14:11:42 +0000 (11:11 -0300)
commit1a5d2da1134c4d7371db71377815aa3fff9f75cd
tree35d842ad8fd4b1dc0747f1e89579d710968fe988
parent3f037426d61027d40063a1fc2d00a08154c7c187
[media] drivers/media/dvb-frontends/lg2160.c: Removes useless kfree()

Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@
if (x@p1 == NULL) { ... when != I(x,...) S
                        when != e = e1
                        when != e += e1
                        when != e -= e1
                        when != ++e
                        when != --e
                        when != e++
                        when != e--
                        when != &e
   kfree@p2(x); ... return ...; }
@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@
... when != true x@p1 == NULL
kfree@p2(x);
@depends on !ok && unchanged@
position r.p2;
expression x;
@@
*kfree@p2(x);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb-frontends/lg2160.c