]> Pileus Git - ~andy/linux/commit
rbd: protect against duplicate client creation
authorAlex Elder <elder@inktank.com>
Wed, 29 May 2013 16:19:00 +0000 (11:19 -0500)
committerSage Weil <sage@inktank.com>
Wed, 3 Jul 2013 22:32:39 +0000 (15:32 -0700)
commit08f75463c15e26e9d67a7c992ce7dd8964c6cbdd
treeb1ec2df4acc47286381aa0085eeb5c76f03e628d
parent3b5cf2a2f1746a253d56f54ffbb45170c90b1cbd
rbd: protect against duplicate client creation

If more than one rbd image has the same ceph cluster configuration
(same options, same set of monitors, same keys) they normally share
a single rbd client.

When an image is getting mapped, rbd looks to see if an existing
client can be used, and creates a new one if not.

The lookup and creation are not done under a common lock though, so
mapping two images concurrently could lead to duplicate clients
getting set up needlessly.  This isn't a major problem, but it's
wasteful and different from what's intended.

This patch fixes that by using the control mutex to protect
both the lookup and (if needed) creation of the client.  It
was previously used just when creating.

This resolves:
    http://tracker.ceph.com/issues/3094

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
drivers/block/rbd.c