]> Pileus Git - ~andy/linux/commit
tcp: fix incorrect ca_state in tail loss probe
authorYuchung Cheng <ycheng@google.com>
Sat, 12 Oct 2013 17:16:27 +0000 (10:16 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Oct 2013 19:41:02 +0000 (15:41 -0400)
commit031afe4990a7c9dbff41a3a742c44d3e740ea0a1
treefaf4f3bcc4b2e99d57f18990da44b97d0795939f
parent09b69024d97356fb660d1162e172ed4f1be7ceae
tcp: fix incorrect ca_state in tail loss probe

On receiving an ACK that covers the loss probe sequence, TLP
immediately sets the congestion state to Open, even though some packets
are not recovered and retransmisssion are on the way.  The later ACks
may trigger a WARN_ON check in step D of tcp_fastretrans_alert(), e.g.,
https://bugzilla.redhat.com/show_bug.cgi?id=989251

The fix is to follow the similar procedure in recovery by calling
tcp_try_keep_open(). The sender switches to Open state if no packets
are retransmissted. Otherwise it goes to Disorder and let subsequent
ACKs move the state to Recovery or Open.

Reported-By: Michael Sterrett <michael@sterretts.net>
Tested-By: Dormando <dormando@rydia.net>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c