]> Pileus Git - ~andy/linux/commit
kvm: optimize out smp_mb after srcu_read_unlock
authorMichael S. Tsirkin <mst@redhat.com>
Mon, 4 Nov 2013 20:36:25 +0000 (22:36 +0200)
committerGleb Natapov <gleb@redhat.com>
Wed, 6 Nov 2013 07:32:31 +0000 (09:32 +0200)
commit01b71917b55d28c09ade9fb8c683cf0d2aad1858
tree5ec0842876cd80c754c486dac1a810850d98ecd6
parentce332f662deb545c8a4f3f58debcca26bb2e44b0
kvm: optimize out smp_mb after srcu_read_unlock

I noticed that srcu_read_lock/unlock both have a memory barrier,
so just by moving srcu_read_unlock earlier we can get rid of
one call to smp_mb() using smp_mb__after_srcu_read_unlock instead.

Unsurprisingly, the gain is small but measureable using the unit test
microbenchmark:
before
        vmcall in the ballpark of 1410 cycles
after
        vmcall in the ballpark of 1360 cycles

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
arch/x86/kvm/x86.c