From 5854707bd97fa9b5206353a98dbcfa4b578c4604 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Tue, 13 Apr 2004 19:22:35 +0000 Subject: [PATCH] Document possible accelerator gotcha when using this function. (#139641, 2004-04-13 Matthias Clasen * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document possible accelerator gotcha when using this function. (#139641, Christian Persch) --- ChangeLog | 4 ++++ ChangeLog.pre-2-10 | 4 ++++ ChangeLog.pre-2-4 | 4 ++++ ChangeLog.pre-2-6 | 4 ++++ ChangeLog.pre-2-8 | 4 ++++ gtk/gtkactiongroup.c | 7 ++++++- 6 files changed, 26 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 568d5b601..b6c801da2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2004-04-13 Matthias Clasen + * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document + possible accelerator gotcha when using this function. (#139641, + Christian Persch) + * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak list nodes. (#138862, Morten Welinder) diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 568d5b601..b6c801da2 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,5 +1,9 @@ 2004-04-13 Matthias Clasen + * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document + possible accelerator gotcha when using this function. (#139641, + Christian Persch) + * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak list nodes. (#138862, Morten Welinder) diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index 568d5b601..b6c801da2 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,5 +1,9 @@ 2004-04-13 Matthias Clasen + * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document + possible accelerator gotcha when using this function. (#139641, + Christian Persch) + * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak list nodes. (#138862, Morten Welinder) diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 568d5b601..b6c801da2 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,5 +1,9 @@ 2004-04-13 Matthias Clasen + * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document + possible accelerator gotcha when using this function. (#139641, + Christian Persch) + * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak list nodes. (#138862, Morten Welinder) diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 568d5b601..b6c801da2 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,5 +1,9 @@ 2004-04-13 Matthias Clasen + * gtk/gtkactiongroup.c (gtk_action_group_add_action): Document + possible accelerator gotcha when using this function. (#139641, + Christian Persch) + * gtk/gtkuimanager.c (node_remove_ui_reference): Don't leak list nodes. (#138862, Morten Welinder) diff --git a/gtk/gtkactiongroup.c b/gtk/gtkactiongroup.c index 67cc65247..a9318b0db 100644 --- a/gtk/gtkactiongroup.c +++ b/gtk/gtkactiongroup.c @@ -525,7 +525,12 @@ gtk_action_group_get_action (GtkActionGroup *action_group, * @action_group: the action group * @action: an action * - * Adds an action object to the action group. + * Adds an action object to the action group. Note that this function + * does not set up the accel path of the action, which can lead to problems + * if a user tries to modify the accelerator of a menuitem associated with + * the action. Therefore you must either set the accel path yourself with + * gtk_action_set_accel_path(), or use + * gtk_action_group_add_action_with_accel (..., NULL). * * Since: 2.4 */ -- 2.43.2