]> Pileus Git - ~andy/gtk/log
~andy/gtk
14 years agoMerge branch 'master' into toolpalette
Johannes Schmid [Wed, 28 Oct 2009 09:57:46 +0000 (10:57 +0100)]
Merge branch 'master' into toolpalette

14 years agoUse standard mac shortcuts: add gtk/gtkrc.key.mac
Yevgen Muntyan [Tue, 27 Oct 2009 23:43:08 +0000 (00:43 +0100)]
Use standard mac shortcuts: add gtk/gtkrc.key.mac

This completes commit 3c510f028f9a399c80851d2cb8c230e930abd4ff

https://bugzilla.gnome.org/show_bug.cgi?id=530351

14 years agoDeprecate functions according to deprecated GtkButton signals
Christian Dywan [Tue, 27 Oct 2009 21:39:30 +0000 (22:39 +0100)]
Deprecate functions according to deprecated GtkButton signals

https://bugzilla.gnome.org/show_bug.cgi?id=599218

14 years agoDon't use deprecated button signal functions in clist and combo
Christian Dywan [Tue, 27 Oct 2009 21:38:46 +0000 (22:38 +0100)]
Don't use deprecated button signal functions in clist and combo

14 years agoDon't use deprecated button signal functions in Gail
Christian Dywan [Tue, 27 Oct 2009 21:37:57 +0000 (22:37 +0100)]
Don't use deprecated button signal functions in Gail

14 years agoUpdated Spanish translation
Jorge González [Tue, 27 Oct 2009 20:40:12 +0000 (21:40 +0100)]
Updated Spanish translation

14 years agoDon't use structure fields of GtkAccelMap in GtkSocket
Christian Dywan [Tue, 27 Oct 2009 20:27:28 +0000 (21:27 +0100)]
Don't use structure fields of GtkAccelMap in GtkSocket

https://bugzilla.gnome.org/show_bug.cgi?id=599403

14 years agoAllow removing all closures with gtk_accel_group_disconnect
Christian Dywan [Tue, 27 Oct 2009 20:25:56 +0000 (21:25 +0100)]
Allow removing all closures with gtk_accel_group_disconnect

https://bugzilla.gnome.org/show_bug.cgi?id=599403

14 years agoDon't assign a GtkPageOrientation to a boolean value
Marek Kasik [Tue, 27 Oct 2009 16:35:37 +0000 (17:35 +0100)]
Don't assign a GtkPageOrientation to a boolean value

GtkPrintOperationPrivate->orientation is a boolean value.

14 years agoRotate number-up layout according to orientation when printing
Marek Kasik [Tue, 27 Oct 2009 15:53:43 +0000 (16:53 +0100)]
Rotate number-up layout according to orientation when printing

Number-up layout has to be rotated differently since rotation in
"landscape" and "reversed landscape" mode was changed.

14 years agoTake printer margins into account on Windows
Adrian Johnson [Mon, 26 Oct 2009 09:09:16 +0000 (11:09 +0200)]
Take printer margins into account on Windows

Fixes bug #381371.

14 years agoOnly set the accesible label if it is non-empty
Christian Dywan [Mon, 26 Oct 2009 23:30:54 +0000 (00:30 +0100)]
Only set the accesible label if it is non-empty

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=599446

14 years agoUse G_STRLOC instead __FILE__ and __LINE__
Javier Jardón [Mon, 26 Oct 2009 21:51:41 +0000 (22:51 +0100)]
Use G_STRLOC instead __FILE__ and __LINE__

14 years agogtk_init_with_args() arguments should be const gchar*
Nick Schermer [Mon, 26 Oct 2009 21:27:03 +0000 (22:27 +0100)]
gtk_init_with_args() arguments should be const gchar*

The translation_domain argument should be const gchar * to allow compilation
with -Wwrite-strings. It only passes the argument to
g_option_context_add_main_entries() which is already const gchar*.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=583305

14 years agoUpdated Romanian translation
Dumitru Mișu Moldovan [Mon, 26 Oct 2009 20:54:59 +0000 (22:54 +0200)]
Updated Romanian translation

14 years agoUse G_STRFUNC and G_STRLOC instead __FUNCTION__ and __FILE__
Javier Jardón [Wed, 21 Oct 2009 21:02:29 +0000 (23:02 +0200)]
Use G_STRFUNC and G_STRLOC instead __FUNCTION__ and __FILE__

14 years agoUse G_STRFUNC instead __FUNCTION__
Javier Jardón [Wed, 21 Oct 2009 20:47:05 +0000 (22:47 +0200)]
Use G_STRFUNC instead __FUNCTION__

14 years agoUse G_STRLOC instead __LINE__
Javier Jardón [Wed, 21 Oct 2009 21:25:56 +0000 (23:25 +0200)]
Use G_STRLOC instead __LINE__

14 years agoUse G_STRFUNC instead __FUNCTION__
Javier Jardón [Wed, 21 Oct 2009 20:35:12 +0000 (22:35 +0200)]
Use G_STRFUNC instead __FUNCTION__

14 years agoShow correct print preview
Marek Kasik [Mon, 26 Oct 2009 16:47:37 +0000 (17:47 +0100)]
Show correct print preview

Modify print preview according to settings from print dialog.
Similar approach as during real print is applied to the preview
process (#592582).

14 years agoCast to gchar* to fix a compilation warning
Javier Jardón [Sun, 25 Oct 2009 21:47:17 +0000 (22:47 +0100)]
Cast to gchar* to fix a compilation warning

14 years agoUpdate copyright
Kristian Rietveld [Mon, 26 Oct 2009 08:57:11 +0000 (09:57 +0100)]
Update copyright

14 years agoUpdate position of toplevels after display reconfiguration
Kristian Rietveld [Mon, 26 Oct 2009 08:20:28 +0000 (09:20 +0100)]
Update position of toplevels after display reconfiguration

We have to do this, especially after the screen containing the menubar
has changed.  Such more larger changes in monitor geometry will cause
changes to how monitors are laid out in the root window.  The position
coordinates of the windows will have to be updated to reflect their
position in the new layout.

14 years agoFixup get_nsscreen_for_x()
Kristian Rietveld [Mon, 26 Oct 2009 07:58:12 +0000 (08:58 +0100)]
Fixup get_nsscreen_for_x()

14 years agoRemove unused variable (fix compiler warning)
Kristian Rietveld [Mon, 26 Oct 2009 07:53:52 +0000 (08:53 +0100)]
Remove unused variable (fix compiler warning)

14 years agoUpdate size of root window after display reconfiguration
Kristian Rietveld [Mon, 26 Oct 2009 07:53:20 +0000 (08:53 +0100)]
Update size of root window after display reconfiguration

14 years agoSupport arbitrary screen layouts
Kristian Rietveld [Mon, 26 Oct 2009 07:42:15 +0000 (08:42 +0100)]
Support arbitrary screen layouts

The Quartz port now supports arbitrary multiple monitor layouts instead
of only monitors are were laid out horizontally.  This builds on the
reworked coordinate translation done in a previous commit.

14 years agoRework coordinate transformation to be based on root window
Kristian Rietveld [Sun, 25 Oct 2009 20:36:56 +0000 (21:36 +0100)]
Rework coordinate transformation to be based on root window

The root window contains all the monitors attached to a Mac.  The
coordinate transformation now both translates the x and y coordinate,
translating it from the Cocoa monitor coordinate space to the GDK
coordinate space.  How monitors are laid out in the root window differs
between Cocoa and GDK, which is why it is important to translate based
on the root window to get multi monitor setups to work properly.

We have replaced the old y coordinate transformation function with
new functions that translate both the x and y coordinate.

When creating new toplevels, we have to determine the Cocoa screen on
which the toplevel should appear and translate the coordinates according
to that screen.

This change also fixes event handling in case there is a monitor left
of the screen containing the menu bar.  In such a case all coordinates
on the left monitor are negative.  Event handling broke, because of
_gdk_quartz_window_find_child() checking bounds.  Now that coordinates
are always properly translated to GDK coordinate space, in which negative
coordinates do never occur, the checks here will work properly.

14 years agoBe consistent with X11: emit monitors-changed first, then size-changed
Kristian Rietveld [Sat, 24 Oct 2009 12:53:28 +0000 (14:53 +0200)]
Be consistent with X11: emit monitors-changed first, then size-changed

14 years agoUpdate documentation for ::monitors-changed to mention OS X support
Kristian Rietveld [Sat, 24 Oct 2009 10:26:46 +0000 (12:26 +0200)]
Update documentation for ::monitors-changed to mention OS X support

14 years agoUse screen when emitting signal, not _gdk_screen
Kristian Rietveld [Sat, 24 Oct 2009 10:25:55 +0000 (12:25 +0200)]
Use screen when emitting signal, not _gdk_screen

14 years agoEmit monitors-changed signal when appropriate
Kristian Rietveld [Sat, 24 Oct 2009 10:25:29 +0000 (12:25 +0200)]
Emit monitors-changed signal when appropriate

14 years agoMove screen resolution setup to GdkScreenQuartz initializer
Kristian Rietveld [Sat, 24 Oct 2009 09:51:51 +0000 (11:51 +0200)]
Move screen resolution setup to GdkScreenQuartz initializer

14 years agoCreate a proper subclass of GdkScreen: GdkScreenQuartz
Kristian Rietveld [Sat, 24 Oct 2009 09:48:39 +0000 (11:48 +0200)]
Create a proper subclass of GdkScreen: GdkScreenQuartz

14 years agoRegister and handle a display reconfiguration callback
Kristian Rietveld [Sat, 24 Oct 2009 08:29:43 +0000 (10:29 +0200)]
Register and handle a display reconfiguration callback

Using this we can update our internal monitor/screen layout state
and emit the GdkScreen::size-changed signal.  Work has not
completely finished on this yet, see bug 596238.

14 years agoSetup monitor rects during screen initialization and re-use data
Kristian Rietveld [Mon, 12 Oct 2009 07:55:45 +0000 (09:55 +0200)]
Setup monitor rects during screen initialization and re-use data

14 years agoMove screen initialization to gdkscreen-quartz.c
Kristian Rietveld [Wed, 7 Oct 2009 16:54:47 +0000 (18:54 +0200)]
Move screen initialization to gdkscreen-quartz.c

14 years agoFix issues with symbolic colors in rc file parsing
Matthias Clasen [Mon, 26 Oct 2009 03:47:59 +0000 (23:47 -0400)]
Fix issues with symbolic colors in rc file parsing

Don't recreate the settings color hash every time, repopulate it
instead. This avoids invalidating the references held by RcContexts.

14 years agoFixes for the compose-parse.py script
Matthias Clasen [Mon, 26 Oct 2009 03:46:27 +0000 (23:46 -0400)]
Fixes for the compose-parse.py script

Several fixes by Ray Strode and Peter Hutterer to make compose-parse.py
work with the current X.org Compose file.

14 years agoUpdate compose sequences
Matthias Clasen [Mon, 26 Oct 2009 03:42:58 +0000 (23:42 -0400)]
Update compose sequences

This patch includes additions to the X.org Compose file from the
last year. Patch by Peter Hutterer

14 years agoGdkPixbuf loader for QTIF format
Kevin Peng [Sun, 25 Oct 2009 21:03:19 +0000 (22:03 +0100)]
GdkPixbuf loader for QTIF format

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=366217

14 years agoUse standard mac shortcuts
Yevgen Muntyan [Sun, 25 Oct 2009 22:46:19 +0000 (23:46 +0100)]
Use standard mac shortcuts

This changes Ctrl-X, Ctrl-C, etc. to Cmd-X, Cmd-C, etc. Also,
Alt-Left and Alt-Right in text widgets bound to Ctrl-Left and
Ctrl-Right actions

https://bugzilla.gnome.org/show_bug.cgi?id=530351

14 years agoCast to gchar* to fix a compilation warning
Javier Jardón [Sat, 24 Oct 2009 15:09:01 +0000 (17:09 +0200)]
Cast to gchar* to fix a compilation warning

14 years agoFix for position bug
Michael Emmel [Sat, 24 Oct 2009 15:17:06 +0000 (17:17 +0200)]
Fix for position bug

https://bugzilla.gnome.org/show_bug.cgi?id=590800

14 years agoBug 581150 - GtkIconView tries to paint items with invalid sizes
Matthew Barnes [Fri, 23 Oct 2009 23:32:25 +0000 (19:32 -0400)]
Bug 581150 - GtkIconView tries to paint items with invalid sizes

Run gtk_icon_view_layout() if necessary before attempting to paint the
icon view items during an expose event.  This ensures all the items have
valid sizes, as some themes don't take kindly to negative dimensions.

14 years agoBug 598881 - Unimplemented GdkWindowImplIface methods crash gimp on OSX
Kristian Rietveld [Fri, 23 Oct 2009 11:53:57 +0000 (13:53 +0200)]
Bug 598881 - Unimplemented GdkWindowImplIface methods crash gimp on OSX

Add dummy for _gdk_input_window_crossing ().  Set both input_window_destroy
and input_window_crossing pointers in the Impl struct.

Reported by John Ralls.

14 years agoUse correct type text/uri-list for the dropped files selection
Tor Lillqvist [Fri, 23 Oct 2009 10:40:27 +0000 (13:40 +0300)]
Use correct type text/uri-list for the dropped files selection

Fixes bug #599321.

14 years agoCast to gchar* to fix a compilation warning
Javier Jardón [Wed, 21 Oct 2009 22:00:52 +0000 (00:00 +0200)]
Cast to gchar* to fix a compilation warning

14 years agoCast to fix compilation warning
Javier Jardón [Wed, 21 Oct 2009 21:53:01 +0000 (23:53 +0200)]
Cast to fix compilation warning

14 years agoAdd translators comments for tab labels (closes 599118)
Luca Ferretti [Wed, 21 Oct 2009 20:06:14 +0000 (22:06 +0200)]
Add translators comments for tab labels (closes 599118)

14 years agoMinor fixes
Luca Ferretti [Wed, 21 Oct 2009 19:47:06 +0000 (21:47 +0200)]
Minor fixes

14 years agoUse G_STRLOC instead __FILE__ and __LINE__
Javier Jardon [Wed, 21 Oct 2009 18:46:44 +0000 (21:46 +0300)]
Use G_STRLOC instead __FILE__ and __LINE__

Patch from bug #599225

14 years agoAdd single-include guard and reduce includes to what's needed
Michael Natterer [Wed, 21 Oct 2009 18:21:20 +0000 (20:21 +0200)]
Add single-include guard and reduce includes to what's needed

14 years agoDon't allow to include this new header individually
Michael Natterer [Wed, 21 Oct 2009 18:20:54 +0000 (20:20 +0200)]
Don't allow to include this new header individually

14 years agoFix a compilation warning: use NULL instead ""
Javier Jardón [Wed, 21 Oct 2009 17:41:50 +0000 (19:41 +0200)]
Fix a compilation warning: use NULL instead ""

14 years agoRemove unused function
Javier Jardón [Wed, 21 Oct 2009 03:33:58 +0000 (05:33 +0200)]
Remove unused function

14 years agoFix compilation warnings: use G_GSIZE_FORMAT instead %i
Javier Jardón [Wed, 21 Oct 2009 03:19:39 +0000 (05:19 +0200)]
Fix compilation warnings: use G_GSIZE_FORMAT instead %i

14 years agobgo#563010 - Fix clearing the selection in GtkFileChooserButton
Federico Mena Quintero [Wed, 21 Oct 2009 17:29:03 +0000 (12:29 -0500)]
bgo#563010 - Fix clearing the selection in GtkFileChooserButton

Previously the filename would get re-set on the button if one cleared the selection,
as an async cancellable was not getting canceled in that case.

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoAdded editing_canceled property to GtkCellEditable
Cody Russell [Wed, 21 Oct 2009 16:40:19 +0000 (18:40 +0200)]
Added editing_canceled property to GtkCellEditable

GTK_ENTRY()->editing_canceled should really have been a parameter of the
GtkCellEditable::editing-done signal, it should be a property on the cell
editable interface

https://bugzilla.gnome.org/show_bug.cgi?id=594962

14 years agoDeprecated GtkNotebook tab packing
Christian Dywan [Wed, 21 Oct 2009 16:25:02 +0000 (18:25 +0200)]
Deprecated GtkNotebook tab packing

https://bugzilla.gnome.org/show_bug.cgi?id=596083

14 years agoDeprecate GtkCurve and GtkGammaCurve
Christian Dywan [Wed, 21 Oct 2009 16:15:52 +0000 (18:15 +0200)]
Deprecate GtkCurve and GtkGammaCurve

https://bugzilla.gnome.org/show_bug.cgi?id=556263

14 years agoAdded accesor for GTK_VIEWPORT (widget)->bin_window
Christian Dywan [Wed, 21 Oct 2009 16:12:01 +0000 (18:12 +0200)]
Added accesor for GTK_VIEWPORT (widget)->bin_window

Although, you can use:
gtk_widget_get_parent_window (gtk_bin_get_child (GTK_BIN (widget)))
there already are gtk_tree_view_get_bin_window() and
gtk_layout_get_bin_window() in GTK+ api.

https://bugzilla.gnome.org/show_bug.cgi?id=594960

14 years agoFix a compilation warning
Javier Jardón [Wed, 21 Oct 2009 00:55:46 +0000 (02:55 +0200)]
Fix a compilation warning

Use switch instead if's to get a default value

14 years agoFix a compilation warning
Javier Jardón [Tue, 20 Oct 2009 02:08:00 +0000 (04:08 +0200)]
Fix a compilation warning

Reorder the function so the "lookup_context" variable can't be
used uninitialized

14 years agoFix some compilation warning
Javier Jardón [Wed, 21 Oct 2009 00:37:05 +0000 (02:37 +0200)]
Fix some compilation warning

Complete the previous patch: set lower to 0 too

14 years agoFix some compilation warning
Javier Jardón [Wed, 21 Oct 2009 00:07:26 +0000 (02:07 +0200)]
Fix some compilation warning

Added some default cases and assert if reached

14 years agoFix a compilation warning
Javier Jardón [Tue, 20 Oct 2009 02:06:05 +0000 (04:06 +0200)]
Fix a compilation warning

Use parenthesis in a expression with "&" operator

14 years agoFix a compilation warning
Javier Jardón [Tue, 20 Oct 2009 18:43:44 +0000 (20:43 +0200)]
Fix a compilation warning

Catch the returned value of write()

14 years agoFix compilation warning
Javier Jardón [Tue, 20 Oct 2009 02:01:52 +0000 (04:01 +0200)]
Fix compilation warning

Use g_get_current_dir() instead getcwd()

14 years agoRemove some unnused variables
Javier Jardón [Tue, 20 Oct 2009 02:00:02 +0000 (04:00 +0200)]
Remove some unnused variables

14 years agoA small correction of previous commit
Marek Kasik [Mon, 19 Oct 2009 09:44:09 +0000 (11:44 +0200)]
A small correction of previous commit

Correct of a typo.

14 years agoCorrect a small oversight
Matthias Clasen [Mon, 19 Oct 2009 00:38:28 +0000 (20:38 -0400)]
Correct a small oversight

When changing themes, we also need to update the box spacing of
tooltips.

14 years agoUse correct size for root window with multiple monitors
Tor Lillqvist [Sun, 18 Oct 2009 11:35:17 +0000 (14:35 +0300)]
Use correct size for root window with multiple monitors

The root window width and height have already been correctly
initialised in _gdk_root_window_size_init() to cover all monitors, so
don't incorrectly re-initialise using GetSystemMetrics(SM_C[XY]SCREEN)
which only gives the size of the primary monitor anyway. (See MSDN.)

This fixes at least gdk_screen_get_{width,height}() which indirectly
affects at least the positioning of combo box pop-up menus on multiple
monitors.

14 years agoDelete a couple of leftover commented-out lines
Tor Lillqvist [Sun, 18 Oct 2009 11:19:55 +0000 (14:19 +0300)]
Delete a couple of leftover commented-out lines

14 years agoAdd missing newline to debugging output
Tor Lillqvist [Sun, 18 Oct 2009 11:19:24 +0000 (14:19 +0300)]
Add missing newline to debugging output

14 years agoDelete unused leftover static function
Tor Lillqvist [Sun, 18 Oct 2009 09:08:18 +0000 (12:08 +0300)]
Delete unused leftover static function

14 years agoMore meaningful debugging output in gdk_win32_window_get_root_coords
Tor Lillqvist [Sun, 18 Oct 2009 09:06:29 +0000 (12:06 +0300)]
More meaningful debugging output in gdk_win32_window_get_root_coords

14 years agoRemove unused variables and static functions
Tor Lillqvist [Sun, 18 Oct 2009 08:51:57 +0000 (11:51 +0300)]
Remove unused variables and static functions

14 years agoCorrect function names in debugging output
Tor Lillqvist [Sun, 18 Oct 2009 08:43:33 +0000 (11:43 +0300)]
Correct function names in debugging output

14 years agoDon't omit GTK_ICON_SIZE_DIALOG
Matthias Clasen [Sun, 18 Oct 2009 06:07:58 +0000 (02:07 -0400)]
Don't omit GTK_ICON_SIZE_DIALOG

14 years agoFix a problem in GtkImage size allocation
Matthias Clasen [Sun, 18 Oct 2009 05:36:14 +0000 (01:36 -0400)]
Fix a problem in GtkImage size allocation

When GtkMisc padding is set on an image, the optimization for only
recalculating size after a clear() breaks, since the requisition is
not (0, 0). We need a separate 'need_calc' flag.

14 years agoUpdated Greek translation
Simos Xenitellis [Sat, 17 Oct 2009 14:30:28 +0000 (17:30 +0300)]
Updated Greek translation

14 years agoUpdated Spanish translation
Jorge González [Sat, 17 Oct 2009 11:45:01 +0000 (13:45 +0200)]
Updated Spanish translation

14 years agoUndefine GTK_DISABLE_DEPRECATED in testinput to keep it compiling
Christian Dywan [Fri, 16 Oct 2009 16:45:53 +0000 (18:45 +0200)]
Undefine GTK_DISABLE_DEPRECATED in testinput to keep it compiling

14 years agoDeprecate GtkInputDialog
Christian Dywan [Fri, 16 Oct 2009 14:05:13 +0000 (16:05 +0200)]
Deprecate GtkInputDialog

Deprecate the widget and adjust the documentation.

https://bugzilla.gnome.org/show_bug.cgi?id=594903

14 years agoFix build on Windows
Tor Lillqvist [Fri, 16 Oct 2009 10:29:54 +0000 (13:29 +0300)]
Fix build on Windows

14 years agoUse G_BEGIN/END_DECLS in gtkcellrendererspinner.h
Debarshi Ray [Thu, 15 Oct 2009 21:22:20 +0000 (00:22 +0300)]
Use G_BEGIN/END_DECLS in gtkcellrendererspinner.h

14 years agoFix thinkos in which fields get used
Federico Mena Quintero [Wed, 30 Sep 2009 23:49:33 +0000 (18:49 -0500)]
Fix thinkos in which fields get used

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoOops, it's gsize, not GSize
Federico Mena Quintero [Wed, 30 Sep 2009 23:39:33 +0000 (18:39 -0500)]
Oops, it's gsize, not GSize

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoFix a g_strdup_printf()
Federico Mena Quintero [Wed, 30 Sep 2009 22:55:12 +0000 (17:55 -0500)]
Fix a g_strdup_printf()

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoPut the list of column types in a macro
Federico Mena Quintero [Fri, 11 Sep 2009 19:28:36 +0000 (14:28 -0500)]
Put the list of column types in a macro

Every call to _gtk_file_system_model_new*() gets the same list of column types,
so we now keep the list in a macro instead of having duplicated copies all around.

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoClarify the arguments of g_file_query_info_async()
Federico Mena Quintero [Fri, 11 Sep 2009 19:20:19 +0000 (14:20 -0500)]
Clarify the arguments of g_file_query_info_async()

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoMake copy_attribute() a function instead of a macro
Federico Mena Quintero [Fri, 11 Sep 2009 18:32:08 +0000 (13:32 -0500)]
Make copy_attribute() a function instead of a macro

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoDon't leak a treepath if the treeview is not populated yet
Federico Mena Quintero [Fri, 11 Sep 2009 18:25:29 +0000 (13:25 -0500)]
Don't leak a treepath if the treeview is not populated yet

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoFactor out function to set a fixed size for the icon cell renderers
Federico Mena Quintero [Fri, 11 Sep 2009 18:14:49 +0000 (13:14 -0500)]
Factor out function to set a fixed size for the icon cell renderers

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoComment that the column order needs to be kept in sync across two functions
Federico Mena Quintero [Fri, 11 Sep 2009 18:08:11 +0000 (13:08 -0500)]
Comment that the column order needs to be kept in sync across two functions

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoFix typo in a comment
Federico Mena Quintero [Fri, 11 Sep 2009 18:03:34 +0000 (13:03 -0500)]
Fix typo in a comment

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoMake get_selected_file() return a ref'ed file
Federico Mena Quintero [Fri, 11 Sep 2009 17:44:21 +0000 (12:44 -0500)]
Make get_selected_file() return a ref'ed file

The old semantics was to return a GFile* owned by the file system model; the new
semantics is to hand out new references whenever possible.

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agoIn set_filter(), handle the case where the new filter is the same as the old filter
Federico Mena Quintero [Thu, 10 Sep 2009 22:22:12 +0000 (17:22 -0500)]
In set_filter(), handle the case where the new filter is the same as the old filter

Signed-off-by: Federico Mena Quintero <federico@novell.com>
14 years agos/get_is_visible/iter_is_visible for clarity
Federico Mena Quintero [Thu, 10 Sep 2009 21:33:37 +0000 (16:33 -0500)]
s/get_is_visible/iter_is_visible for clarity

Signed-off-by: Federico Mena Quintero <federico@novell.com>