Tor Lillqvist [Thu, 21 Feb 2008 12:47:45 +0000 (12:47 +0000)]
Must pass the format string to strftime in the C library's locale's
2008-02-21 Tor Lillqvist <tml@novell.com>
* gtk/gtkfilechooserdefault.c (list_mtime_data_func) [Win32]: Must
pass the format string to strftime in the C library's locale's
charset, not the system's. Correspondingly, the return value from
strftime() is in the C library's locale's charset. (#509885)
Johan Dahlin [Sun, 17 Feb 2008 22:28:55 +0000 (22:28 +0000)]
When converting a stock item based on the label, remove the label
2008-02-17 Johan Dahlin <johan@gnome.org>
* gtk/gtk-builder-convert (GtkBuilderConverter._add_action_from_menuitem):
When converting a stock item based on the label, remove the label property.
(bug #515824, Yuri Pimenov)
Richard Hult [Sun, 17 Feb 2008 10:11:11 +0000 (10:11 +0000)]
Update the position after showing the window since the window manager
2008-02-17 Richard Hult <richard@imendio.com>
* gdk/quartz/GdkQuartzWindow.c: (showAndMakeKey): Update the
position after showing the window since the window manager might
not place it where we requested in the first places.
Richard Hult [Sun, 17 Feb 2008 10:01:52 +0000 (10:01 +0000)]
Clear the toplevel ordering list in all places where the order is
2008-02-17 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkwindow-quartz.c: (show_window_internal),
(_gdk_quartz_window_detach_from_parent),
(_gdk_quartz_window_attach_to_parent), (gdk_window_focus): Clear
the toplevel ordering list in all places where the order is
potentially changed. Fixes mouse focus issues for windows with
a transient parent set.
Richard Hult [Thu, 14 Feb 2008 21:41:59 +0000 (21:41 +0000)]
Make sure we leave fullscreen mode if the window is hidden.
2008-02-14 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkwindow-quartz.c: (get_fullscreen_geometry),
(gdk_window_hide), (gdk_window_fullscreen),
(gdk_window_unfullscreen): Make sure we leave fullscreen mode if
the window is hidden.
Richard Hult [Wed, 13 Feb 2008 14:20:51 +0000 (14:20 +0000)]
Fix the return value (return number of colors that failed), and handle
2008-02-13 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkcolor-quartz.c: (gdk_colormap_alloc_colors): Fix
the return value (return number of colors that failed), and handle
RGBA colormap.
(gdk_colormap_free_colors): Fix typo in comment.
Fix 419737 - don't focus the file list when activating a shortcut in the file chooser
2008-02-12 Federico Mena Quintero <federico@novell.com>
Merged from gtk-2-12:
Don't focus the file list when shortcuts get activated. This
removes a lot of ambiguity in when the file selection should
change, and makes the overall code flow simpler.
This fixes http://bugzilla.gnome.org/show_bug.cgi?id=419737 -
file/save dialog clears the filename entry when changing
directories.
Also fixes http://bugzilla.gnome.org/show_bug.cgi?id=499940 -
focus should not go to the file list when a shortcut is activated.
* gtk/gtkfilechooserdefault.c
(shortcuts_activate_volume_mount_cb): Don't focus the file list
(shortcuts_activate_get_info_cb): Likewise.
* gtk/gtkfilechooserdefault.c (switch_to_shortcut): Don't focus
the file list (this was the last place where we would focus the
file list explicitly). If you are in the location entry, for
example, you don't want Alt-Home to take you to the file list; you
just want the current folder to change. Thanks to Olle Bergkvist
<olle.bergkvist@yahoo.se> for pointing this out in
http://bugzilla.gnome.org/show_bug.cgi?id=419737#c51.
(focus_browse_tree_view_if_possible): Removed.
Signed-off-by: Federico Mena Quintero <federico@gnu.org>
svn path=/trunk/; revision=19543
Matthias Clasen [Tue, 12 Feb 2008 17:34:43 +0000 (17:34 +0000)]
Skip exensions when selecting filenames in the save-as dialog. (#362516,
2008-02-12 Matthias Clasen <mclasen@redhat.com>
Skip exensions when selecting filenames in the save-as dialog.
(#362516, Carlos Garnacho)
* gtk/gtkfilechooserentry.h:
* gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_select_filename):
New function to skip the extension part when selecting a filename.
(_gtk_file_chooser_entry_set_base_folder): Use it here.
Emmanuele Bassi [Tue, 12 Feb 2008 16:38:00 +0000 (16:38 +0000)]
Set the default value of the :show-not-found property to TRUE, as every
2008-02-12 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkrecentchooser.c:
(gtk_recent_chooser_class_init): Set the default value of the
:show-not-found property to TRUE, as every implementation sets
it to TRUE already.
* gtk/gtkrecentchooserdefault.c:
(_gtk_recent_chooser_default_init): Sync show_tips to the
default value of the :show-tips property.
guard against people deleting the row in question in the selection-changed
2008-02-12 Kristian Rietveld <kris@imendio.com>
* gtk/gtktreeview.c (gtk_tree_view_real_select_cursor_row),
(gtk_tree_view_real_toggle_cursor_row): guard against people
deleting the row in question in the selection-changed callback.
(#514621, Andreas Koehler).
Matthias Clasen [Tue, 12 Feb 2008 15:07:38 +0000 (15:07 +0000)]
Use gtk_selection_data_set_uris() instead of doing it by hand. (#514890,
2008-02-12 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserdefault.c (recent_model_sort_drag_data_get):
(recent_model_sort_drag_data_get):
(search_model_sort_drag_data_get):
* gtk/gtkfilesystemmodel.c (drag_source_drag_data_get):
* gtk/gtkpathbar.c (button_drag_data_get_cb):
Use gtk_selection_data_set_uris() instead of doing it
by hand. (#514890, Christian Persch)
Michael Natterer [Tue, 12 Feb 2008 10:02:46 +0000 (10:02 +0000)]
simply use gtk_window_get_key_hash() to get the hash instead of manually
2008-02-12 Michael Natterer <mitch@imendio.com>
* gtk/gtkwindow.c (gtk_window_activate_key): simply use
gtk_window_get_key_hash() to get the hash instead of manually
fiddling with quarks and gtk_window_keys_changed(). Also add
g_return_if_fail() to this public function.
gtk/gtkcellview.c (gtk_cell_view_cell_layout_reorder) plug leak wrt. link
2008-02-11 Kristian Rietveld <kris@imendio.com>
* gtk/gtkcellview.c (gtk_cell_view_cell_layout_reorder)
* gtk/gtkiconview.c (gtk_icon_view_cell_layout_reorder): plug leak
wrt. link deletion from list; contination of fix for #503569.
Cody Russell [Mon, 11 Feb 2008 01:51:14 +0000 (01:51 +0000)]
Check the return value of _gtk_file_chooser_get_file_system () for NULL
2008-02-10 Cody Russell <bratsche@gnome.org>
* gtk/gtkfilechooser.c (gtk_file_chooser_get_current_folder_uri):
Check the return value of _gtk_file_chooser_get_file_system () for
NULL before passing it to gtk_file_system_path_to_uri ().
(#515667, Francesco Montorsi)
Richard Hult [Fri, 8 Feb 2008 19:08:40 +0000 (19:08 +0000)]
Ignore the delta from the NSEvent for now, generating multiple scroll
2008-02-08 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkevents-quartz.c (gdk_event_translate): Ignore the
delta from the NSEvent for now, generating multiple scroll events
results in a lot of events getting queued up and things get really
slow.
Cody Russell [Thu, 7 Feb 2008 19:25:07 +0000 (19:25 +0000)]
gdk/win32/gdkevents-win32.c Fixed two declarations in the middle of a
2008-02-07 Cody Russell <bratsche@gnome.org>
* gdk/win32/gdkevents-win32.c
* gdk/win32/gdkwindow-win32.c: Fixed two declarations in the middle
of a block that were causing compile problems on old
compilers. (#515053, reported by Kazuki IWAMOTO)
If the pixbuf has an alpha channel, use gdk_draw_rgb_32_image to draw it
2008-02-07 Christian Persch <chpe@gnome.org>
* gdk/gdkpixbuf-render.c:
(gdk_pixbuf_render_pixmap_and_mask_for_colormap): If the pixbuf has an
alpha channel, use gdk_draw_rgb_32_image to draw it to the pixmap;
otherwise there will be random pixel values in the semi-transparent
area of the pixbuf within the mask. Bug #487865.
Cody Russell [Wed, 6 Feb 2008 16:32:41 +0000 (16:32 +0000)]
Check if the window is a temp window, otherwise things get wonky when you
2008-02-06 Cody Russell <bratsche@gnome.org>
* gdk/win32/gdkevents-win32.c: Check if the window is a temp window,
otherwise things get wonky when you click on a menu. This fixes
a regression caused in #505928. Thanks to Tor for spotting this
one! (#514789)
Cody Russell [Tue, 5 Feb 2008 23:46:35 +0000 (23:46 +0000)]
Walk down the stack until we get to a window that is mapped. Otherwise
2008-02-05 Cody Russell <bratsche@gnome.org>
* gdk/win32/gdkwindow-win32.c (_gdk_modal_current): Walk
down the stack until we get to a window that is mapped.
Otherwise hiding a window will cause all windows in the app
to be blocked. (#514643)
Matthias Clasen [Tue, 5 Feb 2008 18:35:54 +0000 (18:35 +0000)]
Install a printerr handler that prepends the program name, since
2008-02-05 Matthias Clasen <mclasen@redhat.com>
* gtk/updateiconcache.c: Install a printerr handler that
prepends the program name, since gtk-update-icon-cache output
often appears in the middle of other output, e.g. rpm update logs.
g_return_if_fail() is the cell is not part of the combo instead of
2008-02-04 Michael Natterer <mitch@imendio.com>
* gtk/gtkcombobox.c (gtk_combo_box_cell_layout_add_attribute):
g_return_if_fail() is the cell is not part of the combo instead of
crashing in the next line.
projects / ~andy / gtk / log