]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkbox.c
Minor doc cleanup
[~andy/gtk] / gtk / gtkbox.c
index 84c28de3d69108916542594936b97dd0be624968..5c8e6e3ff839b4132cf1fb09aa1255ffe07320e2 100644 (file)
@@ -12,9 +12,7 @@
  * Lesser General Public License for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with this library; if not, write to the
- * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
- * Boston, MA 02111-1307, USA.
+ * License along with this library. If not, see <http://www.gnu.org/licenses/>.
  */
 
 /*
 
 /**
  * SECTION:gtkbox
- * @Short_description: Base class for box containers
+ * @Short_description: A container box
  * @Title: GtkBox
- * @See_also:i #GtkHBox, #GtkVBox, #GtkFrame, #GtkTable, #GtkLayout
+ * @See_also: #GtkFrame, #GtkGrid, #GtkLayout
  *
- * GtkBox is an widget which encapsulates functionality for a
- * particular kind of container, one that organizes a variable number of
- * widgets into a rectangular area.  GtkBox has a number of derived
- * classes, e.g. #GtkHBox and #GtkVBox.
+ * The GtkBox widget organizes child widgets into a rectangular area.
  *
  * The rectangular area of a GtkBox is organized into either a single row
- * or a single column of child widgets depending upon whether the box is
- * of type #GtkHBox or #GtkVBox, respectively.  Thus, all children of a
- * GtkBox are allocated one dimension in common, which is the height of a
- * row, or the width of a column.
+ * or a single column of child widgets depending upon the orientation.
+ * Thus, all children of a GtkBox are allocated one dimension in common,
+ * which is the height of a row, or the width of a column.
  *
- * GtkBox uses a notion of <emphasis>packing</emphasis>.  Packing
- * refers to adding widgets with reference to a particular position in a
- * #GtkContainer.  For a GtkBox, there are two reference positions: the
+ * GtkBox uses a notion of <emphasis>packing</emphasis>. Packing refers
+ * to adding widgets with reference to a particular position in a
+ * #GtkContainer. For a GtkBox, there are two reference positions: the
  * <emphasis>start</emphasis> and the <emphasis>end</emphasis> of the box.
- * For a #GtkVBox, the start is defined as the top of the box and the end is
- * defined as the bottom.  For a #GtkHBox the start is defined as the
- * left side and the end is defined as the right side.
+ * For a vertical #GtkBox, the start is defined as the top of the box and
+ * the end is defined as the bottom. For a horizontal #GtkBox the start
+ * is defined as the left side and the end is defined as the right side.
  *
  * Use repeated calls to gtk_box_pack_start() to pack widgets into a
- * GtkBox from start to end.  Use gtk_box_pack_end() to add widgets from
- * end to start.  You may intersperse these calls and add widgets from
+ * GtkBox from start to end. Use gtk_box_pack_end() to add widgets from
+ * end to start. You may intersperse these calls and add widgets from
  * both ends of the same GtkBox.
  *
- * Because GtkBox is a #GtkContainer, you may also use
- * gtk_container_add() to insert widgets into the box, and they will be
- * packed with the default values for #GtkBox:expand and #GtkBox:fill.
- * Use gtk_container_remove() to remove widgets from the GtkBox.
+ * Because GtkBox is a #GtkContainer, you may also use gtk_container_add()
+ * to insert widgets into the box, and they will be packed with the default
+ * values for #GtkBox:expand and #GtkBox:fill. Use gtk_container_remove()
+ * to remove widgets from the GtkBox.
  *
  * Use gtk_box_set_homogeneous() to specify whether or not all children
  * of the GtkBox are forced to get the same amount of space.
  *
  * Use gtk_box_set_spacing() to determine how much space will be
- * minimally placed between all children in the GtkBox.
+ * minimally placed between all children in the GtkBox. Note that
+ * spacing is added <emphasis>between</emphasis> the children, while
+ * padding added by gtk_box_pack_start() or gtk_box_pack_end() is added
+ * <emphasis>on either side</emphasis> of the widget it belongs to.
  *
  * Use gtk_box_reorder_child() to move a GtkBox child to a different
  * place in the box.
  * Use gtk_box_set_child_packing() to reset the #GtkBox:expand,
  * #GtkBox:fill and #GtkBox:padding child properties.
  * Use gtk_box_query_child_packing() to query these fields.
+ *
+ * <note><para>
+ * Note that a single-row or single-column #GtkGrid provides exactly
+ * the same functionality as #GtkBox.
+ * </para></note>
  */
 
 #include "config.h"
 
 #include "gtkbox.h"
+#include "gtkboxprivate.h"
+#include "gtkintl.h"
 #include "gtkorientable.h"
-#include "gtksizerequest.h"
+#include "gtkorientableprivate.h"
 #include "gtkprivate.h"
-#include "gtkintl.h"
+#include "gtktypebuiltins.h"
+#include "gtksizerequest.h"
+#include "gtkwidgetpath.h"
+#include "gtkwidgetprivate.h"
+#include "a11y/gtkcontaineraccessible.h"
 
 
 enum {
@@ -98,13 +106,11 @@ enum {
   CHILD_PROP_POSITION
 };
 
-
-struct _GtkBoxPriv
+struct _GtkBoxPrivate
 {
-  GtkOrientation  orientation;
-
   GList          *children;
 
+  GtkOrientation  orientation;
   gint16          spacing;
 
   guint           default_expand : 1;
@@ -112,9 +118,6 @@ struct _GtkBoxPriv
   guint           spacing_set    : 1;
 };
 
-
-typedef struct _GtkBoxDesiredSizes GtkBoxDesiredSizes;
-typedef struct _GtkBoxSpreading    GtkBoxSpreading;
 typedef struct _GtkBoxChild        GtkBoxChild;
 
 /*
@@ -142,21 +145,15 @@ struct _GtkBoxChild
   guint      pack   : 1;
 };
 
-struct _GtkBoxDesiredSizes
-{
-  gint minimum_size;
-  gint natural_size;
-};
-
-struct _GtkBoxSpreading
-{
-  GtkBoxChild *child;
-  gint index;
-};
-
 static void gtk_box_size_allocate         (GtkWidget              *widget,
                                            GtkAllocation          *allocation);
 
+static void gtk_box_compute_expand     (GtkWidget      *widget,
+                                        gboolean       *hexpand,
+                                        gboolean       *vexpand);
+static void gtk_box_direction_changed  (GtkWidget        *widget,
+                                        GtkTextDirection  previous_direction);
+
 static void gtk_box_set_property       (GObject        *object,
                                         guint           prop_id,
                                         const GValue   *value,
@@ -165,7 +162,6 @@ static void gtk_box_get_property       (GObject        *object,
                                         guint           prop_id,
                                         GValue         *value,
                                         GParamSpec     *pspec);
-
 static void gtk_box_add                (GtkContainer   *container,
                                         GtkWidget      *widget);
 static void gtk_box_remove             (GtkContainer   *container,
@@ -185,32 +181,30 @@ static void gtk_box_get_child_property (GtkContainer   *container,
                                         GValue         *value,
                                         GParamSpec     *pspec);
 static GType gtk_box_child_type        (GtkContainer   *container);
+static GtkWidgetPath * gtk_box_get_path_for_child
+                                       (GtkContainer   *container,
+                                        GtkWidget      *child);
+
+
+static void               gtk_box_get_preferred_width            (GtkWidget           *widget,
+                                                                  gint                *minimum_size,
+                                                                  gint                *natural_size);
+static void               gtk_box_get_preferred_height           (GtkWidget           *widget,
+                                                                  gint                *minimum_size,
+                                                                  gint                *natural_size);
+static void               gtk_box_get_preferred_width_for_height (GtkWidget           *widget,
+                                                                  gint                 height,
+                                                                  gint                *minimum_width,
+                                                                  gint                *natural_width);
+static void               gtk_box_get_preferred_height_for_width (GtkWidget           *widget,
+                                                                  gint                 width,
+                                                                  gint                *minimum_height,
+                                                                  gint                *natural_height);
 
 
-static void               gtk_box_size_request_init    (GtkSizeRequestIface *iface);
-static GtkSizeRequestMode gtk_box_get_request_mode     (GtkSizeRequest      *widget);
-static void               gtk_box_get_width            (GtkSizeRequest      *widget,
-                                                       gint                *minimum_size,
-                                                       gint                *natural_size);
-static void               gtk_box_get_height           (GtkSizeRequest      *widget,
-                                                       gint                *minimum_size,
-                                                       gint                *natural_size);
-static void               gtk_box_get_width_for_height (GtkSizeRequest      *widget,
-                                                       gint                 height,
-                                                       gint                *minimum_width,
-                                                       gint                *natural_width);
-static void               gtk_box_get_height_for_width (GtkSizeRequest      *widget,
-                                                       gint                 width,
-                                                       gint                *minimum_height,
-                                                       gint                *natural_height);
-
-static GtkSizeRequestIface *parent_size_request_iface;
-
 G_DEFINE_TYPE_WITH_CODE (GtkBox, gtk_box, GTK_TYPE_CONTAINER,
                          G_IMPLEMENT_INTERFACE (GTK_TYPE_ORIENTABLE,
-                                                NULL)
-                         G_IMPLEMENT_INTERFACE (GTK_TYPE_SIZE_REQUEST,
-                                                gtk_box_size_request_init));
+                                                NULL))
 
 static void
 gtk_box_class_init (GtkBoxClass *class)
@@ -222,7 +216,13 @@ gtk_box_class_init (GtkBoxClass *class)
   object_class->set_property = gtk_box_set_property;
   object_class->get_property = gtk_box_get_property;
 
-  widget_class->size_allocate = gtk_box_size_allocate;
+  widget_class->size_allocate                  = gtk_box_size_allocate;
+  widget_class->get_preferred_width            = gtk_box_get_preferred_width;
+  widget_class->get_preferred_height           = gtk_box_get_preferred_height;
+  widget_class->get_preferred_height_for_width = gtk_box_get_preferred_height_for_width;
+  widget_class->get_preferred_width_for_height = gtk_box_get_preferred_width_for_height;
+  widget_class->compute_expand                 = gtk_box_compute_expand;
+  widget_class->direction_changed              = gtk_box_direction_changed;
 
   container_class->add = gtk_box_add;
   container_class->remove = gtk_box_remove;
@@ -230,6 +230,8 @@ gtk_box_class_init (GtkBoxClass *class)
   container_class->child_type = gtk_box_child_type;
   container_class->set_child_property = gtk_box_set_child_property;
   container_class->get_child_property = gtk_box_get_child_property;
+  container_class->get_path_for_child = gtk_box_get_path_for_child;
+  gtk_container_class_handle_border_width (container_class);
 
   g_object_class_override_property (object_class,
                                     PROP_ORIENTATION,
@@ -261,6 +263,10 @@ gtk_box_class_init (GtkBoxClass *class)
    * Note that the default value for this property is %FALSE for GtkBox,
    * but #GtkHBox, #GtkVBox and other subclasses use the old default
    * of %TRUE.
+   *
+   * Note that the #GtkWidget:halign, #GtkWidget:valign, #GtkWidget:hexpand
+   * and #GtkWidget:vexpand properties are the preferred way to influence
+   * child size allocation in containers.
    */
   gtk_container_class_install_child_property (container_class,
                                              CHILD_PROP_EXPAND,
@@ -275,16 +281,16 @@ gtk_box_class_init (GtkBoxClass *class)
    *
    * Whether the child should receive extra space when the parent grows.
    *
-   * Note that the default value for this property is %FALSE for GtkBox,
-   * but #GtkHBox, #GtkVBox and other subclasses use the old default
-   * of %TRUE.
+   * Note that the #GtkWidget:halign, #GtkWidget:valign, #GtkWidget:hexpand
+   * and #GtkWidget:vexpand properties are the preferred way to influence
+   * child size allocation in containers.
    */
   gtk_container_class_install_child_property (container_class,
                                              CHILD_PROP_FILL,
                                              g_param_spec_boolean ("fill",
                                                                    P_("Fill"),
                                                                    P_("Whether extra space given to the child should be allocated to the child or used as padding"),
-                                                                   FALSE,
+                                                                   TRUE,
                                                                    GTK_PARAM_READWRITE));
 
   gtk_container_class_install_child_property (container_class,
@@ -297,29 +303,31 @@ gtk_box_class_init (GtkBoxClass *class)
   gtk_container_class_install_child_property (container_class,
                                              CHILD_PROP_PACK_TYPE,
                                              g_param_spec_enum ("pack-type",
-                                                                P_("Pack type"), 
+                                                                P_("Pack type"),
                                                                 P_("A GtkPackType indicating whether the child is packed with reference to the start or end of the parent"),
                                                                 GTK_TYPE_PACK_TYPE, GTK_PACK_START,
                                                                 GTK_PARAM_READWRITE));
   gtk_container_class_install_child_property (container_class,
                                              CHILD_PROP_POSITION,
-                                             g_param_spec_int ("position", 
-                                                               P_("Position"), 
+                                             g_param_spec_int ("position",
+                                                               P_("Position"),
                                                                P_("The index of the child in the parent"),
                                                                -1, G_MAXINT, 0,
                                                                GTK_PARAM_READWRITE));
 
-  g_type_class_add_private (object_class, sizeof (GtkBoxPriv));
+  g_type_class_add_private (object_class, sizeof (GtkBoxPrivate));
+
+  gtk_widget_class_set_accessible_role (widget_class, ATK_ROLE_FILLER);
 }
 
 static void
 gtk_box_init (GtkBox *box)
 {
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
 
   box->priv = G_TYPE_INSTANCE_GET_PRIVATE (box,
                                            GTK_TYPE_BOX,
-                                           GtkBoxPriv);
+                                           GtkBoxPrivate);
   private = box->priv;
 
   gtk_widget_set_has_window (GTK_WIDGET (box), FALSE);
@@ -341,12 +349,13 @@ gtk_box_set_property (GObject      *object,
                       GParamSpec   *pspec)
 {
   GtkBox *box = GTK_BOX (object);
-  GtkBoxPriv *private = box->priv;
+  GtkBoxPrivate *private = box->priv;
 
   switch (prop_id)
     {
     case PROP_ORIENTATION:
       private->orientation = g_value_get_enum (value);
+      _gtk_orientable_set_style_classes (GTK_ORIENTABLE (box));
       gtk_widget_queue_resize (GTK_WIDGET (box));
       break;
     case PROP_SPACING:
@@ -368,7 +377,7 @@ gtk_box_get_property (GObject    *object,
                       GParamSpec *pspec)
 {
   GtkBox *box = GTK_BOX (object);
-  GtkBoxPriv *private = box->priv;
+  GtkBoxPrivate *private = box->priv;
 
   switch (prop_id)
     {
@@ -393,7 +402,7 @@ count_expand_children (GtkBox *box,
                        gint *visible_children,
                        gint *expand_children)
 {
-  GtkBoxPriv  *private = box->priv;
+  GtkBoxPrivate  *private = box->priv;
   GList       *children;
   GtkBoxChild *child;
 
@@ -406,310 +415,306 @@ count_expand_children (GtkBox *box,
       if (gtk_widget_get_visible (child->widget))
        {
          *visible_children += 1;
-         if (child->expand)
+         if (child->expand || gtk_widget_compute_expand (child->widget, private->orientation))
            *expand_children += 1;
        }
     }
 }
 
-static gint
-gtk_box_compare_gap (gconstpointer p1,
-                      gconstpointer p2,
-                      gpointer      data)
-{
-  GtkBoxDesiredSizes *sizes = data;
-  const GtkBoxSpreading *c1 = p1;
-  const GtkBoxSpreading *c2 = p2;
-
-  const gint d1 = MAX (sizes[c1->index].natural_size -
-                       sizes[c1->index].minimum_size,
-                       0);
-  const gint d2 = MAX (sizes[c2->index].natural_size -
-                       sizes[c2->index].minimum_size,
-                       0);
-
-  gint delta = (d2 - d1);
-
-  if (0 == delta)
-    delta = (c2->index - c1->index);
-
-  return delta;
-}
-
 static void
 gtk_box_size_allocate (GtkWidget     *widget,
                        GtkAllocation *allocation)
 {
   GtkBox *box = GTK_BOX (widget);
-  GtkBoxPriv *private = box->priv;
+  GtkBoxPrivate *private = box->priv;
   GtkBoxChild *child;
   GList *children;
   gint nvis_children;
   gint nexpand_children;
 
-  widget->allocation = *allocation;
+  GtkTextDirection direction;
+  GtkAllocation child_allocation;
+  GtkRequestedSize *sizes;
+
+  GtkPackType packing;
+
+  gint size;
+  gint extra;
+  gint n_extra_widgets = 0; /* Number of widgets that receive 1 extra px */
+  gint x = 0, y = 0, i;
+  gint child_size;
+
+
+  gtk_widget_set_allocation (widget, allocation);
 
   count_expand_children (box, &nvis_children, &nexpand_children);
 
-  if (nvis_children > 0)
+  /* If there is no visible child, simply return. */
+  if (nvis_children <= 0)
+    return;
+
+  direction = gtk_widget_get_direction (widget);
+  sizes = g_newa (GtkRequestedSize, nvis_children);
+
+  if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
+    size = allocation->width - (nvis_children - 1) * private->spacing;
+  else
+    size = allocation->height - (nvis_children - 1) * private->spacing;
+
+  /* Retrieve desired size for visible children. */
+  for (i = 0, children = private->children; children; children = children->next)
     {
-      guint border_width = gtk_container_get_border_width (GTK_CONTAINER (box));
-      GtkTextDirection direction = gtk_widget_get_direction (widget);
-      GtkAllocation child_allocation;
-      GtkBoxSpreading *spreading = g_newa (GtkBoxSpreading, nvis_children);
-      GtkBoxDesiredSizes *sizes = g_newa (GtkBoxDesiredSizes, nvis_children);
+      child = children->data;
 
-      GtkPackType packing;
+      if (!gtk_widget_get_visible (child->widget))
+       continue;
 
-      gint size;
-      gint extra;
-      gint x = 0, y = 0, i;
-      gint child_size;
+      if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
+       gtk_widget_get_preferred_width_for_height (child->widget,
+                                                   allocation->height,
+                                                   &sizes[i].minimum_size,
+                                                   &sizes[i].natural_size);
+      else
+       gtk_widget_get_preferred_height_for_width (child->widget,
+                                                   allocation->width,
+                                                   &sizes[i].minimum_size,
+                                                   &sizes[i].natural_size);
+
+
+      /* Assert the api is working properly */
+      if (sizes[i].minimum_size < 0)
+       g_error ("GtkBox child %s minimum %s: %d < 0 for %s %d",
+                gtk_widget_get_name (GTK_WIDGET (child->widget)),
+                (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "width" : "height",
+                sizes[i].minimum_size,
+                (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "height" : "width",
+                (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? allocation->height : allocation->width);
+
+      if (sizes[i].natural_size < sizes[i].minimum_size)
+       g_error ("GtkBox child %s natural %s: %d < minimum %d for %s %d",
+                gtk_widget_get_name (GTK_WIDGET (child->widget)),
+                (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "width" : "height",
+                sizes[i].natural_size,
+                sizes[i].minimum_size,
+                (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "height" : "width",
+                (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? allocation->height : allocation->width);
+
+      size -= sizes[i].minimum_size;
+      size -= child->padding * 2;
+
+      sizes[i].data = child;
+
+      i++;
+    }
 
+  if (private->homogeneous)
+    {
+      /* If were homogenous we still need to run the above loop to get the
+       * minimum sizes for children that are not going to fill
+       */
       if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
-        size = allocation->width - border_width * 2 - (nvis_children - 1) * private->spacing;
+       size = allocation->width - (nvis_children - 1) * private->spacing;
       else
-        size = allocation->height - border_width * 2 - (nvis_children - 1) * private->spacing;
+       size = allocation->height - (nvis_children - 1) * private->spacing;
 
-      /* Retrieve desired size for visible children */
-      i = 0;
-      children = private->children;
-      while (children)
-       {
-         child = children->data;
-         children = children->next;
+      extra = size / nvis_children;
+      n_extra_widgets = size % nvis_children;
+    }
+  else
+    {
+      /* Bring children up to size first */
+      size = gtk_distribute_natural_allocation (MAX (0, size), nvis_children, sizes);
 
-         if (gtk_widget_get_visible (child->widget))
-           {
-             if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
-               gtk_size_request_get_width_for_height (GTK_SIZE_REQUEST (child->widget),
-                                                         allocation->height,
-                                                         &sizes[i].minimum_size,
-                                                         &sizes[i].natural_size);
-             else
-               gtk_size_request_get_height_for_width (GTK_SIZE_REQUEST (child->widget),
-                                                         allocation->width,
-                                                         &sizes[i].minimum_size,
-                                                         &sizes[i].natural_size);
-             
-             
-             /* Assert the api is working properly */
-             if (sizes[i].minimum_size < 0)
-               g_error ("GtkBox child %s minimum %s: %d < 0 for %s %d",
-                        gtk_widget_get_name (GTK_WIDGET (child->widget)),
-                        (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "width" : "height",
-                        sizes[i].minimum_size,
-                        (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "height" : "width",
-                        (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? allocation->height : allocation->width);
-
-             if (sizes[i].natural_size < sizes[i].minimum_size)
-               g_error ("GtkBox child %s natural %s: %d < minimum %d for %s %d",
-                        gtk_widget_get_name (GTK_WIDGET (child->widget)),
-                        (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "width" : "height",
-                        sizes[i].natural_size, 
-                        sizes[i].minimum_size,
-                        (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "height" : "width",
-                        (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? allocation->height : allocation->width);
-             
-             size -= sizes[i].minimum_size;
-             size -= child->padding * 2;
-             
-             spreading[i].index = i;
-             spreading[i].child = child;
-             
-             i += 1;
-           }
+      /* Calculate space which hasn't distributed yet,
+       * and is available for expanding children.
+       */
+      if (nexpand_children > 0)
+       {
+         extra = size / nexpand_children;
+         n_extra_widgets = size % nexpand_children;
        }
+      else
+       extra = 0;
+    }
 
-      if (private->homogeneous)
+  /* Allocate child positions. */
+  for (packing = GTK_PACK_START; packing <= GTK_PACK_END; ++packing)
+    {
+      if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
        {
-         /* If were homogenous we still need to run the above loop to get the minimum sizes
-          * for children that are not going to fill 
-          */
-         if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
-           size = allocation->width - border_width * 2 - (nvis_children - 1) * private->spacing;
+         child_allocation.y = allocation->y;
+         child_allocation.height = MAX (1, allocation->height);
+         if (packing == GTK_PACK_START)
+           x = allocation->x;
          else
-           size = allocation->height - border_width * 2 - (nvis_children - 1) * private->spacing;
-         
-          extra = size / nvis_children;
-        }
+           x = allocation->x + allocation->width;
+       }
       else
        {
+         child_allocation.x = allocation->x;
+         child_allocation.width = MAX (1, allocation->width);
+         if (packing == GTK_PACK_START)
+           y = allocation->y;
+         else
+           y = allocation->y + allocation->height;
+       }
 
-          /* Distribute the container's extra space c_gap. We want to assign
-           * this space such that the sum of extra space assigned to children
-           * (c^i_gap) is equal to c_cap. The case that there's not enough
-           * space for all children to take their natural size needs some
-           * attention. The goals we want to achieve are:
-           *
-           *   a) Maximize number of children taking their natural size.
-           *   b) The allocated size of children should be a continuous
-           *   function of c_gap.  That is, increasing the container size by
-           *   one pixel should never make drastic changes in the distribution.
-           *   c) If child i takes its natural size and child j doesn't,
-           *   child j should have received at least as much gap as child i.
-           *
-           * The following code distributes the additional space by following
-           * this rules.
-           */
-
-          /* Sort descending by gap and position. */
-          g_qsort_with_data (spreading,
-                             nvis_children, sizeof (GtkBoxSpreading),
-                             gtk_box_compare_gap, sizes);
-
-          /* Distribute available space.
-           * This master piece of a loop was conceived by Behdad Esfahbod.
-           */
-          for (i = nvis_children - 1; size > 0 && i >= 0; --i)
-            {
-              /* Divide remaining space by number of remaining children.
-               * Sort order and reducing remaining space by assigned space
-               * ensures that space is distributed equally.
-               */
-              gint glue = (size + i) / (i + 1);
-              gint gap = sizes[spreading[i].index].natural_size
-                       - sizes[spreading[i].index].minimum_size;
-
-              extra = MIN (glue, gap);
-              sizes[spreading[i].index].minimum_size += extra;
-
-              size -= extra;
-            }
+      for (i = 0, children = private->children;
+          children;
+          children = children->next)
+       {
+         child = children->data;
 
-          /* Calculate space which hasn't distributed yet,
-           * and is available for expanding children.
-           */
-          if (nexpand_children > 0)
-            extra = size / nexpand_children;
-          else
-            extra = 0;
-        }
+         /* If widget is not visible, skip it. */
+         if (!gtk_widget_get_visible (child->widget))
+           continue;
 
-      /* Allocate child positions. */
+         /* If widget is packed differently skip it, but still increment i,
+          * since widget is visible and will be handled in next loop iteration.
+          */
+         if (child->pack != packing)
+           {
+             i++;
+             continue;
+           }
 
-      for (packing = GTK_PACK_START; packing <= GTK_PACK_END; ++packing)
-        {
-          if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
-            {
-              child_allocation.y = allocation->y + border_width;
-              child_allocation.height = MAX (1, allocation->height - border_width * 2);
-              if (packing == GTK_PACK_START)
-                x = allocation->x + border_width;
-              else
-                x = allocation->x + allocation->width - border_width;
-            }
-          else
-            {
-              child_allocation.x = allocation->x + border_width;
-              child_allocation.width = MAX (1, allocation->width - border_width * 2);
-              if (packing == GTK_PACK_START)
-                y = allocation->y + border_width;
-              else
-                y = allocation->y + allocation->height - border_width;
-            }
+         /* Assign the child's size. */
+         if (private->homogeneous)
+           {
+             child_size = extra;
+
+             if (n_extra_widgets > 0)
+               {
+                 child_size++;
+                 n_extra_widgets--;
+               }
+           }
+         else
+           {
+             child_size = sizes[i].minimum_size + child->padding * 2;
+
+             if (child->expand || gtk_widget_compute_expand (child->widget, private->orientation))
+               {
+                 child_size += extra;
+
+                 if (n_extra_widgets > 0)
+                   {
+                     child_size++;
+                     n_extra_widgets--;
+                   }
+               }
+           }
 
-         i = 0;
-          children = private->children;
-          while (children)
+         /* Assign the child's position. */
+         if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
            {
-             child = children->data;
-             children = children->next;
-
-             if (gtk_widget_get_visible (child->widget))
-               {
-                  if (child->pack == packing)
-                    {
-                      /* Assign the child's size. */
-                     if (private->homogeneous)
-                       {
-                         if (nvis_children == 1)
-                            child_size = size;
-                         else
-                            child_size = extra;
-
-                         nvis_children -= 1;
-                         size -= extra;
-                       }
-                     else
-                       {
-                         child_size = sizes[i].minimum_size + child->padding * 2;
-
-                         if (child->expand)
-                           {
-                             if (nexpand_children == 1)
-                                child_size += size;
-                             else
-                                child_size += extra;
-
-                             nexpand_children -= 1;
-                             size -= extra;
-                           }
-                       }
-
-                      /* Assign the child's position. */
-                      if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
-                        {
-                         if (child->fill)
-                           {
-                              child_allocation.width = MAX (1, child_size - child->padding * 2);
-                              child_allocation.x = x + child->padding;
-                           }
-                         else
-                           {
-                             child_allocation.width = sizes[i].minimum_size;
-                              child_allocation.x = x + (child_size - child_allocation.width) / 2;
-                           }
-
-                          if (packing == GTK_PACK_START)
-                           {
-                             x += child_size + private->spacing;
-                           }
-                          else
-                           {
-                             x -= child_size + private->spacing;
-
-                             child_allocation.x -= child_size;
-                           }
-
-                         if (direction == GTK_TEXT_DIR_RTL)
-                            child_allocation.x = allocation->x + allocation->width - (child_allocation.x - allocation->x) - child_allocation.width;
-
-                        }
-                      else /* (private->orientation == GTK_ORIENTATION_VERTICAL) */
-                        {
-                         if (child->fill)
-                           {
-                              child_allocation.height = MAX (1, child_size - child->padding * 2);
-                              child_allocation.y = y + child->padding;
-                           }
-                         else
-                           {
-                             child_allocation.height = sizes[i].minimum_size;
-                              child_allocation.y = y + (child_size - child_allocation.height) / 2;
-                           }
-
-                         if (packing == GTK_PACK_START)
-                          {
-                            y += child_size + private->spacing;
-                          }
-                         else
-                          {
-                            y -= child_size + private->spacing;
-
-                            child_allocation.y -= child_size;
-                          }
-                        }
-                     gtk_widget_size_allocate (child->widget, &child_allocation);
-                    }
-
-                 i += 1;
-                }
+             if (child->fill)
+               {
+                 child_allocation.width = MAX (1, child_size - child->padding * 2);
+                 child_allocation.x = x + child->padding;
+               }
+             else
+               {
+                 child_allocation.width = sizes[i].minimum_size;
+                 child_allocation.x = x + (child_size - child_allocation.width) / 2;
+               }
+
+             if (packing == GTK_PACK_START)
+               {
+                 x += child_size + private->spacing;
+               }
+             else
+               {
+                 x -= child_size + private->spacing;
+
+                 child_allocation.x -= child_size;
+               }
+
+             if (direction == GTK_TEXT_DIR_RTL)
+               child_allocation.x = allocation->x + allocation->width - (child_allocation.x - allocation->x) - child_allocation.width;
+
            }
+         else /* (private->orientation == GTK_ORIENTATION_VERTICAL) */
+           {
+             if (child->fill)
+               {
+                 child_allocation.height = MAX (1, child_size - child->padding * 2);
+                 child_allocation.y = y + child->padding;
+               }
+             else
+               {
+                 child_allocation.height = sizes[i].minimum_size;
+                 child_allocation.y = y + (child_size - child_allocation.height) / 2;
+               }
+
+             if (packing == GTK_PACK_START)
+               {
+                 y += child_size + private->spacing;
+               }
+             else
+               {
+                 y -= child_size + private->spacing;
+
+                 child_allocation.y -= child_size;
+               }
+           }
+         gtk_widget_size_allocate (child->widget, &child_allocation);
+
+         i++;
        }
     }
 }
 
+static void
+gtk_box_compute_expand (GtkWidget      *widget,
+                        gboolean       *hexpand_p,
+                        gboolean       *vexpand_p)
+{
+  GtkBoxPrivate  *private = GTK_BOX (widget)->priv;
+  GList       *children;
+  GtkBoxChild *child;
+  gboolean our_expand;
+  gboolean opposite_expand;
+  GtkOrientation opposite_orientation;
+
+  if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
+    opposite_orientation = GTK_ORIENTATION_VERTICAL;
+  else
+    opposite_orientation = GTK_ORIENTATION_HORIZONTAL;
+
+  our_expand = FALSE;
+  opposite_expand = FALSE;
+
+  for (children = private->children; children; children = children->next)
+    {
+      child = children->data;
+
+      /* we don't recurse into children anymore as soon as we know
+       * expand=TRUE in an orientation
+       */
+
+      if (child->expand || (!our_expand && gtk_widget_compute_expand (child->widget, private->orientation)))
+        our_expand = TRUE;
+
+      if (!opposite_expand && gtk_widget_compute_expand (child->widget, opposite_orientation))
+        opposite_expand = TRUE;
+
+      if (our_expand && opposite_expand)
+        break;
+    }
+
+  if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
+    {
+      *hexpand_p = our_expand;
+      *vexpand_p = opposite_expand;
+    }
+  else
+    {
+      *hexpand_p = opposite_expand;
+      *vexpand_p = our_expand;
+    }
+}
+
 static GType
 gtk_box_child_type (GtkContainer   *container)
 {
@@ -834,6 +839,138 @@ gtk_box_get_child_property (GtkContainer *container,
     }
 }
 
+typedef struct _CountingData CountingData;
+struct _CountingData {
+  GtkWidget *widget;
+  gboolean found;
+  guint before;
+  guint after;
+};
+
+static void
+count_widget_position (GtkWidget *widget,
+                       gpointer   data)
+{
+  CountingData *count = data;
+
+  if (!gtk_widget_get_visible (widget))
+    return;
+
+  if (count->widget == widget)
+    count->found = TRUE;
+  else if (count->found)
+    count->after++;
+  else
+    count->before++;
+}
+
+static gint
+gtk_box_get_visible_position (GtkBox    *box,
+                              GtkWidget *child)
+{
+  CountingData count = { child, FALSE, 0, 0 };
+
+  /* foreach iterates in visible order */
+  gtk_container_foreach (GTK_CONTAINER (box),
+                         count_widget_position,
+                         &count);
+
+  /* the child wasn't found, it's likely an internal child of some
+   * subclass, return -1 to indicate that there is no sibling relation
+   * to the regular box children
+   */
+  if (!count.found)
+    return -1;
+
+  if (box->priv->orientation == GTK_ORIENTATION_HORIZONTAL &&
+      gtk_widget_get_direction (GTK_WIDGET (box)) == GTK_TEXT_DIR_RTL)
+    return count.after;
+  else
+    return count.before;
+}
+
+static GtkWidgetPath *
+gtk_box_get_path_for_child (GtkContainer *container,
+                            GtkWidget    *child)
+{
+  GtkWidgetPath *path, *sibling_path;
+  GtkBox *box;
+  GtkBoxPrivate *private;
+  GList *list, *children;
+
+  box = GTK_BOX (container);
+  private = box->priv;
+
+  path = _gtk_widget_create_path (GTK_WIDGET (container));
+
+  if (gtk_widget_get_visible (child))
+    {
+      gint position;
+
+      sibling_path = gtk_widget_path_new ();
+
+      /* get_children works in visible order */
+      children = gtk_container_get_children (container);
+      if (private->orientation == GTK_ORIENTATION_HORIZONTAL &&
+          gtk_widget_get_direction (GTK_WIDGET (box)) == GTK_TEXT_DIR_RTL)
+        children = g_list_reverse (children);
+
+      for (list = children; list; list = list->next)
+        {
+          if (!gtk_widget_get_visible (list->data))
+            continue;
+
+          gtk_widget_path_append_for_widget (sibling_path, list->data);
+        }
+
+      g_list_free (children);
+
+      position = gtk_box_get_visible_position (box, child);
+
+      if (position >= 0)
+        gtk_widget_path_append_with_siblings (path, sibling_path, position);
+      else
+        gtk_widget_path_append_for_widget (path, child);
+
+      gtk_widget_path_unref (sibling_path);
+    }
+  else
+    gtk_widget_path_append_for_widget (path, child);
+
+  return path;
+}
+
+static void
+gtk_box_invalidate_order_foreach (GtkWidget *widget)
+{
+  _gtk_widget_invalidate_style_context (widget, GTK_CSS_CHANGE_POSITION | GTK_CSS_CHANGE_SIBLING_POSITION);
+}
+
+static void
+gtk_box_invalidate_order (GtkBox *box)
+{
+  gtk_container_foreach (GTK_CONTAINER (box),
+                         (GtkCallback) gtk_box_invalidate_order_foreach,
+                         NULL);
+}
+
+static void
+gtk_box_direction_changed (GtkWidget        *widget,
+                           GtkTextDirection  previous_direction)
+{
+  gtk_box_invalidate_order (GTK_BOX (widget));
+}
+
+static void
+box_child_visibility_notify_cb (GObject *obj,
+                                GParamSpec *pspec,
+                                gpointer user_data)
+{
+  GtkBox *box = user_data;
+
+  gtk_box_invalidate_order (box);
+}
+
 static void
 gtk_box_pack (GtkBox      *box,
               GtkWidget   *child,
@@ -842,12 +979,12 @@ gtk_box_pack (GtkBox      *box,
               guint        padding,
               GtkPackType  pack_type)
 {
-  GtkBoxPriv *private = box->priv;
+  GtkBoxPrivate *private = box->priv;
   GtkBoxChild *child_info;
 
   g_return_if_fail (GTK_IS_BOX (box));
   g_return_if_fail (GTK_IS_WIDGET (child));
-  g_return_if_fail (child->parent == NULL);
+  g_return_if_fail (gtk_widget_get_parent (child) == NULL);
 
   child_info = g_new (GtkBoxChild, 1);
   child_info->widget = child;
@@ -860,8 +997,12 @@ gtk_box_pack (GtkBox      *box,
 
   gtk_widget_freeze_child_notify (child);
 
+  gtk_box_invalidate_order (box);
   gtk_widget_set_parent (child, GTK_WIDGET (box));
-  
+
+  g_signal_connect (child, "notify::visible",
+                    G_CALLBACK (box_child_visibility_notify_cb), box);
+
   gtk_widget_child_notify (child, "expand");
   gtk_widget_child_notify (child, "fill");
   gtk_widget_child_notify (child, "padding");
@@ -870,44 +1011,20 @@ gtk_box_pack (GtkBox      *box,
   gtk_widget_thaw_child_notify (child);
 }
 
-
 static void
-gtk_box_size_request_init (GtkSizeRequestIface *iface)
-{
-  parent_size_request_iface = g_type_interface_peek_parent (iface);
-
-  iface->get_request_mode     = gtk_box_get_request_mode;
-  iface->get_width            = gtk_box_get_width;
-  iface->get_height           = gtk_box_get_height;
-  iface->get_height_for_width = gtk_box_get_height_for_width;
-  iface->get_width_for_height = gtk_box_get_width_for_height;
-}
-
-static GtkSizeRequestMode
-gtk_box_get_request_mode  (GtkSizeRequest  *widget)
-{
-  GtkBoxPriv *private = GTK_BOX (widget)->priv;
-
-  return (private->orientation == GTK_ORIENTATION_VERTICAL) ?
-    GTK_SIZE_REQUEST_HEIGHT_FOR_WIDTH : GTK_SIZE_REQUEST_WIDTH_FOR_HEIGHT;
-}
-
-static void
-gtk_box_get_size (GtkSizeRequest      *widget,
-                 GtkOrientation       orientation,
-                 gint                *minimum_size,
-                 gint                *natural_size)
+gtk_box_get_size (GtkWidget      *widget,
+                 GtkOrientation  orientation,
+                 gint           *minimum_size,
+                 gint           *natural_size)
 {
   GtkBox *box;
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
   GList *children;
   gint nvis_children;
-  gint border_width;
   gint minimum, natural;
 
   box = GTK_BOX (widget);
   private = box->priv;
-  border_width = gtk_container_get_border_width (GTK_CONTAINER (box));
 
   minimum = natural = 0;
 
@@ -922,11 +1039,11 @@ gtk_box_get_size (GtkSizeRequest      *widget,
           gint child_minimum, child_natural;
 
          if (orientation == GTK_ORIENTATION_HORIZONTAL)
-           gtk_size_request_get_width (GTK_SIZE_REQUEST (child->widget),
-                                       &child_minimum, &child_natural);
+           gtk_widget_get_preferred_width (child->widget,
+                                            &child_minimum, &child_natural);
          else
-           gtk_size_request_get_height (GTK_SIZE_REQUEST (child->widget),
-                                        &child_minimum, &child_natural);
+           gtk_widget_get_preferred_height (child->widget,
+                                             &child_minimum, &child_natural);
 
           if (private->orientation == orientation)
            {
@@ -968,9 +1085,6 @@ gtk_box_get_size (GtkSizeRequest      *widget,
       natural += (nvis_children - 1) * private->spacing;
     }
 
-  minimum += border_width * 2;
-  natural += border_width * 2;
-
   if (minimum_size)
     *minimum_size = minimum;
 
@@ -979,243 +1093,209 @@ gtk_box_get_size (GtkSizeRequest      *widget,
 }
 
 static void
-gtk_box_get_width (GtkSizeRequest      *widget,
-                  gint                *minimum_size,
-                  gint                *natural_size)
+gtk_box_get_preferred_width (GtkWidget *widget,
+                             gint      *minimum_size,
+                             gint      *natural_size)
 {
   gtk_box_get_size (widget, GTK_ORIENTATION_HORIZONTAL, minimum_size, natural_size);
 }
 
 static void
-gtk_box_get_height (GtkSizeRequest      *widget,
-                   gint                *minimum_size,
-                   gint                *natural_size)
+gtk_box_get_preferred_height (GtkWidget *widget,
+                              gint      *minimum_size,
+                              gint      *natural_size)
 {
   gtk_box_get_size (widget, GTK_ORIENTATION_VERTICAL, minimum_size, natural_size);
 }
 
-static void 
+static void
 gtk_box_compute_size_for_opposing_orientation (GtkBox *box,
                                               gint    avail_size,
                                               gint   *minimum_size,
                                               gint   *natural_size)
 {
-  GtkBoxPriv    *private = box->priv;
-  GtkBoxChild   *child;
-  GList         *children;
-  gint           nvis_children;
-  gint           nexpand_children;
-  gint           computed_minimum = 0, computed_natural = 0;
-  guint          border_width = gtk_container_get_border_width (GTK_CONTAINER (box));
+  GtkBoxPrivate       *private = box->priv;
+  GtkBoxChild      *child;
+  GList            *children;
+  gint              nvis_children;
+  gint              nexpand_children;
+  gint              computed_minimum = 0, computed_natural = 0;
+  GtkRequestedSize *sizes;
+  GtkPackType       packing;
+  gint              size, extra, i;
+  gint              child_size, child_minimum, child_natural;
+  gint              n_extra_widgets = 0;
 
   count_expand_children (box, &nvis_children, &nexpand_children);
 
-  if (nvis_children > 0)
-    {
-      GtkBoxSpreading     *spreading    = g_newa (GtkBoxSpreading, nvis_children);
-      GtkBoxDesiredSizes  *sizes        = g_newa (GtkBoxDesiredSizes, nvis_children);
-      GtkPackType          packing;
-      gint                 size;
-      gint                 extra, i;
-      gint                 child_size, child_minimum, child_natural;
+  if (nvis_children <= 0)
+    return;
 
-      size = avail_size - border_width * 2 - (nvis_children - 1) * private->spacing;
+  sizes = g_newa (GtkRequestedSize, nvis_children);
+  size = avail_size - (nvis_children - 1) * private->spacing;
+
+  /* Retrieve desired size for visible children */
+  for (i = 0, children = private->children; children; children = children->next)
+    {
+      child = children->data;
 
-      /* Retrieve desired size for visible children */
-      for (i = 0, children = private->children; children; children = children->next)
+      if (gtk_widget_get_visible (child->widget))
        {
-         child = children->data;
-         
-         if (gtk_widget_get_visible (child->widget))
-           {
-             if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
-               gtk_size_request_get_width (GTK_SIZE_REQUEST (child->widget),
-                                           &sizes[i].minimum_size,
-                                           &sizes[i].natural_size);
-             else
-               gtk_size_request_get_height (GTK_SIZE_REQUEST (child->widget),
-                                            &sizes[i].minimum_size,
-                                            &sizes[i].natural_size);
-             
-             /* Assert the api is working properly */
-             if (sizes[i].minimum_size < 0)
-               g_error ("GtkBox child %s minimum %s: %d < 0",
-                        gtk_widget_get_name (GTK_WIDGET (child->widget)),
-                        (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "width" : "height",
-                        sizes[i].minimum_size);
-
-             if (sizes[i].natural_size < sizes[i].minimum_size)
-               g_error ("GtkBox child %s natural %s: %d < minimum %d",
-                        gtk_widget_get_name (GTK_WIDGET (child->widget)),
-                        (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "width" : "height",
-                        sizes[i].natural_size, 
-                        sizes[i].minimum_size);
-
-             size -= sizes[i].minimum_size;
-             size -= child->padding * 2;
-             
-             spreading[i].index = i;
-             spreading[i].child = child;
-             
-             i += 1;
-           }
+         if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
+           gtk_widget_get_preferred_width (child->widget,
+                                            &sizes[i].minimum_size,
+                                            &sizes[i].natural_size);
+         else
+           gtk_widget_get_preferred_height (child->widget,
+                                             &sizes[i].minimum_size,
+                                             &sizes[i].natural_size);
+
+         /* Assert the api is working properly */
+         if (sizes[i].minimum_size < 0)
+           g_error ("GtkBox child %s minimum %s: %d < 0",
+                    gtk_widget_get_name (GTK_WIDGET (child->widget)),
+                    (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "width" : "height",
+                    sizes[i].minimum_size);
+
+         if (sizes[i].natural_size < sizes[i].minimum_size)
+           g_error ("GtkBox child %s natural %s: %d < minimum %d",
+                    gtk_widget_get_name (GTK_WIDGET (child->widget)),
+                    (private->orientation == GTK_ORIENTATION_HORIZONTAL) ? "width" : "height",
+                    sizes[i].natural_size,
+                    sizes[i].minimum_size);
+
+         size -= sizes[i].minimum_size;
+         size -= child->padding * 2;
+
+         sizes[i].data = child;
+
+         i += 1;
        }
+    }
 
-      if (private->homogeneous)
+  if (private->homogeneous)
+    {
+      /* If were homogenous we still need to run the above loop to get the
+       * minimum sizes for children that are not going to fill
+       */
+      size = avail_size - (nvis_children - 1) * private->spacing;
+      extra = size / nvis_children;
+      n_extra_widgets = size % nvis_children;
+    }
+  else
+    {
+      /* Bring children up to size first */
+      size = gtk_distribute_natural_allocation (MAX (0, size), nvis_children, sizes);
+
+      /* Calculate space which hasn't distributed yet,
+       * and is available for expanding children.
+       */
+      if (nexpand_children > 0)
        {
-         /* If were homogenous we still need to run the above loop to get the minimum sizes
-          * for children that are not going to fill 
-          */
-         size = avail_size - border_width * 2 - (nvis_children - 1) * private->spacing;
-          extra = size / nvis_children;
-        }
+         extra = size / nexpand_children;
+         n_extra_widgets = size % nexpand_children;
+       }
       else
+       extra = 0;
+    }
+
+  /* Allocate child positions. */
+  for (packing = GTK_PACK_START; packing <= GTK_PACK_END; ++packing)
+    {
+      for (i = 0, children = private->children;
+          children;
+          children = children->next)
        {
+         child = children->data;
 
-          /* Distribute the container's extra space c_gap. We want to assign
-           * this space such that the sum of extra space assigned to children
-           * (c^i_gap) is equal to c_cap. The case that there's not enough
-           * space for all children to take their natural size needs some
-           * attention. The goals we want to achieve are:
-           *
-           *   a) Maximize number of children taking their natural size.
-           *   b) The allocated size of children should be a continuous
-           *   function of c_gap.  That is, increasing the container size by
-           *   one pixel should never make drastic changes in the distribution.
-           *   c) If child i takes its natural size and child j doesn't,
-           *   child j should have received at least as much gap as child i.
-           *
-           * The following code distributes the additional space by following
-           * this rules.
-           */
-
-          /* Sort descending by gap and position. */
-
-          g_qsort_with_data (spreading,
-                             nvis_children, sizeof (GtkBoxSpreading),
-                             gtk_box_compare_gap, sizes);
-
-          /* Distribute available space.
-           * This master piece of a loop was conceived by Behdad Esfahbod.
-           */
-          for (i = nvis_children - 1; size > 0 && i >= 0; --i)
-            {
-              /* Divide remaining space by number of remaining children.
-               * Sort order and reducing remaining space by assigned space
-               * ensures that space is distributed equally.
-               */
-              gint glue = (size + i) / (i + 1);
-              gint gap = sizes[spreading[i].index].natural_size
-                       - sizes[spreading[i].index].minimum_size;
-
-              extra = MIN (glue, gap);
-              sizes[spreading[i].index].minimum_size += extra;
-
-              size -= extra;
-            }
+         /* If widget is not visible, skip it. */
+         if (!gtk_widget_get_visible (child->widget))
+           continue;
 
-          /* Calculate space which hasn't distributed yet,
-           * and is available for expanding children.
-           */
-          if (nexpand_children > 0)
-            extra = size / nexpand_children;
-          else
-            extra = 0;
-        }
+         /* If widget is packed differently skip it, but still increment i,
+          * since widget is visible and will be handled in next loop iteration.
+          */
+         if (child->pack != packing)
+           {
+             i++;
+             continue;
+           }
 
-      /* Allocate child positions. */
-      for (packing = GTK_PACK_START; packing <= GTK_PACK_END; ++packing)
-        {
-          for (i = 0, children = private->children; children; children = children->next)
+         if (child->pack == packing)
            {
-             child = children->data;
-
-             if (gtk_widget_get_visible (child->widget))
-               {
-                  if (child->pack == packing)
-                    {
-                      /* Assign the child's size. */
-                     if (private->homogeneous)
-                       {
-                         if (nvis_children == 1)
-                            child_size = size;
-                         else
-                            child_size = extra;
-
-                         nvis_children -= 1;
-                         size -= extra;
-                       }
-                     else
-                       {
-                         child_size = sizes[i].minimum_size + child->padding * 2;
-
-                         if (child->expand)
-                           {
-                             if (nexpand_children == 1)
-                                child_size += size;
-                             else
-                                child_size += extra;
-
-                             nexpand_children -= 1;
-                             size -= extra;
-                           }
-                       }
-
-                     if (child->fill)
-                       {
-                         child_size = MAX (1, child_size - child->padding * 2);
-                       }
-                     else
+             /* Assign the child's size. */
+             if (private->homogeneous)
+               {
+                 child_size = extra;
+
+                 if (n_extra_widgets > 0)
+                   {
+                     child_size++;
+                     n_extra_widgets--;
+                   }
+               }
+             else
+               {
+                 child_size = sizes[i].minimum_size + child->padding * 2;
+
+                 if (child->expand || gtk_widget_compute_expand (child->widget, private->orientation))
+                   {
+                     child_size += extra;
+
+                     if (n_extra_widgets > 0)
                        {
-                         child_size = sizes[i].minimum_size;
+                         child_size++;
+                         n_extra_widgets--;
                        }
+                   }
+               }
 
+             if (child->fill)
+               {
+                 child_size = MAX (1, child_size - child->padding * 2);
+               }
+             else
+               {
+                 child_size = sizes[i].minimum_size;
+               }
 
-                      /* Assign the child's position. */
-                      if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
-                       gtk_size_request_get_height_for_width (GTK_SIZE_REQUEST (child->widget),
-                                                                 child_size, &child_minimum, &child_natural);
-                      else /* (private->orientation == GTK_ORIENTATION_VERTICAL) */
-                       gtk_size_request_get_width_for_height (GTK_SIZE_REQUEST (child->widget),
-                                                                 child_size, &child_minimum, &child_natural);
 
-                     
-                     computed_minimum = MAX (computed_minimum, child_minimum);
-                     computed_natural = MAX (computed_natural, child_natural);
-                    }
-                 i += 1;
-                }
+             /* Assign the child's position. */
+             if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
+               gtk_widget_get_preferred_height_for_width (child->widget,
+                                                           child_size, &child_minimum, &child_natural);
+             else /* (private->orientation == GTK_ORIENTATION_VERTICAL) */
+               gtk_widget_get_preferred_width_for_height (child->widget,
+                                                           child_size, &child_minimum, &child_natural);
+
+
+             computed_minimum = MAX (computed_minimum, child_minimum);
+             computed_natural = MAX (computed_natural, child_natural);
            }
+         i += 1;
        }
     }
 
-  computed_minimum += border_width * 2;
-  computed_natural += border_width * 2;
-
   if (minimum_size)
     *minimum_size = computed_minimum;
   if (natural_size)
     *natural_size = computed_natural;
-}  
+}
 
-static void 
+static void
 gtk_box_compute_size_for_orientation (GtkBox *box,
                                      gint    avail_size,
                                      gint   *minimum_size,
                                      gint   *natural_size)
 {
-  GtkBoxPriv    *private = box->priv;
+  GtkBoxPrivate    *private = box->priv;
   GList         *children;
   gint           nvis_children = 0;
   gint           required_size = 0, required_natural = 0, child_size, child_natural;
   gint           largest_child = 0, largest_natural = 0;
-  guint          border_width;
 
-  border_width = gtk_container_get_border_width (GTK_CONTAINER (box));
-  avail_size -= border_width * 2;
-
-  for (children = private->children; children != NULL; 
-       children = children->next, nvis_children++)
+  for (children = private->children; children != NULL;
+       children = children->next)
     {
       GtkBoxChild *child = children->data;
 
@@ -1223,11 +1303,11 @@ gtk_box_compute_size_for_orientation (GtkBox *box,
         {
 
           if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
-           gtk_size_request_get_width_for_height (GTK_SIZE_REQUEST (child->widget),
-                                                     avail_size, &child_size, &child_natural);
+           gtk_widget_get_preferred_width_for_height (child->widget,
+                                                       avail_size, &child_size, &child_natural);
          else
-           gtk_size_request_get_height_for_width (GTK_SIZE_REQUEST (child->widget),
-                                                     avail_size, &child_size, &child_natural);
+           gtk_widget_get_preferred_height_for_width (child->widget,
+                                                      avail_size, &child_size, &child_natural);
 
 
          child_size    += child->padding * 2;
@@ -1241,6 +1321,8 @@ gtk_box_compute_size_for_orientation (GtkBox *box,
 
          required_size    += child_size;
          required_natural += child_natural;
+
+          nvis_children += 1;
         }
     }
 
@@ -1256,9 +1338,6 @@ gtk_box_compute_size_for_orientation (GtkBox *box,
       required_natural  += (nvis_children - 1) * private->spacing;
     }
 
-  required_size    += border_width * 2;
-  required_natural += border_width * 2;
-
   if (minimum_size)
     *minimum_size = required_size;
 
@@ -1266,29 +1345,29 @@ gtk_box_compute_size_for_orientation (GtkBox *box,
     *natural_size = required_natural;
 }
 
-static void 
-gtk_box_get_width_for_height (GtkSizeRequest *widget,
-                             gint            height,
-                             gint           *minimum_width,
-                             gint           *natural_width)
+static void
+gtk_box_get_preferred_width_for_height (GtkWidget *widget,
+                                        gint       height,
+                                        gint      *minimum_width,
+                                        gint      *natural_width)
 {
   GtkBox        *box     = GTK_BOX (widget);
-  GtkBoxPriv    *private = box->priv;
+  GtkBoxPrivate *private = box->priv;
 
   if (private->orientation == GTK_ORIENTATION_VERTICAL)
-    gtk_box_compute_size_for_opposing_orientation (box, height, minimum_width, natural_width); 
+    gtk_box_compute_size_for_opposing_orientation (box, height, minimum_width, natural_width);
   else
     gtk_box_compute_size_for_orientation (box, height, minimum_width, natural_width);
 }
 
-static void 
-gtk_box_get_height_for_width (GtkSizeRequest *widget,
-                             gint            width,
-                             gint           *minimum_height,
-                             gint           *natural_height)
+static void
+gtk_box_get_preferred_height_for_width (GtkWidget *widget,
+                                        gint       width,
+                                        gint      *minimum_height,
+                                        gint      *natural_height)
 {
   GtkBox        *box     = GTK_BOX (widget);
-  GtkBoxPriv    *private = box->priv;
+  GtkBoxPrivate *private = box->priv;
 
   if (private->orientation == GTK_ORIENTATION_HORIZONTAL)
     gtk_box_compute_size_for_opposing_orientation (box, width, minimum_height, natural_height);
@@ -1298,8 +1377,7 @@ gtk_box_get_height_for_width (GtkSizeRequest *widget,
 
 /**
  * gtk_box_new:
- * @orientation: the box' orientation.
- * @homogeneous: %TRUE if all children are to be given equal space allocations.
+ * @orientation: the box's orientation.
  * @spacing: the number of pixels to place by default between children.
  *
  * Creates a new #GtkBox.
@@ -1310,13 +1388,11 @@ gtk_box_get_height_for_width (GtkSizeRequest *widget,
  **/
 GtkWidget*
 gtk_box_new (GtkOrientation orientation,
-             gboolean       homogeneous,
              gint           spacing)
 {
   return g_object_new (GTK_TYPE_BOX,
                        "orientation", orientation,
                        "spacing",     spacing,
-                       "homogeneous", homogeneous ? TRUE : FALSE,
                        NULL);
 }
 
@@ -1324,22 +1400,22 @@ gtk_box_new (GtkOrientation orientation,
  * gtk_box_pack_start:
  * @box: a #GtkBox
  * @child: the #GtkWidget to be added to @box
- * @expand: %TRUE if the new child is to be given extra space allocated to
- * @box.  The extra space will be divided evenly between all children of
- * @box that use this option
+ * @expand: %TRUE if the new child is to be given extra space allocated
+ *     to @box. The extra space will be divided evenly between all children
+ *     that use this option
  * @fill: %TRUE if space given to @child by the @expand option is
- *   actually allocated to @child, rather than just padding it.  This
- *   parameter has no effect if @expand is set to %FALSE.  A child is
- *   always allocated the full height of a #GtkHBox and the full width 
- *   of a #GtkVBox. This option affects the other dimension
+ *     actually allocated to @child, rather than just padding it.  This
+ *     parameter has no effect if @expand is set to %FALSE.  A child is
+ *     always allocated the full height of a horizontal #GtkBox and the full width
+ *     of a vertical #GtkBox. This option affects the other dimension
  * @padding: extra space in pixels to put between this child and its
  *   neighbors, over and above the global amount specified by
- *   #GtkBox:spacing property.  If @child is a widget at one of the 
- *   reference ends of @box, then @padding pixels are also put between 
+ *   #GtkBox:spacing property.  If @child is a widget at one of the
+ *   reference ends of @box, then @padding pixels are also put between
  *   @child and the reference edge of @box
  *
  * Adds @child to @box, packed with reference to the start of @box.
- * The @child is packed after any other child packed with reference 
+ * The @child is packed after any other child packed with reference
  * to the start of @box.
  */
 void
@@ -1356,22 +1432,22 @@ gtk_box_pack_start (GtkBox    *box,
  * gtk_box_pack_end:
  * @box: a #GtkBox
  * @child: the #GtkWidget to be added to @box
- * @expand: %TRUE if the new child is to be given extra space allocated 
- *   to @box. The extra space will be divided evenly between all children 
+ * @expand: %TRUE if the new child is to be given extra space allocated
+ *   to @box. The extra space will be divided evenly between all children
  *   of @box that use this option
  * @fill: %TRUE if space given to @child by the @expand option is
  *   actually allocated to @child, rather than just padding it.  This
  *   parameter has no effect if @expand is set to %FALSE.  A child is
- *   always allocated the full height of a #GtkHBox and the full width 
- *   of a #GtkVBox.  This option affects the other dimension
+ *   always allocated the full height of a horizontal #GtkBox and the full width
+ *   of a vertical #GtkBox.  This option affects the other dimension
  * @padding: extra space in pixels to put between this child and its
  *   neighbors, over and above the global amount specified by
- *   #GtkBox:spacing property.  If @child is a widget at one of the 
- *   reference ends of @box, then @padding pixels are also put between 
+ *   #GtkBox:spacing property.  If @child is a widget at one of the
+ *   reference ends of @box, then @padding pixels are also put between
  *   @child and the reference edge of @box
  *
- * Adds @child to @box, packed with reference to the end of @box.  
- * The @child is packed after (away from end of) any other child 
+ * Adds @child to @box, packed with reference to the end of @box.
+ * The @child is packed after (away from end of) any other child
  * packed with reference to the end of @box.
  */
 void
@@ -1389,16 +1465,16 @@ gtk_box_pack_end (GtkBox    *box,
  * @box: a #GtkBox
  * @homogeneous: a boolean value, %TRUE to create equal allotments,
  *   %FALSE for variable allotments
- * 
- * Sets the #GtkBox:homogeneous property of @box, controlling 
- * whether or not all children of @box are given equal space 
+ *
+ * Sets the #GtkBox:homogeneous property of @box, controlling
+ * whether or not all children of @box are given equal space
  * in the box.
  */
 void
 gtk_box_set_homogeneous (GtkBox  *box,
                         gboolean homogeneous)
 {
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
 
   g_return_if_fail (GTK_IS_BOX (box));
 
@@ -1434,14 +1510,14 @@ gtk_box_get_homogeneous (GtkBox *box)
  * @box: a #GtkBox
  * @spacing: the number of pixels to put between children
  *
- * Sets the #GtkBox:spacing property of @box, which is the 
+ * Sets the #GtkBox:spacing property of @box, which is the
  * number of pixels to place between children of @box.
  */
 void
 gtk_box_set_spacing (GtkBox *box,
                     gint    spacing)
 {
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
 
   g_return_if_fail (GTK_IS_BOX (box));
 
@@ -1461,9 +1537,9 @@ gtk_box_set_spacing (GtkBox *box,
 /**
  * gtk_box_get_spacing:
  * @box: a #GtkBox
- * 
+ *
  * Gets the value set by gtk_box_set_spacing().
- * 
+ *
  * Return value: spacing between children
  **/
 gint
@@ -1478,7 +1554,7 @@ void
 _gtk_box_set_spacing_set (GtkBox  *box,
                           gboolean spacing_set)
 {
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
 
   g_return_if_fail (GTK_IS_BOX (box));
 
@@ -1490,7 +1566,7 @@ _gtk_box_set_spacing_set (GtkBox  *box,
 gboolean
 _gtk_box_get_spacing_set (GtkBox *box)
 {
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
 
   g_return_val_if_fail (GTK_IS_BOX (box), FALSE);
 
@@ -1503,27 +1579,27 @@ _gtk_box_get_spacing_set (GtkBox *box)
  * gtk_box_reorder_child:
  * @box: a #GtkBox
  * @child: the #GtkWidget to move
- * @position: the new position for @child in the list of children 
- *   of @box, starting from 0. If negative, indicates the end of 
+ * @position: the new position for @child in the list of children
+ *   of @box, starting from 0. If negative, indicates the end of
  *   the list
  *
- * Moves @child to a new @position in the list of @box children.  
+ * Moves @child to a new @position in the list of @box children.
  * The list is the <structfield>children</structfield> field of
- * #GtkBox-struct, and contains both widgets packed #GTK_PACK_START 
- * as well as widgets packed #GTK_PACK_END, in the order that these 
+ * #GtkBox-struct, and contains both widgets packed #GTK_PACK_START
+ * as well as widgets packed #GTK_PACK_END, in the order that these
  * widgets were added to @box.
- * 
- * A widget's position in the @box children list determines where 
- * the widget is packed into @box.  A child widget at some position 
- * in the list will be packed just after all other widgets of the 
+ *
+ * A widget's position in the @box children list determines where
+ * the widget is packed into @box.  A child widget at some position
+ * in the list will be packed just after all other widgets of the
  * same packing type that appear earlier in the list.
- */ 
+ */
 void
 gtk_box_reorder_child (GtkBox    *box,
                       GtkWidget *child,
                       gint       position)
 {
-  GtkBoxPriv *priv;
+  GtkBoxPrivate *priv;
   GList *old_link;
   GList *new_link;
   GtkBoxChild *child_info = NULL;
@@ -1563,18 +1639,25 @@ gtk_box_reorder_child (GtkBox    *box,
   gtk_widget_child_notify (child, "position");
   if (gtk_widget_get_visible (child)
       && gtk_widget_get_visible (GTK_WIDGET (box)))
-    gtk_widget_queue_resize (child);
+    {
+      gtk_box_invalidate_order (box);
+      gtk_widget_queue_resize (child);
+    }
 }
 
 /**
  * gtk_box_query_child_packing:
  * @box: a #GtkBox
  * @child: the #GtkWidget of the child to query
- * @expand: pointer to return location for #GtkBox:expand child property 
- * @fill: pointer to return location for #GtkBox:fill child property 
- * @padding: pointer to return location for #GtkBox:padding child property 
- * @pack_type: pointer to return location for #GtkBox:pack-type child property 
- * 
+ * @expand: (out): pointer to return location for #GtkBox:expand child
+ *     property
+ * @fill: (out): pointer to return location for #GtkBox:fill child
+ *     property
+ * @padding: (out): pointer to return location for #GtkBox:padding
+ *     child property
+ * @pack_type: (out): pointer to return location for #GtkBox:pack-type
+ *     child property
+ *
  * Obtains information about how @child is packed into @box.
  */
 void
@@ -1585,7 +1668,7 @@ gtk_box_query_child_packing (GtkBox      *box,
                             guint       *padding,
                             GtkPackType *pack_type)
 {
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
   GList *list;
   GtkBoxChild *child_info = NULL;
 
@@ -1621,7 +1704,7 @@ gtk_box_query_child_packing (GtkBox      *box,
  * gtk_box_set_child_packing:
  * @box: a #GtkBox
  * @child: the #GtkWidget of the child to set
- * @expand: the new value of the #GtkBox:expand child property 
+ * @expand: the new value of the #GtkBox:expand child property
  * @fill: the new value of the #GtkBox:fill child property
  * @padding: the new value of the #GtkBox:padding child property
  * @pack_type: the new value of the #GtkBox:pack-type child property
@@ -1636,7 +1719,7 @@ gtk_box_set_child_packing (GtkBox      *box,
                           guint        padding,
                           GtkPackType  pack_type)
 {
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
   GList *list;
   GtkBoxChild *child_info = NULL;
 
@@ -1658,17 +1741,32 @@ gtk_box_set_child_packing (GtkBox      *box,
   gtk_widget_freeze_child_notify (child);
   if (list)
     {
-      child_info->expand = expand != FALSE;
-      gtk_widget_child_notify (child, "expand");
+      gboolean expanded;
+
+      expanded = expand != FALSE;
+
+      /* avoid setting expand if unchanged, since queue_compute_expand
+       * can be expensive-ish
+       */
+      if (child_info->expand != expanded)
+        {
+          child_info->expand = expand != FALSE;
+          gtk_widget_queue_compute_expand (GTK_WIDGET (box));
+          gtk_widget_child_notify (child, "expand");
+        }
+
       child_info->fill = fill != FALSE;
       gtk_widget_child_notify (child, "fill");
       child_info->padding = padding;
       gtk_widget_child_notify (child, "padding");
-      if (pack_type == GTK_PACK_END)
-       child_info->pack = GTK_PACK_END;
-      else
-       child_info->pack = GTK_PACK_START;
-      gtk_widget_child_notify (child, "pack-type");
+      if (pack_type != GTK_PACK_END)
+        pack_type = GTK_PACK_START;
+      if (child_info->pack != pack_type)
+        {
+         child_info->pack = pack_type;
+          gtk_widget_child_notify (child, "pack-type");
+          gtk_box_invalidate_order (box);
+        }
 
       if (gtk_widget_get_visible (child)
           && gtk_widget_get_visible (GTK_WIDGET (box)))
@@ -1680,7 +1778,7 @@ gtk_box_set_child_packing (GtkBox      *box,
 void
 _gtk_box_set_old_defaults (GtkBox *box)
 {
-  GtkBoxPriv *private;
+  GtkBoxPrivate *private;
 
   g_return_if_fail (GTK_IS_BOX (box));
 
@@ -1693,11 +1791,11 @@ static void
 gtk_box_add (GtkContainer *container,
             GtkWidget    *widget)
 {
-  GtkBoxPriv *priv = GTK_BOX (container)->priv;
+  GtkBoxPrivate *priv = GTK_BOX (container)->priv;
 
   gtk_box_pack_start (GTK_BOX (container), widget,
                       priv->default_expand,
-                      priv->default_expand,
+                      TRUE,
                       0);
 }
 
@@ -1706,7 +1804,7 @@ gtk_box_remove (GtkContainer *container,
                GtkWidget    *widget)
 {
   GtkBox *box = GTK_BOX (container);
-  GtkBoxPriv *priv = box->priv;
+  GtkBoxPrivate *priv = box->priv;
   GtkBoxChild *child;
   GList *children;
 
@@ -1719,6 +1817,10 @@ gtk_box_remove (GtkContainer *container,
        {
          gboolean was_visible;
 
+          g_signal_handlers_disconnect_by_func (widget,
+                                                box_child_visibility_notify_cb,
+                                                box);
+
          was_visible = gtk_widget_get_visible (widget);
          gtk_widget_unparent (widget);
 
@@ -1730,7 +1832,10 @@ gtk_box_remove (GtkContainer *container,
           * since that's what is needed by toplevels.
           */
          if (was_visible)
-           gtk_widget_queue_resize (GTK_WIDGET (container));
+            {
+              gtk_box_invalidate_order (box);
+             gtk_widget_queue_resize (GTK_WIDGET (container));
+            }
 
          break;
        }
@@ -1746,7 +1851,7 @@ gtk_box_forall (GtkContainer *container,
                gpointer      callback_data)
 {
   GtkBox *box = GTK_BOX (container);
-  GtkBoxPriv *priv = box->priv;
+  GtkBoxPrivate *priv = box->priv;
   GtkBoxChild *child;
   GList *children;
 
@@ -1774,7 +1879,7 @@ gtk_box_forall (GtkContainer *container,
 GList *
 _gtk_box_get_children (GtkBox *box)
 {
-  GtkBoxPriv *priv;
+  GtkBoxPrivate *priv;
   GtkBoxChild *child;
   GList *children;
   GList *retval = NULL;