]> Pileus Git - ~andy/fetchmail/blobdiff - socket.c
Merge branch 'legacy_63'
[~andy/fetchmail] / socket.c
index adc4f585866a61f8859e52a1ed060900fdfc9130..06a8efb5e56be736e78ae2a750e2edf687526ee5 100644 (file)
--- a/socket.c
+++ b/socket.c
 #include <errno.h>
 #include <string.h>
 #include <ctype.h> /* isspace() */
-#ifdef HAVE_MEMORY_H
-#include <memory.h>
-#endif /* HAVE_MEMORY_H */
 #include <sys/types.h>
 #include <sys/stat.h>
-#ifndef HAVE_NET_SOCKET_H
 #include <sys/socket.h>
-#else
-#include <net/socket.h>
-#endif
 #include <sys/un.h>
 #include <netinet/in.h>
-#ifdef HAVE_ARPA_INET_H
 #include <arpa/inet.h>
-#endif
 #include <netdb.h>
-#if defined(STDC_HEADERS)
 #include <stdlib.h>
-#endif
-#if defined(HAVE_UNISTD_H)
 #include <unistd.h>
-#endif
-#if defined(HAVE_STDARG_H)
 #include <stdarg.h>
-#else
-#include <varargs.h>
-#endif
-#if TIME_WITH_SYS_TIME
-# include <sys/time.h>
-# include <time.h>
-#else
-# if HAVE_SYS_TIME_H
-#  include <sys/time.h>
-# else
-#  include <time.h>
-# endif
-#endif
+#include <sys/time.h>
+#include <time.h>
 
 #include "socket.h"
 #include "fetchmail.h"
 #include "getaddrinfo.h"
-#include "i18n.h"
+#include "gettext.h"
 #include "sdump.h"
 
-/* Defines to allow BeOS and Cygwin to play nice... */
-#ifdef __BEOS__
-static char peeked;
-#define fm_close(a)  closesocket(a)
-#define fm_write(a,b,c)  send(a,b,c,0)
-#define fm_peek(a,b,c)   recv(a,b,c,0)
-#define fm_read(a,b,c)   recv(a,b,c,0)
-#else
-#define fm_close(a)  close(a)
+/* Defines to allow Cygwin to play nice... */
+#define fm_close(a)     close(a)
 #define fm_write(a,b,c)  write(a,b,c)
 #define fm_peek(a,b,c)   recv(a,b,c, MSG_PEEK)
+
 #ifdef __CYGWIN__
 #define fm_read(a,b,c)   cygwin_read(a,b,c)
 static ssize_t cygwin_read(int sock, void *buf, size_t count);
 #else /* ! __CYGWIN__ */
 #define fm_read(a,b,c)   read(a,b,c)
 #endif /* __CYGWIN__ */
-#endif
 
 /* We need to define h_errno only if it is not already */
 #ifndef h_errno
-
-#ifdef HAVE_RES_SEARCH
-/* some versions of FreeBSD should declare this but don't */
+# if !HAVE_DECL_H_ERRNO
 extern int h_errno;
-#else
-/* pretend we have h_errno to avoid some #ifdef's later */
-static int h_errno;
-#endif
-
+# endif
 #endif /* ndef h_errno */
 
-#ifdef HAVE_SOCKETPAIR
 static char *const *parse_plugin(const char *plugin, const char *host, const char *service)
-{      const char **argvec;
+{
+       char **argvec;
        const char *c, *p;
        char *cp, *plugin_copy;
        unsigned int plugin_copy_len;
@@ -135,25 +97,26 @@ static char *const *parse_plugin(const char *plugin, const char *host, const cha
        }
        plugin_copy[plugin_copy_len] = 0;
 
-       argvec = (const char **)malloc(s);
+       argvec = (char **)malloc(s);
        if (!argvec)
        {
+               free(plugin_copy);
                report(stderr, GT_("fetchmail: malloc failed\n"));
                return NULL;
        }
        memset(argvec, 0, s);
-       for (c = p = plugin_copy, i = 0; *c; c++)
-       {       if ((!isspace((unsigned char)*c)) && (c == p ? 1 : isspace((unsigned char)*p))) {
-                       argvec[i] = c;
+       for (p = cp = plugin_copy, i = 0; *cp; cp++)
+       {       if ((!isspace((unsigned char)*cp)) && (cp == p ? 1 : isspace((unsigned char)*p))) {
+                       argvec[i] = cp;
                        i++;
                }
-               p = c;
+               p = cp;
        }
        for (cp = plugin_copy; *cp; cp++)
        {       if (isspace((unsigned char)*cp))
                        *cp = 0;
        }
-       return (char *const*)argvec;
+       return argvec;
 }
 
 static int handle_plugin(const char *host,
@@ -184,16 +147,18 @@ static int handle_plugin(const char *host,
                (void) close(fds[1]);
                if ( (dup2(fds[0],0) == -1) || (dup2(fds[0],1) == -1) ) {
                        report(stderr, GT_("dup2 failed\n"));
-                       exit(1);
+                       _exit(EXIT_FAILURE);
                }
                /* fds[0] is now connected to 0 and 1; close it */
                (void) close(fds[0]);
                if (outlevel >= O_VERBOSE)
                    report(stderr, GT_("running %s (host %s service %s)\n"), plugin, host, service);
                argvec = parse_plugin(plugin,host,service);
+               if (argvec == NULL)
+                       _exit(EXIT_FAILURE);
                execvp(*argvec, argvec);
                report(stderr, GT_("execvp(%s) failed\n"), *argvec);
-               exit(0);
+               _exit(EXIT_FAILURE);
                break;
        default:        /* parent */
                /* NOP */
@@ -203,31 +168,12 @@ static int handle_plugin(const char *host,
     (void) close(fds[0]);
     return fds[1];
 }
-#endif /* HAVE_SOCKETPAIR */
 
-#ifdef __UNUSED__
-
-int SockCheckOpen(int fd)
-/* poll given socket; is it selectable? */
-{
-    fd_set r, w, e;
-    int rt;
-    struct timeval tv;
-  
-    for (;;) 
-    {
-       FD_ZERO(&r); FD_ZERO(&w); FD_ZERO(&e);
-       FD_SET(fd, &e);
-    
-       tv.tv_sec = 0; tv.tv_usec = 0;
-       rt = select(fd+1, &r, &w, &e, &tv);
-       if (rt == -1 && (errno != EAGAIN && errno != EINTR))
-           return 0;
-       if (rt != -1)
-           return 1;
-    }
+/** Set socket to SO_KEEPALIVE. \return 0 for success. */
+int SockKeepalive(int sock) {
+    int keepalive = 1;
+    return setsockopt(sock, SOL_SOCKET, SO_KEEPALIVE, &keepalive, sizeof keepalive);
 }
-#endif /* __UNUSED__ */
 
 int UnixOpen(const char *path)
 {
@@ -244,12 +190,12 @@ int UnixOpen(const char *path)
        return -1;
     }
 
-       /* Socket opened saved. Usefull if connect timeout 
-        * because it can be closed.
-        */
-       mailserver_socket_temp = sock;
-    
-       if (connect(sock, (struct sockaddr *) &ad, sizeof(ad)) < 0)
+    /* Socket opened saved. Useful if connect timeout
+     * because it can be closed.
+     */
+    mailserver_socket_temp = sock;
+
+    if (connect(sock, (struct sockaddr *) &ad, sizeof(ad)) < 0)
     {
        int olderr = errno;
        fm_close(sock); /* don't use SockClose, no traffic yet */
@@ -257,9 +203,9 @@ int UnixOpen(const char *path)
        errno = olderr;
        sock = -1;
     }
-       
-       /* No connect timeout, then no need to set mailserver_socket_temp */
-       mailserver_socket_temp = -1;
+
+    /* No connect timeout, then no need to set mailserver_socket_temp */
+    mailserver_socket_temp = -1;
 
     return sock;
 }
@@ -269,11 +215,11 @@ int SockOpen(const char *host, const char *service,
 {
     struct addrinfo *ai, req;
     int i, acterr = 0;
+    int ord;
+    char errbuf[8192] = "";
 
-#ifdef HAVE_SOCKETPAIR
     if (plugin)
        return handle_plugin(host,service,plugin);
-#endif /* HAVE_SOCKETPAIR */
 
     memset(&req, 0, sizeof(struct addrinfo));
     req.ai_socktype = SOCK_STREAM;
@@ -290,10 +236,13 @@ int SockOpen(const char *host, const char *service,
        return -1;
     }
 
+    /* NOTE a Linux bug here - getaddrinfo will happily return 127.0.0.1
+     * twice if no IPv6 is configured */
     i = -1;
-    for (ai = *ai0; ai; ai = ai->ai_next) {
-       char buf[80],pb[80];
-       int gnie;
+    for (ord = 0, ai = *ai0; ai; ord++, ai = ai->ai_next) {
+       char buf[256]; /* hostname */
+       char pb[256];  /* service name */
+       int gnie;      /* getnameinfo result code */
 
        gnie = getnameinfo(ai->ai_addr, ai->ai_addrlen, buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
        if (gnie)
@@ -304,17 +253,22 @@ int SockOpen(const char *host, const char *service,
 
        if (outlevel >= O_VERBOSE)
            report_build(stdout, GT_("Trying to connect to %s/%s..."), buf, pb);
-       i = socket(ai->ai_family, ai->ai_socktype, 0);
+       i = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol);
        if (i < 0) {
+           int e = errno;
            /* mask EAFNOSUPPORT errors, they confuse users for
             * multihomed hosts */
            if (errno != EAFNOSUPPORT)
                acterr = errno;
            if (outlevel >= O_VERBOSE)
-               report_complete(stdout, GT_("cannot create socket: %s\n"), strerror(errno));
+               report_complete(stdout, GT_("cannot create socket: %s\n"), strerror(e));
+           snprintf(errbuf+strlen(errbuf), sizeof(errbuf)-strlen(errbuf),\
+                    GT_("name %d: cannot create socket family %d type %d: %s\n"), ord, ai->ai_family, ai->ai_socktype, strerror(e));
            continue;
        }
 
+       SockKeepalive(i);
+
        /* Save socket descriptor.
         * Used to close the socket after connect timeout. */
        mailserver_socket_temp = i;
@@ -328,8 +282,9 @@ int SockOpen(const char *host, const char *service,
 
            if (outlevel >= O_VERBOSE)
                report_complete(stdout, GT_("connection failed.\n"));
-           if (outlevel > O_SILENT)
+           if (outlevel >= O_VERBOSE)
                report(stderr, GT_("connection to %s:%s [%s/%s] failed: %s.\n"), host, service, buf, pb, strerror(e));
+           snprintf(errbuf+strlen(errbuf), sizeof(errbuf)-strlen(errbuf), GT_("name %d: connection to %s:%s [%s/%s] failed: %s.\n"), ord, host, service, buf, pb, strerror(e));
            fm_close(i);
            i = -1;
            continue;
@@ -347,51 +302,54 @@ int SockOpen(const char *host, const char *service,
     fm_freeaddrinfo(*ai0);
     *ai0 = NULL;
 
-    if (i == -1)
+    if (i == -1) {
+       report(stderr, GT_("Connection errors for this poll:\n%s"), errbuf);
        errno = acterr;
+    }
 
     return i;
 }
 
-
-#if defined(HAVE_STDARG_H)
 int SockPrintf(int sock, const char* format, ...)
 {
-#else
-int SockPrintf(sock,format,va_alist)
-int sock;
-char *format;
-va_dcl {
-#endif
-
     va_list ap;
     char buf[8192];
 
-#if defined(HAVE_STDARG_H)
     va_start(ap, format) ;
-#else
-    va_start(ap);
-#endif
     vsnprintf(buf, sizeof(buf), format, ap);
     va_end(ap);
     return SockWrite(sock, buf, strlen(buf));
-
 }
 
 #ifdef SSL_ENABLE
+#define OPENSSL_NO_SSL_INTERN 1
 #include <openssl/ssl.h>
 #include <openssl/err.h>
 #include <openssl/pem.h>
 #include <openssl/x509v3.h>
 #include <openssl/rand.h>
 
+static void report_SSL_errors(FILE *stream)
+{
+    unsigned long err;
+
+    while (0ul != (err = ERR_get_error())) {
+       char *errstr = ERR_error_string(err, NULL);
+       report(stream, GT_("OpenSSL reported: %s\n"), errstr);
+    }
+}
+
+/* override ERR_print_errors_fp to our own implementation */
+#undef ERR_print_errors_fp
+#define ERR_print_errors_fp(stream) report_SSL_errors((stream))
+
 static SSL_CTX *_ctx[FD_SETSIZE];
 static SSL *_ssl_context[FD_SETSIZE];
 
 static SSL     *SSLGetContext( int );
 #endif /* SSL_ENABLE */
 
-int SockWrite(int sock, char *buf, int len)
+int SockWrite(int sock, const char *buf, int len)
 {
     int n, wrlen = 0;
 #ifdef SSL_ENABLE
@@ -425,14 +383,6 @@ int SockRead(int sock, char *buf, int len)
 
     if (--len < 1)
        return(-1);
-#ifdef __BEOS__
-    if (peeked != 0){
-        (*bp) = peeked;
-        bp++;
-        len--;
-        peeked = 0;
-    }
-#endif        
     do {
        /* 
         * The reason for these gymnastics is that we want two things:
@@ -446,7 +396,7 @@ int SockRead(int sock, char *buf, int len)
                /* OK...  SSL_peek works a little different from MSG_PEEK
                        Problem is that SSL_peek can return 0 if there
                        is no data currently available.  If, on the other
-                       hand, we loose the socket, we also get a zero, but
+                       hand, we lose the socket, we also get a zero, but
                        the SSL_read then SEGFAULTS!  To deal with this,
                        we'll check the error code any time we get a return
                        of zero from SSL_peek.  If we have an error, we bail.
@@ -495,18 +445,12 @@ int SockRead(int sock, char *buf, int len)
 #endif /* SSL_ENABLE */
        {
 
-#ifdef __BEOS__
-           if ((n = fm_read(sock, bp, 1)) <= 0)
-#else
            if ((n = fm_peek(sock, bp, len)) <= 0)
-#endif
                return (-1);
            if ((newline = (char *)memchr(bp, '\n', n)) != NULL)
                n = newline - bp + 1;
-#ifndef __BEOS__
            if ((n = fm_read(sock, bp, n)) == -1)
                return(-1);
-#endif /* __BEOS__ */
        }
        bp += n;
        len -= n;
@@ -561,9 +505,6 @@ int SockPeek(int sock)
        if (n == -1)
                return -1;
 
-#ifdef __BEOS__
-    peeked = ch;
-#endif
     return(ch);
 }
 
@@ -574,7 +515,9 @@ static      int _check_fp;
 static char *_check_digest;
 static         char *_server_label;
 static int _depth0ck;
+static int _firstrun;
 static int _prev_err;
+static int _verify_ok;
 
 SSL *SSLGetContext( int sock )
 {
@@ -585,12 +528,12 @@ SSL *SSLGetContext( int sock )
        return _ssl_context[sock];
 }
 
-
 /* ok_return (preverify_ok) is 1 if this stage of certificate verification
    passed, or 0 if it failed. This callback lets us display informative
    errors, and perform additional validation (e.g. CN matches) */
 static int SSL_verify_callback( int ok_return, X509_STORE_CTX *ctx, int strict )
 {
+#define SSLverbose (((outlevel) >= O_DEBUG) || ((outlevel) >= O_VERBOSE && (depth) == 0)) 
        char buf[257];
        X509 *x509_cert;
        int err, depth, i;
@@ -608,10 +551,21 @@ static int SSL_verify_callback( int ok_return, X509_STORE_CTX *ctx, int strict )
        subj = X509_get_subject_name(x509_cert);
        issuer = X509_get_issuer_name(x509_cert);
 
-       if (depth == 0 && !_depth0ck) {
-               _depth0ck = 1;
+       if (outlevel >= O_VERBOSE) {
+               if (depth == 0 && SSLverbose)
+                       report(stdout, GT_("Server certificate:\n"));
+               else {
+                       if (_firstrun) {
+                               _firstrun = 0;
+                               if (SSLverbose)
+                                       report(stdout, GT_("Certificate chain, from root to peer, starting at depth %d:\n"), depth);
+                       } else {
+                               if (SSLverbose)
+                                       report(stdout, GT_("Certificate at depth %d:\n"), depth);
+                       }
+               }
 
-               if (outlevel >= O_VERBOSE) {
+               if (SSLverbose) {
                        if ((i = X509_NAME_get_text_by_NID(issuer, NID_organizationName, buf, sizeof(buf))) != -1) {
                                report(stdout, GT_("Issuer Organization: %s\n"), (tt = sdump(buf, i)));
                                xfree(tt);
@@ -627,30 +581,39 @@ static int SSL_verify_callback( int ok_return, X509_STORE_CTX *ctx, int strict )
                        } else
                                report(stdout, GT_("Unknown Issuer CommonName\n"));
                }
+       }
+
+       if ((i = X509_NAME_get_text_by_NID(subj, NID_commonName, buf, sizeof(buf))) != -1) {
+               if (SSLverbose) {
+                       report(stdout, GT_("Subject CommonName: %s\n"), (tt = sdump(buf, i)));
+                       xfree(tt);
+               }
+               if ((size_t)i >= sizeof(buf) - 1) {
+                       /* Possible truncation. In this case, this is a DNS name, so this
+                        * is really bad. We do not tolerate this even in the non-strict case. */
+                       report(stderr, GT_("Bad certificate: Subject CommonName too long!\n"));
+                       return (0);
+               }
+               if ((size_t)i > strlen(buf)) {
+                       /* Name contains embedded NUL characters, so we complain. This is likely
+                        * a certificate spoofing attack. */
+                       report(stderr, GT_("Bad certificate: Subject CommonName contains NUL, aborting!\n"));
+                       return 0;
+               }
+       }
+
+       if (depth == 0) { /* peer certificate */
+               if (!_depth0ck) {
+                       _depth0ck = 1;
+               }
+
                if ((i = X509_NAME_get_text_by_NID(subj, NID_commonName, buf, sizeof(buf))) != -1) {
-                       if (outlevel >= O_VERBOSE) {
-                               report(stdout, GT_("Server CommonName: %s\n"), (tt = sdump(buf, i)));
-                               xfree(tt);
-                       }
-                       if ((size_t)i >= sizeof(buf) - 1) {
-                               /* Possible truncation. In this case, this is a DNS name, so this
-                                * is really bad. We do not tolerate this even in the non-strict case. */
-                               report(stderr, GT_("Bad certificate: Subject CommonName too long!\n"));
-                               return (0);
-                       }
-                       if ((size_t)i > strlen(buf)) {
-                               /* Name contains embedded NUL characters, so we complain. This is likely
-                                * a certificate spoofing attack. */
-                               report(stderr, GT_("Bad certificate: Subject CommonName contains NUL, aborting!\n"));
-                               return 0;
-                       }
                        if (_ssl_server_cname != NULL) {
                                char *p1 = buf;
                                char *p2 = _ssl_server_cname;
-                               int n;
                                int matched = 0;
                                STACK_OF(GENERAL_NAME) *gens;
-                               
+
                                /* RFC 2595 section 2.4: find a matching name
                                 * first find a match among alternative names */
                                gens = (STACK_OF(GENERAL_NAME) *)X509_get_ext_d2i(x509_cert, NID_subject_alt_name, NULL, NULL);
@@ -659,48 +622,37 @@ static int SSL_verify_callback( int ok_return, X509_STORE_CTX *ctx, int strict )
                                        for (j = 0, r = sk_GENERAL_NAME_num(gens); j < r; ++j) {
                                                const GENERAL_NAME *gn = sk_GENERAL_NAME_value(gens, j);
                                                if (gn->type == GEN_DNS) {
-                                                       char *p1 = (char *)gn->d.ia5->data;
-                                                       char *p2 = _ssl_server_cname;
+                                                       char *pp1 = (char *)gn->d.ia5->data;
+                                                       char *pp2 = _ssl_server_cname;
                                                        if (outlevel >= O_VERBOSE) {
-                                                               report(stdout, GT_("Subject Alternative Name: %s\n"), (tt = sdump(p1, (size_t)gn->d.ia5->length)));
+                                                               report(stdout, GT_("Subject Alternative Name: %s\n"), (tt = sdump(pp1, (size_t)gn->d.ia5->length)));
                                                                xfree(tt);
                                                        }
                                                        /* Name contains embedded NUL characters, so we complain. This
                                                         * is likely a certificate spoofing attack. */
-                                                       if ((size_t)gn->d.ia5->length != strlen(p1)) {
+                                                       if ((size_t)gn->d.ia5->length != strlen(pp1)) {
                                                                report(stderr, GT_("Bad certificate: Subject Alternative Name contains NUL, aborting!\n"));
                                                                sk_GENERAL_NAME_free(gens);
                                                                return 0;
                                                        }
-                                                       if (*p1 == '*') {
-                                                               ++p1;
-                                                               n = strlen(p2) - strlen(p1);
-                                                               if (n >= 0)
-                                                                       p2 += n;
-                                                       }
-                                                       if (0 == strcasecmp(p1, p2)) {
-                                                               matched = 1;
+                                                       if (name_match(pp1, pp2)) {
+                                                           matched = 1;
                                                        }
                                                }
                                        }
-                                       sk_GENERAL_NAME_free(gens);
-                               }
-                               if (*p1 == '*') {
-                                       ++p1;
-                                       n = strlen(p2) - strlen(p1);
-                                       if (n >= 0)
-                                               p2 += n;
+                                       GENERAL_NAMES_free(gens);
                                }
-                               if (0 == strcasecmp(p1, p2)) {
+                               if (name_match(p1, p2)) {
                                        matched = 1;
                                }
                                if (!matched) {
-                                       report(stderr,
-                                           GT_("Server CommonName mismatch: %s != %s\n"),
-                                           (tt = sdump(buf, i)), _ssl_server_cname );
-                                       xfree(tt);
-                                       if (ok_return && strict)
-                                               return (0);
+                                       if (strict || SSLverbose) {
+                                               report(stderr,
+                                                               GT_("Server CommonName mismatch: %s != %s\n"),
+                                                               (tt = sdump(buf, i)), _ssl_server_cname );
+                                               xfree(tt);
+                                       }
+                                       ok_return = 0;
                                }
                        } else if (ok_return) {
                                report(stderr, GT_("Server name not set, could not verify certificate!\n"));
@@ -754,14 +706,46 @@ static int SSL_verify_callback( int ok_return, X509_STORE_CTX *ctx, int strict )
        } /* if (depth == 0 && !_depth0ck) */
 
        if (err != X509_V_OK && err != _prev_err && !(_check_fp != 0 && _check_digest && !strict)) {
+               char *tmp;
+               int did_rep_err = 0;
                _prev_err = err;
-               report(stderr, GT_("Server certificate verification error: %s\n"), X509_verify_cert_error_string(err));
-               /* We gave the error code, but maybe we can add some more details for debugging */
+
+                report(stderr, GT_("Server certificate verification error: %s\n"), X509_verify_cert_error_string(err));
+                /* We gave the error code, but maybe we can add some more details for debugging */
+
                switch (err) {
+               /* actually we do not want to lump these together, but
+                * since OpenSSL flipped the meaning of these error
+                * codes in the past, and they do hardly make a
+                * practical difference because servers need not provide
+                * the root signing certificate, we don't bother telling
+                * users the difference:
+                */
+               case X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY:
                case X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT:
                        X509_NAME_oneline(issuer, buf, sizeof(buf));
                        buf[sizeof(buf) - 1] = '\0';
-                       report(stderr, GT_("unknown issuer (first %d characters): %s\n"), (int)(sizeof(buf)-1), buf);
+                       report(stderr, GT_("Broken certification chain at: %s\n"), (tmp = sdump(buf, strlen(buf))));
+                       xfree(tmp);
+                       report(stderr, GT_(     "This could mean that the server did not provide the intermediate CA's certificate(s), "
+                                               "which is nothing fetchmail could do anything about.  For details, "
+                                               "please see the README.SSL-SERVER document that ships with fetchmail.\n"));
+                       did_rep_err = 1;
+                       /* FALLTHROUGH */
+               case X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT:
+               case X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN:
+                       if (!did_rep_err) {
+                           X509_NAME_oneline(issuer, buf, sizeof(buf));
+                           buf[sizeof(buf) - 1] = '\0';
+                           report(stderr, GT_("Missing trust anchor certificate: %s\n"), (tmp = sdump(buf, strlen(buf))));
+                           xfree(tmp);
+                       }
+                       report(stderr, GT_(     "This could mean that the root CA's signing certificate is not in the "
+                                               "trusted CA certificate location, or that c_rehash needs to be run "
+                                               "on the certificate directory. For details, please "
+                                               "see the documentation of --sslcertpath and --sslcertfile in the manual page.\n"));
+                       break;
+               default:
                        break;
                }
        }
@@ -769,6 +753,7 @@ static int SSL_verify_callback( int ok_return, X509_STORE_CTX *ctx, int strict )
         * If not in strict checking mode (--sslcertck), override this
         * and pretend that verification had succeeded.
         */
+       _verify_ok &= ok_return;
        if (!strict)
                ok_return = 1;
        return (ok_return);
@@ -819,16 +804,17 @@ static const char *SSLCertGetCN(const char *mycert,
  * uses SSL *ssl global variable, which is currently defined
  * in this file
  */
-int SSLOpen(int sock, char *mycert, char *mykey, char *myproto, int certck, char *certpath,
+int SSLOpen(int sock, char *mycert, char *mykey, const char *myproto, int certck,
+    char *cacertfile, char *certpath,
     char *fingerprint, char *servercname, char *label, char **remotename)
 {
         struct stat randstat;
         int i;
 
        SSL_load_error_strings();
-       SSLeay_add_ssl_algorithms(); /* synonym for SSL_library_init() */
-       
-#ifdef SSL_ENABLE
+       SSL_library_init();
+       OpenSSL_add_all_algorithms(); /* see Debian Bug#576430 and manpage */
+
         if (stat("/dev/random", &randstat)  &&
             stat("/dev/urandom", &randstat)) {
           /* Neither /dev/random nor /dev/urandom are present, so add
@@ -844,8 +830,6 @@ int SSLOpen(int sock, char *mycert, char *mykey, char *myproto, int certck, char
             RAND_add (buf, sizeof buf, 0.1);
           }
         }
-#endif /* SSL_ENABLE */
-
 
        if( sock < 0 || (unsigned)sock > FD_SETSIZE ) {
                report(stderr, GT_("File descriptor out of range for SSL") );
@@ -855,16 +839,14 @@ int SSLOpen(int sock, char *mycert, char *mykey, char *myproto, int certck, char
        /* Make sure a connection referring to an older context is not left */
        _ssl_context[sock] = NULL;
        if(myproto) {
-               if(!strcasecmp("ssl2",myproto)) {
-                       _ctx[sock] = SSL_CTX_new(SSLv2_client_method());
-               } else if(!strcasecmp("ssl3",myproto)) {
+               if(!strcasecmp("ssl3",myproto)) {
                        _ctx[sock] = SSL_CTX_new(SSLv3_client_method());
                } else if(!strcasecmp("tls1",myproto)) {
                        _ctx[sock] = SSL_CTX_new(TLSv1_client_method());
                } else if (!strcasecmp("ssl23",myproto)) {
                        myproto = NULL;
                } else {
-                       fprintf(stderr,GT_("Invalid SSL protocol '%s' specified, using default (SSLv23).\n"), myproto);
+                       report(stderr,GT_("Invalid SSL protocol '%s' specified, using default (SSLv23).\n"), myproto);
                        myproto = NULL;
                }
        }
@@ -876,19 +858,34 @@ int SSLOpen(int sock, char *mycert, char *mykey, char *myproto, int certck, char
                return(-1);
        }
 
-       SSL_CTX_set_options(_ctx[sock], SSL_OP_ALL);
+       SSL_CTX_set_options(_ctx[sock], (SSL_OP_ALL | SSL_OP_NO_SSLv2) & ~SSL_OP_DONT_INSERT_EMPTY_FRAGMENTS);
 
        if (certck) {
                SSL_CTX_set_verify(_ctx[sock], SSL_VERIFY_PEER, SSL_ck_verify_callback);
        } else {
                /* In this case, we do not fail if verification fails. However,
-                *  we provide the callback for output and possible fingerprint checks. */
+                * we provide the callback for output and possible fingerprint
+                * checks. */
                SSL_CTX_set_verify(_ctx[sock], SSL_VERIFY_PEER, SSL_nock_verify_callback);
        }
-       if (certpath)
-               SSL_CTX_load_verify_locations(_ctx[sock], NULL, certpath);
-       else
-               SSL_CTX_set_default_verify_paths(_ctx[sock]);
+
+       /* Check which trusted X.509 CA certificate store(s) to load */
+       {
+               char *tmp;
+               int want_default_cacerts = 0;
+
+               /* Load user locations if any is given */
+               if (certpath || cacertfile)
+                       SSL_CTX_load_verify_locations(_ctx[sock],
+                                               cacertfile, certpath);
+               else
+                       want_default_cacerts = 1;
+
+               tmp = getenv("FETCHMAIL_INCLUDE_DEFAULT_X509_CA_CERTS");
+               if (want_default_cacerts || (tmp && tmp[0])) {
+                       SSL_CTX_set_default_verify_paths(_ctx[sock]);
+               }
+       }
        
        _ssl_context[sock] = SSL_new(_ctx[sock]);
        
@@ -905,6 +902,8 @@ int SSLOpen(int sock, char *mycert, char *mykey, char *myproto, int certck, char
        _check_fp = 1;
        _check_digest = fingerprint;
        _depth0ck = 0;
+       _firstrun = 1;
+       _verify_ok = 1;
        _prev_err = -1;
 
        if( mycert || mykey ) {
@@ -955,6 +954,11 @@ int SSLOpen(int sock, char *mycert, char *mykey, char *myproto, int certck, char
                }
        }
 
+       if (!certck && !fingerprint &&
+               (SSL_get_verify_result(_ssl_context[sock]) != X509_V_OK || !_verify_ok)) {
+               report(stderr, GT_("Warning: the connection is insecure, continuing anyways. (Better use --sslcertck!)\n"));
+       }
+
        return(0);
 }
 #endif
@@ -973,30 +977,6 @@ int SockClose(int sock)
     }
 #endif
 
-#ifdef __UNUSED__
-    /* 
-     * This hangs in RedHat 6.2 after fetchmail runs for a while a
-     * FIN_WAIT2 comes up in netstat and fetchmail never returns from
-     * the recv system call. (Reported from jtnews
-     * <jtnews@bellatlantic.net>, Wed, 24 May 2000 21:26:02.)
-     *
-     * Half-close the connection first so the other end gets notified.
-     *
-     * This stops sends but allows receives (effectively, it sends a
-     * TCP <FIN>).  */
-    if (shutdown(sock, 1) == 0) {
-       char ch;
-       /* If there is any data still waiting in the queue, discard it.
-        * Call recv() until either it returns 0 (meaning we received a FIN)
-        * or any error occurs.  This makes sure all data sent by the other
-        * side is acknowledged at the TCP level.
-        */
-       if (fm_peek(sock, &ch, 1) > 0)
-           while (fm_read(sock, &ch, 1) > 0)
-               continue;
-    }
-#endif /* __UNUSED__ */
-
     /* if there's an error closing at this point, not much we can do */
     return(fm_close(sock));    /* this is guarded */
 }
@@ -1009,18 +989,18 @@ int SockClose(int sock)
  */
 static ssize_t cygwin_read(int sock, void *buf, size_t count)
 {
-    char *bp = buf;
-    int n = 0;
+    char *bp = (char *)buf;
+    size_t n = 0;
 
-    if ((n = read(sock, bp, count)) == -1)
+    if ((n = read(sock, bp, count)) == (size_t)-1)
        return(-1);
 
     if (n != count) {
-       int n2 = 0;
+       size_t n2 = 0;
        if (outlevel >= O_VERBOSE)
            report(stdout, GT_("Cygwin socket read retry\n"));
        n2 = read(sock, bp + n, count - n);
-       if (n2 == -1 || n + n2 != count) {
+       if (n2 == (size_t)-1 || n + n2 != count) {
            report(stderr, GT_("Cygwin socket read retry failed!\n"));
            return(-1);
        }
@@ -1029,21 +1009,3 @@ static ssize_t cygwin_read(int sock, void *buf, size_t count)
     return count;
 }
 #endif /* __CYGWIN__ */
-
-#ifdef MAIN
-/*
- * Use the chargen service to test input buffering directly.
- * You may have to uncomment the `chargen' service description in your
- * inetd.conf (and then SIGHUP inetd) for this to work.  */
-main()
-{
-    int                sock = SockOpen("localhost", "chargen", NULL);
-    char       buf[80];
-
-    while (SockRead(sock, buf, sizeof(buf)-1))
-       SockWrite(1, buf, strlen(buf));
-    SockClose(sock);
-}
-#endif /* MAIN */
-
-/* socket.c ends here */