]> Pileus Git - aweather/blobdiff - src/plugins/radar.c
Fix pointer/loading bugs in RadarSite hiding
[aweather] / src / plugins / radar.c
index 75fc3783de71e9399ec75d570ae9f40ab7ef8f80..a4ed00479bc19b5713505f7d310ae7a88d058e50 100644 (file)
 #include "level2.h"
 #include "../aweather-location.h"
 
+GtkWidget *_gtk_check_label_new(const gchar *text, gboolean state,
+               GCallback on_clicked, gpointer user_data)
+{
+       GtkWidget *hbox  = gtk_hbox_new(FALSE, 0);
+       GtkWidget *check = gtk_check_button_new();
+       GtkWidget *label = gtk_label_new(text);
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(check), state);
+       g_signal_connect_swapped(check , "clicked",
+                       G_CALLBACK(on_clicked), user_data);
+       gtk_box_pack_start(GTK_BOX(hbox), label, TRUE, TRUE, 0);
+       gtk_box_pack_end(GTK_BOX(hbox), check , FALSE, FALSE, 0);
+       gtk_widget_show_all(hbox);
+       return hbox;
+}
+
 void _gtk_bin_set_child(GtkBin *bin, GtkWidget *new)
 {
        GtkWidget *old = gtk_bin_get_child(bin);
@@ -88,6 +103,7 @@ struct _RadarSite {
        GtkWidget     *pconfig;
 
        /* When loaded */
+       gboolean        hidden;
        RadarSiteStatus status;     // Loading status for the site
        GtkWidget      *config;
        AWeatherLevel2 *level2;     // The Level2 structure for the current volume
@@ -130,23 +146,15 @@ gboolean _site_update_end(gpointer _site)
 gpointer _site_update_thread(gpointer _site)
 {
        RadarSite *site = _site;
-       g_debug("GisPluginRadar: _update - %s", site->city->code);
-       site->status = STATUS_LOADING;
+       g_debug("GisPluginRadar: _site_update_thread - %s", site->city->code);
        site->message = NULL;
 
        gboolean offline = gis_viewer_get_offline(site->viewer);
        gchar *nexrad_url = gis_prefs_get_string(site->prefs,
                        "aweather/nexrad_url", NULL);
 
-       /* Remove old volume */
-       g_debug("GisPluginRadar: _update - remove - %s", site->city->code);
-       if (site->level2_ref) {
-               gis_viewer_remove(site->viewer, site->level2_ref);
-               site->level2_ref = NULL;
-       }
-
        /* Find nearest volume (temporally) */
-       g_debug("GisPluginRadar: _update - find nearest - %s", site->city->code);
+       g_debug("GisPluginRadar: _site_update_thread - find nearest - %s", site->city->code);
        gchar *dir_list = g_strconcat(nexrad_url, "/", site->city->code,
                        "/", "dir.list", NULL);
        GList *files = gis_http_available(site->http,
@@ -162,7 +170,7 @@ gpointer _site_update_thread(gpointer _site)
        }
 
        /* Fetch new volume */
-       g_debug("GisPluginRadar: _update - fetch");
+       g_debug("GisPluginRadar: _site_update_thread - fetch");
        gchar *local = g_strconcat(site->city->code, "/", nearest, NULL);
        gchar *uri   = g_strconcat(nexrad_url, "/", local,   NULL);
        gchar *file = gis_http_fetch(site->http, uri, local,
@@ -178,7 +186,7 @@ gpointer _site_update_thread(gpointer _site)
        }
 
        /* Load and add new volume */
-       g_debug("GisPluginRadar: _update - load - %s", site->city->code);
+       g_debug("GisPluginRadar: _site_update_thread - load - %s", site->city->code);
        site->level2 = aweather_level2_new_from_file(
                        site->viewer, colormaps, file, site->city->code);
        g_free(file);
@@ -186,6 +194,7 @@ gpointer _site_update_thread(gpointer _site)
                site->message = "Load failed";
                goto out;
        }
+       GIS_OBJECT(site->level2)->hidden = site->hidden;
        site->level2_ref = gis_viewer_add(site->viewer,
                        GIS_OBJECT(site->level2), GIS_LEVEL_WORLD, TRUE);
 
@@ -195,8 +204,12 @@ out:
 }
 void _site_update(RadarSite *site)
 {
+       if (site->status == STATUS_LOADING)
+               return;
+       site->status = STATUS_LOADING;
+
        site->time = gis_viewer_get_time(site->viewer);
-       g_debug("GisPluginRadar: _on_time_changed %s - %d",
+       g_debug("GisPluginRadar: _site_update %s - %d",
                        site->city->code, (gint)site->time);
 
        /* Add a progress bar */
@@ -204,6 +217,13 @@ void _site_update(RadarSite *site)
        gtk_progress_bar_set_text(GTK_PROGRESS_BAR(progress), "Loading...");
        _gtk_bin_set_child(GTK_BIN(site->config), progress);
 
+       /* Remove old volume */
+       g_debug("GisPluginRadar: _site_update - remove - %s", site->city->code);
+       if (site->level2_ref) {
+               gis_viewer_remove(site->viewer, site->level2_ref);
+               site->level2_ref = NULL;
+       }
+
        /* Fork loading right away so updating the
         * list of times doesn't take too long */
        g_thread_create(_site_update_thread, site, FALSE, NULL);
@@ -235,28 +255,25 @@ void radar_site_unload(RadarSite *site)
        site->status = STATUS_UNLOADED;
 }
 
+void radar_site_toggle(RadarSite *site)
+{
+       site->hidden = !site->hidden;
+       if (site->level2) {
+               GIS_OBJECT(site->level2)->hidden = site->hidden;
+               gtk_widget_queue_draw(GTK_WIDGET(site->viewer));
+       }
+}
+
 void radar_site_load(RadarSite *site)
 {
        g_debug("GisPluginRadar: radar_site_load %s", site->city->code);
-       site->status = STATUS_LOADING;
 
        /* Add tab page */
        site->config = gtk_alignment_new(0, 0, 1, 1);
-       GtkWidget *tab   = gtk_hbox_new(FALSE, 0);
-       GtkWidget *close = gtk_button_new();
-       GtkWidget *label = gtk_label_new(site->city->name);
-       gtk_container_add(GTK_CONTAINER(close),
-                       gtk_image_new_from_stock(GTK_STOCK_CLOSE,
-                               GTK_ICON_SIZE_MENU));
-       gtk_button_set_relief(GTK_BUTTON(close), GTK_RELIEF_NONE);
-       g_signal_connect_swapped(close, "clicked",
-                       G_CALLBACK(radar_site_unload), site);
-       gtk_box_pack_start(GTK_BOX(tab), label, TRUE, TRUE, 0);
-       gtk_box_pack_end(GTK_BOX(tab), close, FALSE, FALSE, 0);
-       gtk_notebook_append_page(GTK_NOTEBOOK(site->pconfig),
-                       site->config, tab);
+       gtk_notebook_append_page(GTK_NOTEBOOK(site->pconfig), site->config,
+                       _gtk_check_label_new(site->city->name, !site->hidden,
+                               G_CALLBACK(radar_site_toggle), site));
        gtk_widget_show_all(site->config);
-       gtk_widget_show_all(tab);
 
        /* Set up radar loading */
        site->time_id = g_signal_connect_swapped(site->viewer, "time-changed",
@@ -308,7 +325,8 @@ RadarSite *radar_site_new(city_t *city, GtkWidget *pconfig,
        site->pconfig = pconfig;
 
        /* Add marker */
-       g_idle_add(_site_add_marker, site);
+       g_idle_add_full(G_PRIORITY_LOW, _site_add_marker, site, NULL);
+
 
        /* Connect signals */
        site->location_id  = g_signal_connect(viewer, "location-changed",
@@ -331,16 +349,23 @@ void radar_site_free(RadarSite *site)
 /**************
  * RadarConus *
  **************/
+#define CONUS_NORTH       50.406626367301044
+#define CONUS_WEST       -127.620375523875420
+#define CONUS_WIDTH       3400.0
+#define CONUS_HEIGHT      1600.0
+#define CONUS_DEG_PER_PX  0.017971305190311
+
 struct _RadarConus {
        GisViewer   *viewer;
        GisHttp     *http;
        GtkWidget   *config;
        time_t       time;
-       GisTile     *tile;
-       gpointer    *tile_ref;
-       GdkPixbuf   *pixbuf;
        const gchar *message;
-       gchar       *nearest;
+       GStaticMutex loading;
+
+       gchar       *path;
+       GisTile     *tile[2];
+       gpointer    *tile_ref[2];
 
        guint        time_id;     // "time-changed"     callback ID
        guint        refresh_id;  // "refresh"          callback ID
@@ -359,119 +384,157 @@ void _conus_update_loading(gchar *file, goffset cur,
        g_free(msg);
 }
 
-gboolean _conus_update_end(gpointer _conus)
+/* Copy images to graphics memory */
+static void _conus_update_end_copy(GisTile *tile, guchar *pixels)
 {
-       RadarConus *conus = _conus;
-
-       guchar    *pixels = gdk_pixbuf_get_pixels(conus->pixbuf);
-       gboolean   alpha  = gdk_pixbuf_get_has_alpha(conus->pixbuf);
-       gint       width  = gdk_pixbuf_get_width(conus->pixbuf);
-       gint       height = gdk_pixbuf_get_height(conus->pixbuf);
-
-       if (!conus->tile->data) {
-               conus->tile->data = g_new0(guint, 1);
-               glGenTextures(1, conus->tile->data);
+       if (!tile->data) {
+               tile->data = g_new0(guint, 1);
+               glGenTextures(1, tile->data);
        }
 
-       guint *tex = conus->tile->data;
+       guint *tex = tile->data;
        glBindTexture(GL_TEXTURE_2D, *tex);
 
        glPixelStorei(GL_UNPACK_ALIGNMENT, 1);
        glPixelStorei(GL_PACK_ALIGNMENT, 1);
-       glTexImage2D(GL_TEXTURE_2D, 0, 4, width, height, 0,
-                       (alpha ? GL_RGBA : GL_RGB), GL_UNSIGNED_BYTE, pixels);
-       glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
-       glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
+       glTexImage2D(GL_TEXTURE_2D, 0, 4, 2048, 2048, 0,
+                       GL_RGBA, GL_UNSIGNED_BYTE, NULL);
+       glTexSubImage2D(GL_TEXTURE_2D, 0, 1,1, CONUS_WIDTH/2,CONUS_HEIGHT,
+                       GL_RGBA, GL_UNSIGNED_BYTE, pixels);
+       tile->coords.n = 1.0/(CONUS_WIDTH/2);
+       tile->coords.w = 1.0/ CONUS_HEIGHT;
+       tile->coords.s = tile->coords.n +  CONUS_HEIGHT   / 2048.0;
+       tile->coords.e = tile->coords.w + (CONUS_WIDTH/2) / 2048.0;
+       glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST);
+       glTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST);
        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP);
        glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP);
        glFlush();
+}
 
-       /* finish */
-       _gtk_bin_set_child(GTK_BIN(conus->config),
-                       gtk_label_new(conus->nearest));
-       gtk_widget_queue_draw(GTK_WIDGET(conus->viewer));
+/* Split the pixbuf into east and west halves (with 2K sides)
+ * Also map the pixbuf's alpha values */
+static void _conus_update_end_split(guchar *pixels, guchar *west, guchar *east,
+               gint width, gint height, gint pxsize)
+{
+       g_debug("GisPluginRadar: _conus_update_end_split");
+       guchar *out[] = {west,east};
+       const guchar alphamap[][4] = {
+               {0x04, 0xe9, 0xe7, 0x30},
+               {0x01, 0x9f, 0xf4, 0x60},
+               {0x03, 0x00, 0xf4, 0x90},
+       };
+       for (int y = 0; y < height; y++)
+       for (int x = 0; x < width;  x++) {
+               gint subx = x % (width/2);
+               gint idx  = x / (width/2);
+               guchar *src = &pixels[(y*width+x)*pxsize];
+               guchar *dst = &out[idx][(y*(width/2)+subx)*4];
+               if (src[0] > 0xe0 &&
+                   src[1] > 0xe0 &&
+                   src[2] > 0xe0) {
+                       dst[3] = 0x00;
+               } else {
+                       dst[0] = src[0];
+                       dst[1] = src[1];
+                       dst[2] = src[2];
+                       dst[3] = 0xff;
+                       for (int j = 0; j < G_N_ELEMENTS(alphamap); j++)
+                               if (src[0] == alphamap[j][0] &&
+                                   src[1] == alphamap[j][1] &&
+                                   src[2] == alphamap[j][2])
+                                       dst[3] = alphamap[j][3];
+               }
+       }
+}
+
+gboolean _conus_update_end(gpointer _conus)
+{
+       RadarConus *conus = _conus;
+       g_debug("GisPluginRadar: _conus_update_end");
+
+       /* Check error status */
+       if (conus->message) {
+               g_warning("GisPluginRadar: _conus_update_end - %s", conus->message);
+               _gtk_bin_set_child(GTK_BIN(conus->config), gtk_label_new(conus->message));
+               goto out;
+       }
 
-       /* free data */
-       g_object_unref(conus->pixbuf);
-       g_free(conus->nearest);
+       /* Load and pixbuf */
+       GError *error = NULL;
+       GdkPixbuf *pixbuf = gdk_pixbuf_new_from_file(conus->path, &error);
+       guchar    *pixels = gdk_pixbuf_get_pixels(pixbuf);
+       gint       width  = gdk_pixbuf_get_width(pixbuf);
+       gint       height = gdk_pixbuf_get_height(pixbuf);
+       gint       pxsize = gdk_pixbuf_get_has_alpha(pixbuf) ? 4 : 3;
+
+       /* Split pixels into east/west parts */
+       guchar *pixels_west = g_malloc(4*(width/2)*height);
+       guchar *pixels_east = g_malloc(4*(width/2)*height);
+       _conus_update_end_split(pixels, pixels_west, pixels_east,
+                       width, height, pxsize);
+       g_object_unref(pixbuf);
+
+       /* Copy pixels to graphics memory */
+       _conus_update_end_copy(conus->tile[0], pixels_west);
+       _conus_update_end_copy(conus->tile[1], pixels_east);
+       g_free(pixels_west);
+       g_free(pixels_east);
+
+       /* Update GUI */
+       gchar *label = g_path_get_basename(conus->path);
+       _gtk_bin_set_child(GTK_BIN(conus->config), gtk_label_new(label));
+       gtk_widget_queue_draw(GTK_WIDGET(conus->viewer));
+       g_free(label);
 
+out:
+       g_free(conus->path);
+       g_static_mutex_unlock(&conus->loading);
        return FALSE;
 }
 
 gpointer _conus_update_thread(gpointer _conus)
 {
        RadarConus *conus = _conus;
+       conus->message = NULL;
 
        /* Find nearest */
+       g_debug("GisPluginRadar: _conus_update_thread - nearest");
        gboolean offline = gis_viewer_get_offline(conus->viewer);
        gchar *conus_url = "http://radar.weather.gov/Conus/RadarImg/";
        GList *files = gis_http_available(conus->http,
                        "^Conus_[^\"]*_N0Ronly.gif$", "",
                        NULL, (offline ? NULL : conus_url));
-       conus->nearest = _find_nearest(conus->time, files, 6, "%Y%m%d_%H%M");
+       gchar *nearest = _find_nearest(conus->time, files, 6, "%Y%m%d_%H%M");
        g_list_foreach(files, (GFunc)g_free, NULL);
        g_list_free(files);
-       if (!conus->nearest) {
+       if (!nearest) {
                conus->message = "No suitable files";
                goto out;
        }
 
        /* Fetch the image */
-       gchar *uri     = g_strconcat(conus_url, conus->nearest, NULL);
-       gchar *path    = gis_http_fetch(conus->http, uri, conus->nearest, GIS_ONCE,
+       g_debug("GisPluginRadar: _conus_update_thread - fetch");
+       gchar *uri  = g_strconcat(conus_url, nearest, NULL);
+       conus->path = gis_http_fetch(conus->http, uri, nearest, GIS_ONCE,
                        _conus_update_loading, conus);
+       g_free(nearest);
        g_free(uri);
-       if (!path) {
+       if (!conus->path) {
                conus->message = "Fetch failed";
                goto out;
        }
 
-       /* Load the image to a pixbuf */
-       GError *error = NULL;
-       conus->pixbuf = gdk_pixbuf_new_from_file(path, &error);
-       g_free(path);
-       if (!gdk_pixbuf_get_has_alpha(conus->pixbuf)) {
-               GdkPixbuf *tmp = gdk_pixbuf_add_alpha(conus->pixbuf, TRUE, 0xff, 0xff, 0xff);
-               g_object_unref(conus->pixbuf);
-               conus->pixbuf = tmp;
-       }
-
-       /* Map the pixbuf's alpha values */
-       const guchar colormap[][2][4] = {
-               {{0x04, 0xe9, 0xe7}, {0x04, 0xe9, 0xe7, 0x30}},
-               {{0x01, 0x9f, 0xf4}, {0x01, 0x9f, 0xf4, 0x60}},
-               {{0x03, 0x00, 0xf4}, {0x03, 0x00, 0xf4, 0x90}},
-       };
-       guchar *pixels = gdk_pixbuf_get_pixels(conus->pixbuf);
-       gint    height = gdk_pixbuf_get_height(conus->pixbuf);
-       gint    width  = gdk_pixbuf_get_width(conus->pixbuf);
-       for (int i = 0; i < width*height; i++) {
-               for (int j = 0; j < G_N_ELEMENTS(colormap); j++) {
-                       if (pixels[i*4+0] > 0xe0 &&
-                           pixels[i*4+1] > 0xe0 &&
-                           pixels[i*4+2] > 0xe0) {
-                               pixels[i*4+3] = 0x00;
-                               break;
-                       }
-                       if (pixels[i*4+0] == colormap[j][0][0] &&
-                           pixels[i*4+1] == colormap[j][0][1] &&
-                           pixels[i*4+2] == colormap[j][0][2]) {
-                               pixels[i*4+0] = colormap[j][1][0];
-                               pixels[i*4+1] = colormap[j][1][1];
-                               pixels[i*4+2] = colormap[j][1][2];
-                               pixels[i*4+3] = colormap[j][1][3];
-                               break;
-                       }
-               }
-       }
-
 out:
+       g_debug("GisPluginRadar: _conus_update_thread - done");
        g_idle_add(_conus_update_end, conus);
        return NULL;
 }
 
 void _conus_update(RadarConus *conus)
 {
+       if (!g_static_mutex_trylock(&conus->loading))
+               return;
        conus->time = gis_viewer_get_time(conus->viewer);
        g_debug("GisPluginRadar: _conus_update - %d",
                        (gint)conus->time);
@@ -484,6 +547,15 @@ void _conus_update(RadarConus *conus)
        g_thread_create(_conus_update_thread, conus, FALSE, NULL);
 }
 
+void radar_conus_toggle(RadarConus *conus)
+{
+       GIS_OBJECT(conus->tile[0])->hidden =
+               !GIS_OBJECT(conus->tile[0])->hidden;
+       GIS_OBJECT(conus->tile[1])->hidden =
+               !GIS_OBJECT(conus->tile[1])->hidden;
+       gtk_widget_queue_draw(GTK_WIDGET(conus->viewer));
+}
+
 RadarConus *radar_conus_new(GtkWidget *pconfig,
                GisViewer *viewer, GisHttp *http)
 {
@@ -491,19 +563,28 @@ RadarConus *radar_conus_new(GtkWidget *pconfig,
        conus->viewer  = g_object_ref(viewer);
        conus->http    = http;
        conus->config  = gtk_alignment_new(0, 0, 1, 1);
-       conus->tile    = gis_tile_new(NULL,
-                       50.406626367301044,   50.406626367301044-0.017971305190311*1600,
-                       -127.620375523875420+0.017971305190311*3400, -127.620375523875420);
-       conus->tile->zindex = 1;
-       conus->tile_ref = gis_viewer_add(viewer,
-                       GIS_OBJECT(conus->tile), GIS_LEVEL_WORLD, TRUE);
+       g_static_mutex_init(&conus->loading);
+
+       gdouble south =  CONUS_NORTH - CONUS_DEG_PER_PX*CONUS_HEIGHT;
+       gdouble east  =  CONUS_WEST  + CONUS_DEG_PER_PX*CONUS_WIDTH;
+       gdouble mid   =  CONUS_WEST  + CONUS_DEG_PER_PX*CONUS_WIDTH/2;
+       conus->tile[0] = gis_tile_new(NULL, CONUS_NORTH, south, mid, CONUS_WEST);
+       conus->tile[1] = gis_tile_new(NULL, CONUS_NORTH, south, east, mid);
+       conus->tile[0]->zindex = 2;
+       conus->tile[1]->zindex = 1;
+       conus->tile_ref[0] = gis_viewer_add(viewer,
+                       GIS_OBJECT(conus->tile[0]), GIS_LEVEL_WORLD, TRUE);
+       conus->tile_ref[1] = gis_viewer_add(viewer,
+                       GIS_OBJECT(conus->tile[1]), GIS_LEVEL_WORLD, TRUE);
 
        conus->time_id = g_signal_connect_swapped(viewer, "time-changed",
                        G_CALLBACK(_conus_update), conus);
        conus->refresh_id = g_signal_connect_swapped(viewer, "refresh",
                        G_CALLBACK(_conus_update), conus);
 
-       gtk_notebook_append_page(GTK_NOTEBOOK(pconfig), conus->config, gtk_label_new("Conus"));
+       gtk_notebook_append_page(GTK_NOTEBOOK(pconfig), conus->config,
+                       _gtk_check_label_new("Conus", TRUE,
+                               G_CALLBACK(radar_conus_toggle), conus));
        _conus_update(conus);
        return conus;
 }
@@ -513,11 +594,15 @@ void radar_conus_free(RadarConus *conus)
        g_signal_handler_disconnect(conus->viewer, conus->time_id);
        g_signal_handler_disconnect(conus->viewer, conus->refresh_id);
 
-       if (conus->tile->data) {
-               glDeleteTextures(1, conus->tile->data);
-               g_free(conus->tile->data);
+       for (int i = 0; i < 2; i++) {
+               GisTile *tile = conus->tile[i];
+               gpointer ref  = conus->tile_ref[i];
+               if (tile->data) {
+                       glDeleteTextures(1, tile->data);
+                       g_free(tile->data);
+               }
+               gis_viewer_remove(conus->viewer, ref);
        }
-       gis_viewer_remove(conus->viewer, conus->tile_ref);
 
        g_object_unref(conus->viewer);
        g_free(conus);