From eb013767bbfd2943ad886d1d61763d8f7faba231 Mon Sep 17 00:00:00 2001
From: Benjamin Otte <otte@redhat.com>
Date: Wed, 15 Feb 2012 17:18:22 +0100
Subject: [PATCH] selector: Remove a misleading error message

Duplicate selectors are indeed fine and shouldn't cause errors.
You want to use them to up specificity.
---
 gtk/gtkcssselector.c              | 8 --------
 tests/css/parser/Makefile.am      | 1 -
 tests/css/parser/selector.errors  | 1 -
 tests/css/parser/selector.ref.css | 8 ++++----
 4 files changed, 4 insertions(+), 14 deletions(-)
 delete mode 100644 tests/css/parser/selector.errors

diff --git a/gtk/gtkcssselector.c b/gtk/gtkcssselector.c
index 71247c0cc..96f010adb 100644
--- a/gtk/gtkcssselector.c
+++ b/gtk/gtkcssselector.c
@@ -187,14 +187,6 @@ parse_selector_pseudo_class (GtkCssParser   *parser,
     {
       if (g_ascii_strcasecmp (name, classes[i].name) == 0)
         {
-          if ((*region_to_modify & classes[i].region_flag) ||
-              (*state_to_modify & classes[i].state_flag))
-            {
-              if (classes == nth_child_classes)
-                _gtk_css_parser_error (parser, "Duplicate pseudo-class 'nth-child(%s)'", name);
-              else
-                _gtk_css_parser_error (parser, "Duplicate pseudo-class '%s'", name);
-            }
           *region_to_modify |= classes[i].region_flag;
           *state_to_modify |= classes[i].state_flag;
 
diff --git a/tests/css/parser/Makefile.am b/tests/css/parser/Makefile.am
index 44bf32ae1..af82581a3 100644
--- a/tests/css/parser/Makefile.am
+++ b/tests/css/parser/Makefile.am
@@ -296,7 +296,6 @@ EXTRA_DIST += \
 	pseudo-classes-unknown.errors \
 	pseudo-classes-unknown.ref.css \
 	selector.css \
-	selector.errors \
 	selector.ref.css \
 	shorthand.css \
 	shorthand.ref.css \
diff --git a/tests/css/parser/selector.errors b/tests/css/parser/selector.errors
deleted file mode 100644
index 42cc16e1d..000000000
--- a/tests/css/parser/selector.errors
+++ /dev/null
@@ -1 +0,0 @@
-selector.css:201: error: GTK_CSS_PROVIDER_ERROR_SYNTAX
diff --git a/tests/css/parser/selector.ref.css b/tests/css/parser/selector.ref.css
index 37ba16add..e98214571 100644
--- a/tests/css/parser/selector.ref.css
+++ b/tests/css/parser/selector.ref.css
@@ -86,10 +86,6 @@ a > b {
   int-property: 42;
 }
 
-:hover {
-  int-property: 42;
-}
-
 a.b {
   int-property: 42;
 }
@@ -166,6 +162,10 @@ a > :hover {
   int-property: 42;
 }
 
+:hover:hover {
+  int-property: 42;
+}
+
 :hover :hover {
   int-property: 42;
 }
-- 
2.43.2