From e58c6eca328bc42eadab818d9be443be4ff52e25 Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Wed, 6 Feb 2002 22:22:37 +0000 Subject: [PATCH] remove unused variable (gtk_text_view_get_window): add warning about how 2002-02-06 Havoc Pennington * gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable (gtk_text_view_get_window): add warning about how you can't get the private window. #70683, and avoid default: in the switch so we get "enum value unhandled" warnings --- ChangeLog | 7 +++++++ ChangeLog.pre-2-0 | 7 +++++++ ChangeLog.pre-2-10 | 7 +++++++ ChangeLog.pre-2-2 | 7 +++++++ ChangeLog.pre-2-4 | 7 +++++++ ChangeLog.pre-2-6 | 7 +++++++ ChangeLog.pre-2-8 | 7 +++++++ gtk/gtktextview.c | 8 +++++--- 8 files changed, 54 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index ca832684f..633111a19 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2002-02-06 Havoc Pennington + + * gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable + (gtk_text_view_get_window): add warning about how you + can't get the private window. #70683, and avoid default: in the + switch so we get "enum value unhandled" warnings + 2002-02-06 Havoc Pennington * gtk/gtktextchild.c: Add warnings if you try to use a child diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0 index ca832684f..633111a19 100644 --- a/ChangeLog.pre-2-0 +++ b/ChangeLog.pre-2-0 @@ -1,3 +1,10 @@ +2002-02-06 Havoc Pennington + + * gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable + (gtk_text_view_get_window): add warning about how you + can't get the private window. #70683, and avoid default: in the + switch so we get "enum value unhandled" warnings + 2002-02-06 Havoc Pennington * gtk/gtktextchild.c: Add warnings if you try to use a child diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index ca832684f..633111a19 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,10 @@ +2002-02-06 Havoc Pennington + + * gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable + (gtk_text_view_get_window): add warning about how you + can't get the private window. #70683, and avoid default: in the + switch so we get "enum value unhandled" warnings + 2002-02-06 Havoc Pennington * gtk/gtktextchild.c: Add warnings if you try to use a child diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index ca832684f..633111a19 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,10 @@ +2002-02-06 Havoc Pennington + + * gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable + (gtk_text_view_get_window): add warning about how you + can't get the private window. #70683, and avoid default: in the + switch so we get "enum value unhandled" warnings + 2002-02-06 Havoc Pennington * gtk/gtktextchild.c: Add warnings if you try to use a child diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index ca832684f..633111a19 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,10 @@ +2002-02-06 Havoc Pennington + + * gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable + (gtk_text_view_get_window): add warning about how you + can't get the private window. #70683, and avoid default: in the + switch so we get "enum value unhandled" warnings + 2002-02-06 Havoc Pennington * gtk/gtktextchild.c: Add warnings if you try to use a child diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index ca832684f..633111a19 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,10 @@ +2002-02-06 Havoc Pennington + + * gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable + (gtk_text_view_get_window): add warning about how you + can't get the private window. #70683, and avoid default: in the + switch so we get "enum value unhandled" warnings + 2002-02-06 Havoc Pennington * gtk/gtktextchild.c: Add warnings if you try to use a child diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index ca832684f..633111a19 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,10 @@ +2002-02-06 Havoc Pennington + + * gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable + (gtk_text_view_get_window): add warning about how you + can't get the private window. #70683, and avoid default: in the + switch so we get "enum value unhandled" warnings + 2002-02-06 Havoc Pennington * gtk/gtktextchild.c: Add warnings if you try to use a child diff --git a/gtk/gtktextview.c b/gtk/gtktextview.c index 08f016f5d..6c0488119 100644 --- a/gtk/gtktextview.c +++ b/gtk/gtktextview.c @@ -4704,7 +4704,6 @@ gtk_text_view_scroll_hpages (GtkTextView *text_view, gint cursor_x_pos, cursor_y_pos; GtkTextIter new_insert; gint y, height; - gint x, width; g_return_if_fail (text_view->hadjustment != NULL); @@ -6695,11 +6694,14 @@ gtk_text_view_get_window (GtkTextView *text_view, return NULL; break; - default: - g_warning ("%s: Unknown GtkTextWindowType", G_STRLOC); + case GTK_TEXT_WINDOW_PRIVATE: + g_warning ("%s: You can't get GTK_TEXT_WINDOW_PRIVATE, it has \"PRIVATE\" in the name because it is private.", __FUNCTION__); return NULL; break; } + + g_warning ("%s: Unknown GtkTextWindowType", __FUNCTION__); + return NULL; } /** -- 2.43.2