From bf3b5f785e84f450c4c95ca0b2bd02acc88e652f Mon Sep 17 00:00:00 2001 From: Matthew Barnes Date: Fri, 3 Sep 2010 12:48:50 -0400 Subject: [PATCH] Don't leak display name Bug 628656 - _gdk_windowing_get_startup_notify_id memory leak get_display_name() returns a newly allocated string, which was being fed directory info a g_strdup_printf() call. --- gdk/x11/gdkapplaunchcontext-x11.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdk/x11/gdkapplaunchcontext-x11.c b/gdk/x11/gdkapplaunchcontext-x11.c index 0d5b10e23..b91b21355 100644 --- a/gdk/x11/gdkapplaunchcontext-x11.c +++ b/gdk/x11/gdkapplaunchcontext-x11.c @@ -311,7 +311,11 @@ _gdk_windowing_get_startup_notify_id (GAppLaunchContext *context, if (files_count == 0) description = g_strdup_printf (_("Starting %s"), g_app_info_get_name (info)); else if (files_count == 1) - description = g_strdup_printf (_("Opening %s"), get_display_name (files->data)); + { + gchar *display_name = get_display_name (files->data); + description = g_strdup_printf (_("Opening %s"), display_name); + g_free (display_name); + } else description = g_strdup_printf (g_dngettext (GETTEXT_PACKAGE, "Opening %d Item", -- 2.43.2