From 9e31ef616d97c778f5df050ef492dac268cbd4ca Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Mon, 18 Oct 2010 19:08:55 +0200 Subject: [PATCH] cups: Add hack to work around gcc warning gcc warns if you switch on values that are not part of the enum you're switching on. So handle those cases in the default handler by using if statments. PS: Someone file a bug against cups about this? --- modules/printbackends/cups/gtkprintbackendcups.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/modules/printbackends/cups/gtkprintbackendcups.c b/modules/printbackends/cups/gtkprintbackendcups.c index 2486c2072..1b83e32e6 100644 --- a/modules/printbackends/cups/gtkprintbackendcups.c +++ b/modules/printbackends/cups/gtkprintbackendcups.c @@ -845,9 +845,6 @@ request_password (gpointer data) switch (dispatch->request->ipp_request->request.op.operation_id) { - case 0: - prompt = g_strdup_printf ( _("Authentication is required to get a file from %s"), hostname); - break; case IPP_PRINT_JOB: if (job_title != NULL && printer_name != NULL) prompt = g_strdup_printf ( _("Authentication is required to print document '%s' on printer %s"), job_title, printer_name); @@ -873,7 +870,11 @@ request_password (gpointer data) prompt = g_strdup_printf ( _("Authentication is required to get printers from %s"), hostname); break; default: - prompt = g_strdup_printf ( _("Authentication is required on %s"), hostname); + /* work around gcc warning about 0 not being a value for this enum */ + if (dispatch->request->ipp_request->request.op.operation_id == 0) + prompt = g_strdup_printf ( _("Authentication is required to get a file from %s"), hostname); + else + prompt = g_strdup_printf ( _("Authentication is required on %s"), hostname); break; } -- 2.43.2