From 4d61cd6ec764368689fab3bd19e78d76c1e6b176 Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Wed, 16 May 2012 07:13:17 -0400 Subject: [PATCH] cifs: add a deprecation warning to CIFS_IOC_CHECKUMOUNT ioctl This was used by an ancient version of umount.cifs and in nowhere else that I'm aware of. Let's add a warning now and dump it for 3.7. Signed-off-by: Jeff Layton --- fs/cifs/ioctl.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/cifs/ioctl.c b/fs/cifs/ioctl.c index 4221b5e48a4..6d2667f0c98 100644 --- a/fs/cifs/ioctl.c +++ b/fs/cifs/ioctl.c @@ -51,7 +51,15 @@ long cifs_ioctl(struct file *filep, unsigned int command, unsigned long arg) cifs_sb = CIFS_SB(inode->i_sb); switch (command) { + static bool warned = false; case CIFS_IOC_CHECKUMOUNT: + if (!warned) { + warned = true; + cERROR(1, "the CIFS_IOC_CHECKMOUNT ioctl will " + "be deprecated in 3.7. Please " + "migrate away from the use of " + "umount.cifs"); + } cFYI(1, "User unmount attempted"); if (cifs_sb->mnt_uid == current_uid()) rc = 0; -- 2.43.2