From 147ce69974cc1b44defa2d3d9c202ee83e2f2f3b Mon Sep 17 00:00:00 2001 From: Al Viro Date: Sat, 15 Jun 2013 10:26:35 +0400 Subject: [PATCH 1/1] proc_fill_cache(): kill pointless check we'd just checked that child->d_inode is non-NULL, for fuck sake! Signed-off-by: Al Viro --- fs/proc/base.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 0016350ad95..306419c1968 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1710,10 +1710,8 @@ bool proc_fill_cache(struct file *file, struct dir_context *ctx, if (!child || IS_ERR(child) || !child->d_inode) goto end_instantiate; inode = child->d_inode; - if (inode) { - ino = inode->i_ino; - type = inode->i_mode >> 12; - } + ino = inode->i_ino; + type = inode->i_mode >> 12; dput(child); end_instantiate: if (!ino) -- 2.43.2