From 0ffd8a84cb0b252d4acbb6327d3049d6cad4701e Mon Sep 17 00:00:00 2001 From: Tim Janik Date: Fri, 24 Feb 2006 11:02:25 +0000 Subject: [PATCH] added G_GNUC_WARN_UNUSED_RESULT warnings for iterator functions, to avoid Fri Feb 17 14:20:29 2006 Tim Janik * gtk/gtktreemodel.h: * gtk/gtktextbtree.h: added G_GNUC_WARN_UNUSED_RESULT warnings for iterator functions, to avoid invalid iterators go unnoticed, suggested by Markku Vire . --- ChangeLog | 7 +++++++ ChangeLog.pre-2-10 | 7 +++++++ gtk/gtktextbtree.h | 8 ++++---- gtk/gtktreemodel.h | 18 +++++++++--------- 4 files changed, 27 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 64a6fb2e4..de3bb6d8c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Fri Feb 17 14:20:29 2006 Tim Janik + + * gtk/gtktreemodel.h: + * gtk/gtktextbtree.h: added G_GNUC_WARN_UNUSED_RESULT warnings for + iterator functions, to avoid invalid iterators go unnoticed, + suggested by Markku Vire . + 2006-02-23 Matthias Clasen * tests/Makefile.am: diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 64a6fb2e4..de3bb6d8c 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,10 @@ +Fri Feb 17 14:20:29 2006 Tim Janik + + * gtk/gtktreemodel.h: + * gtk/gtktextbtree.h: added G_GNUC_WARN_UNUSED_RESULT warnings for + iterator functions, to avoid invalid iterators go unnoticed, + suggested by Markku Vire . + 2006-02-23 Matthias Clasen * tests/Makefile.am: diff --git a/gtk/gtktextbtree.h b/gtk/gtktextbtree.h index 2b2d17cba..d757aecbd 100644 --- a/gtk/gtktextbtree.h +++ b/gtk/gtktextbtree.h @@ -155,10 +155,10 @@ void _gtk_text_btree_get_iter_at_line_byte (GtkTextBTree *tree, gint byte_index); gboolean _gtk_text_btree_get_iter_from_string (GtkTextBTree *tree, GtkTextIter *iter, - const gchar *string); + const gchar *string) G_GNUC_WARN_UNUSED_RESULT; gboolean _gtk_text_btree_get_iter_at_mark_name (GtkTextBTree *tree, GtkTextIter *iter, - const gchar *mark_name); + const gchar *mark_name) G_GNUC_WARN_UNUSED_RESULT; void _gtk_text_btree_get_iter_at_mark (GtkTextBTree *tree, GtkTextIter *iter, GtkTextMark *mark); @@ -170,10 +170,10 @@ void _gtk_text_btree_get_iter_at_line (GtkTextBTree *tree, gint byte_offset); gboolean _gtk_text_btree_get_iter_at_first_toggle (GtkTextBTree *tree, GtkTextIter *iter, - GtkTextTag *tag); + GtkTextTag *tag) G_GNUC_WARN_UNUSED_RESULT; gboolean _gtk_text_btree_get_iter_at_last_toggle (GtkTextBTree *tree, GtkTextIter *iter, - GtkTextTag *tag); + GtkTextTag *tag) G_GNUC_WARN_UNUSED_RESULT; void _gtk_text_btree_get_iter_at_child_anchor (GtkTextBTree *tree, GtkTextIter *iter, diff --git a/gtk/gtktreemodel.h b/gtk/gtktreemodel.h index cc5b937d9..7c5dc2665 100644 --- a/gtk/gtktreemodel.h +++ b/gtk/gtktreemodel.h @@ -136,8 +136,8 @@ GType gtk_tree_path_get_type (void) G_GNUC_CONST; gint gtk_tree_path_compare (const GtkTreePath *a, const GtkTreePath *b); void gtk_tree_path_next (GtkTreePath *path); -gboolean gtk_tree_path_prev (GtkTreePath *path); -gboolean gtk_tree_path_up (GtkTreePath *path); +gboolean gtk_tree_path_prev (GtkTreePath *path) G_GNUC_WARN_UNUSED_RESULT; +gboolean gtk_tree_path_up (GtkTreePath *path) G_GNUC_WARN_UNUSED_RESULT; void gtk_tree_path_down (GtkTreePath *path); gboolean gtk_tree_path_is_ancestor (GtkTreePath *path, @@ -191,14 +191,14 @@ GType gtk_tree_model_get_column_type (GtkTreeModel *tree_model, /* Iterator movement */ gboolean gtk_tree_model_get_iter (GtkTreeModel *tree_model, GtkTreeIter *iter, - GtkTreePath *path); + GtkTreePath *path) G_GNUC_WARN_UNUSED_RESULT; gboolean gtk_tree_model_get_iter_from_string (GtkTreeModel *tree_model, GtkTreeIter *iter, - const gchar *path_string); + const gchar *path_string) G_GNUC_WARN_UNUSED_RESULT; gchar * gtk_tree_model_get_string_from_iter (GtkTreeModel *tree_model, GtkTreeIter *iter); gboolean gtk_tree_model_get_iter_first (GtkTreeModel *tree_model, - GtkTreeIter *iter); + GtkTreeIter *iter) G_GNUC_WARN_UNUSED_RESULT; GtkTreePath * gtk_tree_model_get_path (GtkTreeModel *tree_model, GtkTreeIter *iter); void gtk_tree_model_get_value (GtkTreeModel *tree_model, @@ -206,10 +206,10 @@ void gtk_tree_model_get_value (GtkTreeModel *tree_model, gint column, GValue *value); gboolean gtk_tree_model_iter_next (GtkTreeModel *tree_model, - GtkTreeIter *iter); + GtkTreeIter *iter) G_GNUC_WARN_UNUSED_RESULT; gboolean gtk_tree_model_iter_children (GtkTreeModel *tree_model, GtkTreeIter *iter, - GtkTreeIter *parent); + GtkTreeIter *parent) G_GNUC_WARN_UNUSED_RESULT; gboolean gtk_tree_model_iter_has_child (GtkTreeModel *tree_model, GtkTreeIter *iter); gint gtk_tree_model_iter_n_children (GtkTreeModel *tree_model, @@ -217,10 +217,10 @@ gint gtk_tree_model_iter_n_children (GtkTreeModel *tree_model, gboolean gtk_tree_model_iter_nth_child (GtkTreeModel *tree_model, GtkTreeIter *iter, GtkTreeIter *parent, - gint n); + gint n) G_GNUC_WARN_UNUSED_RESULT; gboolean gtk_tree_model_iter_parent (GtkTreeModel *tree_model, GtkTreeIter *iter, - GtkTreeIter *child); + GtkTreeIter *child) G_GNUC_WARN_UNUSED_RESULT; void gtk_tree_model_ref_node (GtkTreeModel *tree_model, GtkTreeIter *iter); void gtk_tree_model_unref_node (GtkTreeModel *tree_model, -- 2.43.2