]> Pileus Git - ~andy/linux/commit
rt2x00: fix stop queue
authorStanislaw Gruszka <stf_xl@wp.pl>
Sun, 28 Jul 2013 11:17:22 +0000 (13:17 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 29 Jul 2013 18:39:44 +0000 (14:39 -0400)
commite2288b66fe7ff0288382b2af671b4da558b44472
treed26d1e38df570e92077f849ada809d2dfce79c19
parenta538ae3189a9fa4095ca58c14bc6593622c89ab9
rt2x00: fix stop queue

Since we clear QUEUE_STARTED in rt2x00queue_stop_queue(), following
call to rt2x00queue_pause_queue() reduce to noop, i.e we do not
stop queue in mac80211.

To fix that introduce rt2x00queue_pause_queue_nocheck() function,
which will stop queue in mac80211 directly.

Note that rt2x00_start_queue() explicitly set QUEUE_PAUSED bit.

Note also that reordering operations i.e. first call to
rt2x00queue_pause_queue() and then clear QUEUE_STARTED bit, will race
with rt2x00queue_unpause_queue(), so calling ieee80211_stop_queue()
directly is the only available solution to fix the problem without
major rework.

Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2x00queue.c