]> Pileus Git - ~andy/linux/commit
xfs: fix incorrect remote symlink block count
authorDave Chinner <dchinner@redhat.com>
Mon, 27 May 2013 06:38:20 +0000 (16:38 +1000)
committerBen Myers <bpm@sgi.com>
Thu, 30 May 2013 17:37:04 +0000 (12:37 -0500)
commit321a95839e65db3759a07a3655184b0283af90fe
tree9e5e95564afdd0758d685ae45035004be1fd5014
parent34510185abeaa5be9b178a41c0a03d30aec3db7e
xfs: fix incorrect remote symlink block count

When CRCs are enabled, the number of blocks needed to hold a remote
symlink on a 1k block size filesystem may be 2 instead of 1. The
transaction reservation for the allocated blocks was not taking this
into account and only allocating one block. Hence when trying to
read or invalidate such symlinks, we are mapping a hole where there
should be a block and things go bad at that point.

Fix the reservation to use the correct block count, clean up the
block count calculation similar to the remote attribute calculation,
and add a debug guard to detect when we don't write the entire
symlink to disk.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/xfs/xfs_symlink.c