majorly speed up execution by reducing timeouts and converting main loop
2007-12-06 10:44:52 Tim Janik <timj@imendio.com>
* tests/autotestfilechooser.c: majorly speed up execution by reducing
timeouts and converting main loop sleeps to pending/iterate loops with
very low priority async handlers. eliminate output for non-verbose
tests. assert successfull subtests in all test functions. use testing
framework in main().
* tests/Makefile.am: add autotestfilechooser to TEST_PROGS, so it's
executed inside Xvfb upon make check.
run tests in current dir after setting up the logging directory, so their
2007-12-05 18:59:59 Tim Janik <timj@imendio.com>
* gtk+/Makefile.decl: run tests in current dir after setting up the
logging directory, so their results get properly merged into the
resulting test log.
* gtk+/gtk/gtktestutils.[hc]: added gtk_test_list_all_types() for
tests to loop over registered Gdk/Gtk+ types.
* gtk+/tests/objecttests.c: new test program, implements automated
property tests. several properties are blacklisted because they
seem to trigger Gdk/Gtk+ bugs. ./objecttests -m thorough --verbose
can be used to test blacklisted properties and see which proprty failed.
Richard Hult [Mon, 3 Dec 2007 19:51:20 +0000 (19:51 +0000)]
Don't crash when dragging from a source that doesn't support uri lists
2007-12-03 Richard Hult <richard@imendio.com>
* gtk/gtkquartz.c: (_gtk_quartz_set_selection_data_for_pasteboard):
Don't crash when dragging from a source that doesn't support uri
lists (bug #499868, Paul Davis).
Richard Hult [Mon, 3 Dec 2007 19:34:30 +0000 (19:34 +0000)]
Don't crash when a parent relative bg pixmap is set, and no parent has a
2007-12-03 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkwindow-quartz.c:
(gdk_window_impl_quartz_begin_paint_region): Don't crash when a
parent relative bg pixmap is set, and no parent has a bg
pixmap. Fixes bug #500804.
Matthias Clasen [Mon, 3 Dec 2007 17:44:27 +0000 (17:44 +0000)]
Two optimizations for icon cache lookups.
2007-12-03 Matthias Clasen <mclasen@redhat.com>
Two optimizations for icon cache lookups.
* gtk/gtkiconcache.[hc]:
* gtk/gtkicontheme.c: Remember the directory index for
subdirectories, instead of running over the directory list
again and again.
* gtk/gtkiconcache.c (find_image_offset): Remember the last
chain and try it first; this helps with the the usage patterns
in gtkicontheme.c, where the same icon is queried for a lot
of subdirectories.
use 'grep -o' to extract _get_type functions from header files. this
2007-12-03 15:18:17 Tim Janik <timj@imendio.com>
* gtk/Makefile.am (gtktypefuncs.c): use 'grep -o' to extract _get_type
functions from header files. this should be portable across linux and
Mac OS, unlike the previpous sed expression.
Cody Russell [Sat, 1 Dec 2007 22:08:19 +0000 (22:08 +0000)]
[Win32]: On Windows, queue a redraw of child2 whenever we set the pane
2007-12-1 Cody Russell <bratsche@gnome.org>
* gtk/gtkpaned.c: (gtk_paned_set_position) [Win32]:
On Windows, queue a redraw of child2 whenever we set
the pane handle position. This is unfortunately kind
of hacky, but solves the visual artifacts that were
occuring on at least certain types of child widgets
(e.g., text views and tree views) that are inside
horizontal or vertical panes. (#144269)
Tor Lillqvist [Wed, 28 Nov 2007 01:06:07 +0000 (01:06 +0000)]
A proper build of GNU libintl is supposed to export the variable
2007-11-28 Tor Lillqvist <tml@novell.com>
A proper build of GNU libintl is supposed to export the variable
_nl_msg_cat_cntr. configure looks for that variable in order to
recognize GNU gettext. If it sees that it is indeed GNU gettext
that is used, it decides to install message catalogs in
share/locale, otherwise in lib/locale. Until now on Windows I have
built GTK+ against a build of GNU gettext that did not export
_nl_msg_cat_cntr. But this will change, so we can't assume message
catalogs are always in lib/locale.
* gtk/gtkmain.c: (_gtk_get_localedir) [Win32]: Rework to handle
GTK_LOCALEDIR being either in "lib" or "share". Move the function
before the inclusion of gtkprivate.h so that it sees the original
GTK_LOCALEDIR.
* gtk-zip.sh.in: Check whether the message catalogs are in
share/locale or lib/locale.
Tor Lillqvist [Tue, 27 Nov 2007 22:48:32 +0000 (22:48 +0000)]
Remove fuzzy marker for the metadata entry (the first one, for the string
2007-11-28 Tor Lillqvist <tml@novell.com>
* io.po: Remove fuzzy marker for the metadata entry (the first
one, for the string ""), as having that fuzzy crashes msgfmt from
gettext 0.17, at least for me.
Tor Lillqvist [Tue, 27 Nov 2007 22:29:46 +0000 (22:29 +0000)]
Fix #375893, patch by Ben Hague:
2007-11-28 Tor Lillqvist <tml@novell.com>
Fix #375893, patch by Ben Hague:
* gtk/gtkfilesystemwin32.c (get_viewable_logical_drives): Wrapper
around GetLogicalDrives() that takes also the viewable drive
restrictions in the Registry (which are usually the result of an
Active Directory Group Policy) into account.
(check_volumes, gtk_file_system_win32_list_volumes) Call
get_viewable_logical_drives() instead of GetLogicalDrives().
Ryan Lortie [Tue, 27 Nov 2007 03:25:09 +0000 (03:25 +0000)]
add clarification stating that the construct_child function is responsible
2006-11-26 Ryan Lortie <desrt@desrt.ca>
* docs/reference/gtk/tmpl/gtkbuildable.sgml: add clarification stating
that the construct_child function is responsible for returning a
reference.
* gtkbuilder.c (_gtk_builder_construct): remove g_object_ref() for
objects from constructors
* gtkuimanager.c (gtk_ui_manager_buildable_construct_child): add
g_object_ref() to this construction function (it's the only
implementer in GTK)
Josselin Mouette [Mon, 26 Nov 2007 23:16:19 +0000 (23:16 +0000)]
reviewed by: Federico Mena Quintero
2007-11-26 Josselin Mouette <joss@malsain.org>
reviewed by: Federico Mena Quintero
* gtk/gtkfilechooserdefault.c: (shortcuts_append_paths),
(shortcuts_add_bookmarks), (shortcuts_selection_changed_cb),
(shortcuts_list_create), (gtk_file_chooser_default_should_respond):
Make the shortcuts activate with a single click. (#148828)
Fix a few things affected by the change:
- Set selection mode to GTK_SELECTION_SINGLE to allow a case
where no shortcut is selected.
- Don't activate a shortcut in the response callback.
- Filter out duplicate entries in volumes and bookmarks to
avoid the selection to change when reordering them with DnD.
Tor Lillqvist [Sun, 25 Nov 2007 22:59:50 +0000 (22:59 +0000)]
Use the monitor the window currently is on, not always the primary
2007-11-26 Tor Lillqvist <tml@novell.com>
* gdk/win32/gdkwindow-win32.c (gdk_window_fullscreen): Use the
monitor the window currently is on, not always the primary
monitor. (#463865, Tim Evans)
initialize automake variables EXTRA_DIST and TEST_PROGS for unconditional
2007-11-22 15:48:26 Tim Janik <timj@imendio.com>
* Makefile.decl: initialize automake variables EXTRA_DIST and
TEST_PROGS for unconditional appending via += in other makefiles.
define recursive test targets: test, test-report, perf-report,
full-report, as described here:
http://mail.gnome.org/archives/gtk-devel-list/2007-November/msg00000.html
the test targets will execute Gtk+ test programs within an Xvfb session.
* gtk/gtktestutils.c: call g_test_init() from gtk_test_init().
* gtk/tests/testing.c: use g_test_add_func() to register tests and use
g_test_run() to run the tests to integrate with the testing framework.
Behdad Esfahbod [Wed, 21 Nov 2007 09:12:59 +0000 (09:12 +0000)]
Add Gtk/EnableAccels and Gtk/EnableMnemonics xsettings for
2007-11-21 Behdad Esfahbod <behdad@gnome.org>
* gdk/x11/gdksettings.c (gdk_settings_names, gdk_settings_map): Add
Gtk/EnableAccels and Gtk/EnableMnemonics xsettings for
gtk-enable-accels and gtk-enable-mnemonics GtkSettings respectively.
(#436536, Tommi Komulainen)
Tim Janik [Tue, 20 Nov 2007 15:03:28 +0000 (15:03 +0000)]
Added unit tests for Gtk+ testing utilities.
* gtk/tests/testing.c: added a sample test program that tests Gtk+ test
utility functions. some g_test_* related portions are disabled and need
to be enabled once Gtk+ depends on a new glib with the GLib testing
framework integrated.
* gtk/tests/Makefile.am: new subdirectory to include quick Gtk+ tests.
added exemplary test rules to run tests inside Xvfb. this needs to depend
on gtester for full fledged testing.
* gtk/Makefile.am: build gtk+/gtk/tests, define -DGTK_ENABLE_BROKEN when
collecting _get_type functions to catch e.g. gtk_text_get_type().
* configure.in: create gtk/tests/Makefile.in and gtk/tests/Makefile.
Tim Janik [Tue, 20 Nov 2007 15:03:26 +0000 (15:03 +0000)]
Added Gtk+ testing utilities.
* gtk/gtktestutils.h, gtk/gtktestutils.c: added unit test utility functions.
for the most part, the functions herein involve navigating and interacting
with dialog elements programatically, to automate user interaction tests of
dialogs and widgets.
* gtk/gtk.h: include gtk/gtktestutils.h as public API.
* gtk/gtk.symbols: added gtk_test_* symbols.
* gtk/Makefile.am: include gtktestutils.h and gtktestutils.c into the build.
generate gtktypefuncs.c which contains a list of all _get_type functions in
Gtk+ and Gdk.
Yevgen Muntyan [Thu, 15 Nov 2007 17:03:09 +0000 (17:03 +0000)]
new functions _gtk_text_btree_get_insert() and
2007-11-15 Yevgen Muntyan <muntyan@tamu.edu>
* gtk/gtktextbtree.h:
* gtk/gtktextbtree.c: new functions _gtk_text_btree_get_insert()
and _gtk_text_btree_get_selection_bound() (#497102).
* gtk/gtktextbuffer.c (gtk_text_buffer_get_insert),
(gtk_text_buffer_get_selection_bound): use them here instead of
hash table lookup.
Yevgen Muntyan [Thu, 15 Nov 2007 17:00:33 +0000 (17:00 +0000)]
sort returned tags array by tags priority (#497102).
2007-11-15 Yevgen Muntyan <muntyan@tamu.edu>
* gtk/gtktextbtree.c (_gtk_text_btree_get_tags): sort returned
tags array by tags priority (#497102).
* gtk/gtktextiter.c (gtk_text_iter_get_tags), (gtk_text_iter_get_attributes):
* gtk/gtktextlayout.c (get_tags_array_at_iter): and do not sort it here.
Yevgen Muntyan [Thu, 15 Nov 2007 16:24:42 +0000 (16:24 +0000)]
do not call _gtk_text_btree_get_iter_at_line() and
2007-11-15 Yevgen Muntyan <muntyan@tamu.edu>
* gtk/gtktextlayout.c: (gtk_text_layout_get_line_display),
(get_style): do not call _gtk_text_btree_get_iter_at_line() and
_gtk_text_btree_get_tags() for every segment, instead call them
once and then collect the tags while iterating over the segments.
(get_tags_array_at_iter), (tags_array_toggle_tag): new functions
for tags array handling.
Avoid loading the ISO8859-1 iconv module. We're already doing all the
2007-11-12 Alexander Larsson <alexl@redhat.com>
* gdk/x11/gdkselection-x11.c:
Avoid loading the ISO8859-1 iconv module.
We're already doing all the required work anyway.
This saves 4kb private dirty memory per gtk+ process
Yevgen Muntyan [Sun, 11 Nov 2007 19:07:27 +0000 (19:07 +0000)]
Moved gtk_text_view_update_im_spot_location() calls into an idle, fixes
2007-11-11 Yevgen Muntyan <muntyan@tamu.edu>
* gtk/gtktextview.c: Moved gtk_text_view_update_im_spot_location()
calls into an idle, fixes #494776.
GtkTextViewPrivate:im_spot_idle, do_update_im_spot_location(),
queue_update_im_spot_location(), flush_update_im_spot_location(): new
field and functions to queue the call;
(changed_handler): call queue_update_im_spot_location() instead of
gtk_text_view_update_im_spot_location();
(gtk_text_view_key_press_event): flush the idle here.
projects / ~andy / gtk / log