remove unused variable (gtk_text_view_get_window): add warning about how
2002-02-06 Havoc Pennington <hp@redhat.com>
* gtk/gtktextview.c (gtk_text_view_scroll_hpages): remove unused variable
(gtk_text_view_get_window): add warning about how you
can't get the private window. #70683, and avoid default: in the
switch so we get "enum value unhandled" warnings
Add warnings if you try to use a child anchor that isn't inside a buffer.
2002-02-06 Havoc Pennington <hp@redhat.com>
* gtk/gtktextchild.c: Add warnings if you try to use a child
anchor that isn't inside a buffer. Really kind of lame;
we should separate the anchor from the buffer. But not worth
fixing for now. #70601
Owen Taylor [Wed, 6 Feb 2002 00:41:07 +0000 (00:41 +0000)]
Keep the length of the anti-expose queue finite, by if it gets too long,
Tue Feb 5 19:13:42 2002 Owen Taylor <otaylor@redhat.com>
* gdk/x11/gdkgeometry-x11.c (gdk_window_queue): Keep
the length of the anti-expose queue finite, by if
it gets too long, first doing a XSync() and checking
the event queue, and if that doesn't work, simply
discarding all anti-expose items in the queue.
* gdk/x11/gdkdnd-x11.c (gdk_window_cache_filter): Fix ordering
on ConfigureNotify (#56349, Thomas Leonard)
offset area being gotten from pixmap by the align/padding offsets, so we
2002-02-05 Havoc Pennington <hp@redhat.com>
* gtk/gtkimage.c (gtk_image_expose): offset area being gotten from
pixmap by the align/padding offsets, so we don't get warnings
in gdk_pixbuf_get_from_drawable (and so it works, of course)
let's set the path, which we're going to pass with the emission of
Tue Feb 5 22:54:16 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtkliststore.c (gtk_list_store_insert_after): let's set the
path, which we're going to pass with the emission of row_inserted, to
the iter we inserted and not its sibling.
Owen Taylor [Mon, 4 Feb 2002 15:43:09 +0000 (15:43 +0000)]
Fix from Matthias Clasen to clear background appropriately for theme by
Mon Feb 4 10:40:28 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkstyle.c (gtk_default_draw_resize_grip):
Fix from Matthias Clasen to clear background appropriately
for theme by calling gtk_style_apply_default_background().
(#70449)
Owen Taylor [Sun, 3 Feb 2002 03:02:07 +0000 (03:02 +0000)]
RC file lookup improvements (#68234, suggestions from Matthias Clasen.)
Sat Feb 2 21:54:01 2002 Owen Taylor <otaylor@redhat.com>
RC file lookup improvements (#68234, suggestions
from Matthias Clasen.)
* gtk/gtkrc.c (gtk_rc_parse_file): Look for the
locale suffix variants (gtkrc.en_US, gtkrc.en) for
all RC files we parse, not just the default RC
files.
* gtk/gtkrc.c (gtk_rc_parse_default_files): Remove
support for charset specific RC files.
Owen Taylor [Sun, 3 Feb 2002 01:25:32 +0000 (01:25 +0000)]
Non-exported _gtk_menu_select_first() function that selects the first item
Sat Feb 2 20:16:04 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.c (_gtk_menu_shell_select_first):
Non-exported _gtk_menu_select_first() function that
selects the first item of the menu in a standard
way. (Skipping tearoffs.)
* gtk/gtkmenushell.c gtk/gtkentry.c gtk/gtktextview.c
gtkmenuitem.c: Use _gtk_menu_shell_select_first().
* gtk/gtkmenuitem.c (gtk_real_menu_item_select): Remember
if we are starting the timeout from a keypress so
we can set menushell->ignore_enter properly.
* gtk/gtknotebook.c (focus_child_in): Return something
meaningful if there are no children.
Owen Taylor [Sat, 2 Feb 2002 22:52:22 +0000 (22:52 +0000)]
Add a GtkSetting (gtk-entry-select-on-focus) controlling whether the
Sat Feb 2 17:43:00 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkentry.c (gtk_entry_grab_focus): Add a GtkSetting
(gtk-entry-select-on-focus) controlling whether the
contents of an entry are selected on focus in.
* gtk/gtkmenu.c (gtk_menu_key_press): Add a GtkSetting
(gtk-can-change-accels) controlling whether accelerators can be
changed on the fly or not. (#51902)
* gtk/gtkmenu.c (gtk_menu_key_press): Allow unmodified
accelerators, now that accelerator changing can be turned
off for those who won't expect it. (#61285)
* gtk/gtkaccelgroup.c (gtk_accelerator_valid): Allow
Backspace/Delete/KP_Delete as valid accelerators.
* gtk/gtkmenu.c (gtk_menu_key_press): Allow setting of
Delete/Backspace as accelerators by making them toggle
the menu item between empty and the pressed key.
(#58605)
* tests/testgtkrc: Remove the objectionably short cursor blink
time setting.
Owen Taylor [Sat, 2 Feb 2002 21:50:46 +0000 (21:50 +0000)]
To get around the fact that we may have a owner_events = FALSE grab in
Sat Feb 2 16:43:31 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenu.c (gtk_menu_popup): To get around the fact
that we may have a owner_events = FALSE grab in effect
when we pop up a window, make a temporary grab on a
different window, then grab on the real window. Fixes
a problem where if a context menu popped up under the
cursor, the first item would be stuck unselected.
(#59812, reported by Arnaud Charlet.)
Owen Taylor [Sat, 2 Feb 2002 17:52:01 +0000 (17:52 +0000)]
Remove the "select first item if popped up from keypress" hack -- was
Sat Feb 2 11:37:21 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenu.c (gtk_menu_popup): Remove the
"select first item if popped up from keypress" hack --
was causing more problems than it was worth
(#53191, #68483)
* gtk/gtktextview.c (popup_targets_received):
gtk/gtkentry.c (popup_targets_received): If activated
from keyboard, select first item of popup menu.
set upper member of vadjustment correct, so the vscrollbars of lists
Sat Feb 2 18:07:51 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_size_allocate): set upper member
of vadjustment correct, so the vscrollbars of lists smaller than
1 page are somewhat saner (#66905)
* gtk/gtkliststore.c (gtk_list_store_remove_silently): do not
increment the stamp, liststore is a model with persisting iters
Owen Taylor [Sat, 2 Feb 2002 04:34:09 +0000 (04:34 +0000)]
Parse the RC string here when the first object is created rather than in
Fri Feb 1 23:25:33 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtktooltips.c (gtk_tooltips_init): Parse the
RC string here when the first object is created
rather than in the class_init to not break doc
building. (#70341, Havoc Pennington.)
* gtk/gtkrc.c (parse_include_file): Use the directories
for the currently parsed files as the starting point
to look for include files. (#59975)
Owen Taylor [Sat, 2 Feb 2002 01:00:42 +0000 (01:00 +0000)]
Fix use of ! in shell.
Fri Feb 1 19:57:59 2002 Owen Taylor <otaylor@redhat.com>
* configure.in: Fix use of ! in shell.
* gtk/gtktooltips.c (gtk_tooltips_class_init) gtkrc.default:
Move the setting of default tooltips colors to gtktooltips.c
from gtkrc.default. (Use default priority so themes will
override.) (#58542)
use y coordinate relative to the tree and not the treeview window (fixes
Fri Feb 1 00:37:49 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): use
y coordinate relative to the tree and not the treeview window
(fixes the PgDn/PgUp brokenness)
Owen Taylor [Thu, 31 Jan 2002 15:26:52 +0000 (15:26 +0000)]
Handle the case where bin->child is NULL. (#70153, Padraig O'Briain)
Thu Jan 31 10:21:05 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkplug.c (gtk_plug_focus): Handle the case where
bin->child is NULL. (#70153, Padraig O'Briain)
* gtk/gtktextutil.c (_gtk_text_util_append_special_char_menuitems):
Actually call gettext() on the labels; previously they
were marked with N_() but we never called gettext().
Owen Taylor [Wed, 30 Jan 2002 03:07:14 +0000 (03:07 +0000)]
Consistently use GdkModifierType. (#66950, Mark Patton)
Tue Jan 29 21:50:28 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkaccelmap.[ch] gtk/gtkbindings.[ch] gtk/gtkwidget.[ch]:
Consistently use GdkModifierType. (#66950, Mark Patton)
* gtk/gtkimagemenuitem.c (gtk_image_menu_item_new_from_stock):
For consistency with gtk_button_new_from_stock(), fall back
to gtk_image_menu_item_new_with_mnemnonic(). (#65944,
Havoc Pennington)
* gtk/gtkitemfactory.[ch] (gtk_item_factory_path_from_widget):
Make G_CONST_RETURN. (#68527, Matt Wilson)
Owen Taylor [Wed, 30 Jan 2002 01:47:27 +0000 (01:47 +0000)]
Revert the last changes to make the number of digits only effect drawing,
Tue Jan 29 20:38:04 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkscale.[ch]: Revert the last changes to make the
number of digits only effect drawing, instead, don't
round unless we are in the 'draw_value' mode -- this
is the behavior of GTK+-1.2, and keeps the behavior that
if the user sees a displayed value, it is the correct value.
Owen Taylor [Wed, 30 Jan 2002 00:35:51 +0000 (00:35 +0000)]
Fix wrong usage of g_value_set/get_object for PROP_TABS and memory leak in
Tue Jan 29 19:32:47 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtktextview.c (gtk_text_view_get/set_property):
Fix wrong usage of g_value_set/get_object for PROP_TABS
and memory leak in getter for PROP_TABS. (Jeff Franks)
Owen Taylor [Wed, 30 Jan 2002 00:08:41 +0000 (00:08 +0000)]
Document that a size of (GtkIconSize)-1 means don't scale.
Tue Jan 29 19:04:41 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkstyle.c (gtk_style_render_icon): Document that
a size of (GtkIconSize)-1 means don't scale.
* gtk/gtkstyle.c (gtk_default_render_icon): Obey the
-1 convention.
* gtk/gtkimage.c (gtk_image_expose): Pass in -1 to
gtk_style_render_icon() to make sure that we catch it
obviously if the style's render function tries to
scale.
Tue Jan 29 18:50:46 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): free
cursor_path after usage
(gtk_tree_view_real_start_interactive_search): use new g_signal
and g_object calls
(gtk_tree_view_search_dialog_destroy): use g_object calls and free
selected_iter if set
(gtk_tree_view_search_position_func): rework so it will never ever
appear offscreen (#68492)
(gtk_tree_view_search_move): use new g_object calls
(gtk_tree_view_search_init): free selected_iter if set, use new
g_object calls
(gtk_tree_view_leave_notify): don't destroy interactive search
dialog
Tue Jan 29 23:07:03 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_real_start_interactive_search):
send focus in event
(gtk_tree_view_search_dialog_destroy): send focus out event (#66466)
Owen Taylor [Tue, 29 Jan 2002 20:53:17 +0000 (20:53 +0000)]
Switch over to GtkTreeView from GtkCList. Remove the entries above the
Tue Jan 29 15:24:59 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfontsel.[ch]: Switch over to GtkTreeView from
GtkCList. Remove the entries above the font/face lists
since they were a little confusing. (Not sure about this
change, so the code is still there the entries are
just hidden.) (#68890)
* gtk/gtkfilesel.c: Switch over to GtkTreeView from
GtkCList. Add mnemonics for fileops. Allow Control/Shift
Tab to focus out.
* gtk/gtkfilesel.c: Make fileop dialogs transient-for
the fileselector. (#69336, patch from Melvin Hadasht)
* gtk/gtkgamma.c (button_clicked_callback): Fix handling
of gamma dialog a bit. (#69336, Matthias Clasen.)
Owen Taylor [Tue, 29 Jan 2002 19:44:49 +0000 (19:44 +0000)]
Add <Control>Tab bindings for "move-focus" so that Control-Tab to escape
Tue Jan 29 14:24:49 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_class_init): Add <Control>Tab
bindings for "move-focus" so that Control-Tab to escape from
something that eats Tab just works if not otherwise overriden.
* gtk/gtkspinbutton.c (gtk_spin_button_new_with_range)
* gtk/gtkvscale.c (gtk_vscale_new_with_range)
* gtk/gtkhscale.c (gtk_hscale_new_with_range): Use a page_size
of zero for the adjustment, since at times we think that the range
is lower to upper - page_size. A page size equally to the
step_increment is, in any case, not meaningful.
Tor Lillqvist [Tue, 29 Jan 2002 13:59:47 +0000 (13:59 +0000)]
Add comment about gtk-1-3-win32-production branch currently being ahead in
2002-01-29 Tor Lillqvist <tml@iki.fi>
* README.win32: Add comment about gtk-1-3-win32-production branch
currently being ahead in functionality and code cleanliness (in
gdk/win32). Just in case somebody looks at the code in gdk/win32
here and starts fixing it, when it is going to change soonish
anyway.
Tim Janik [Tue, 29 Jan 2002 11:35:28 +0000 (11:35 +0000)]
fix default value for ::digits property, leave as 1 as per havoc's
Tue Jan 29 11:51:14 2002 Tim Janik <timj@gtk.org>
* gtk/gtkscale.[hc]: fix default value for ::digits property,
leave as 1 as per havoc's request.
don't apply the draw_digits value to range->round_digits,
so we don't perform gross quantization by default.
Havoc Pennington [Tue, 29 Jan 2002 04:55:48 +0000 (04:55 +0000)]
fix assertion failure by creating the line data, but not validating it at
2002-01-25 Havoc Pennington <hp@redhat.com>
* gtk/gtktextbtree.c (_gtk_text_btree_delete): fix assertion
failure by creating the line data, but not validating it at this
stage. Also, remove old code related to the "bogus newline" mess
that removed all tags from the last char in the buffer if you
tried to delete it.
(_gtk_text_line_data_new): put this here and prepend underscore,
remove from gtktextlayout.c
projects / ~andy / gtk / log