Emmanuele Bassi [Sat, 31 May 2008 18:52:50 +0000 (18:52 +0000)]
Bug 535830 – wrong content type adding an item
2008-05-31 Emmanuele Bassi <ebassi@gnome.org>
Bug 535830 – wrong content type adding an item
* gtk/gtkrecentmanager.c:
(gtk_recent_manager_add_item_query_info): Use the correct API
for retrieving the fast MIME type of a URI. (Carlos Garcia
Campos)
Bug 530146 - Setting non-string tooltip with
gtk_tree_view_set_tooltip_column() segfaults
* gtk/gtktreeview.c (gtk_tree_view_set_tooltip_query_cb): use
gtk_tree_model_get_value() and explicitly transform the value to a
string before setting it as tooltip.
* gdk/gdkapplaunchcontext.h
* gdk/gdktestutils.h
* gtk/gtkmountoperation.h
* gtk/gtkshow.h
* gtk/gtktestutils.h
* gtk/gtktoolshell.h: no need to allow disabling single includes
conditionally in these new files. Simply forbid including them
individually from the beginning.
Michael Natterer [Fri, 30 May 2008 12:02:19 +0000 (12:02 +0000)]
gtk/gtkmountoperation.h gtk/gtkshow.h gtk/gtktestutils.h no need to allow
2008-05-30 Michael Natterer <mitch@imendio.com>
* gtk/gtkmountoperation.h
* gtk/gtkshow.h
* gtk/gtktestutils.h
* gtk/gtktoolshell.h: no need to allow disabling single includes
conditionally in these new files. Simply forbid including them
individually from the beginning.
Matthias Clasen [Thu, 29 May 2008 14:33:49 +0000 (14:33 +0000)]
Bug 522084 – GIcon support for GtkIconTheme & GtkImage
2008-05-27 Matthias Clasen <mclasen@redhat.com>
Bug 522084 – GIcon support for GtkIconTheme & GtkImage
* gtk/gtkicontheme.[hc]: Add support for GIcon based lookups.
* gtk/gtkimage.[hc]: Allow setting an image from a GIcon.
* gtk/gtk.symbols: Additions
* tests/testimage.c: Add a GIcon test
Michael Natterer [Thu, 29 May 2008 09:34:53 +0000 (09:34 +0000)]
gtk/Makefile.am add a single-include header for the unix print stuff.
2008-05-29 Michael Natterer <mitch@imendio.org>
* gtk/Makefile.am
* gtk/gtkunixprint.h: add a single-include header for the unix
print stuff.
* gtk/gtkpagesetupunixdialog.h
* gtk/gtkprinter.h
* gtk/gtkprintjob.h
* gtk/gtkprintunixdialog.h: add single-include guards that #error
out if GTK_DISABLE_SINGLE_INCLUDES is defined and any of these
files is included individually.
Michael Natterer [Wed, 28 May 2008 15:35:43 +0000 (15:35 +0000)]
whitespace cleanup: remove trailing whitespace and excess newlines and
2008-05-28 Michael Natterer <mitch@imendio.com>
* gtk/gtk*.h: whitespace cleanup: remove trailing whitespace and
excess newlines and sprinkled some newlines where needed. Zero
code or formatting changes included.
Michael Natterer [Wed, 28 May 2008 15:08:57 +0000 (15:08 +0000)]
last but not least, add G_DISABLE_SINGLE_INCLUDES,
2008-05-28 Michael Natterer <mitch@gimp.org>
* configure.in: last but not least, add G_DISABLE_SINGLE_INCLUDES,
GDK_PIXBUF_DISABLE_SINGLE_INCLUDES and GTK_DISABLE_SINGLE_INCLUDES
to CPPFLAGS so it's impossible to commit code that would break
apps which use DISABLE_INCLUDE defines.
Michael Natterer [Wed, 28 May 2008 15:07:04 +0000 (15:07 +0000)]
define __GTK_H_INSIDE__ around including all other headers.
2008-05-28 Michael Natterer <mitch@imendio.com>
* gtk/gtk.h: define __GTK_H_INSIDE__ around including all other
headers.
* gtk/gtktypebuiltins.h.template
* gtk/gtkversion.h.in
* gtk/gtk*.h: add single-include guards that #error out if
GTK_DISABLE_SINGLE_INCLUDES is defined and any of these files is
included individually.
* gtk/gtkprintbackend.h
* gtk/gtkprinter-private.h
* gtk/gtktextlayout.h
* gtk/gtktexttagprivate.h
* gtk/gtktexttypes.h
* gtk/gtktreedatalist.h: include <gtk/gtk.h> instead of individual
headers in these private or semi-private headers.
* gtk/gtkimmodule.h: also here because it's not in gtk.h.
* gtk/gtkpagesetupunixdialog.h
* gtk/gtkprinter.h
* gtk/gtkprintjob.h
* gtk/gtkprintunixdialog.h: likewise in the gtkunixprint headers.
* gtk/gtkclist.h
* gtk/gtkcombo.h
* gtk/gtkctree.h
* gtk/gtkfilesel.h
* gtk/gtkitemfactory.h
* gtk/gtklist.h
* gtk/gtklistitem.h
* gtk/gtkoldeditable.h
* gtk/gtkoptionmenu.h
* gtk/gtkpixmap.h
* gtk/gtkpreview.h
* gtk/gtksignal.h
* gtk/gtktipsquery.h: whenever possible, include only <gtk/gtk.h>
instead of individual headers in these deprecated headers. They
don't get included at all when GTK_DISABLE_DEPRECATED is defined,
so if an app needs them anyway, it must undef GTK_DISABLE_DEPRECATED
and include them individually, which should continue to work.
* gtk/gtkclist.c: include "gtkctree.h" because of the change
above.
Bug 449625 - crash in gtk_tree_view_real_move_cursor at gtktreeview.c:9641
2008-05-28 Kristian Rietveld <kris@imendio.com>
Bug 449625 - crash in gtk_tree_view_real_move_cursor at
gtktreeview.c:9641
* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down):
cursor_offset *must* be larger than background height of the cursor
node, not just equal otherwise there is no guarantee there is a next
node.
Michael Natterer [Wed, 28 May 2008 14:01:57 +0000 (14:01 +0000)]
define __GDK_H_INSIDE__ around including all other headers.
2008-05-28 Michael Natterer <mitch@imendio.com>
* gdk/gdk.h: define __GDK_H_INSIDE__ around including all other
headers.
* gdk/gdkenumtypes.h.template
* gdk/gdk*.h: add single-include guards that #error out if
GTK_DISABLE_SINGLE_INCLUDES is defined and any of these files is
included individually. Also removed some redundant includes and
did some tiny trailing whitespace removal that's not worth to
commit separately.
* gdk/gdkprivate.h: include <gdk/gdk.h> instead of individual
files.
* gdk/win32/gdkwin32.h
* gdk/x11/gdkx.h: only include <gdk/gdkprivate.h> and remove all
other includes.
Bug 504087 - make gtk_tooltip_set_custom a no-op for setting the current
2008-05-28 Kristian Rietveld <kris@imendio.com>
Bug 504087 - make gtk_tooltip_set_custom a no-op for setting the
current widget again.
* gtk/gtktooltip.c (gtk_tooltip_set_custom),
(gtk_tooltip_reset), (gtk_tooltip_run_requery): use a
custom_was_reset field to check if the custom widget is set again in
the query-tooltip callback; if not, we set it to NULL. Based on a
patch by Xavier Claessens, insightful comments from Jean-Yves Lefort
and Christian Persch.
Michael Natterer [Wed, 28 May 2008 13:39:52 +0000 (13:39 +0000)]
define GDK_PIXBUF_H_INSIDE around including all other headers.
2008-05-28 Michael Natterer <mitch@imendio.com>
* gdk-pixbuf.h: define GDK_PIXBUF_H_INSIDE around including all
other headers.
* gdk-pixbuf-animation.h
* gdk-pixbuf-core.h
* gdk-pixbuf-enum-types.h.template
* gdk-pixbuf-features.h.in
* gdk-pixbuf-io.h
* gdk-pixbuf-loader.h
* gdk-pixbuf-simple-anim.h
* gdk-pixbuf-transform.h: add single-include guards that #error
out if GDK_PIXBUF_DISABLE_SINGLE_INCLUDES is defined and any of
these files is included individually.
Michael Natterer [Wed, 28 May 2008 12:59:48 +0000 (12:59 +0000)]
include <gtk/gtk.h> instead of <gtk/gtkaccessible.h>
2008-05-28 Michael Natterer <mitch@gimp.org>
* modules/other/gail/gailwidget.h: include <gtk/gtk.h> instead of
<gtk/gtkaccessible.h>
* modules/other/gail/*.h: don't include anyting from gtk since all
headers indirectly include gailwidget.h.
* modules/other/gail/gailcellparent.c: include <gtk/gtk.h> instead
of individual files.
* modules/other/gail/gailcheckmenuitem.c
* modules/other/gail/gailmenu.c
* modules/other/gail/gailtreeview.c: remove all gtk includes since
it's always included by including any gail header.
Bug 324282 - add selected signal to cell renderer combo.
2006-05-28 Kristian Rietveld <kris@imendio.com>
Bug 324282 - add selected signal to cell renderer combo.
* gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_class_init),
(gtk_cell_renderer_combo_changed),
(gtk_cell_renderer_combo_start_editing): add a new "changed" signal
that will be emitted as soon as the combo box emitted changed and has
an active iterator. (Modified patch based on work by James
Pelletier).
Refactor expand/collapse timeout handling (amendment to bug 511217).
2008-05-28 Kristian Rietveld <kris@imendio.com>
Refactor expand/collapse timeout handling (amendment to bug 511217).
* gtk/gtktreeview.c (add_expand_collapse_timeout),
(remove_expand_collapse_timeout): new functions, the remove function
also clears expanded_collapsed_node,
(cancel_arrow_animation): moved to be next to the add/remove timeout
functions,
(gtk_tree_view_unrealize),
(gtk_tree_view_row_deleted),
(gtk_tree_view_set_model),
(cancel_arrow_animation),
(gtk_tree_view_real_expand_row),
(gtk_tree_view_real_collapse_row): use the new add/remove functions.
Matthias Clasen [Wed, 28 May 2008 01:43:34 +0000 (01:43 +0000)]
Bug 509788 – GTK+ should use CUPS to set Postscript level of PS output
* modules/printbackends/cups/gtkprintbackendcups.c
(cups_printer_create_cairo_surface): Fall back to PostScript level 2
if the printer does not support level 3. Patch by Marek Kašík.
* modules/input/gtkimcontextime.h
* modules/input/gtkimcontextmultipress.h
* modules/input/gtkimcontextthai.h
* modules/input/gtkimcontextxim.h: include <gtk/gtk.h> instead of
individual files.
* modules/input/gtkimcontextime.c
* modules/input/gtkimcontextmultipress.c
* modules/input/gtkimcontextxim.c
* modules/input/imam-et.c
* modules/input/imcedilla.c
* modules/input/imcyrillic-translit.c
* modules/input/iminuktitut.c
* modules/input/imipa.c
* modules/input/imti-er.c
* modules/input/imti-et.c
* modules/input/imviqr.c: ditto. Some minor cleanups like moving
"gtk/gtkintl.h" to the end of includes.
bgo533891 - disallow DnD from the file list into itself
2008-05-27 Federico Mena Quintero <federico@novell.com>
http://bugzilla.gnome.org/show_bug.cgi?id=533891 - Don't allow
drag and drop from the file list into itself, as it doesn't make
sense (it would just change the current folder).
* gtk/gtkfilechooserdefault.c (file_list_dest_targets): Use
GTK_TARGET_OTHER_WIDGET so we don't DnD from the file list into
itself.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=20194
Tor Lillqvist [Tue, 27 May 2008 13:03:49 +0000 (13:03 +0000)]
Use simpler mode for open() on Windows. (No S_I?GRP and S_I?OTH bits are
2008-05-27 Tor Lillqvist <tml@novell.com>
* gtk/updateiconcache.c (build_cache): Use simpler mode for open()
on Windows. (No S_I?GRP and S_I?OTH bits are defined in
<sys/stat.h> on Windows, and the mode used in open() doesn't
matter much as there are no rwxrwxrwx bits on Windows anyway.)
Open file in binary mode. Passing "b" to fdopen() later isn't
enough.
Michael Natterer [Tue, 27 May 2008 12:05:14 +0000 (12:05 +0000)]
Fix and simplify definition of GDK_PIXBUF_VAR:
2008-05-27 Michael Natterer <mitch@imendio.com>
Fix and simplify definition of GDK_PIXBUF_VAR:
* Makefile.am: add -DGDK_PIXBUF_COMPILATION to INCLUDES.
* gdk-pixbuf.c: don't #define it here. Remove GDK_PIXBUF_VAR from
the definition of the version variables.
* gdk-pixbuf-features.h.in: in the !G_PLATFORM_WIN32 case, always
define GDK_PIXBUF_VAR to "extern". Remove redundant #ifndef
GDK_PIXBUF_VAR around the whole block, the header itself already
has include guards.
Carlos Garnacho [Tue, 27 May 2008 00:12:33 +0000 (00:12 +0000)]
Enable correctly dialog buttons sensitivity when the anonymous option is
2008-05-27 Carlos Garnacho <carlos@imendio.com>
* gtk/gtkmountoperation.c (gtk_mount_operation_ask_password): Enable
correctly dialog buttons sensitivity when the anonymous option is
enabled by default. Bug #531865.
Carlos Garnacho [Tue, 27 May 2008 00:08:00 +0000 (00:08 +0000)]
Set password dialog modal and transient for the parent window also if it
2008-05-27 Carlos Garnacho <carlos@imendio.com>
* gtk/gtkmountoperation.c (gtk_mount_operation_ask_password): Set
password dialog modal and transient for the parent window also if it
was specified in the constructor. Bug #531864.
Richard Hult [Mon, 26 May 2008 08:54:00 +0000 (08:54 +0000)]
Bug 530353 – Mac-like gtk_accelerator_get_label()
2008-05-26 Richard Hult <richard@imendio.com>
Bug 530353 – Mac-like gtk_accelerator_get_label()
* gtk/gtkaccellabel.c: (gtk_accel_label_class_init),
(append_keyval_symbol), (_gtk_accel_label_class_get_accelerator_label):
On quartz, make gtk_accelerator_get_label() format a Mac-like
string, using unicode characters for modifier keys, arrows, delete
etc. Patch from Yevgen Muntyan.
Cody Russell [Sun, 25 May 2008 23:41:43 +0000 (23:41 +0000)]
Bug 523562 - gtk-update-icon-cache core dumps when run concurrently and
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 523562 - gtk-update-icon-cache core dumps when run concurrently and
when options are missing
* gtk/updateiconcache.c: Open the cache file (O_CREAT | O_EXCL) so
that other processes that try to open it will fail gracefully. Also
fix a crasher caused by lack of a NULL check. Report and patch
by Erwann Chenede.
Cody Russell [Sun, 25 May 2008 23:27:34 +0000 (23:27 +0000)]
Bug 526635 - _gdk_window_get_toplevel handles FOREIGN windows
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 526635 - _gdk_window_get_toplevel handles FOREIGN windows
* gdk/x11/gdkwindow-x11.c (_gdk_window_get_toplevel): Check
!WINDOW_IS_TOPLEVEL instead of checking for GDK_WINDOW_CHILD,
so that we also take into account for foreign windows.
Report and patch by Nathaniel Smith.
Cody Russell [Sun, 25 May 2008 23:21:40 +0000 (23:21 +0000)]
Bug 525461 - Don't invalidate under an input-only child
2008-05-25 Cody Russell <bratsche@gnome.org>
Bug 525461 - Don't invalidate under an input-only child
* gdk/x11/gdkgeometry-x11.c (_gdk_window_move_resize_child):
Check that the window is not input-only before invalidating.
Report and patch by Owen Taylor.
projects / ~andy / gtk / log