]>
Pileus Git - ~andy/gtk/log
Matthias Clasen [Mon, 27 Jun 2011 00:46:26 +0000 (20:46 -0400)]
GtkTextviewAccessible: some initial cleanup and code rearrangement
Matthias Clasen [Mon, 27 Jun 2011 00:42:54 +0000 (20:42 -0400)]
GtkEntryAccessible: Slight simplification of attribute handling
Make this use the same convenience function as is used elsewhwere.
Matthias Clasen [Sun, 26 Jun 2011 04:38:20 +0000 (00:38 -0400)]
GtkLabelAccessible: avoid some pointless variables
Matthias Clasen [Sun, 26 Jun 2011 03:08:26 +0000 (23:08 -0400)]
Initial move GailTextView -> GtkTextViewAccessible
This just does the renaming, and drops the factory.
Benjamin Otte [Sun, 26 Jun 2011 21:07:11 +0000 (23:07 +0200)]
tests: Add an a11y test for scales
Benjamin Otte [Sun, 26 Jun 2011 21:00:49 +0000 (23:00 +0200)]
gail: Remove AtkText implementation from GailScale
AtkText should only be implemented by text editing widgets. For just
giving out a small text string, AtkObject::name should be used.
Benjamin Otte [Sun, 26 Jun 2011 20:52:14 +0000 (22:52 +0200)]
cellareacontext: Don't ever return -1 for preferred sized
People don't check for -1 when computing size requests. Document this
new behavior.
Benjamin Otte [Sat, 25 Jun 2011 17:49:37 +0000 (19:49 +0200)]
Revert 'Insert an LRM, to prevent -20 to come out as 20- in RTL'
Correct text direction for printing of doubles should be (and is) done
by printf() and friend and not enforced by GtkScale.
This reverts commit
5eb2aac9474e1e8d035af1cbb4bc6756539af335
https://bugzilla.gnome.org/show_bug.cgi?id=322571
Benjamin Otte [Sat, 25 Jun 2011 17:47:46 +0000 (19:47 +0200)]
a11y: Export the printed value of a scale as the description.
Benjamin Otte [Fri, 24 Jun 2011 21:17:28 +0000 (23:17 +0200)]
a11y: Remove AtkText implementation from GailMenuitem
AtkText should only be implemented by text editing widgets. For just
giving out a small text string, AtkObject::name should be used.
Benjamin Otte [Fri, 24 Jun 2011 21:03:15 +0000 (23:03 +0200)]
a11y: Remove AtkText implementation from GailExpander
AtkText should only be implemented by text editing widgets. For just
giving out a small text string, AtkObject::name should be used.
Matthias Clasen [Sun, 26 Jun 2011 02:44:46 +0000 (22:44 -0400)]
Add some texts for text selection signals
Test that we do emit ::text_caret_moved and ::text_selection_changed
as expected.
Matthias Clasen [Sun, 26 Jun 2011 02:44:07 +0000 (22:44 -0400)]
Minor optimization
No need to get the cursor position twice in a row.
Matthias Clasen [Sun, 26 Jun 2011 02:43:02 +0000 (22:43 -0400)]
GtkLabelAccessible: some selection handling fixes
Don't move the cursor to 0 when removing the selection,
and don't overlook growing selections.
Matthias Clasen [Sun, 26 Jun 2011 02:42:17 +0000 (22:42 -0400)]
GtkLabel: optimize away some ::notify emissions
Matthias Clasen [Sun, 26 Jun 2011 02:03:12 +0000 (22:03 -0400)]
Skip line-related tests for GtkEntry
GtkEntry sets single-paragraph mode on its pango layout,
so the results for line-related navigation don't match.
Matthias Clasen [Sun, 26 Jun 2011 01:53:00 +0000 (21:53 -0400)]
GtkEntryAccessible: shorten some function names
Just cosmetics
Matthias Clasen [Sun, 26 Jun 2011 01:35:10 +0000 (21:35 -0400)]
Remove a bit of dead code
Matthias Clasen [Sun, 26 Jun 2011 01:26:51 +0000 (21:26 -0400)]
GtkEntryAccessible: Clean up the AtkAction implementation a bit
No functional changes.
Matthias Clasen [Sun, 26 Jun 2011 01:05:12 +0000 (21:05 -0400)]
Purge traces of insert idle handler
Matthias Clasen [Sun, 26 Jun 2011 01:00:02 +0000 (21:00 -0400)]
GtkEntryAccessible: Rework text_changed handling
No more signal emission from an idle.
Matthias Clasen [Sat, 25 Jun 2011 22:49:54 +0000 (18:49 -0400)]
Fix up signal ordering issues in GtkEntry
Ensure that text and selection boundaries are in a
consistent state when we emit notifications, that ::insert-text
and ::delete-text are emitted before any changes, and that
::changed is emitted after property notifications when inserting
or deleting text.
Matthias Clasen [Sat, 25 Jun 2011 22:47:51 +0000 (18:47 -0400)]
Add a test for entry signals
These tests check that text and selection boundaries are in a
consistent state when we emit notifications, that ::insert-text
and ::delete-text are emitted before any changes, and that
::changed is emitted after property notifications when inserting
or deleting text.
Matthias Clasen [Sat, 25 Jun 2011 18:43:59 +0000 (14:43 -0400)]
GtkEntryAccessible: port from GailTextUtil to GtkPango
Also clean up and rearrange the code.
As a side-effect, the no-longer-existing stipple attributes
are dropped. Update test results to match.
Matthias Clasen [Sat, 25 Jun 2011 17:57:55 +0000 (13:57 -0400)]
Allow use of private api in a11y/
Matthias Clasen [Sat, 25 Jun 2011 17:57:42 +0000 (13:57 -0400)]
Trivial whitespace fix
Matthias Clasen [Sat, 25 Jun 2011 02:28:54 +0000 (22:28 -0400)]
GtkSpinButtonAccessible: Coding style cleanups
And some code rearrangement.
Matthias Clasen [Sat, 25 Jun 2011 02:12:55 +0000 (22:12 -0400)]
First cut at GailEntry -> GtkEntryAccessible
Replace the factory for entry and spin button with
gtk_widget_class_set_accessible_type() calls, and move then
to the GtkAccessible namespace.
Matthias Clasen [Sat, 25 Jun 2011 01:18:07 +0000 (21:18 -0400)]
Avoid warnings in clipboard code
The a11y selection tests poke the selection on unrealized
labels. Don't spew warnings in this case.
Matthias Clasen [Sat, 25 Jun 2011 01:17:55 +0000 (21:17 -0400)]
Add some tests for selection handling
Matthias Clasen [Sat, 25 Jun 2011 00:57:22 +0000 (20:57 -0400)]
Add some more basic tests
Matthias Clasen [Sat, 25 Jun 2011 00:47:59 +0000 (20:47 -0400)]
Remove debug spew
Matthias Clasen [Sat, 25 Jun 2011 00:42:16 +0000 (20:42 -0400)]
Expand the insert/delete text
GtkLabel passes this now.
Matthias Clasen [Sat, 25 Jun 2011 00:37:42 +0000 (20:37 -0400)]
Update test results
The label accessible port dropped the no-longer-existing
stipple attributes; so update the expected test results to match.
Matthias Clasen [Sat, 25 Jun 2011 00:36:05 +0000 (20:36 -0400)]
Port GtkLabelAccessible from GailTextUtil to GtkPango api
Unfortunately, we still keep a copy of the text around, for
::insert/::delete signals; those emissions need to be moved to
GtkLabel itself.
Matthias Clasen [Sat, 25 Jun 2011 00:26:42 +0000 (20:26 -0400)]
GtkStyleContext: add some aux. a11y api
This function translates the fg/bg color into atk attributes.
Matthias Clasen [Sat, 25 Jun 2011 00:22:55 +0000 (20:22 -0400)]
Add some aux. pango api to help AtkText implementations
These functions are implementations of the AtkText api on top
of a PangoLayout, and are intended to replace GailTextUtil.
Since gtkpango.h is a private header, also remove the individual
inclusion prohibition.
Matthias Clasen [Sat, 25 Jun 2011 00:16:05 +0000 (20:16 -0400)]
Replace the boundary test
The new test is much smaller, and the results have been carefully
looked at; GtkLabel gets it right, the others don't.
Also, temporarily include some code that dumps out useful information.
Matthias Clasen [Fri, 24 Jun 2011 05:01:50 +0000 (01:01 -0400)]
Sort text attributes alphabetically in dumps
Matthias Clasen [Fri, 24 Jun 2011 03:30:57 +0000 (23:30 -0400)]
GtkLabel: factor out two getters
Make the get_property switch look a little nicer.
We export these functions privately for use in the label
accessible implementation later on.
Benjamin Otte [Fri, 24 Jun 2011 03:01:03 +0000 (05:01 +0200)]
messagedialog: Initialize style values in init()
Fixes underallocation warnings
Benjamin Otte [Thu, 23 Jun 2011 21:45:36 +0000 (23:45 +0200)]
a11y: Remove setters for column description/header
Benjamin Otte [Thu, 23 Jun 2011 18:58:51 +0000 (20:58 +0200)]
a11y: Make treeview header and caption no longer settable
It's not exposed in AT-SPI so we don't need it.
Benjamin Otte [Thu, 23 Jun 2011 15:57:26 +0000 (17:57 +0200)]
a11y: Remove setters for row description/header
AT-SPI doesn't expose them, so there's no need to keep them.
Matthias Clasen [Thu, 23 Jun 2011 22:41:47 +0000 (18:41 -0400)]
GtkHSV: set a suitable role for the accessible
The consensus of the accessibility team was that 'color chooser'
fits best for this. Update tests to match.
Matthias Clasen [Thu, 23 Jun 2011 22:31:22 +0000 (18:31 -0400)]
GtkSpinner: set a suitable role for the accessible
The consensus of the accessibility team was that this is
an animation. Update tests to match.
Matthias Clasen [Thu, 23 Jun 2011 22:18:11 +0000 (18:18 -0400)]
GtkLabelAccessible: remove redundant check
We always have the textutil now, so remove some NULL checks.
Also, never say 'State is defunct' again...
Matthias Clasen [Thu, 23 Jun 2011 21:56:03 +0000 (17:56 -0400)]
GtkLabel: freeze property notification where appropriate
When setting properties that require recalculating the label
text, freeze notification until the label is properly updated.
This fixes bug 126797.
Matthias Clasen [Thu, 23 Jun 2011 21:54:07 +0000 (17:54 -0400)]
GtkLabelAccessible: remove broken workarounds
This removes a horrible workaround for bug 126797. To prevent
picking up accidental markup in label texts, the label accessible
is listening for window creation and mapping and defers initializing
its text until then.
Matthias Clasen [Thu, 23 Jun 2011 21:52:39 +0000 (17:52 -0400)]
Add a testcase for a very old bug
This tests a problem that was first noticed in 2003, in
bug 126797: The text of a label accessible is not properly
updated when the label switches from !use-markup to use-markup.
Matthias Clasen [Thu, 23 Jun 2011 21:11:49 +0000 (17:11 -0400)]
Test lots of boring string functions
Needless to say, these tests still fail.
Matthias Clasen [Thu, 23 Jun 2011 17:07:50 +0000 (13:07 -0400)]
Add some AtkText tests
These unfortunately all fail really miserably, currently.
Matthias Clasen [Thu, 23 Jun 2011 05:12:29 +0000 (01:12 -0400)]
GailLabel -> GtkLabelAccessible
A first experimental conversion from the gail namespace to gtkaccessible.
At the same time, use gtk_widget_class_set_accessible_type() to register
the accessible type for GtkLabel.
Matthias Clasen [Thu, 23 Jun 2011 04:09:18 +0000 (00:09 -0400)]
Remove gail_widget_new()
The function was unused and unnecessary.
Matthias Clasen [Thu, 23 Jun 2011 04:08:50 +0000 (00:08 -0400)]
Forgotten file
Matthias Clasen [Thu, 23 Jun 2011 03:20:11 +0000 (23:20 -0400)]
spinbutton testcase
Matthias Clasen [Thu, 23 Jun 2011 03:16:28 +0000 (23:16 -0400)]
iconview testcase
Matthias Clasen [Thu, 23 Jun 2011 03:11:20 +0000 (23:11 -0400)]
Paned testcase
Matthias Clasen [Thu, 23 Jun 2011 03:08:59 +0000 (23:08 -0400)]
Statusbar testcases
Matthias Clasen [Thu, 23 Jun 2011 03:02:24 +0000 (23:02 -0400)]
tree-performance: test with tree stores too
This duplicates the current test with a GtkTreeStore instead
of a GtkListStore.
Matthias Clasen [Thu, 23 Jun 2011 02:27:10 +0000 (22:27 -0400)]
GailTreeView: optimize a bit
Avoid many unnecessary list iterations by using a hash table
to store cell infos, and caching row and column counts. Based
on patches by William Jon McCann, bug 554171.
tree-performance results:
before: (MINPERF:large tree test with a11y: 9.18531sec)
after: (MINPERF:large tree test with a11y: 0.923463sec)
for comparison, without accessibility:
(MINPERF:large tree test: 0.016179sec)
Matthias Clasen [Wed, 22 Jun 2011 21:39:38 +0000 (17:39 -0400)]
a11y: add a treeview performance test
This test creates a treeview with a few columns and a liststore,
and then populates it with a 1000 rows.
Matthias Clasen [Wed, 22 Jun 2011 03:49:05 +0000 (23:49 -0400)]
Add a calendar testcase
Matthias Clasen [Wed, 22 Jun 2011 03:45:46 +0000 (23:45 -0400)]
Add an infobar testcase
Matthias Clasen [Wed, 22 Jun 2011 03:41:29 +0000 (23:41 -0400)]
Add a GtkProgressBar testcase
Matthias Clasen [Wed, 22 Jun 2011 03:37:30 +0000 (23:37 -0400)]
Add a GtkSpinner testcase
Matthias Clasen [Wed, 22 Jun 2011 03:34:38 +0000 (23:34 -0400)]
Add a lockbutton testcase
Matthias Clasen [Wed, 22 Jun 2011 03:31:34 +0000 (23:31 -0400)]
Add a testcase for all the pickers
Matthias Clasen [Wed, 22 Jun 2011 03:30:38 +0000 (23:30 -0400)]
Don't pass NULL to functions expecing a real string
...and when you do pass them a real string, don't leak it.
Benjamin Otte [Wed, 22 Jun 2011 02:29:42 +0000 (04:29 +0200)]
Revert "Add a testcase with a print dialog"
THe testcase depends on the installed printers, so is nondeterministic.
This reverts commit
5bf14cc7485fe015ad15747454e877f2fb3dabc5 .
Benjamin Otte [Wed, 22 Jun 2011 02:24:32 +0000 (04:24 +0200)]
Revert "Add a filechooser testcase"
File choosers depend on the files in the current directory and the
settings the user has set for the file chooser, so the output cannot be
deterministic.
This reverts commit
f05c9e02c49f857c33e02c3d89483fcccb5df254 .
Benjamin Otte [Wed, 22 Jun 2011 02:21:53 +0000 (04:21 +0200)]
Revert "Add a testcase involving a font selection dialog"
The font chooser depends on the fonts installed on the system, so the
output is nondeterministic.
This reverts commit
08fdc399762c2af07d94e42a1801e691e5d4d6ab .
Benjamin Otte [Wed, 22 Jun 2011 02:20:36 +0000 (04:20 +0200)]
tests: Don't emit a message for every unnamed object
Benjamin Otte [Wed, 22 Jun 2011 02:14:49 +0000 (04:14 +0200)]
tests: Reset the unnamed counter before a test run
This guarantees that objects are named the same all the time.
Benjamin Otte [Wed, 22 Jun 2011 01:47:25 +0000 (03:47 +0200)]
gail: Add support for action_set_description
As set_description is never called and unsupported by the at-spi, we can
omit implementing it.
This means we can also omit get_description calls in various places, as
they'd just return the default value: NULL.
Benjamin Otte [Tue, 21 Jun 2011 16:14:40 +0000 (18:14 +0200)]
tests: Fix crash due to freeing random pointers
Benjamin Otte [Tue, 21 Jun 2011 14:43:56 +0000 (16:43 +0200)]
a11y: Remove hack for old code
This code was supposed to work around a bad interaction between GOK and
Nautilus from 7 years ago.
If it still exists, the GOK developers may complain to the Nautilus
developers.
https://bugzilla.gnome.org/show_bug.cgi?id=137401
Benjamin Otte [Tue, 21 Jun 2011 11:16:11 +0000 (13:16 +0200)]
gail: Remove useless code
The ATK default code does the same thing as these two functions.
Joachim Breitner [Tue, 21 Jun 2011 08:55:28 +0000 (10:55 +0200)]
docs: Remove mention of client messages
Matthias Clasen [Wed, 22 Jun 2011 00:18:04 +0000 (20:18 -0400)]
Add an assistant testcase
Matthias Clasen [Wed, 22 Jun 2011 00:12:37 +0000 (20:12 -0400)]
Add a testcase involving an expander
Matthias Clasen [Wed, 22 Jun 2011 00:08:46 +0000 (20:08 -0400)]
Add a testcase with a print dialog
Matthias Clasen [Wed, 22 Jun 2011 00:03:08 +0000 (20:03 -0400)]
Add a messagedialog testcase
Matthias Clasen [Tue, 21 Jun 2011 23:58:25 +0000 (19:58 -0400)]
Add a testcase involving a font selection dialog
Matthias Clasen [Tue, 21 Jun 2011 23:55:39 +0000 (19:55 -0400)]
Add a testcase with an appchooser dialog
Matthias Clasen [Tue, 21 Jun 2011 23:34:55 +0000 (19:34 -0400)]
Add a README for accessibility-dump
Matthias Clasen [Tue, 21 Jun 2011 23:20:59 +0000 (19:20 -0400)]
Add an about dialog testcase
Matthias Clasen [Tue, 21 Jun 2011 23:20:28 +0000 (19:20 -0400)]
Add a color chooser testcase
Matthias Clasen [Tue, 21 Jun 2011 23:12:55 +0000 (19:12 -0400)]
Add a scrollbar to the range testcase
Matthias Clasen [Tue, 21 Jun 2011 22:56:32 +0000 (18:56 -0400)]
Add a filechooser testcase
Matthias Clasen [Tue, 21 Jun 2011 22:53:30 +0000 (18:53 -0400)]
Remove debug spew
This had crept into the expected output for the buttons
testcase.
Matthias Clasen [Tue, 21 Jun 2011 22:53:06 +0000 (18:53 -0400)]
GailTreeView: deal with absence of model
Matthias Clasen [Tue, 21 Jun 2011 22:52:24 +0000 (18:52 -0400)]
GailImageCell: Deal with absence of pixbufs
...and when there are pixbufs, don't leak them.
Matthias Clasen [Tue, 21 Jun 2011 22:51:40 +0000 (18:51 -0400)]
Fix dependencies between directories
This ensures that libgtk gets relinked when I touch sources
in gtk/a11y.
Matthias Clasen [Tue, 21 Jun 2011 22:06:02 +0000 (18:06 -0400)]
Try harder to generate names for accessibles
We are still hitting the 'no name' case in GtkFileChooser for
a GailBox, otherwise.
Matthias Clasen [Tue, 21 Jun 2011 22:01:26 +0000 (18:01 -0400)]
Handle AtkValue implementations that return integer values
We do this by transforming the returned GValue to a string.
As a side-effect, the formatting for doubles changes, so
adjust expected output to match.
Matthias Clasen [Mon, 20 Jun 2011 13:03:25 +0000 (09:03 -0400)]
Don't build the libgail-util docs
The doc build for that is currently broken, and libgail-util is
undergoing reconstructive surgery anyway, currently.
Or maybe it'll turn out to be an amputation...
Benjamin Otte [Mon, 20 Jun 2011 12:22:49 +0000 (14:22 +0200)]
tests: omit fg-color and bg-color values from attributes
They depend on the environment, too.
Benjamin Otte [Mon, 20 Jun 2011 12:14:00 +0000 (14:14 +0200)]
tests: Add line breaks when dumping text attributes
This improves diff readability a lot when attributes differ.
Benjamin Otte [Mon, 20 Jun 2011 11:58:10 +0000 (13:58 +0200)]
widget: Use g_type_add_class_private()
It turns out that that funciton does indeed exist and my rant was just
outdated. Shame on me.