Christian Persch [Wed, 31 Jan 2007 18:40:32 +0000 (18:40 +0000)]
Hide the Credits button iff there are no credits to show. Bug #402806.
2007-01-31 Christian Persch <chpe@svn.gnome.org>
* gtk/gtkaboutdialog.c: (update_credits_button_visibility),
(gtk_about_dialog_set_authors), (gtk_about_dialog_set_documenters),
(gtk_about_dialog_set_artists),
(gtk_about_dialog_set_translator_credits): Hide the Credits button iff
there are no credits to show. Bug #402806.
Tor Lillqvist [Tue, 30 Jan 2007 23:49:39 +0000 (23:49 +0000)]
New debugging function. (_gdk_input_wintab_init_check): Call it when
2007-01-31 Tor Lillqvist <tml@novell.com>
* gdk/win32/gdkinput-win32.c (print_cursor): New debugging
function.
(_gdk_input_wintab_init_check): Call it when debugging output is
requested.
(_gdk_input_wintab_init_check): Skip duplicated cursors for Wacom
tablets. The Wacom driver reports duplicated cursors with
physid==0. Fix verified by Robert *gren. (Should be U+00D6
there, but svn won't let me.)
Matthias Clasen [Tue, 30 Jan 2007 18:36:44 +0000 (18:36 +0000)]
Be more careful about toplevel possibly being NULL. (#402453, Sebastian
2007-01-30 Matthias Clasen <mclasen@redhat.com>
* gdk/x11/gdkwindow-x11.c (gdk_x11_window_move_to_current_desktop):
(gdk_x11_window_set_user_time): Be more careful about toplevel
possibly being NULL. (#402453, Sebastian Bacher)
Michael Natterer [Mon, 29 Jan 2007 15:45:18 +0000 (15:45 +0000)]
queue a draw on the parent_menu_item of this menu item's menu, to enable
2007-01-29 Michael Natterer <mitch@imendio.com>
* gtk/gtkmenuitem.c (gtk_menu_item_select)
(gtk_menu_item_deselect): queue a draw on the parent_menu_item of
this menu item's menu, to enable themeing menu items depending on
whether something is selected in their submenu (patch taken from
maemo-gtk).
Matthias Clasen [Mon, 29 Jan 2007 03:24:09 +0000 (03:24 +0000)]
Reinstate gtk_toolbar_content_new_compatibility() that was mistakenly
2007-01-28 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktoolbar.c: Reinstate gtk_toolbar_content_new_compatibility()
that was mistakenly "cleaned up" a while ago. Also
revert a problematic change to the screen_changed
handler. (#401598, Søren Sandmann)
Matthias Clasen [Sun, 28 Jan 2007 03:16:30 +0000 (03:16 +0000)]
Rearrange things so that setting multiple properties causes not more than
2007-01-27 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktoolbar.c:
* gtk/gtktoolitem.c:
* gtk/gtktoolbutton.c: Rearrange things so that setting
multiple properties causes not more than a single
reconstruction of the contents.
* gtk/gtkaction.c (connect_proxy): Set all tool button
properties in one go.
Michael Natterer [Fri, 26 Jan 2007 13:31:35 +0000 (13:31 +0000)]
destroy the XIM only if it exists. While the code does look safe in
2007-01-26 Michael Natterer <mitch@imendio.com>
* modules/input/gtkimcontextxim.c (gtk_im_context_xim_finalize):
destroy the XIM only if it exists. While the code does look safe
in general, there can be corner cases where the "reconnecting"
boolean being FALSE does not correspond to the XIM being
allocated (fix taken from maemo-gtk).
Michael Natterer [Fri, 26 Jan 2007 11:39:16 +0000 (11:39 +0000)]
only block/unblock completion->priv->insert_text_id if it is actually
2007-01-26 Michael Natterer <mitch@imendio.com>
* gtk/gtkentrycompletion.c (gtk_entry_completion_insert_prefix):
only block/unblock completion->priv->insert_text_id if it is
actually connected. While this can't happen the way GtkEntry
itself uses the completion, it's still public API and should not
blindly call functions that will spit warnings (fix taken from
maemo-gtk).
Michael Natterer [Wed, 24 Jan 2007 16:10:40 +0000 (16:10 +0000)]
revert generic disabling of PRELIGHT state for the reasons given in bug
2007-01-24 Michael Natterer <mitch@imendio.com>
* gtk/gtkwidget.c (gtk_widget_set_state): revert generic disabling
of PRELIGHT state for the reasons given in bug #135666. Widget
states are sometimes abused or otherwise used wrongly for historic
reasons, causing this part of the patch to break e.g. menu items.
Chris Wilson [Mon, 22 Jan 2007 15:19:53 +0000 (15:19 +0000)]
Bug 399314 – Add G_GNUC_WARN_UNUSED_RESULT to gtk_style_attach
2007-01-22 Chris Wilson <chris@chris-wilson.co.uk>
Bug 399314 – Add G_GNUC_WARN_UNUSED_RESULT to gtk_style_attach
* gtk/gtkstyle.h:
Cause gcc to issue a warning if the style returned from
gtk_style_attach is not used. Failure to update
widget->style causes some very difficult to identify bugs,
eg Bug 353498 – crash in Terminal: changing icon theme.
Robert Oegren [Fri, 19 Jan 2007 02:38:46 +0000 (02:38 +0000)]
Fix for bug #143460 - missed tablet clicks on Windows
2007-01-19 Robert Oegren <gtk@roboros.com>
Fix for bug #143460 - missed tablet clicks on Windows
* gdk/win32/gdkinput-win32.c (_gdk_input_wintab_init_check):
Request absolute reporting of tablet button state, and cut down
the packet queue size a bit.
(_gdk_input_other_event): Change button state handling
accordingly. Also drop the no longer necessary code that detects
missed clicks/releases for button 1. The switch to absolute button
state should prevent missed events for all buttons. Additionally,
swap button 2 and 3.
(_gdk_input_grab_pointer): Don't reset button_state, that will only
cause a new press event as soon as the next tablet packet arrives.
* gdk/win32/gdkinput-win32.c (_gdk_input_wintab_init_check): Try
to load wintab32.dll dynamically here. If it is found look up the
handful Wintab functions we use.
(rest of file): Use these function pointers instead of calling the
functions from wntab32x.lib. The code in wntab32x.lib did the same
thing anyway: tried to load wintab32.dll, and looked up the
addresses of the actual functions from it.
* gdk/Makefile.am
* gdk/win32/Makefile.am: Drop the libwntab32x hacks.
* gdk/win32/wintab.h
* gdk/win32/pktdef.h: New files. Copied from the Wintab
SDK. Copyright blurb says: "The text and information contained in
this file may be freely used, copied, or distributed without
compensation or licensing restrictions."
* README.win32: Update a bit. Remove the text about the Wintab
SDK.
Tor Lillqvist [Fri, 19 Jan 2007 00:06:01 +0000 (00:06 +0000)]
gdk-pixbuf/Makefile.am gdk/Makefile.am gdk/win32/Makefile.am Fixes for
2007-01-18 Tor Lillqvist <tml@novell.com>
* gdk-pixbuf/Makefile.am
* gdk/Makefile.am
* gdk/win32/Makefile.am
* gtk/Makefile.am: Fixes for building outside srcdir on
Win32. (#336819, #340113) Drop distributing the handmade .la
libtool wrapper for the wntab32x library. It's too much trouble
making it work when building outside srcdir. Just link to the
library direcly using -Wl,win32/libwntab32x.a.
* gtk/gtkcheckbutton.c
* gtk/gtkdnd.c
* gtk/gtkentry.c
* gtk/gtkmenu.c
* gtk/gtktreeview.c
* gtk/gtkviewport.c: pass more clip rectangles to gtk_paint_foo()
functions. Based on a patch from maemo-gtk (bug #398023).
Tor Lillqvist [Wed, 17 Jan 2007 01:18:42 +0000 (01:18 +0000)]
Proper fix for #396175:
2007-01-17 Tor Lillqvist <tml@novell.com>
Proper fix for #396175:
* gtk/gtkimmulticontext.c: Revert change by Hans Breuer below: Do
include gtkprivate.h. On Win32 we do want to use the redefinition
of GTK_LOCALEDIR as a call to the function _gtk_get_localedir().
* gtk/gtkimmodule.c: Instead, correct the prefix also on
simple_context_info.domain_dirname. Do the prefix corrections
always on Win32, not just when GTK_LIBDIR is defined. i.e., until
now they were done only in the autoconfiscated gcc builds. Hans
needs to make sure GTK_LIBDIR and GTK_LOCALEDIR are defined also
in MSVC builds now.
(correct_localedir_prefix): New function, like
correct_libdir_prefix(), but for GTK_LOCALEDIR.
(_gtk_im_module_list): Call correct_localedir_prefix() on
simple_context_info.domain_dirname.
Christian Persch [Sun, 14 Jan 2007 18:47:36 +0000 (18:47 +0000)]
Use gtk_target_table_new_from_list and gtk_target_table_free instead of
2007-01-14 Christian Persch <chpe@svn.gnome.org>
* gtk/gtkclipboard.c: (gtk_clipboard_set_text),
(gtk_clipboard_set_image): Use gtk_target_table_new_from_list and
gtk_target_table_free instead of duplicating the code. Bug #396493.
Michael Natterer [Fri, 12 Jan 2007 11:56:57 +0000 (11:56 +0000)]
don't add entry->scroll_offset to entry->drag_start_y. Fixes the entry
2007-01-12 Michael Natterer <mitch@imendio.com>
* gtk/gtkentry.c (gtk_entry_button_press): don't add
entry->scroll_offset to entry->drag_start_y. Fixes the entry
starting drags after ridiculously small mouse movements.
Kjartan Maraas [Thu, 11 Jan 2007 00:53:00 +0000 (00:53 +0000)]
Make a single tilde go to $HOME in the location entry. Patch from Yevgen
2007-01-11 Kjartan Maraas <kmaraas@gnome.org>
* gtk/gtkfilesystemunix.c: (expand_tilde):
Make a single tilde go to $HOME in the location entry.
Patch from Yevgen Muntyan. Closes the gtk+ part of
bug #334168.
refactor to initialize indicator_size to TOGGLE_WIDTH instead of the
2007-01-10 Kristian Rietveld <kris@imendio.com>
* gtk/gtkcellrenderertoggle.c (gtk_cell_renderer_toggle_init):
refactor to initialize indicator_size to TOGGLE_WIDTH instead
of the hardcoded value of 12.
Peter Teichman [Mon, 8 Jan 2007 18:34:06 +0000 (18:34 +0000)]
Save the expanded state of the folder browser with the file chooser
* gtk/gtkfilechooserdefault.c:
* gtk/gtkfilechooserprivate.h:
* gtk/gtkfilechoosersettings.c:
* gtk/gtkfilechoosersettings.h:
Save the expanded state of the folder browser with the file
chooser settings. Resolves the expander portions of (#153828,
Lemmit Kaplinski)
Emmanuele Bassi [Mon, 8 Jan 2007 16:47:19 +0000 (16:47 +0000)]
Don't leak the icon pixbuf after setting it to the image menu item. Found
2007-01-08 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkrecentchoosermenu.c (gtk_recent_chooser_menu_create_item):
Don't leak the icon pixbuf after setting it to the image menu
item. Found by Paolo Borelli.
Matthias Clasen [Mon, 8 Jan 2007 14:49:30 +0000 (14:49 +0000)]
Don't corrupt memory when faced with paths with ridiculously large
2007-01-08 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktreemodel.c (gtk_tree_path_to_string): Don't
corrupt memory when faced with paths with ridiculously
large indices. Found by the GTKVTS test suite.
Tor Lillqvist [Sat, 6 Jan 2007 03:05:37 +0000 (03:05 +0000)]
New file. Downloaded from freedesktop.org's webcvs. Slighly edited cursors
2007-01-06 Tor Lillqvist <tml@novell.com>
* gdk/win32/cursor.bdf: New file. Downloaded from
freedesktop.org's webcvs. Slighly edited cursors "crosshair",
"diamond_cross", "draft_large", "gobbler" and "target" to fix
#392504. It is possible that the same end result could have been
achieved by tweaking bdfcursor.c instead.
do allow for invalidated nodes if the tree view is not realized. (#363147,
2007-01-05 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_row_changed): do allow for
invalidated nodes if the tree view is not realized. (#363147,
Carlos Garnacho, Miguel Cabrera).
Carlos Garnacho [Fri, 5 Jan 2007 17:29:49 +0000 (17:29 +0000)]
take into account both scroll arrows when calculating size request in
2007-01-05 Carlos Garnacho <carlosg@gnome.org>
* gtk/gtknotebook.c (gtk_notebook_size_request): take into account
both scroll arrows when calculating size request in GTK_POS_LEFT or
GTK_POS_RIGHT notebooks. (#393124, reported by Christian Persch)
Matthias Clasen [Fri, 5 Jan 2007 05:41:25 +0000 (05:41 +0000)]
move set_cursor after realization of the popup window, so clamp node
2007-01-04 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkcombobox.c (gtk_combo_box_popup): move set_cursor
after realization of the popup window, so clamp node doesn't fail.
(#346616, Tommi Komulainen, patch by Kristian Rietveld).
Matthias Clasen [Thu, 4 Jan 2007 06:09:13 +0000 (06:09 +0000)]
Rework the beep-on-uninserted-text by calling the input method regardless
2007-01-03 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktextview.c: Rework the beep-on-uninserted-text
by calling the input method regardless of editability,
and beeping from the commit/preedit-changed handlers.
(#390514, Yevgen Muntyan)
Matthias Clasen [Thu, 4 Jan 2007 05:58:32 +0000 (05:58 +0000)]
Fix #332604, reported by Joe Wreschnig, patch by Jan Arne Petersen and
2007-01-03 Matthias Clasen <mclasen@redhat.com>
Fix #332604, reported by Joe Wreschnig, patch
by Jan Arne Petersen and Behdad Esfahbod.
* gtk/gtklabel.c (gtk_label_size_allocate): Only
set the width of the layout when necessary.
(get_layout_location): Use pango_layout_get_pixel_extents()
instead of pango_layout_get_width().
projects / ~andy / gtk / log