Miguel de Icaza [Wed, 15 Apr 1998 02:15:36 +0000 (02:15 +0000)]
Fix the problem introduced by whoever thought that randomly changing ints
1998-04-14 Miguel de Icaza <miguel@nuclecu.unam.mx>
* gdk/gdkwindow.c (gdk_window_xid_at): Fix the problem introduced
by whoever thought that randomly changing ints to unsigned int
without reviewing the code was a good idea. It is, btw not
mentioned in the ChangeLog as usual, but I know it was not Elliot
the culprit this time.
Owen Taylor [Tue, 14 Apr 1998 01:39:40 +0000 (01:39 +0000)]
Don't read the character past the end of the text.
Mon Apr 13 21:40:14 1998 Owen Taylor <owt1@cornell.edu>
* gtk/gtktext.c (find_char_width): Don't read the
character past the end of the text.
* gtk/gtkrange.c (gtk_real_range_timer): If the mouse
button has been released before the timer is activated,
don't keep on scrolling.
* gdk/gdk.c (gdk_event_translate): Filter subsequent configure
events after we discard the first. Removed obsolete and
sometimes very slow GdkOtherEvent. (Left in gdktypes.h
with signal in GTK)
Owen Taylor [Mon, 13 Apr 1998 00:20:17 +0000 (00:20 +0000)]
Set a flag so instead of clearing the area in advance. That looked
Sun Apr 12 20:09:40 1998 Owen Taylor <owt1@cornell.edu>
* gtk/gtklabel.[ch] (gtk_label_expose): Set a flag so
instead of clearing the area in advance. That looked
_really_ bad.
* gtk/gtkcontainer.c (gtk_container_class_init): Changed
"focus" to RUN_LAST.
* gtk/gtkentry.c (gtk_entry_realize): Fixed place
where allocation was used where requisition was meant.
(Found by David J N Begley <david@avarice.nepean.uws.edu.au>)
* gtk/gtkwindow.c (gtk_window_set_default): Fixed
assertion in when setting default to NULL>
("Damon Chaplin" <DAChaplin@email.msn.com>)
* gtk/gtkwidget.c (gtk_widget_unparent): Unset the
default widget on the toplevel, if necessary.
Sun Apr 12 02:04:21 1998 Owen Taylor <owt1@cornell.edu>
* gtk/gtkpreview.c: Removed unecessary and harmful
htons/ntohs when storing properties. (X does the byte
swapping itself)
Owen Taylor [Wed, 8 Apr 1998 21:40:45 +0000 (21:40 +0000)]
Make sure widgets get removed from the resize queue before the connection
Wed Apr 8 17:27:40 1998 Owen Taylor <owt1@cornell.edu>
* gtk/gtkwidget.c (gtk_widget_unparent): Make sure
widgets get removed from the resize queue before the
connection between them and the resize queue is broken
by unparenting their parent.
Miguel de Icaza [Wed, 8 Apr 1998 19:46:09 +0000 (19:46 +0000)]
During drag and drop, set the event mask at ButtonPress time to include
1998-04-08 Miguel de Icaza <miguel@nuclecu.unam.mx>
* gdk/gdk.c (gdk_event_translate): During drag and drop, set the
event mask at ButtonPress time to include ButtonPressMask and
ButtonReleaseMask, otherwise, if the button is released, and we
get a LeaveNotify event, it still thinks we are doing a drag.
Owen Taylor [Tue, 7 Apr 1998 23:59:25 +0000 (23:59 +0000)]
Removed, because that's what a NULL comparison function means. And it
Tue Apr 7 19:36:48 1998 Owen Taylor <owt1@cornell.edu>
* gutils.c (g_direct_compare): Removed, because that's what
a NULL comparison function means. And it wasn't 64 bit safe.
Tue Apr 7 19:14:03 1998 Owen Taylor <owt1@cornell.edu>
* gdk/gdkpixmap.c: Added maximum field widths to prevent
possible '%s' scanf overflows. Replaced scanf("%c")
with getc(), Don't interpret /*/ as a full comment. Use
g_realloc/g_new.
* gtk/gtkwidget.h gtk/gtkprivate.h: Changed all flag
tests to check for ((GTK_WIDGET_FLAGS(widget) & FLAG) != 0)
instead of (GTK_WIDGET_FLAGS(widget) & FLAG)
* gtk/gtkfilesel.c: Use getwd() instead of getcwd() on
SunOS, because getcwd() hangs up in a wait4().
(Found by David Monniaux <monniaux@clipper.ens.fr>)
- Check device/inode/mtime not just inode/mtime, when
caching scanned directories.
(From: scottk@ig.utexas.edu (Scott Kempf))
* gdk/gdkpixmap.c: Check for 0 width/height when
creating pixmaps.
* gtk/*.c: Global substitution of recently introduced
"MAX (0," for allocations to "MAX (1,", since
creating a backing pixmap with a zero width or height
fails.
* gdk/gdkwindow.c (gdk_window_new): Don't set all the
WM properties for child windows. Don't set the base
size, since the value we set will be taken as a minimum
size.
* gtk/gtkmain.c (gtk_main_iteration_do): gdk_flush() the X-queue if
iteration_done==TRUE since we will most likely not get invoked again
(Marius Vollmer).
Elliot Lee [Tue, 7 Apr 1998 19:51:06 +0000 (19:51 +0000)]
gtk_button_remove(): When removing a child widget from a button, we don't
gtk_button_remove():
When removing a child widget from a button, we don't want to check
the child's visibility after removal (for the purpose of knowing
whether a queue_resize is needed), we want to check it *before*,
because the child may be destroyed during the
gtk_widget_unparent()
The diff is clearer than this stupid log message. :)
Added function to set the homogeneous flag of the table (needed by derived
1998-04-06 Federico Mena Quintero <federico@nuclecu.unam.mx>
* gtk/gtktable.h:
* gtk/gtktable.c (gtk_table_set_homogeneous): Added function to
set the homogeneous flag of the table (needed by derived widgets
and such).
1998-04-03 Federico Mena Quintero <federico@nuclecu.unam.mx>
* gtk/gtkradiobutton.h: Add prototype for gtk_radio_button_new_with_label_from_widget.
Owen Taylor [Mon, 6 Apr 1998 12:59:06 +0000 (12:59 +0000)]
Take border in account properly.
Mon Apr 6 08:05:23 1998 Owen Taylor <owt1@cornell.edu>
* gtk/gtkbutton.c (gtk_button_paint): Take border in
account properly.
* gtk/gtktext.c (gtk_text_realize): Don't recompute
geometry when creating with initial 1x1 geometry,
since our calculations can't handle that. Leave
text->line_start_cache NULL as sign we don't have
a real geometry yet.
* gtk/gtkentry.c (gtk_entry_motion_notify): Use the x
value we get from gdk_window_get_pointer, not from
event->x - since we always specify OwnerGrabButtonMask
(why???), event->x can refer to another window.
Owen Taylor [Mon, 6 Apr 1998 04:31:15 +0000 (04:31 +0000)]
Make tab key move in reading order (left-to-right top to bottom) - which
Mon Apr 6 00:28:28 1998 Owen Taylor <owt1@cornell.edu>
* gtk/gtkcontainer.c (gtk_container_focus_tab): Make
tab key move in reading order (left-to-right top
to bottom) - which might have been the original intended
behavior modulo sorting bugs.
* gtk-config.in: Never output -I/usr/include from --cflags
Owen Taylor [Sun, 5 Apr 1998 23:30:26 +0000 (23:30 +0000)]
Fixed assignment of adjustment->value to negative values. Moved a few
Sun Apr 5 19:30:23 1998 Owen Taylor <owt1@cornell.edu>
* gtk/gtkclist.c: Fixed assignment of adjustment->value
to negative values. Moved a few other allocation type things
around in ways that may or may matter. Fixed some allocation
errors (scrollbars were overlapping main window).
* gtk/gtkbutton.c (gtk_real_button_released): Small hack to keep
button labels from vanishing when the invoked operation blocks.
* gtk/gtkbox.c (gtk_box_remove): Assigning GTK_WIDGET_VISIBLE (widget)
to a gboolean (char) is _bad_. GTK_VISIBLE == 256.
Tim Janik [Sun, 5 Apr 1998 09:18:08 +0000 (09:18 +0000)]
take expired timeouts into account, otherwise things like e.g.
Sun Apr 5 09:35:55 1998 Tim Janik <timj@gtk.org>
* gtk/gtkmain.c (gtk_events_pending): take expired timeouts into
account, otherwise things like e.g. spin-buttons don't work.
also, count gtk_main_quit() as an event.
New function to draw a nifty "textured metal" frame. Could be useful in
1998-04-03 Federico Mena Quintero <federico@nuclecu.unam.mx>
* gtk/gtkhandlebox.c (draw_textured_frame): New function to draw a
nifty "textured metal" frame. Could be useful in gtkstyle.c, maybe.
(gtk_handle_box_paint): Paint a handle that does not make you puke
when you look at it.
Tim Janik [Tue, 31 Mar 1998 00:38:59 +0000 (00:38 +0000)]
show the menu_label unconditionally (even if it is not a default label).
Tue Mar 31 01:17:23 1998 Tim Janik <timj@gtk.org>
* gtk/gtknotebook.c (gtk_notebook_menu_item_create): show the menu_label
unconditionally (even if it is not a default label).
(gtk_notebook_update_labels): if we have a tab_label, then use its label
as the default menu_label.
Tim Janik [Mon, 30 Mar 1998 20:03:36 +0000 (20:03 +0000)]
removed this function, it was unneeded and not exported.
Mon Mar 30 21:40:21 1998 Tim Janik <timj@gtk.org>
* gtk/gtkclist.c (gtk_clist_row_from_ypixel): removed this function,
it was unneeded and not exported.
* gtk/gtkwidget.c (gtk_widget_ref) (gtk_widget_unref): don't check-cast
the widgets to volatile GtkObjects (which was there for debugging
purposes only). these functions should probably be macros, but that
would break binary compatibility again, sigh.
(gtk_widget_destroy): removed superfluous check-casts, since the
neccessary checks are done in gtk_object_destroy anyways. this should
be a macro as well but stays as a function for the above reasoonings.
Tim Janik [Sun, 29 Mar 1998 20:40:10 +0000 (20:40 +0000)]
Added wrapping capabilities to GtkSpinButton. New function :
Sun Mar 29 22:29:00 1998 Tim Janik <timj@gtk.org>
* gtk/gtkspinbutton.[ch] gtk/testgtk.c (gtk_spin_button_set_wrap):
Added wrapping capabilities to GtkSpinButton. New function :
gtk_spin_button_set_wrap (Lars Hamann and Stefan Jeske).
Owen Taylor [Sat, 28 Mar 1998 02:08:27 +0000 (02:08 +0000)]
Don't call XTranslateCoordinates on a destroyed window. (Why do we do
Fri Mar 27 21:01:17 1998 Owen Taylor <owt1@cornell.edu>
* gdk/gdk.c (gdk_event_translate): Don't call
XTranslateCoordinates on a destroyed window. (Why do we
do event processing at all on destroyed windows when we
throw out the results?)
* gtk/gtklabel.c: Clear the background when changing style/
state.