Olle Bergkvist [Wed, 18 Jun 2008 22:35:32 +0000 (22:35 +0000)]
bgo538784 - Don't change the filename entry in CREATE_FOLDER mode
2008-06-18 Olle Bergkvist <olle.bergkvist@yahoo.se>
http://bugzilla.gnome.org/show_bug.cgi?id=538784 - Don't change
the filename in the name entry in CREATE_FOLDER mode when changing
folders, so that you can enter a new subfolder name, double-click on a
folder to change to it, and close the dialog.
* gtk/gtkfilechooserdefault.c (update_chooser_entry): Don't change
the filename in the entry in CREATE_FOLDER mode, either.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=20457
http://bugzilla.gnome.org/show_bug.cgi?id=419737#c59 - The file
chooser clears the filename entry in SAVE/CREATE_FOLDER modes when
it shouldn't.
* gtk/gtkfilechooserdefault.c (shortcuts_activate_iter): Don't
clear the entry for CREATE_FOLDER either; this needs the same
behavior as SAVE mode.
(update_chooser_entry): Only clear the entry in OPEN/SELECT_FOLDER
modes.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
svn path=/trunk/; revision=20455
Michael Natterer [Wed, 18 Jun 2008 15:42:27 +0000 (15:42 +0000)]
set the maximum of the "year" property to G_MAXINT >> 8 instead of
2008-06-18 Michael Natterer <mitch@imendio.com>
* gtk/gtkcalendar.c: set the maximum of the "year" property to
G_MAXINT >> 8 instead of G_MAXINT to fix overflows in internal
calculations which in turn caused writing beyond the boundaries of
the calendar->day_month[] and day[] arrays which in turn caused a
SEGV. This limits the lifetime of GTK+ to the year 8,388,608 ;)
* gtk/gtksettings.c (gtk_settings_install_property)
(gtk_settings_install_property_parser): get rid of using
gtk_type_class() by keeping a static reference to GtkSettingsClass
around in both functions and passing that pointer on to
settings_install_property_parser().
* tests/testgtk.c: use g_type_class_ref()/unref() instead of
gtk_type_class().
* gtk/gtkobject.c: #undef GTK_DISABLE_DEPRECATED around including
gtktypeutils.h.
Tor Lillqvist [Tue, 17 Jun 2008 19:29:22 +0000 (19:29 +0000)]
Need to do the GTK_DISABLE_DEPRECATED #undef/#define dance here, too,
2008-06-17 Tor Lillqvist <tml@novell.com>
* gtk/gtknotebook.c: Need to do the GTK_DISABLE_DEPRECATED
#undef/#define dance here, too, because
gtk_notebook_set_group_id() is deprecated but used here before it
is defined, and gcc complains about conflicting type from the
implicit int declaration when it sees the actual void definition.
Michael Natterer [Tue, 17 Jun 2008 16:03:46 +0000 (16:03 +0000)]
build with GTK_DISABLE_DEPRECATED.
2008-06-17 Michael Natterer <mitch@imendio.com>
* gtk/Makefile.am: build with GTK_DISABLE_DEPRECATED.
* gtk/gtkclist.c
* gtk/gtkcombo.c
* gtk/gtkctree.c
* gtk/gtklist.c
* gtk/gtklistitem.c
* gtk/gtkoldeditable.c
* gtk/gtkpixmap.c
* gtk/gtktext.c
* gtk/gtktipsquery.c
* gtk/gtktree.c
* gtk/gtktreeitem.c: whenever we #undef GTK_DISABLE_DEPRECATED and
actually use deprecated symbols (not just types or macros),
#define it again before #include "gtkalias.h" so the symbols match
and the beast links.
* modules/input/gtkimcontextmultipress.h
* modules/input/gtkimcontextthai.h
* modules/input/gtkimcontextxim.h: use G_TYPE instead of GTK_CHECK
type checking macros.
* gtk/gtktypeutils.h: deprecate GTK_CHECK_CAST, GTK_CHECK_CLASS_CAST,
GTK_CHECK_GET_CLASS, GTK_CHECK_TYPE and GTK_CHECK_CLASS_TYPE.
Move the GtkType typedef to an undeprecated section.
Michael Natterer [Tue, 17 Jun 2008 14:14:06 +0000 (14:14 +0000)]
use G_TYPE macros for type checking instead of GTK_CHECK ones because it's
2008-06-17 Michael Natterer <mitch@imendio.com>
* gtk/gtkprogress.h: use G_TYPE macros for type checking instead
of GTK_CHECK ones because it's the parent class of an undeprecated
class and the GTK_CHECK stuff will soon be deprecated.
* gtk/gtkfilesel.c
* gtk/gtkinputdialog.c
* gtk/gtkmenutoolbutton.c
* gtk/gtkoptionmenu.c
* gtk/gtktoolitem.c
* gtk/gtktooltips.c: add or move around
#undef GTK_DISABLE_DEPRECATED so it's possible to build without
deprecated stuff again (with the minor glitch that it doesn't
link ;) but at least it's a tool to keep the code clean).
Emmanuele Bassi [Tue, 17 Jun 2008 13:42:53 +0000 (13:42 +0000)]
Increase the consistency of the errors returned by GtkRecentManager.
2008-06-17 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkrecentmanager.c:
(gtk_recent_manager_remove_item),
(gtk_recent_manager_move_item): Increase the consistency of the
errors returned by GtkRecentManager. (Paolo Borelli)
Michael Natterer [Tue, 17 Jun 2008 12:54:16 +0000 (12:54 +0000)]
remove static integer variables which hold the number of members in
2008-06-17 Michael Natterer <mitch@imendio.com>
* gtk/gtkfilechooserdefault.c: remove static integer variables
which hold the number of members in GtkTargetEntry arrays and use
G_N_ELEMENTS() directly instead.
Emmanuele Bassi [Tue, 17 Jun 2008 12:46:12 +0000 (12:46 +0000)]
Remove the GtkRecentManager screen dance, as it has been deprecated since
2008-06-17 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkfilechooserdefault.c:
(gtk_file_chooser_default_init),
(gtk_file_chooser_default_constructor),
(gtk_file_chooser_default_screen_changed),
(recent_start_loading): Remove the GtkRecentManager screen
dance, as it has been deprecated since 2.12. Now we get the
GtkRecentManager singleton whewn we create the FileChooserDefault
instance. (Michael Natterer)
Michael Natterer [Mon, 16 Jun 2008 20:02:33 +0000 (20:02 +0000)]
use gtk_binding_entry_clear() instead of gtk_binding_entry_add() (the
2008-06-16 Michael Natterer <mitch@imendio.com>
* gtk/gtkbindings.c (_gtk_binding_entry_add_signall): use
gtk_binding_entry_clear() instead of gtk_binding_entry_add()
(the former is deprecated and #defined to gtk_binding_entry_clear)
Tor Lillqvist [Mon, 16 Jun 2008 13:27:46 +0000 (13:27 +0000)]
Bug 538362 - Get Win32 icons back in the file chooser
2008-06-16 Tor Lillqvist <tml@novell.com>
Bug 538362 - Get Win32 icons back in the file chooser
* gtk/gtkicontheme.c (choose_icon): Check if the icon name is a
reference to an icon resource in a DLL or .EXE as in the
Registry. In that case, extract the icon and convert to a
GdkPixbuf. Patch by Hans Breuer.
Carlos Garnacho [Sun, 15 Jun 2008 23:32:11 +0000 (23:32 +0000)]
Return full path here as expected, not just the basename.
2008-06-15 Carlos Garnacho <carlos@imendio.com>
* gtk/gtkfilechooser.c (gtk_file_chooser_get_filename): Return full
path here as expected, not just the basename.
* gtk/gtkfilechooserdefault.c
(gtk_file_chooser_default_update_current_folder): Ensure that we keep
a reference to file, since it can be destroyed when switching back to
browse mode.
* gtk/gtkfilesystem.c (get_icon_for_special_directory): Removed, home
and desktop directories are dealt by the filechooser as normal files,
not volumes, so the icon for these is handled directly by GIO.
(_gtk_file_system_volume_render_icon): Update caller.
Initialize hwnd to NULL. This fixes OpenClipboard() failure and,
according to MSDN docs, associates the open clipboard with the
current task. (#378158, reported by Andreas Köhler)
Michael Natterer [Fri, 13 Jun 2008 10:44:34 +0000 (10:44 +0000)]
silently skip unknown attributes instead of bailing out with an error in
2008-06-13 Michael Natterer <mitch@imendio.com>
* gtk/gtkuimanager.c (start_element_handler): silently skip
unknown attributes instead of bailing out with an error in order
to be compatible with possible future attribute names.
This is related to the discussion in bug #516425 but actually
needed for any kind of XML format extension.
Michael Natterer [Thu, 12 Jun 2008 11:17:16 +0000 (11:17 +0000)]
limit the number of displayed items by the actual screen height instead of
2008-06-12 Michael Natterer <mitch@imendio.com>
* gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup):
limit the number of displayed items by the actual screen height
instead of some arbitrary value (Bug #408154, Xan Lopez and
Christian Dywan).
Matthias Clasen [Wed, 11 Jun 2008 03:17:55 +0000 (03:17 +0000)]
Add standard icon names, and also fall back to builtin gtk stock icons.
* gtk/gtkfilesystem.c (get_icon_for_special_directory):
(gtk_file_system_volume_render_icon): Add standard icon names,
and also fall back to builtin gtk stock icons.