]>
Pileus Git - ~andy/gtk/log
Matthias Clasen [Wed, 29 Jun 2011 21:31:09 +0000 (17:31 -0400)]
Convert GailComboBox to GtkComboBoxAccessible
Benjamin Otte [Wed, 29 Jun 2011 16:16:23 +0000 (18:16 +0200)]
tests: Don't print selection count
Selection count is tested via assertions and can be inferred from
looking at the number of selected children.
And I'd like to reduce the output of the tests. We're outputting way too
much anyway.
Benjamin Otte [Wed, 29 Jun 2011 16:11:07 +0000 (18:11 +0200)]
tests: Make accessibility-dump output selected children by name
And put one child in every row to make diffing easier.
Benjamin Otte [Wed, 29 Jun 2011 16:00:37 +0000 (18:00 +0200)]
tests: Fix compiler warnings
Benjamin Otte [Wed, 29 Jun 2011 15:34:50 +0000 (17:34 +0200)]
tests: Add assert to accessibility-dump
Check that number of selected children == number of children that
actually are selected. If that's not the case, assert, to avoid people
being careless about adding tests.
Matthias Clasen [Wed, 29 Jun 2011 15:52:12 +0000 (11:52 -0400)]
Silence compiler warnings
Benjamin Otte [Wed, 29 Jun 2011 00:15:18 +0000 (02:15 +0200)]
a11y: Make notebookpage emit child-added signal sync
Don't use an idle handler
Benjamin Otte [Wed, 29 Jun 2011 14:17:07 +0000 (16:17 +0200)]
a11y: Keep the gail notebook in the notebook page
We used to keep the GtkNotebook, but that causes issues at creation time
of the GailNotebook, when the GtkNotebook does not yet have an
accessible set and so it can't be queried.
Benjamin Otte [Wed, 29 Jun 2011 13:23:06 +0000 (15:23 +0200)]
a11y: Redo notebook page management
Previously, the code tried to track the indexes of the pages and keep
them up to date in a list and tracking the index in the
GtkNotebookPage. Now, we store the widget we are tracking in the
GailNotebookPage and keep a hash table of widget=>GailNotebookPage in the
GailNotebook. This frees us from the burden of tracking page changes.
Benjamin Otte [Wed, 29 Jun 2011 12:42:16 +0000 (14:42 +0200)]
a11y: Redo notebok page lifetime management
It is now done by the GailNotebook. Previously it tried to do it itself.
Also, we now use GtkNotebook::page-removed to track the removal, as
opposed to child::parent-set.
Benjamin Otte [Wed, 29 Jun 2011 00:10:28 +0000 (02:10 +0200)]
a11y: Remove idle handler from menuitem action
Benjamin Otte [Tue, 28 Jun 2011 18:03:35 +0000 (20:03 +0200)]
a11y: Remove idle handler for expander actions
Benjamin Otte [Tue, 28 Jun 2011 18:02:06 +0000 (20:02 +0200)]
a11y: Remove idle handler for combo box action
Benjamin Otte [Tue, 28 Jun 2011 17:26:10 +0000 (19:26 +0200)]
a11y: Remove idle handler from GailButton
Benjamin Otte [Tue, 28 Jun 2011 17:21:19 +0000 (19:21 +0200)]
a11y: Use gtk_button_clicked() to click a button.
Don't fiddle with events.
Benjamin Otte [Tue, 28 Jun 2011 17:13:43 +0000 (19:13 +0200)]
a11y: Remove "press" and "release" actions from buttons
http://mail.gnome.org/archives/gnome-accessibility-devel/2011-June/msg00020.html
has some details about this.
The main problem is that the internal button states get fiddled with and
that is not a good idea to do from an AT.
Also update tests to reflect that.
Benjamin Otte [Tue, 28 Jun 2011 16:34:50 +0000 (18:34 +0200)]
a11y: Do actions on cells immediately
No idle handlers, please.
Benjamin Otte [Tue, 28 Jun 2011 16:31:32 +0000 (18:31 +0200)]
a11y: Use simple code for window name change tracking
Remove idle handler and omit checking if the name really was changed.
ATs will either have to live with the name not really changoing or we
should check in GtkWindow.
Matthias Clasen [Wed, 29 Jun 2011 04:35:24 +0000 (00:35 -0400)]
Add more child-handling related tests
Matthias Clasen [Wed, 29 Jun 2011 03:58:31 +0000 (23:58 -0400)]
Emit the same changed_children details as everybody else
...if any of this was documented...
Matthias Clasen [Wed, 29 Jun 2011 03:42:50 +0000 (23:42 -0400)]
Drop gail-private-macros.h
Nothing like obfuscating an early return behind a macro.
Matthias Clasen [Wed, 29 Jun 2011 03:24:27 +0000 (23:24 -0400)]
Add a test for scrolled window child count
Matthias Clasen [Wed, 29 Jun 2011 03:13:27 +0000 (23:13 -0400)]
Convert GailScrolledWindow to GtkScrolledWindowAccessible
Matthias Clasen [Wed, 29 Jun 2011 02:48:37 +0000 (22:48 -0400)]
Drop use of gail_return_if_fail
Matthias Clasen [Wed, 29 Jun 2011 02:47:21 +0000 (22:47 -0400)]
Fix a test crash
Matthias Clasen [Wed, 29 Jun 2011 02:46:40 +0000 (22:46 -0400)]
Remove old files
Matthias Clasen [Wed, 29 Jun 2011 02:45:42 +0000 (22:45 -0400)]
Convert GailScaleButton to GtkScaleButtonAccessible
Matthias Clasen [Tue, 28 Jun 2011 05:00:00 +0000 (01:00 -0400)]
Drop another unused include
Matthias Clasen [Tue, 28 Jun 2011 04:53:22 +0000 (00:53 -0400)]
Convert GailToggleButton to GtkToggleButtonAccessible
Matthias Clasen [Tue, 28 Jun 2011 04:39:27 +0000 (00:39 -0400)]
Nuke GailAdjustment
This was a fairly trivial wrapper around GtkAdjustment with
no particularly important reason for existence.
Matthias Clasen [Tue, 28 Jun 2011 04:38:20 +0000 (00:38 -0400)]
GtkAdjustment: add an auxiliary function
This is going to be used in AtkValue implementations.
Matthias Clasen [Tue, 28 Jun 2011 03:26:23 +0000 (23:26 -0400)]
Drop an unneeded include
Matthias Clasen [Tue, 28 Jun 2011 03:24:22 +0000 (23:24 -0400)]
Convert GailRadioButton to GtkRadioButtonAccessible
Matthias Clasen [Tue, 28 Jun 2011 03:00:59 +0000 (23:00 -0400)]
GtkLabelAccessible: drop an unneeded include
We eventually want to get rid of gailmisc, so this is progress.
Matthias Clasen [Tue, 28 Jun 2011 02:55:54 +0000 (22:55 -0400)]
Convert GailPaned to GtkPanedAccessible
Matthias Clasen [Tue, 28 Jun 2011 02:39:43 +0000 (22:39 -0400)]
Convert GailRange to GtkRangeAccessible
Matthias Clasen [Mon, 27 Jun 2011 04:52:43 +0000 (00:52 -0400)]
GtkTextViewAccessible: get rid of GailTextUtil usage
Instead, use the newly added GtkTextBuffer functions.
Matthias Clasen [Mon, 27 Jun 2011 04:51:03 +0000 (00:51 -0400)]
GtkTextBuffer: Add accessible api
These functions match closely to the AtkText interface;
they will be used in the GtkTextView accessible implementation.
Keep them private for now.
Matthias Clasen [Mon, 27 Jun 2011 03:48:54 +0000 (23:48 -0400)]
Convert GailLinkButton to GtkLinkButtonAccessible
Matthias Clasen [Mon, 27 Jun 2011 03:16:26 +0000 (23:16 -0400)]
Convert GailImage to GtkImageAccessible
Matthias Clasen [Mon, 27 Jun 2011 03:00:20 +0000 (23:00 -0400)]
Convert GailProgressBar to GtkProgressBarAccessible
Matthias Clasen [Mon, 27 Jun 2011 02:32:34 +0000 (22:32 -0400)]
Convert GailScrollbar to GtkScrollbarAccessible
Matthias Clasen [Mon, 27 Jun 2011 02:14:28 +0000 (22:14 -0400)]
Update test results for recent changes
Matthias Clasen [Mon, 27 Jun 2011 02:13:15 +0000 (22:13 -0400)]
Convert GailFrame to GtkFrameAccessible
Matthias Clasen [Mon, 27 Jun 2011 01:52:35 +0000 (21:52 -0400)]
Remove GailBox
It was only setting a role, and we can do that just as well
in get_accessible().
Matthias Clasen [Mon, 27 Jun 2011 01:44:42 +0000 (21:44 -0400)]
Remove GailCalendar
This was just setting a role, which we can do just as well
in get_accessible().
Matthias Clasen [Mon, 27 Jun 2011 01:39:28 +0000 (21:39 -0400)]
Adapt to expected output to recent changes
Matthias Clasen [Mon, 27 Jun 2011 01:36:11 +0000 (21:36 -0400)]
Drop GailSeparator
Instead, just set a suitable role on a GtkWidgetAccessible.
Matthias Clasen [Mon, 27 Jun 2011 01:28:37 +0000 (21:28 -0400)]
Convert GailArrow to GtkArrowAccessible
Matthias Clasen [Mon, 27 Jun 2011 01:14:08 +0000 (21:14 -0400)]
Convert GailScale to GtkScaleAccessible
Benjamin Otte [Mon, 27 Jun 2011 01:00:26 +0000 (03:00 +0200)]
tests: Update range tests for slider value in description
Benjamin Otte [Mon, 27 Jun 2011 00:59:19 +0000 (02:59 +0200)]
stylecontext: #include <math.h> when using math functions
Benjamin Otte [Mon, 27 Jun 2011 00:58:57 +0000 (02:58 +0200)]
a11y: Make it compile again
Overriding CFLAGS is a bad idea. Use INCLUDES instead.
Benjamin Otte [Mon, 27 Jun 2011 00:58:47 +0000 (02:58 +0200)]
a11y: Update tests after removing AtkText from GailExpander
Benjamin Otte [Mon, 27 Jun 2011 00:57:35 +0000 (02:57 +0200)]
a11y: Update tests after removing AtkText from GailRange
Matthias Clasen [Mon, 27 Jun 2011 00:46:26 +0000 (20:46 -0400)]
GtkTextviewAccessible: some initial cleanup and code rearrangement
Matthias Clasen [Mon, 27 Jun 2011 00:42:54 +0000 (20:42 -0400)]
GtkEntryAccessible: Slight simplification of attribute handling
Make this use the same convenience function as is used elsewhwere.
Matthias Clasen [Sun, 26 Jun 2011 04:38:20 +0000 (00:38 -0400)]
GtkLabelAccessible: avoid some pointless variables
Matthias Clasen [Sun, 26 Jun 2011 03:08:26 +0000 (23:08 -0400)]
Initial move GailTextView -> GtkTextViewAccessible
This just does the renaming, and drops the factory.
Benjamin Otte [Sun, 26 Jun 2011 21:07:11 +0000 (23:07 +0200)]
tests: Add an a11y test for scales
Benjamin Otte [Sun, 26 Jun 2011 21:00:49 +0000 (23:00 +0200)]
gail: Remove AtkText implementation from GailScale
AtkText should only be implemented by text editing widgets. For just
giving out a small text string, AtkObject::name should be used.
Benjamin Otte [Sun, 26 Jun 2011 20:52:14 +0000 (22:52 +0200)]
cellareacontext: Don't ever return -1 for preferred sized
People don't check for -1 when computing size requests. Document this
new behavior.
Benjamin Otte [Sat, 25 Jun 2011 17:49:37 +0000 (19:49 +0200)]
Revert 'Insert an LRM, to prevent -20 to come out as 20- in RTL'
Correct text direction for printing of doubles should be (and is) done
by printf() and friend and not enforced by GtkScale.
This reverts commit
5eb2aac9474e1e8d035af1cbb4bc6756539af335
https://bugzilla.gnome.org/show_bug.cgi?id=322571
Benjamin Otte [Sat, 25 Jun 2011 17:47:46 +0000 (19:47 +0200)]
a11y: Export the printed value of a scale as the description.
Benjamin Otte [Fri, 24 Jun 2011 21:17:28 +0000 (23:17 +0200)]
a11y: Remove AtkText implementation from GailMenuitem
AtkText should only be implemented by text editing widgets. For just
giving out a small text string, AtkObject::name should be used.
Benjamin Otte [Fri, 24 Jun 2011 21:03:15 +0000 (23:03 +0200)]
a11y: Remove AtkText implementation from GailExpander
AtkText should only be implemented by text editing widgets. For just
giving out a small text string, AtkObject::name should be used.
Matthias Clasen [Sun, 26 Jun 2011 02:44:46 +0000 (22:44 -0400)]
Add some texts for text selection signals
Test that we do emit ::text_caret_moved and ::text_selection_changed
as expected.
Matthias Clasen [Sun, 26 Jun 2011 02:44:07 +0000 (22:44 -0400)]
Minor optimization
No need to get the cursor position twice in a row.
Matthias Clasen [Sun, 26 Jun 2011 02:43:02 +0000 (22:43 -0400)]
GtkLabelAccessible: some selection handling fixes
Don't move the cursor to 0 when removing the selection,
and don't overlook growing selections.
Matthias Clasen [Sun, 26 Jun 2011 02:42:17 +0000 (22:42 -0400)]
GtkLabel: optimize away some ::notify emissions
Matthias Clasen [Sun, 26 Jun 2011 02:03:12 +0000 (22:03 -0400)]
Skip line-related tests for GtkEntry
GtkEntry sets single-paragraph mode on its pango layout,
so the results for line-related navigation don't match.
Matthias Clasen [Sun, 26 Jun 2011 01:53:00 +0000 (21:53 -0400)]
GtkEntryAccessible: shorten some function names
Just cosmetics
Matthias Clasen [Sun, 26 Jun 2011 01:35:10 +0000 (21:35 -0400)]
Remove a bit of dead code
Matthias Clasen [Sun, 26 Jun 2011 01:26:51 +0000 (21:26 -0400)]
GtkEntryAccessible: Clean up the AtkAction implementation a bit
No functional changes.
Matthias Clasen [Sun, 26 Jun 2011 01:05:12 +0000 (21:05 -0400)]
Purge traces of insert idle handler
Matthias Clasen [Sun, 26 Jun 2011 01:00:02 +0000 (21:00 -0400)]
GtkEntryAccessible: Rework text_changed handling
No more signal emission from an idle.
Matthias Clasen [Sat, 25 Jun 2011 22:49:54 +0000 (18:49 -0400)]
Fix up signal ordering issues in GtkEntry
Ensure that text and selection boundaries are in a
consistent state when we emit notifications, that ::insert-text
and ::delete-text are emitted before any changes, and that
::changed is emitted after property notifications when inserting
or deleting text.
Matthias Clasen [Sat, 25 Jun 2011 22:47:51 +0000 (18:47 -0400)]
Add a test for entry signals
These tests check that text and selection boundaries are in a
consistent state when we emit notifications, that ::insert-text
and ::delete-text are emitted before any changes, and that
::changed is emitted after property notifications when inserting
or deleting text.
Matthias Clasen [Sat, 25 Jun 2011 18:43:59 +0000 (14:43 -0400)]
GtkEntryAccessible: port from GailTextUtil to GtkPango
Also clean up and rearrange the code.
As a side-effect, the no-longer-existing stipple attributes
are dropped. Update test results to match.
Matthias Clasen [Sat, 25 Jun 2011 17:57:55 +0000 (13:57 -0400)]
Allow use of private api in a11y/
Matthias Clasen [Sat, 25 Jun 2011 17:57:42 +0000 (13:57 -0400)]
Trivial whitespace fix
Matthias Clasen [Sat, 25 Jun 2011 02:28:54 +0000 (22:28 -0400)]
GtkSpinButtonAccessible: Coding style cleanups
And some code rearrangement.
Matthias Clasen [Sat, 25 Jun 2011 02:12:55 +0000 (22:12 -0400)]
First cut at GailEntry -> GtkEntryAccessible
Replace the factory for entry and spin button with
gtk_widget_class_set_accessible_type() calls, and move then
to the GtkAccessible namespace.
Matthias Clasen [Sat, 25 Jun 2011 01:18:07 +0000 (21:18 -0400)]
Avoid warnings in clipboard code
The a11y selection tests poke the selection on unrealized
labels. Don't spew warnings in this case.
Matthias Clasen [Sat, 25 Jun 2011 01:17:55 +0000 (21:17 -0400)]
Add some tests for selection handling
Matthias Clasen [Sat, 25 Jun 2011 00:57:22 +0000 (20:57 -0400)]
Add some more basic tests
Matthias Clasen [Sat, 25 Jun 2011 00:47:59 +0000 (20:47 -0400)]
Remove debug spew
Matthias Clasen [Sat, 25 Jun 2011 00:42:16 +0000 (20:42 -0400)]
Expand the insert/delete text
GtkLabel passes this now.
Matthias Clasen [Sat, 25 Jun 2011 00:37:42 +0000 (20:37 -0400)]
Update test results
The label accessible port dropped the no-longer-existing
stipple attributes; so update the expected test results to match.
Matthias Clasen [Sat, 25 Jun 2011 00:36:05 +0000 (20:36 -0400)]
Port GtkLabelAccessible from GailTextUtil to GtkPango api
Unfortunately, we still keep a copy of the text around, for
::insert/::delete signals; those emissions need to be moved to
GtkLabel itself.
Matthias Clasen [Sat, 25 Jun 2011 00:26:42 +0000 (20:26 -0400)]
GtkStyleContext: add some aux. a11y api
This function translates the fg/bg color into atk attributes.
Matthias Clasen [Sat, 25 Jun 2011 00:22:55 +0000 (20:22 -0400)]
Add some aux. pango api to help AtkText implementations
These functions are implementations of the AtkText api on top
of a PangoLayout, and are intended to replace GailTextUtil.
Since gtkpango.h is a private header, also remove the individual
inclusion prohibition.
Matthias Clasen [Sat, 25 Jun 2011 00:16:05 +0000 (20:16 -0400)]
Replace the boundary test
The new test is much smaller, and the results have been carefully
looked at; GtkLabel gets it right, the others don't.
Also, temporarily include some code that dumps out useful information.
Matthias Clasen [Fri, 24 Jun 2011 05:01:50 +0000 (01:01 -0400)]
Sort text attributes alphabetically in dumps
Matthias Clasen [Fri, 24 Jun 2011 03:30:57 +0000 (23:30 -0400)]
GtkLabel: factor out two getters
Make the get_property switch look a little nicer.
We export these functions privately for use in the label
accessible implementation later on.
Benjamin Otte [Fri, 24 Jun 2011 03:01:03 +0000 (05:01 +0200)]
messagedialog: Initialize style values in init()
Fixes underallocation warnings
Benjamin Otte [Thu, 23 Jun 2011 21:45:36 +0000 (23:45 +0200)]
a11y: Remove setters for column description/header
Benjamin Otte [Thu, 23 Jun 2011 18:58:51 +0000 (20:58 +0200)]
a11y: Make treeview header and caption no longer settable
It's not exposed in AT-SPI so we don't need it.
Benjamin Otte [Thu, 23 Jun 2011 15:57:26 +0000 (17:57 +0200)]
a11y: Remove setters for row description/header
AT-SPI doesn't expose them, so there's no need to keep them.
Matthias Clasen [Thu, 23 Jun 2011 22:41:47 +0000 (18:41 -0400)]
GtkHSV: set a suitable role for the accessible
The consensus of the accessibility team was that 'color chooser'
fits best for this. Update tests to match.