Tor Lillqvist [Sun, 25 Aug 2002 19:27:24 +0000 (19:27 +0000)]
Compile gtk_init_abi_check and gtk_init_check_abi_check when on
2002-08-25 Tor Lillqvist <tml@iki.fi>
* gtk/gtkmain.c: Compile gtk_init_abi_check and
gtk_init_check_abi_check when on G_PLATFORM_WIN32, not just on
G_OS_WIN32, to match gtkmain.h (#91649, Masahiro Sakai).
(check_sizeof_GtkWIndow, check_sizeof_GtkBox): Mention the
-mms-bitfields swicth in addition to -fnative-struct.
Tor Lillqvist [Sat, 24 Aug 2002 23:06:16 +0000 (23:06 +0000)]
Include gtkbox.h and gtkwindow.h on Win32, as the defines for struct
2002-08-25 Tor Lillqvist <tml@iki.fi>
* gtk/gtkmain.h: Include gtkbox.h and gtkwindow.h on Win32, as the
defines for struct packing checks use sizeof() on stuff from
these. (#84211, Andreas Holzmann)
Tor Lillqvist [Sat, 24 Aug 2002 22:03:46 +0000 (22:03 +0000)]
gdk/gdkevents.c gdk/gdkinternals.h gdk/x11/gdkevents-x11.c Move the
2002-08-25 Tor Lillqvist <tml@iki.fi>
* gdk/gdkevents.c
* gdk/gdkinternals.h
* gdk/x11/gdkevents-x11.c
* gdk/win32/gdkevents-win32.c: Move the GdkEventPrivate and
GdkEventFlags definitions from gdkevents.c to
gdkinternals.h. Remove the duplicated definitions in
gdkevents-x11.c and gdkevents-win32.c. (#89771)
Matthias Clasen [Thu, 22 Aug 2002 21:32:06 +0000 (21:32 +0000)]
gdk-pixbuf-io.c (_gdk_pixbuf_generic_image_load): No longer static, thus
* gdk-pixbuf-io.h:
gdk-pixbuf-io.c (_gdk_pixbuf_generic_image_load): No longer
static, thus _gdk_pixbuf-prefixed.
* gdk-pixbuf-animation.c (gdk_pixbuf_animation_new_from_file):
Keep this logic in sync with gdk_pixbuf_new_from_file(). (Based
on a patch by Anders Carlsson)
* io-png.c (gdk_pixbuf__png_image_save): Plug a memory
leak. (#91422, Sven Neumann)
Tor Lillqvist [Wed, 21 Aug 2002 18:50:15 +0000 (18:50 +0000)]
Move GDK_DEP_LIBS from LDFLAGS to each of the libgdk_*_LIBADD, to fix
2002-08-21 Tor Lillqvist <tml@iki.fi>
* gdk/Makefile.am: Move GDK_DEP_LIBS from LDFLAGS to each of the
libgdk_*_LIBADD, to fix problems when cross-compiling, as
suggested by J. Ali Harlow in #87103.
Padraig O'Briain [Mon, 19 Aug 2002 14:39:44 +0000 (14:39 +0000)]
Use gtk_entry_set_positions() to update current_pos and selection_bound so
* gtk/gtkentry.c (gtk_entry_real_delete_text): Use
gtk_entry_set_positions() to update current_pos and selection_bound
so notifications are emitted (#90548)
Hidetoshi Tajima [Wed, 14 Aug 2002 15:11:41 +0000 (15:11 +0000)]
initialize gtk_selection_atoms only once at the 1st call. set length of
* gtk/gtkselection.c (gtk_selection_init): initialize
gtk_selection_atoms only once at the 1st call.
* gdk/x11/gdkselection-x11.c (gdk_selection_property_get):
set length of selection data from number of read bytes (#90595)
Matthias Clasen [Mon, 12 Aug 2002 21:34:45 +0000 (21:34 +0000)]
Remove gdk_screen_close, add a section for GdkDisplayManager, add
* gdk/gdk-sections.txt: Remove gdk_screen_close, add a section
for GdkDisplayManager, add gdk_visual_get_screen and
gdk_colormap_get_screen.
* gdk/gdkdisplaymanager.c:
* gdk/gdkdisplay.c (gdk_pointer_ungrab): Fix doc comments.
* gdk/x11/gdkcolor-x11.c (gdk_colormap_get_screen):
* gdk/x11/gdkimage-x11.c (gdk_image_new_bitmap): Make parameter
names match those in the header file, to silence gtk-doc.
(#89254, patch from Brett Nash;
#85809, patch from daten@dnetc.org;
#76391, patch from Ross Burton;
#74559, Manuel Clos;
#73569, #72005, Alexey A. Malyshev;
#70061, patch from Dennis Bj"orklund;
#64566, #63388, #58328, #57499, #81007, #77349, Vitaly Tishkov;
#78932, Vitaly Tishkov, patch from Ross Burton;
#73306)
Owen Taylor [Fri, 9 Aug 2002 03:57:02 +0000 (03:57 +0000)]
Remove explicit calls to pango_x/xft_shutdown_display() since Pango now
Thu Aug 8 23:26:05 2002 Owen Taylor <otaylor@redhat.com>
* gdk/x11/gdkmain-x11.c gdk/x11/gdkscreen-x11.c: Remove
explicit calls to pango_x/xft_shutdown_display() since
Pango now does it by itself on XCloseDisplay().
Owen Taylor [Mon, 5 Aug 2002 21:22:22 +0000 (21:22 +0000)]
Patch from Soeren Sandmann to improve GtkLabel behavior when it gets a too
Mon Aug 5 17:20:45 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtklabel.c: Patch from Soeren Sandmann
to improve GtkLabel behavior when it gets
a too small allocation. (Always display the
initial portion.) (#71742)
Owen Taylor [Mon, 5 Aug 2002 21:10:09 +0000 (21:10 +0000)]
When overriding LDFLAGS, include @LDFLAGS@, otherwise LDFLAGS the users
Mon Aug 5 17:01:30 2002 Owen Taylor <otaylor@redhat.com>
* gdk/Makefile.am (LDFLAGS): When overriding LDFLAGS,
include @LDFLAGS@, otherwise LDFLAGS the users passes
to configure don't get used. (#89946, Noah Levitt,
Albert Chin)
Owen Taylor [Mon, 5 Aug 2002 19:28:56 +0000 (19:28 +0000)]
Fix problem with wrong depth being used. (#89941, Jacob Berkman.) Remove
Mon Aug 5 15:25:40 2002 Owen Taylor <otaylor@redhat.com>
* gdk/gdkpixbuf-render.c (gdk_pixbuf_render_pixmap_and_mask_for_colormap):
Fix problem with wrong depth being used. (#89941, Jacob
Berkman.) Remove an unneeded 'screen' variable.
Mon Aug 5 15:04:59 2002 Owen Taylor <otaylor@redhat.com>
More fixes for warnings reported by David L. Cooper II
* gtk/gtkaccelmap.c (accel_map_parse_accel_path): Use
GdkModifierType for accel_mods. (#85856)
* gdk/gdkdisplay.h (struct _GdkDisplay): Make button_number
signed, since we use -1 as an 'unset' value. (#85854)
* gdk/x11/xsettings-client.c (parse_settings): Suppress
a warning (#85853)
Owen Taylor [Mon, 5 Aug 2002 18:52:28 +0000 (18:52 +0000)]
Add a note that yes, we do know what () means and we can't change it.
Mon Aug 5 14:50:13 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkitemfactory.h: Add a note that yes, we do know
what () means and we can't change it.
Fixes for warnings reported by David L. Cooper II
* tests/testtext.c: Warning fixes. Fix order of arguments
to gtk_message_dialog_new(). (#85891)
* gtk/gtktreeitem.c (gtk_tree_item_paint): Fix incorrect
use GTK_STATE_INSENSITIVE for a shadow type. (Not clear
what the drawing intent was, but it's ENABLE_BROKEN
anyways.) (#85880)
* gtk/gtktexttypes.c: Use character literals
instead of direct constants to avoid warning. (#85878)
* gtk/theme-bits/decompose-bits.c gtk/gtkstyle.c:
Fix some signed/unsigned problems (#85876)
* gtk/gtksignal.c (gtk_signal_newv): Add an explicit
cast from GtkSignalRunType to GSignalFlags. (#85875)
* gtk/gtkitemfactory.c (gtk_item_factory_add_item): Fix
use of guint instead of GdkModifierType (#85871)
* gtk/gtkimmulticontext.c (gtk_im_multicontext_append_menuitems):
Fix signed/unsigned problem (#85870)
* gtk/gtkimcontext.c (gtk_im_context_class_init): Get
rid of GtkType/Signal*. (Fixes #85869 as a side effect)
* gtk/gtkdnd.c (gtk_drag_get_cursor): Fix some
signed/unsigned warnings (#85865)
Owen Taylor [Fri, 2 Aug 2002 04:57:53 +0000 (04:57 +0000)]
Switch back to using XftDraw so that we take advantage of the
Fri Aug 2 00:43:15 2002 Owen Taylor <otaylor@redhat.com>
* gdk/x11/gdkdrawable-x11.[ch] gdk/x11/gdkgc-x11.c
gdk/x11/gdkpango-x11.c gdk/x11/gdkpixmap-x11.c
gdk/x11/gdkprivate-x11.h gdk/x11/gdkwindow-x11.c:
Switch back to using XftDraw so that we take
advantage of the draw-to-non-RENDER capabilities
of Xft2.
* demos/gtk-demo/changedisplay.c (query_for_toplevel):
Fix the case where the user clicks on the "click on
a window popup".
* gdk/gdkdisplay.c (gdk_display_dispose): Free the
event queue.
* gdk/x11/gdkevents-x11.c gdk/x11/gdkdisplay-x11.c:
Remove the event source when closing a display.
* gdk/gdkdisplay.[ch]: Add a ::closed signal, dispose()
isn't convenient enough by itself.
* gdk/x11/gdkevents-x11.c (gdk_xsettings_watch_cb):
Create foreign windows for watch windows if there isn't
an existing window, instead of installing a global filter.
* gdk/x11/gdkscreen-x11.c gdk/x11/gdkprivate-x11.h
gdk/x11/gdkevents-x11.c (_gdk_x11_events_uninit_screen):
Clean up the xsettings_client when we are done with
it.
* gdk/x11/gdkevents-x11.c (_gdk_events_init): Remove
excess call to _gdk_x11_events_init_screen()
Owen Taylor [Thu, 1 Aug 2002 15:28:40 +0000 (15:28 +0000)]
Start implementing display/screen closing scheme; keep a flag for whether
Thu Aug 1 11:26:03 2002 Owen Taylor <otaylor@redhat.com>
* gdk/gdkdisplay.[ch] gdk/gdkscreen.[ch] gdkinternals.h:
Start implementing display/screen closing scheme; keep a
flag for whether displays and screens are closed,
call g_object_run_dispose(). Remove public gdk_screen_close().
* gdk/x11/gdkdisplay-x11.c gdk/x11/gdkscreen-x11.c: Add
dispose() methods; move appropriate parts of the finalize
there.
* gdk/x11/gdkcolor-x11.c gdk/x11/gdkimage-x11.c
gdk/x11/gdkmain-x11.c gdk/x11/gdkpango-x11.c
gdk/x11/gdkpixmap-x11.c gdk/x11/gdkproperty-x11.c
gdk/x11/gdkselection-x11.c gdk/x11/gdkwindow-x11.c:
Start of making everything correctly ignore operations
when a display has been closed.
* gdk/x11/gdkselection-x11.c (gdk_selection_property_get):
Handle failure better, handle data == NULL, move docs
here, remove an excess round trip by asking for
all selection data at once.
* gdk/gdkselection.c gdk/win32/{x11,win32}/gdkselection-{x11,win32}.c
gdk/{x11,win32}/gdkmain-{x11,win32}.c gdk/gdkdisplay.c: Move
gdk_text_property_to_text_list(), gdk_string_to_compound_text(),
gdk_display_set_sm_client_id() to display-independent part of GDK.
* gdk/Makefile.am (gdk_c_sources): Sort gdkdisplay/screen.[ch]
into the right place.
Fri Jul 26 22:32:57 2002 Kristian Rietveld <kris@gtk.org>
Merge from stable:
* gtk/gtktreestore.c (node_free): return FALSE,
(gtk_tree_store_finalize): use g_node_traverse instead of
g_node_children_foreach, so the whole tree will be freed (#88854,
patch from Emmanuel Briot).
Fri Jul 26 22:32:24 2002 Kristian Rietveld <kris@gtk.org>
Merge from stable:
* gtk/gtktreeview.c (gtk_tree_view_button_press): fix some memleaks,
(#84426, patch from Matthias Clasen).
Fri Jul 26 22:31:25 2002 Kristian Rietveld <kris@gtk.org>
Merge from stable:
* gtk/gtktreeview.c (gtk_tree_view_unref_tree_helper): _iter_children
check shouldn't be in g_return_return_val_if_fail (pointed out by
Josh Green, #88997),
(gtk_tree_view_set_model): call _gtk_tree_view_column_unset_model
for each column when we unset the model (part of #82484),
(gtk_tree_view_get_cell_area): return if we ran out of tree or
if we got an invalid path (#82376).
* gtk/gtktreeviewcolumn.c: implement _gtk_tree_view_column_unset_model
which disconnects the sort_column_changed_signal (part of #82484).
* gtk/gtkliststore.c (gtk_list_store_insert): append row if the
given postion is off the end of the tree (#85813).
* gtk/gtkentry.c (gtk_cell_editable_key_press_event): let's use
2-space indent, commit changes if up/down keys has been pressed,
this overrides the focus key foo so the user won't be surprised
(#84665).
Shivram U [Fri, 26 Jul 2002 11:14:13 +0000 (11:14 +0000)]
Check if depth of the source is not equal to the depth of the colormap
Fri Jul 26 16:34:34 2002 Shivram U <shivaram.upadhyayula@wipro.com>
* gdk/gdkpixbuf-drawable.c (gdk_pixbuf_get_from_drawable),
(gdk_pixbuf_get_from_image), (rgbconvert), (convert_real_slow):
Check if depth of the source is not equal to the depth of the colormap
passed. (#75597)
Owen Taylor [Wed, 24 Jul 2002 20:54:34 +0000 (20:54 +0000)]
Don't use GTK_RC_FILES, since it causes problems with what KDE (etc.) does
Wed Jul 24 16:43:49 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkrc.c docs/references/tmpl/gtkrc.sgml: Don't use
GTK_RC_FILES, since it causes problems with what KDE (etc.)
does to customize GTK+ themes, use GTK2_RC_FILES instead. (#88987)
Sven Neumann [Tue, 16 Jul 2002 16:11:49 +0000 (16:11 +0000)]
gdk/gdk.c gdk/gdkinternals.h gdk/win32/gdkmain-win32.c pass argc and argv
2002-07-16 Sven Neumann <sven@gimp.org>
* gdk/gdk.c
* gdk/gdkinternals.h
* gdk/win32/gdkmain-win32.c
* gdk/x11/gdkmain-x11.c: pass argc and argv to the GDK backend in
_gdk_windowing_init() so that the backend has a chance to process
the command-line arguments (GTK+-DirectFB needs this).
Owen Taylor [Wed, 10 Jul 2002 18:30:23 +0000 (18:30 +0000)]
Fix some cases where signal connection IDs where being assigned to guint
Wed Jul 10 14:27:14 2002 Owen Taylor <otaylor@redhat.com>
* modules/input/gtkimcontextxim.c gtk/gtkcolorsel.c
gtk/gtkdialog.c gtk/gtktextbtree.c: Fix some cases
where signal connection IDs where being assigned to
guint rather than gulong. (part of #87281, Shivram U)
New function for loading an image from a file either via module->load or
* gdk-pixbuf-io.c (generic_image_load): New function for loading
an image from a file either via module->load or incrementally.
(prepared_notify): ModulePreparedNotifyFunc for generic_image_load.
(gdk_pixbuf_new_from_file): Use generic_image_load.
* io-bmp.c, io-ico.c, io-ras.c, io-wbmp.c: Remove trivial
implementations of module->load. (#71266)
Owen Taylor [Sat, 6 Jul 2002 00:21:43 +0000 (00:21 +0000)]
Add an extra parameter to _gtk_menu_item_select_first() to allow us to
Fri Jul 5 20:18:23 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenushell.[ch] gtk/gtkmenubar.c gtk/gtkmenuitem.c
gtk/gtkentry.c gtk/gtktextview.c: Add an extra parameter
to _gtk_menu_item_select_first() to allow us to choose
whether we want to select the first item predictably
or to select the first sensitive item. Fixes problem
with insensitive menu items and keynav. (#85796,
reported by Bill Haneman and others.)
* io-bmp.c (grow_buffer): New function to avoid crashes
on unchecked reallocs.
(DecodeHeader, DecodeColormap, decode_bitmasks,
DoCompressed): Use grow_buffer instead of g_realloc
throughout. Change signatures where necessary to pass the
errors up.
(OneLine16): Fix loading of 16bpp BI_RGB bmps.
(DoCompressed): Rewritten to properly support BI_RLE4 and
skips and jumps.
Use hyphen instead of underscore in signal names in calls to
* gtk/gtksocket.c (gtk_socket_hierarchy_changed):
Use hyphen instead of underscore in signal names in calls to
g_signal_connect_swapped (Fixes bug #86339)
Better colorspace support for the jpeg loader (#61211):
* io-jpeg.c (convert_cmyk_to_rgb): New function.
(gdk_pixbuf__jpeg_image_load,
gdk_pixbuf__jpeg_image_load_increment): Allocate a pixbuf with
alpha for 4-channel jpegs and call convert_cmyk_to_rgb for these.
Owen Taylor [Thu, 20 Jun 2002 23:29:19 +0000 (23:29 +0000)]
Add a singleton object that we can use to get notification when displays
Thu Jun 20 16:49:00 2002 Owen Taylor <otaylor@redhat.com>
* gdk/gdkdisplaymanager.[ch] gdk/gdk.[ch] gdk/gdkdisplay.c
gdk/gdkinternals.h gdk/x11/gdkdisplay-x11.c
gdk/win32/gdkdisplay-win32.c: Add a singleton object that
we can use to get notification when displays
appear / disappear or the default display changes.
* gtk/gtkmain.c: Add gtk_parse_args() that initializes
GTK+ without opening a display.
* gtk/gtkmain.c: Set things up so if a module
exports gtk_module_init() and gtk_module_display_init(),
then we treat it as multihead aware, otherwise,
we only initialize it after the default display is set.
Owen Taylor [Thu, 20 Jun 2002 19:29:16 +0000 (19:29 +0000)]
Get rid of gtk_style_get_font_for_display(), make gtk_style_get_font()
Thu Jun 20 15:17:14 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkstyle.[ch]: Get rid of gtk_style_get_font_for_display(),
make gtk_style_get_font() warn for multihead if called
on an unattached style.
* gtk/gtktext.c: Remove use of gtk_style_get_font_for_display();
this makes gtktext not multihead safe, but it doesn't matter;
it's ENABLE_BROKEN anyways.