* gtk/gtktreeview.c (gtk_tree_view_button_press): make the "editable
widget" show up with the same size as the actual cell, so it doesnt
cover the complete column if there are any other cells in that column.
create the target pixbuf AFTER filling in width/height, so that passing in
2002-04-13 Havoc Pennington <hp@pobox.com>
* gdk/gdkpixbuf-drawable.c (gdk_pixbuf_get_from_drawable): create
the target pixbuf AFTER filling in width/height, so that
passing in -1 for width/height will work.
Sat Apr 13 22:49:45 2002 Kristian Rietveld <kris@gtk.org>
Fixes #75510
* gtk/gtktreeselection.c (gtk_tree_selection_get_selected): make this
function work correctly and more sane
* gtk/gtktreeview.c (gtk_tree_view_real_collapse_row): remove
node->children from rbtree before emitting GtkTreeSelection::changed
Sat Apr 13 17:15:12 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_init): dont set
the mode to GTK_CELL_RENDERER_MODE_EDITABLE by default,
(gtk_cell_renderer_text_class_init): for some reason our default for
editable was TRUE, of course this is FALSE.
(gtk_cell_renderer_text_set_property): update mode when editable
has been changed.
relocate the remove_weak_pointer to just before we free the page, to be
2002-04-12 Havoc Pennington <hp@redhat.com>
* gtk/gtknotebook.c (gtk_notebook_real_remove): relocate the
remove_weak_pointer to just before we free the page, to be sure
it doesn't get re-added. #75282
add clamp_node argument (toplevel): update usages of
Fri Apr 12 18:32:46 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_real_set_cursor): add
clamp_node argument
(toplevel): update usages of gtk_tree_view_real_set_cursor,
(gtk_tree_view_focus_to_cursor): don't let
gtk_tree_view_real_set_cursor clamp the node, so you won't get
unexpected scrolling
Owen Taylor [Tue, 9 Apr 2002 22:41:37 +0000 (22:41 +0000)]
Always set the ALLOC_NEEDED and REQUEST_NEEDED flags up the hierarchy,
Tue Apr 9 18:34:58 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcontainer.c (_gtk_container_queue_resize): Always
set the ALLOC_NEEDED and REQUEST_NEEDED flags up the hierarchy,
even if we aren't currently in a resize container... we need
this to properly handle size changes to widgets that are
being moved from one heirarchy to another. (#78226)
check the return value of _gtk_tree_view_find_node and return if it's
Mon Apr 8 20:28:54 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeselection.c (gtk_tree_selection_select_path),
(gtk_tree_selection_unselect_path),
(gtk_tree_selection_path_is_selected): check the return value of
_gtk_tree_view_find_node and return if it's TRUE. This makes those
functions work somewhat saner on non-expanded trees.
Restructured to use gdk_pixbuf_new instead of manually allocating image
* io-png.c (gdk_pixbuf__png_image_load): Restructured to use
gdk_pixbuf_new instead of manually allocating image storage. This
gives us a good rowstride and overflow checks. (#77807)
Avoid allocating an extra copy of the image by using a
* io-tiff.c (tiff_image_parse): Avoid allocating an extra copy of
the image by using a TIFFRGBAImage{Begin,Get,End} with suitable
put functions instead of TIFFRGBAImage. And check image dimensions
for overflow.
Tor Lillqvist [Thu, 4 Apr 2002 20:23:56 +0000 (20:23 +0000)]
Fix some bugs, and introduce a minor feature.
2002-04-04 Tor Lillqvist <tml@iki.fi>
* gdk/gdkrgb.c: Fix some bugs, and introduce a minor feature.
(gdk_rgb_convert_4_pack): New function, for 16-color (4 bits per
pixel) static visuals (fixes #858).
(gdk_rgb_convert_gray4_pack, gdk_rgb_convert_gray4_d_pack): Fix
same bugs in both functions: Odd start coordinate (partial byte)
was not handled correctly. Also a partial final byte was not
handled correctly.
(gdk_rgb_do_colormaps): Use G_N_ELEMENTS.
(gdk_rgb_create_info): For pseudocolor visuals, use the 2x2x2
colorcube only for depths 3 and 4. For static color, use it for
depths 3..7 like before. (Depth 5..7 pseudocolor probably never
occurs on X11. It doesn't normally occur on Win32 either, but
there is experimental code in gdkvisual-win32.c to let the user
restrict the size of palette used.)
(gdk_rgb_init): Set gdk_rgb_verbose if the GDK_DEBUG_GDKRGB flag
is set.
(gdk_rgb_select_conv): Use gdk_rgb_convert_8 also for depths 5, 6
and 7 (see above). Use gdk_rgb_convert_4_pack for 4 bits per pixel
static color.
add check for y > tree_view->priv->height (fixes #76974)
Mon Apr 1 22:20:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): add
check for y > tree_view->priv->height (fixes #76974)
Mon Apr 1 22:19:39 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreemodelsort.c (gtk_tree_model_sort_sort_level): get
the stamp changes right this time
Mon Apr 1 22:13:24 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreemodel.c (gtk_tree_row_reference_free): only
disconnect the ref callbacks when model == proxy (Thanks go to
Manuel Clos Crespo for the remote debugging)
Owen Taylor [Fri, 29 Mar 2002 23:15:03 +0000 (23:15 +0000)]
Call gdk_keyval_to_lower() on the key passed in, since we lowercase all
Fri Mar 29 18:09:18 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkaccelgroup.c (gtk_accel_group_query): Call
gdk_keyval_to_lower() on the key passed in, since we
lowercase all other key vals passed in, so querying
keyvals will otherwise fail if the caller used
an uppercase accelerators (#76899, Vitaly Tishkov)
Owen Taylor [Fri, 29 Mar 2002 23:05:11 +0000 (23:05 +0000)]
Fix screwup in handling of module path that was resulting in freed memory
Fri Mar 29 17:41:21 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmain.c (load_modules): Fix screwup in handling
of module path that was resulting in freed memory being
accessed when both GTK_MODULES and a theme were set.
(#76902, Johan Dahlin)
Matthias Clasen [Fri, 29 Mar 2002 21:40:01 +0000 (21:40 +0000)]
libpng error handlers must not return to their callers, thus longjmp out.
* io-png.c (png_simple_error_callback): libpng error handlers must
not return to their callers, thus longjmp out. This prevents
annoying stderr output from the default error handler.
Hans Breuer [Thu, 28 Mar 2002 23:25:33 +0000 (23:25 +0000)]
Fixed dashed line issues (#74441) to an IMO reasonable extend. That is:
2002-03-29 Hans Breuer <hans@breuer.org>
Fixed dashed line issues (#74441) to an IMO reasonable extend.
That is: use PS_USERSTYLE on WinNT (the next GDI limit appears
to be with lines width > 50); Render horizontal and vertical
dashed lines on Win9x 'by hand'. Dotted selection rectangles
and Dia look nice ...
* gdk/win32/gdkprivate-win32.h : add pen_dashes pointer and
num_pen_dashes to _GdkGCWin32
* gdk/win32/gdkgc-win32.c : initialize pen_dashes and remove
the guesses from dashes to windoze line styles.
(predraw_set_forground) : always ExtCreatePen (PS_SOLID) on
Win9x, which does not support PS_USERSTYLE.
* gdk/win32/gdkdrawable-win32.c : new functions render_line_
<horizontal|vertical>. Use them if not running on NT in
gdk_win32_draw_<rectangle|segments|lines> ()
* gdk/win32/gdkkeys-win32.c (gdk_keyval_name) : return NULL
for keyval == 0 to avoid to have zeros in all menu entries
without accelerator.
Tim Janik [Thu, 28 Mar 2002 20:08:25 +0000 (20:08 +0000)]
when encountering non-UTF-8 file names, alert the user with g_message()
Thu Mar 28 21:11:04 2002 Tim Janik <timj@gtk.org>
* gtk/gtkfilesel.c (open_new_dir): when encountering non-UTF-8 file
names, alert the user with g_message() instead of g_warning() and
put out the actual conversion error.
* io-png.c (gdk_pixbuf__png_image_load): Get rid of unused
end_info. Also call png_read_end to check proper ending of the png
file and catch text chunks after the image data.
Owen Taylor [Wed, 27 Mar 2002 16:15:48 +0000 (16:15 +0000)]
Set page->last_focus_child to NULL as well as removing the weak reference,
Wed Mar 27 11:10:39 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtknotebook.c (gtk_notebook_real_remove): Set
page->last_focus_child to NULL as well as removing the
weak reference, to deal with reentrancy in set_focus_child().
(#76634)
Owen Taylor [Tue, 26 Mar 2002 19:59:34 +0000 (19:59 +0000)]
Shuffle the ordering around some more (position before realizing) fixing
Tue Mar 26 14:46:50 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmenu.c (gtk_menu_popup): Shuffle the ordering around
some more (position before realizing) fixing problems with
arrows popping up at the wrong time (#73386), hopefully not
introducing other problems. (Reported by Ettore Perrazoli, others)
Sven Neumann [Mon, 25 Mar 2002 20:11:27 +0000 (20:11 +0000)]
free the style's font_description before accessing a new one.
2002-03-25 Sven Neumann <sven@gimp.org>
* gtk/gtkrc.c (gtk_rc_parse_font_name): free the style's
font_description before accessing a new one.
(gtk_rc_parse_stock): always unref the created icon_set. #76289
Sun Mar 24 10:32:38 2002 Jonathan Blandford <jrb@redhat.com>
* gtk/gtktreemodel.c (gtk_tree_path_copy): Make path arg const, #75653
* gtk/gtkfontsel.c (gtk_font_selection_show_available_styles): fix
a warning
* gtk/gtktreeview.c (gtk_tree_view_button_press): remove the grab
when we emit row_activated so that listeners of this signal can
grab the mouse, #75629
Matthias Clasen [Mon, 25 Mar 2002 00:15:00 +0000 (00:15 +0000)]
Changed signature to return success and set a GError parameter, adjusted
* io-png.c (setup_png_transformations): Changed signature to
return success and set a GError parameter, adjusted all callers.
Also work around a possible FPE in libpng and always check that
the new info is sane.
Havoc Pennington [Sat, 23 Mar 2002 22:14:40 +0000 (22:14 +0000)]
invalidate the line containing start, even if the [start,end) range is
2002-03-23 Havoc Pennington <hp@pobox.com>
* gtk/gtktextlayout.c (gtk_text_layout_real_invalidate):
invalidate the line containing start, even if the [start,end)
range is empty (just invalidate [start,end], essentially).
Partially fixes #72374
Matthias Clasen [Sat, 23 Mar 2002 21:17:17 +0000 (21:17 +0000)]
context->updated_func is NULL during a nonincremental load.
* io-wbmp.c (gdk_pixbuf__wbmp_image_load_increment):
context->updated_func is NULL during a nonincremental load.
(gdk_pixbuf__wbmp_image_load): Stop reading after the first error.
Havoc Pennington [Sat, 23 Mar 2002 17:54:16 +0000 (17:54 +0000)]
extend selection for pageup/pagedown and ctrl+pageup/pagedown if shift is
2002-03-23 Havoc Pennington <hp@pobox.com>
* gtk/gtktextview.c (gtk_text_view_move_cursor_internal): extend
selection for pageup/pagedown and ctrl+pageup/pagedown if
shift is held. more of #53934
Havoc Pennington [Sat, 23 Mar 2002 17:35:09 +0000 (17:35 +0000)]
disconnect layout handlers earlier in the function, to avoid possible
2002-03-23 Havoc Pennington <hp@pobox.com>
* gtk/gtktextview.c (gtk_text_view_destroy_layout): disconnect
layout handlers earlier in the function, to avoid possible
reentrancy screwups
(gtk_text_view_invalidate): Don't install idle handlers if
layout == NULL, otherwise we get problems during finalization
since clearing the buffer invalidates and puts the idle handlers
back after we destroy the layout. #74660
(gtk_text_view_ensure_layout): Install the validation handlers
right after creating the layout.
Havoc Pennington [Sat, 23 Mar 2002 04:37:53 +0000 (04:37 +0000)]
add more explanatory text to the error message about missing charsets, and
2002-03-22 Havoc Pennington <hp@pobox.com>
* gdk/x11/gdkfont-x11.c (gdk_fontset_load): add more explanatory
text to the error message about missing charsets, and use
g_printerr() not g_warning() since this is typically not a
programming error (we do not export any API to ask whether
a font set will have missing charsets so apps realistically can't
do anything other than try the gdk_fontset_load())
* gtk/gtktextview.c (gtk_text_view_key_press_event): return FALSE
if the text view isn't editable and the user presses Return,
so default buttons and such can be activated, #74937
* gtk/gtktextbuffer.c (paste_from_buffer): don't insert
if the insertion point is not editable and the paste
is interactive, #74125
* gtk/gtkwindow.c (gtk_window_move_resize): enhance the #if 0
debug spew
* gtk/gtktextbuffer.c (cut_or_copy): only remove the previous
cut/copied data right before replacing it, when we know we are
going to replace it. Fixes #74049
Owen Taylor [Fri, 22 Mar 2002 17:35:14 +0000 (17:35 +0000)]
Partial fix for problem where keypad keys acted as shift-arrows in an
Fri Mar 22 11:29:11 2002 Owen Taylor <otaylor@redhat.com>
Partial fix for problem where keypad keys acted
as shift-arrows in an entry rather than arrows (#74327)
* gtk/gtkkeyhash.c (_gtk_key_hash_lookup): Sort lookup
results by number of modifiers in the entry. Fixes
problem where if a key matched both modified and unmodified
key bindings ... e.g., the distinguishing key binding
was consumed, then it was random which was used.
* gtk/gtkbindings.c (gtk_binding_entries_sort_patterns):
Catch the case where there are multiple entries from the
same bindingset (with different modifiers), and use only
the first entry, which, with the change in _gtk_key_hash_lookup()
* gtk/gtkaccelmap.c: Properly handle short returns from
write() calls. (Handling EINTR isn't enough... that only
handles the case where you were interrupted before you
wrote a single byte.)
* gdk/linux-fb/gdkmouse-fb.c gdk/linux-fb/gdkkeyboard-fb.c:
Robustify against short returns from write() calls.
Tor Lillqvist [Thu, 21 Mar 2002 22:36:02 +0000 (22:36 +0000)]
Don't clear all of the pen_style, just the PS_STYLE_MASK. Seems to fix
2002-03-22 Tor Lillqvist <tml@iki.fi>
* gdk/win32/gdkgc-win32.c (gdk_win32_gc_set_dashes): Don't clear
all of the pen_style, just the PS_STYLE_MASK. Seems to fix #74441,
but that is just the special case of one-pixel wide one-pixel
on-off dotted lines. To fully implement generic X11 style dashed
lines a major rewrite would be needed.
Owen Taylor [Thu, 21 Mar 2002 00:50:15 +0000 (00:50 +0000)]
When changing months when the user clicks on a prev-month or next-month
Wed Mar 20 19:33:31 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcalendar.c (gtk_calendar_main_button): When
changing months when the user clicks on a prev-month
or next-month day, focus and select the new day.
Ignore double clicks on prev-month, next-month days.
(Based on suggestions from Andras Salamon, #74173)
* gtk/gtkcalendar.c: Implement the focused/unfocused
selected color change.
projects / ~andy / gtk / log