]>
Pileus Git - ~andy/gtk/log
Federico Mena Quintero [Tue, 29 Nov 2011 21:07:01 +0000 (15:07 -0600)]
[GtkPathBar] Remove unused error argument
It used to be that _gtk_path_bar_set_file() would return an error if
it wasn't able to switch to the specified file, but that hasn't been
the case for a long while now, since the file chooser became async.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Paolo Borelli [Tue, 29 Nov 2011 20:14:24 +0000 (21:14 +0100)]
Avoid shadowing a variable
Move bg_color variable to an inner scope.
Federico Mena Quintero [Mon, 28 Nov 2011 18:03:02 +0000 (12:03 -0600)]
[path-bar] Add some comments to explain the async recursion on an I/O callback
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 28 Nov 2011 17:49:35 +0000 (11:49 -0600)]
[path-bar] Only reset the children's styles if the children actually changed
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Federico Mena Quintero [Mon, 28 Nov 2011 17:34:37 +0000 (11:34 -0600)]
Remove unused argument
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Benjamin Otte [Tue, 29 Nov 2011 19:39:21 +0000 (20:39 +0100)]
filechooserdefault: Don't unref value twice
Double unref was introduced in
eb02dacb370e8b4e6ef62328d0c09673b1234b32
https://bugzilla.gnome.org/show_bug.cgi?id=646461
https://bugzilla.gnome.org/show_bug.cgi?id=664137
Benjamin Otte [Sat, 26 Nov 2011 23:06:53 +0000 (00:06 +0100)]
treeview: Properly change cursor when row is collapsed
Previously, when the cursor was a descendant of the collapsed row,
the cursor path was set to the collapsed row, but this was not
communicated via cursor-changed events.
Benjamin Otte [Sat, 26 Nov 2011 22:49:05 +0000 (23:49 +0100)]
treeview: Reorder code a bit
This is mainly in preparation for the next commit, but also to reorder
the code to
1) prepare modification of tree
2) modify tree
3) emit signals
Mike Gorse [Sat, 26 Nov 2011 22:08:09 +0000 (23:08 +0100)]
tests: Add new test that is currently failing
Benjamin Otte [Sat, 26 Nov 2011 02:36:45 +0000 (03:36 +0100)]
treeview: Simplify code
Since the changes in commit
2b3de3dd this simplification is possible.
Benjamin Otte [Sat, 26 Nov 2011 01:54:34 +0000 (02:54 +0100)]
treeview: Rename function
_gtk_tree_view_find_path() was not a name that not really described what
the function does. And I kept forgetting it. Also, it took the tree view
as an argument and that was completely unnecessary.
Benjamin Otte [Fri, 25 Nov 2011 19:56:07 +0000 (20:56 +0100)]
tests: Add automatic expanding/collapsing
Makes the test test even more stuff.
Benjamin Otte [Fri, 25 Nov 2011 19:54:48 +0000 (20:54 +0100)]
tests: Fix the iter stepping code
The old code actually was wrong and could cause assertions and crashes,
in particular when stepping out of a deep tree back onto the highest
layer.
Benjamin Otte [Fri, 25 Nov 2011 15:31:34 +0000 (16:31 +0100)]
tests: Check that the cursor keeps up to date
This actually demonstrates a bug where the treeview doesn't emit a
cursor-changed signal when the cursor row is deleted.
Benjamin Otte [Fri, 25 Nov 2011 14:46:23 +0000 (15:46 +0100)]
reftests: Fix test for border-image addition
Cosimo Cecchi [Tue, 29 Nov 2011 15:51:29 +0000 (10:51 -0500)]
widget-factory: make one of the two spinbuttons active
Cosimo Cecchi [Mon, 28 Nov 2011 22:40:32 +0000 (17:40 -0500)]
themingengine: fix a typo
Cosimo Cecchi [Mon, 28 Nov 2011 22:33:19 +0000 (17:33 -0500)]
themingengine: move code to make switch-case more clear
Code is more readable with the default case as the last one in the
switch block.
Yuri Myasoedov [Mon, 28 Nov 2011 20:08:32 +0000 (00:08 +0400)]
Updated Russian translation
Cosimo Cecchi [Mon, 28 Nov 2011 19:41:02 +0000 (14:41 -0500)]
pathbar: add the linked style class to GtkPathBar
Cosimo Cecchi [Mon, 28 Nov 2011 19:40:04 +0000 (14:40 -0500)]
stylecontext: add GTK_STYLE_CLASS_LINKED
"linked" is a style class for linked areas, such as a box containing
buttons belonging to the same control.
Javier Jardón [Mon, 28 Nov 2011 15:23:00 +0000 (15:23 +0000)]
gtk/gtkeditable: Some docs fixes
Cosimo Cecchi [Wed, 23 Nov 2011 03:08:59 +0000 (22:08 -0500)]
spinbutton: redesign to use an horizontal layout
Rewrite GtkSpinButton to use a touchscreen friendly horizontal layout.
Other features include:
- support for theming buttons with nth-child
- full support for RTL
- use + and - symbolic icons instead of arrows
- general streamlining and cleanup of a lot of related code
https://bugzilla.gnome.org/show_bug.cgi?id=663359
Alexander Larsson [Mon, 28 Nov 2011 09:06:38 +0000 (10:06 +0100)]
win32-theme: Make tabs look better
Alexander Larsson [Mon, 28 Nov 2011 09:05:29 +0000 (10:05 +0100)]
Support border-image in theme_engine_render_frame_gap
This is similar to the normal frame rendering, but has a clip
region applied for the gap.
Alexander Larsson [Mon, 28 Nov 2011 08:14:13 +0000 (09:14 +0100)]
win32-theme: Add some margins on GtkScale trought to look like win32
Alexander Larsson [Mon, 28 Nov 2011 08:13:54 +0000 (09:13 +0100)]
win32-theme: Support custom margins in win32 theme parts
Alexander Larsson [Mon, 28 Nov 2011 08:12:28 +0000 (09:12 +0100)]
Fix up makefile rules for parallel builds
The gtkwin32css.h generation code used a temporary filename that was also
used by some other files, which is racy. Use a unique one.
Alexander Larsson [Mon, 28 Nov 2011 07:39:15 +0000 (08:39 +0100)]
win32-theme: Make syntax for mixing theme parts more regular
This lets us extend the argument list better
Alexander Larsson [Fri, 25 Nov 2011 15:43:51 +0000 (16:43 +0100)]
win32-theme: Make notebook tabs slightly better
Alexander Larsson [Fri, 25 Nov 2011 15:40:25 +0000 (16:40 +0100)]
win32-theme: Fix background colors for new bg drawing
Alexander Larsson [Thu, 24 Nov 2011 21:11:35 +0000 (22:11 +0100)]
Fix up background-origin now that we correctly handle the background color
Alexander Larsson [Thu, 24 Nov 2011 21:11:00 +0000 (22:11 +0100)]
css: Always draw the bg color under the bg image
Alexander Larsson [Thu, 24 Nov 2011 21:00:49 +0000 (22:00 +0100)]
Reftest background-origin with various background-clip values
Alexander Larsson [Thu, 24 Nov 2011 20:01:16 +0000 (21:01 +0100)]
Update background-area reftest for background-clip
Alexander Larsson [Thu, 24 Nov 2011 20:00:57 +0000 (21:00 +0100)]
Implement background-clip and background-origin
Alexander Larsson [Thu, 24 Nov 2011 19:57:02 +0000 (20:57 +0100)]
Add GtkCssArea enum
This will be used for background-clip and background-origin css properties.
Alexander Larsson [Thu, 24 Nov 2011 17:25:08 +0000 (18:25 +0100)]
Add reftest to test border-style: none
From the css docs at http://www.w3.org/TR/CSS2/box.html:
8.5.1 Border width: 'border-top-width', 'border-right-width', 'border-bottom-width',
'border-left-width', and 'border-width'
Computed value: absolute length; '0' if the border style is 'none' or 'hidden'
So, if i specify border-style none and a border-width > 0 that should give the
same result as border-width 0.
Alexander Larsson [Thu, 24 Nov 2011 17:38:53 +0000 (18:38 +0100)]
Make computed value of border-width 0 if border-style none
From the css docs at http://www.w3.org/TR/CSS2/box.html:
8.5.1 Border width: 'border-top-width', 'border-right-width', 'border-bottom-width',
'border-left-width', and 'border-width'
Computed value: absolute length; '0' if the border style is 'none' or 'hidden'
Alexander Larsson [Fri, 25 Nov 2011 14:35:13 +0000 (15:35 +0100)]
css: Convert border style parsing to use enums
Alexander Larsson [Fri, 25 Nov 2011 14:30:10 +0000 (15:30 +0100)]
Rename GTK_CSS_REPEAT_STYLE_NONE to GTK_CSS_REPEAT_STYLE_STRETCH
This is a private type, and the CSS default value is "stretch", which
is how we were parsing and printing NONE anyway.
With this fix we can use the enum stuff for printing/parsing
Alexander Larsson [Fri, 25 Nov 2011 13:36:27 +0000 (14:36 +0100)]
css: Use enum parsing for background repeat style
Alexander Larsson [Fri, 25 Nov 2011 13:35:11 +0000 (14:35 +0100)]
css: Break out enum parse/print helper
We need this to parse non-GValue enums
Alexander Larsson [Fri, 25 Nov 2011 13:30:47 +0000 (14:30 +0100)]
css: Parse enums with new case-insensitive helper
Alexander Larsson [Fri, 25 Nov 2011 13:11:56 +0000 (14:11 +0100)]
css: Add _gtk_css_parser_try_enum
This helps parsing GType enums in CSS, properly handling
CSS being case insensitive.
Alexander Larsson [Fri, 25 Nov 2011 12:07:43 +0000 (13:07 +0100)]
Add generation of private g-types for private headers
This starts with just the gtkcsstypesprivate.h header
Benjamin Otte [Fri, 25 Nov 2011 14:11:42 +0000 (15:11 +0100)]
reftests: Make sure border-image-gradient keeps working
.. even with more advanced themes.
Benjamin Otte [Fri, 25 Nov 2011 13:41:11 +0000 (14:41 +0100)]
tests: Add testtreechanging
It's just a treestore going crazy while the treeview has to keep up.
Alexander Larsson [Fri, 25 Nov 2011 10:21:26 +0000 (11:21 +0100)]
win32: Make all GDK_WINDOW_TEMP always on top
This makes menus, popups and tooltips show above the windows
task bar.
Benjamin Otte [Thu, 24 Nov 2011 17:07:23 +0000 (18:07 +0100)]
tests: Add prop editors to testtreeview
It tests treeviews, so we'd better be able to edit them :)
Benjamin Otte [Thu, 24 Nov 2011 17:06:08 +0000 (18:06 +0100)]
reftests: Mark windows as popups
Improves performance, gets rid of resize grip.
Benjamin Otte [Thu, 24 Nov 2011 00:59:18 +0000 (01:59 +0100)]
a11y: Implement ref_state_set using the new APIs
Various tiny semantic changes in here.
The big fix is that we consider every cell as visible and as showing if
the treeview is mapped.
This was also fixed in the tree dump test.
Benjamin Otte [Thu, 24 Nov 2011 00:55:38 +0000 (01:55 +0100)]
a11y: Add get_renderer_state() to cell accessibles
Accessibles can use this function to query the state that their row
would be rendered with.
Benjamin Otte [Wed, 23 Nov 2011 16:35:00 +0000 (17:35 +0100)]
a11y: Add _gtk_cell_accessible_set_cell_data()
See the function documentation for details.
Also included is the implementation for the treeview, but no users yet.
Benjamin Otte [Wed, 23 Nov 2011 02:21:57 +0000 (03:21 +0100)]
treeview: Notify a11y about reordered rows
That way, no more signal handler is needed in the a11y code. Plus, we
avoid needless signal emissions for rows we don't care about.
Benjamin Otte [Wed, 23 Nov 2011 16:54:49 +0000 (17:54 +0100)]
a11y: Don't create fake cell renderers
Florian Müllner [Thu, 24 Nov 2011 15:31:47 +0000 (16:31 +0100)]
build: Add gmodule-2.0 dependency for gtk-query-immodules-3.0
Alexander Larsson [Thu, 24 Nov 2011 10:40:36 +0000 (11:40 +0100)]
win32-theme: Fix up radio and menus in various states
This makes all states in widget-factory look ok
Alexander Larsson [Thu, 24 Nov 2011 08:53:39 +0000 (09:53 +0100)]
win32-theme: Theme column headers
Christian Persch [Mon, 21 Nov 2011 13:07:06 +0000 (14:07 +0100)]
prop-editor: Implement property editing for GdkRGBA properties
Bug #664467.
Christian Persch [Mon, 21 Nov 2011 13:03:01 +0000 (14:03 +0100)]
Revert "tests: use GdkRGBA instead GdkColor"
This reverts commit
85747da97238dc101f92cd8241aa7aea44f35789 .
Conflicts:
tests/prop-editor.c
Bug #664467.
Christian Persch [Mon, 21 Nov 2011 13:19:51 +0000 (14:19 +0100)]
color-button: Notify "color" and "alpha" properties when changing the rgba
Bug #664469.
Matthias Clasen [Wed, 23 Nov 2011 22:49:46 +0000 (17:49 -0500)]
GtkIconView: Fix a segfault
Keynav on an empty iconview was causing segfaults. This
was reported in https://bugzilla.gnome.org/show_bug.cgi?id=664456
Federico Mena Quintero [Wed, 23 Nov 2011 15:44:26 +0000 (09:44 -0600)]
bgo#662814 - Don't print a g_warning() when GtkRecentManager can't find a file
Also, *do* add the file to the recently-used list, even if the file does not
exist yet. This is used from the Save dialog, so even shitty apps which don't
add the file to GtkRecentManager, will get the file added from the Save dialog.
Signed-off-by: Federico Mena Quintero <federico@gnome.org>
Cosimo Cecchi [Wed, 23 Nov 2011 16:22:30 +0000 (11:22 -0500)]
widgetpath: correctly print the siblings index
In gtk_widget_path_to_string() we were counting siblings from zero
instead of one, resulting in confusing output.
Cosimo Cecchi [Wed, 23 Nov 2011 16:21:29 +0000 (11:21 -0500)]
frame: don't access padding before it's initialized
Move padding initialization before its first access.
Benjamin Otte [Tue, 22 Nov 2011 22:27:40 +0000 (23:27 +0100)]
gtk-demo: Fix segfault in editable cells demo
The strings can be freed when edting the description column. This does
not work with constant strings.
Benjamin Otte [Tue, 22 Nov 2011 22:15:53 +0000 (23:15 +0100)]
rbtree: Rewrite to not lose node order
_gtk_rbtree_reorder() was moving the node's data while reordering. As we
use the node pointer in the a11y code as a hash key, this didn't work.
So this rewrite changes that. As a bonus, it is less code and faster.
Woohoo!
Benjamin Otte [Tue, 22 Nov 2011 22:14:09 +0000 (23:14 +0100)]
tests: Add test for _gtk_rbtree_reorder()
Benjamin Otte [Tue, 22 Nov 2011 14:35:53 +0000 (15:35 +0100)]
tests: Speed up rbtree test
We don't need so many tree consistency checks while creating when the
test is about something else.
Matthias Clasen [Tue, 22 Nov 2011 19:55:46 +0000 (14:55 -0500)]
Fix a typo
Matthias Clasen [Tue, 22 Nov 2011 18:41:59 +0000 (13:41 -0500)]
Revert "Clean up includes"
This reverts commit
c5e4af761c9db702b9bbf0740404c204e5b086d2 .
Matthias Clasen [Tue, 22 Nov 2011 14:42:31 +0000 (09:42 -0500)]
Move pangoft2 to Requires.private
We have pango in Requires anyway, and this is just so we
can call pangofc api ourselves.
Matthias Clasen [Tue, 22 Nov 2011 13:25:24 +0000 (08:25 -0500)]
Clean up includes
There's no sign of Pango in this header, so no need to include
pangocairo.h
Benjamin Otte [Tue, 22 Nov 2011 02:42:31 +0000 (03:42 +0100)]
rbtree: Remove needless tests
if the checks are run on the nil node, they will get the second test the
way we expect it anyway, so it's unnecessary.
Benjamin Otte [Tue, 22 Nov 2011 02:30:45 +0000 (03:30 +0100)]
rbtree: Simplify rotation functions
- Make sure the rotated nodes aren't nil
- Use existing functions for complex computations
- Don't use NULL checks for variables guaranteed to not be NULL/nil
Benjamin Otte [Tue, 22 Nov 2011 02:18:31 +0000 (03:18 +0100)]
rbtree: Remove the nil member
Benjamin Otte [Tue, 22 Nov 2011 01:17:05 +0000 (02:17 +0100)]
rbtree: Introduce _gtk_rbtree_is_nil()
Makes for more readable code than "== tree->nil" and allows removing the
nil member later.
Benjamin Otte [Tue, 22 Nov 2011 01:58:05 +0000 (02:58 +0100)]
rbtree: Introduce _gtk_rbtree_first()
... and use it.
Benjamin Otte [Tue, 22 Nov 2011 00:32:28 +0000 (01:32 +0100)]
rbtree: Replace nil node allocation with a preallocated nil
This has one major caveat: The new value is const, so read-only memory.
Any attempt to write to it will cause a crash. Note that we are not ever
supposed to write to it, but bugs happen...
Matthias Clasen [Mon, 21 Nov 2011 23:34:11 +0000 (18:34 -0500)]
Bump version
Matthias Clasen [Mon, 21 Nov 2011 23:14:13 +0000 (18:14 -0500)]
3.3.4
Matthias Clasen [Mon, 21 Nov 2011 22:12:27 +0000 (17:12 -0500)]
More updates
Benjamin Otte [Mon, 21 Nov 2011 21:26:42 +0000 (22:26 +0100)]
tests: Add a test for the rbtree code.
Benjamin Otte [Mon, 21 Nov 2011 20:13:53 +0000 (21:13 +0100)]
rbtree: Don't write to nil node
The code used to set nil->parent, which could cause segfaults. Don't do
that. We also need to pass the parent explicitly to the fixup code,
because the node during fixup may be the nil node.
Benjamin Otte [Mon, 21 Nov 2011 21:28:36 +0000 (22:28 +0100)]
rbtree: Add a local variable
This will be needed in the next patch, and I wanted to split that patch
up.
Benjamin Otte [Mon, 21 Nov 2011 15:07:52 +0000 (16:07 +0100)]
rbtree: Move to an approach where we don't move contents
So instead of copying the children and height to the new node, we keep
the old node and copy all the old stuff to it.
This is necessary so the accessibility code can use the node as a key in
the hash table or store the node as a reference to the row instead of
GtkTreeRowReference. And because it already does that (oops), this fixes
a bunch of segfaults with a11y enabled.
Benjamin Otte [Sun, 20 Nov 2011 20:27:46 +0000 (21:27 +0100)]
rbtree: Use gtk_rbnode_adjust() even more
Use it for the modified node in gtk_rbnode_remove(). Cleans up the code
quite a lot.
Benjamin Otte [Sat, 19 Nov 2011 12:18:05 +0000 (13:18 +0100)]
rbtree: Use gtk_rbnode_adjust()
Make gtk_rbnode_remove() use it when unlinking the node.
Benjamin Otte [Sat, 19 Nov 2011 12:10:05 +0000 (13:10 +0100)]
rbtree: Use gtk_rbnode_adjust() more.
Make _gtk_rbtree_node_set_height() use it.
Benjamin Otte [Sat, 19 Nov 2011 12:08:10 +0000 (13:08 +0100)]
rbtree: Use gtk_rbnode_adjust() more
Make _gtk_rbtree_insert_before() use it.
Benjamin Otte [Sat, 19 Nov 2011 12:06:22 +0000 (13:06 +0100)]
rbtree: Use gtk_rbnode_adjust()
Make _gtk_rbtree_insert_after() use it.
Benjamin Otte [Sat, 19 Nov 2011 11:59:39 +0000 (12:59 +0100)]
rbtree: Split out a common function
gtk_rbtree_adjust() will adjust the summed values of a node and all its
parents in the tree. Currently only implemented by splitting out the
function from gtk_rbtree_free().
Benjamin Otte [Sat, 19 Nov 2011 11:48:25 +0000 (12:48 +0100)]
rbtree: Don't set variable twice
Benjamin Otte [Mon, 21 Nov 2011 18:51:39 +0000 (19:51 +0100)]
rbtree: Add assertions to clarify usage
Benjamin Otte [Mon, 21 Nov 2011 15:59:22 +0000 (16:59 +0100)]
rbtree: Mark all debug sections as debug
Benjamin Otte [Mon, 21 Nov 2011 15:59:37 +0000 (16:59 +0100)]
rbtree: Make debug functions private
They're not used elsewhere
Cosimo Cecchi [Mon, 21 Nov 2011 18:57:27 +0000 (13:57 -0500)]
notebook: use the current page allocation when computing the redraw area
Instead of taking the first page and trying to adjust the rect with
random padding values, take the current page, as it's always guaranteed
to be at least as tall as inactive tabs.
This fixes some annoying 1px drawing artifacts while switching tabs when
the theme disables notebook padding.
https://bugzilla.gnome.org/show_bug.cgi?id=664494
Cosimo Cecchi [Mon, 21 Nov 2011 17:08:11 +0000 (12:08 -0500)]
notebook: properly subtract the initial_gap width from the tab space
Instead of modifying the allocation.
https://bugzilla.gnome.org/show_bug.cgi?id=664494
Matthias Clasen [Mon, 21 Nov 2011 18:12:58 +0000 (13:12 -0500)]
Drop uses of @returns syntax