Avoid some compiler warnings and remove obsolete code. (#339540)
* gtk/gtkcalendar.c: Change week and year variable in
calendar_paint_week_numbers from gint to guint. Remove obsolete "#if
0" block from calendar_paint_day: The feature in question is handled
few lines above. Cast data returned by gtk_selection_data_get_text()
to (gchar*) in gtk_calendar_drag_data_received.
Johan Dahlin [Wed, 19 Dec 2007 13:49:29 +0000 (13:49 +0000)]
Add another call to gtk_builder_add_string after using delayed properties,
2007-12-19 Johan Dahlin <johan@gnome.org>
* tests/buildertest.c (test_object_properties):
Add another call to gtk_builder_add_string after using
delayed properties, as reported in #504393 but already
fixed in #495769.
Matthias Clasen [Tue, 18 Dec 2007 03:24:17 +0000 (03:24 +0000)]
Add a gtk-im-module GTK setting
2007-12-17 Matthias Clasen <mclasen@redhat.com>
* gtk/gtksettings.c: Add a gtk-im-module GTK setting
* gdk/win32/gdkproperty-win32.c:
* gdk/x11/gdksettings.c: ...and back it by a Gtk/IMModule X setting.
* gtk/gtkimmodule.[hc]:
* gtk/gtkimmulticontext.[hc]: When determining the default context,
look at the gtk-im-module setting, and listen for changes to the
setting. (#502446, Akira Tagoh)
use a weak pointer to set last_window to NULL as soon as it's destroyed.
2007-12-17 Kristian Rietveld <kris@imendio.com>
* gtk/gtktooltip.c (gtk_tooltip_finalize),
(gtk_tooltip_set_last_window): use a weak pointer to set last_window
to NULL as soon as it's destroyed. (#496546, patch from
Benjamin Berg).
always determine what arrow to show if show_sort_indicator is true.
2007-12-17 Kristian Rietveld <kris@imendio.com>
* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_update_button):
always determine what arrow to show if show_sort_indicator is true.
(#352738, Chris Vine).
Sebastian Dröge [Sat, 15 Dec 2007 05:01:30 +0000 (05:01 +0000)]
Use u32 instead of __u32 and u8 instead of __u8 as the other types are
* gdk/directfb/gdkcursor-directfb.c: (gdk_cursor_new_for_display):
Use u32 instead of __u32 and u8 instead of __u8 as the other types
are deprecated since DirectFB 1.0.0. If compiling with an older
version define the new type name to the old types. Fixes bug #503190.
Ray Strode [Fri, 14 Dec 2007 17:06:08 +0000 (17:06 +0000)]
Suggest g_signal_connect (..., "realize", ...) instead of
2007-12-14 Ray Strode <rstrode@redhat.com>
* gtk/gtkwidget.c: Suggest g_signal_connect (..., "realize", ...)
instead of g_signal_connect_after (..., "realize", ...) as an
alternative to gtk_widget_realize () (bug 503537).
Extract loading of GtkPageSetup and GtkPrintSettings from their *_new_*()
functions and move that code into separate *_load_*() functions (#475565).
* gtk/gtk.symbols, gtk/gtkpagesetup.c, gtk/gtkpagesetup.h:
Extract gtk_page_setup_load_file, gtk_page_setup_load_key_file,
gtk_print_settings_load_file and gtk_print_settings_load_key_file.
Change the matching *_new_*() functions to use those functions.
Matthias Clasen [Thu, 13 Dec 2007 05:16:33 +0000 (05:16 +0000)]
Implement GAppLaunchContext in gdk, providing startup notification.
2007-12-12 Matthias Clasen <mclasen@redhat.com>
* gdk/gdkapplaunchcontext.[hc]: Implement GAppLaunchContext
in gdk, providing startup notification. (#503203)
* gdk/x11/gdkapplaunchcontext-x11.c:
* gdk/win32/gdkapplaunchcontext-win32.c:
* gdk/quartz/gdkapplaunchcontext-quartz.c:
* gdk/directfb/gdkapplaunchcontext-directfb.c: Backend-specific
parts. All but X11 are just empty stubs for now.
* gdk/directfb/gdktestutils-directfb.c:
* gdk/directfb/Makefile.am: Applied a patch by Claudio Ciccani
which adds testing functions to the DirectFB backend.
made unnecessarily exported symbols static. switched g_return_if_fail()
2007-12-11 15:44:01 Tim Janik <timj@imendio.com>
* buildertest.c: made unnecessarily exported symbols static.
switched g_return_if_fail() statements in tests to assertions.
special cased currently failing Widget/accesibility test to
run only for g_test_thorough(), so it doesn't break make check.
some coding style fixes.
Richard Hult [Mon, 10 Dec 2007 20:44:23 +0000 (20:44 +0000)]
Install backend specific header (bug #405915). Also add a getter for the
2007-12-10 Richard Hult <richard@imendio.com>
* gdk/quartz/Makefile.am:
* gdk/quartz/gdkquartz.h:
* gdk/quartz/gdkwindow-quartz.c: Install backend specific
header (bug #405915). Also add a getter for the toplevel nswindow.
Richard Hult [Mon, 10 Dec 2007 20:22:08 +0000 (20:22 +0000)]
Replace the autorelease pools used for each drawing context and in
2007-12-10 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkdrawable-quartz.c:
(gdk_quartz_drawable_get_context),
(gdk_quartz_drawable_release_context):
* gdk/quartz/gdkeventloop-quartz.c: (gdk_event_prepare),
(gdk_event_check), (gdk_event_dispatch), (poll_func):
* gdk/quartz/gdkwindow-quartz.h: Replace the autorelease pools
used for each drawing context and in prepare, dispatch and poll
with one that exists across each main loop iteration. Fixes leaks
on leopard and protects against future leaks introduce when the
underlying system changes again (bug #492977).
Richard Hult [Mon, 10 Dec 2007 19:00:23 +0000 (19:00 +0000)]
Fix a bug where we could end up trying to handle the same event more than
2007-12-10 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkprivate-quartz.h:
* gdk/quartz/gdkeventloop-quartz.c:
(_gdk_quartz_event_loop_get_pending),
(_gdk_quartz_event_loop_check_pending),
(_gdk_quartz_event_loop_release_event), (gdk_event_prepare),
(gdk_event_check), (gdk_event_dispatch):
* gdk/quartz/gdkevents-quartz.c: (gdk_events_pending)
(_gdk_events_queue): Fix a bug where we could end up trying to
handle the same event more than once. Based on patch from Paul
Davis.
skip tests if gdktarget!=x11, since GUI tests need Xvfb. only start Xvfb
2007-12-07 13:16:33 Tim Janik <timj@imendio.com>
* Makefile.decl: skip tests if gdktarget!=x11, since GUI tests need
Xvfb. only start Xvfb if TEST_PROGS is not empty. moved "set -e" out
of XVFB_START, since it's the GTESTER invokation that needs this.
majorly speed up execution by reducing timeouts and converting main loop
2007-12-06 10:44:52 Tim Janik <timj@imendio.com>
* tests/autotestfilechooser.c: majorly speed up execution by reducing
timeouts and converting main loop sleeps to pending/iterate loops with
very low priority async handlers. eliminate output for non-verbose
tests. assert successfull subtests in all test functions. use testing
framework in main().
* tests/Makefile.am: add autotestfilechooser to TEST_PROGS, so it's
executed inside Xvfb upon make check.
run tests in current dir after setting up the logging directory, so their
2007-12-05 18:59:59 Tim Janik <timj@imendio.com>
* gtk+/Makefile.decl: run tests in current dir after setting up the
logging directory, so their results get properly merged into the
resulting test log.
* gtk+/gtk/gtktestutils.[hc]: added gtk_test_list_all_types() for
tests to loop over registered Gdk/Gtk+ types.
* gtk+/tests/objecttests.c: new test program, implements automated
property tests. several properties are blacklisted because they
seem to trigger Gdk/Gtk+ bugs. ./objecttests -m thorough --verbose
can be used to test blacklisted properties and see which proprty failed.
Richard Hult [Mon, 3 Dec 2007 19:51:20 +0000 (19:51 +0000)]
Don't crash when dragging from a source that doesn't support uri lists
2007-12-03 Richard Hult <richard@imendio.com>
* gtk/gtkquartz.c: (_gtk_quartz_set_selection_data_for_pasteboard):
Don't crash when dragging from a source that doesn't support uri
lists (bug #499868, Paul Davis).
Richard Hult [Mon, 3 Dec 2007 19:34:30 +0000 (19:34 +0000)]
Don't crash when a parent relative bg pixmap is set, and no parent has a
2007-12-03 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkwindow-quartz.c:
(gdk_window_impl_quartz_begin_paint_region): Don't crash when a
parent relative bg pixmap is set, and no parent has a bg
pixmap. Fixes bug #500804.
Matthias Clasen [Mon, 3 Dec 2007 17:44:27 +0000 (17:44 +0000)]
Two optimizations for icon cache lookups.
2007-12-03 Matthias Clasen <mclasen@redhat.com>
Two optimizations for icon cache lookups.
* gtk/gtkiconcache.[hc]:
* gtk/gtkicontheme.c: Remember the directory index for
subdirectories, instead of running over the directory list
again and again.
* gtk/gtkiconcache.c (find_image_offset): Remember the last
chain and try it first; this helps with the the usage patterns
in gtkicontheme.c, where the same icon is queried for a lot
of subdirectories.
use 'grep -o' to extract _get_type functions from header files. this
2007-12-03 15:18:17 Tim Janik <timj@imendio.com>
* gtk/Makefile.am (gtktypefuncs.c): use 'grep -o' to extract _get_type
functions from header files. this should be portable across linux and
Mac OS, unlike the previpous sed expression.
Cody Russell [Sat, 1 Dec 2007 22:08:19 +0000 (22:08 +0000)]
[Win32]: On Windows, queue a redraw of child2 whenever we set the pane
2007-12-1 Cody Russell <bratsche@gnome.org>
* gtk/gtkpaned.c: (gtk_paned_set_position) [Win32]:
On Windows, queue a redraw of child2 whenever we set
the pane handle position. This is unfortunately kind
of hacky, but solves the visual artifacts that were
occuring on at least certain types of child widgets
(e.g., text views and tree views) that are inside
horizontal or vertical panes. (#144269)
Tor Lillqvist [Wed, 28 Nov 2007 01:06:07 +0000 (01:06 +0000)]
A proper build of GNU libintl is supposed to export the variable
2007-11-28 Tor Lillqvist <tml@novell.com>
A proper build of GNU libintl is supposed to export the variable
_nl_msg_cat_cntr. configure looks for that variable in order to
recognize GNU gettext. If it sees that it is indeed GNU gettext
that is used, it decides to install message catalogs in
share/locale, otherwise in lib/locale. Until now on Windows I have
built GTK+ against a build of GNU gettext that did not export
_nl_msg_cat_cntr. But this will change, so we can't assume message
catalogs are always in lib/locale.
* gtk/gtkmain.c: (_gtk_get_localedir) [Win32]: Rework to handle
GTK_LOCALEDIR being either in "lib" or "share". Move the function
before the inclusion of gtkprivate.h so that it sees the original
GTK_LOCALEDIR.
* gtk-zip.sh.in: Check whether the message catalogs are in
share/locale or lib/locale.
Tor Lillqvist [Tue, 27 Nov 2007 22:48:32 +0000 (22:48 +0000)]
Remove fuzzy marker for the metadata entry (the first one, for the string
2007-11-28 Tor Lillqvist <tml@novell.com>
* io.po: Remove fuzzy marker for the metadata entry (the first
one, for the string ""), as having that fuzzy crashes msgfmt from
gettext 0.17, at least for me.
Tor Lillqvist [Tue, 27 Nov 2007 22:29:46 +0000 (22:29 +0000)]
Fix #375893, patch by Ben Hague:
2007-11-28 Tor Lillqvist <tml@novell.com>
Fix #375893, patch by Ben Hague:
* gtk/gtkfilesystemwin32.c (get_viewable_logical_drives): Wrapper
around GetLogicalDrives() that takes also the viewable drive
restrictions in the Registry (which are usually the result of an
Active Directory Group Policy) into account.
(check_volumes, gtk_file_system_win32_list_volumes) Call
get_viewable_logical_drives() instead of GetLogicalDrives().
Ryan Lortie [Tue, 27 Nov 2007 03:25:09 +0000 (03:25 +0000)]
add clarification stating that the construct_child function is responsible
2006-11-26 Ryan Lortie <desrt@desrt.ca>
* docs/reference/gtk/tmpl/gtkbuildable.sgml: add clarification stating
that the construct_child function is responsible for returning a
reference.
* gtkbuilder.c (_gtk_builder_construct): remove g_object_ref() for
objects from constructors
* gtkuimanager.c (gtk_ui_manager_buildable_construct_child): add
g_object_ref() to this construction function (it's the only
implementer in GTK)
Josselin Mouette [Mon, 26 Nov 2007 23:16:19 +0000 (23:16 +0000)]
reviewed by: Federico Mena Quintero
2007-11-26 Josselin Mouette <joss@malsain.org>
reviewed by: Federico Mena Quintero
* gtk/gtkfilechooserdefault.c: (shortcuts_append_paths),
(shortcuts_add_bookmarks), (shortcuts_selection_changed_cb),
(shortcuts_list_create), (gtk_file_chooser_default_should_respond):
Make the shortcuts activate with a single click. (#148828)
Fix a few things affected by the change:
- Set selection mode to GTK_SELECTION_SINGLE to allow a case
where no shortcut is selected.
- Don't activate a shortcut in the response callback.
- Filter out duplicate entries in volumes and bookmarks to
avoid the selection to change when reordering them with DnD.
projects / ~andy / gtk / log