Benjamin Otte [Wed, 1 Feb 2012 23:14:01 +0000 (00:14 +0100)]
raleigh: remove general 'padding' declaration
Fixes reftests that were broken after images and labels applied padding.
Things look much more cramped now. On the plus side, treeview headers
and comboboxes have better spacing. Menubars look like crap now though.
Needs someone with artistical talent to figure out.
Benjamin Otte [Wed, 1 Feb 2012 23:04:08 +0000 (00:04 +0100)]
raleigh: Don't set bg-color for all widgets
Just set oit for things that need it.
(FIXME: Buttons should probably not need it, but spinbuttons and
treeview headers don't have a proper background without it.)
Cosimo Cecchi [Wed, 1 Feb 2012 18:16:06 +0000 (13:16 -0500)]
app-chooser-dialog: make sure to hold a ref when doing async ops
Hold a ref to the GtkDialog while doing async operations with the
GtkAppChooserOnline object.
This is needed, since somebody could call gtk_widget_destroy() on us
while an async operation is in progress. We don't want to be finalized
in that case, but mark the fact that we were dismissed and just return
from the callback in that case.
This avoids crashing if the dialog is destroyed in the middle of a PK
operation.
Cosimo Cecchi [Tue, 31 Jan 2012 23:54:40 +0000 (18:54 -0500)]
combobox: always trim the allocated area by padding and border for child
When we're size allocating the children widgets, always trim the
allocation for padding and border of GtkComboBox, as that's all the area
they have available.
It was using the wrong padding values for RTL, and generally, using the
same variables in a distant macro makes this method even more
complicated than it already is...
Cosimo Cecchi [Tue, 31 Jan 2012 20:34:00 +0000 (15:34 -0500)]
combobox: move the allocation of the button contents box directly
If we're in menu mode with no children, instead of tweaking the
allocation of the arrow and the separator separately, tweak the
allocation of the box that contain both.
Cosimo Cecchi [Tue, 31 Jan 2012 17:01:53 +0000 (12:01 -0500)]
combobox: remove handling of focus-padding and focus-line-width
GtkComboBox always handles focus through its children, so there's no
need to request and allocate them again.
In fact, Adwaita was forcing these style properties to zero for
GtkComboBox.
Cosimo Cecchi [Mon, 30 Jan 2012 22:26:05 +0000 (17:26 -0500)]
entry: use the CSS margin for the progress margin offset
The progressbar inside GtkEntry has a progress-border style property,
which is actually the margin of the progressbar inside the GtkEntry
allocation.
Use a CSS margin instead of reading the progress-border property.
Cosimo Cecchi [Mon, 30 Jan 2012 21:47:55 +0000 (16:47 -0500)]
entry: use padding on the image area to position the image
Don't assume the padding of the icons is the same padding of the rest of
the entry.
This also allows to set different paddings for left and right icons.
Marek Kasik [Tue, 31 Jan 2012 11:15:43 +0000 (12:15 +0100)]
printing: Don't crash when printing
This commit fixes crash which occurs in Firefox, Thunderbird and Inkscape
during printing. This crash was caused because of wrong handling of Custom
CUPS options. (#543520)
Matthias Clasen [Tue, 31 Jan 2012 01:32:22 +0000 (20:32 -0500)]
Document the gtkbuilder xml file better
Replace the (invalid) DTD in the GtkBuilder docs by a
RELAX NG schema. Also install the schema in /usr/share/gtk-3.0,
so it can be used to validate GtkBuilder ui files.
Will Newton [Thu, 12 Jan 2012 11:14:02 +0000 (11:14 +0000)]
iconcache: Always check return value of find_image_offset.
find_image_offset returns 0 if it failed to find a matching image.
Check this return value in _gtk_icon_cache_get_icon to avoid
making bad memory accesses later.
Signed-off-by: Will Newton <will.newton@imgtec.com>
https://bugzilla.gnome.org/show_bug.cgi?id=667745
Ryan Lortie [Wed, 25 Jan 2012 16:30:11 +0000 (11:30 -0500)]
GtkTimeline: protect the timeline from unref
The timeline frame function emits several signals, assuming that the
timeline will exist after these signals return. This assumption can be
invalid if signal handlers unref the timeline.
Matthias Clasen [Wed, 25 Jan 2012 23:21:47 +0000 (18:21 -0500)]
GtkAboutDialog: Make credits section extensible
This commit adds API that allows to add new named sections
to the Credits part of GtkAboutDialog, in addition to the
hardcoded sections for authors, documenters, artists and
translators.
When calling gtk_window_present(), gdk_win32_window_raise did not
actually raise the window anymore. Replacing BringWindowToTop() with
SetForegroundWindow() fixes this.
During testing, we also discovered that sometimes SetForeGroundWindow()
will (correctly) refuse to raise the window and fail(for example: sometimes
when dragging a different application at the time of a gtk_window_present()
call). To prevent a GdkWarning from being produced, usage of the API_CALL
macro has been removed for this case.
Additional goodies of SetForeGroundWindow:
- it brings the window to the front when the process owning the
window to raise is the foreground process (for example when
gtk_window_present is called from a GtkStatusIcon's activate
signal handler)
- it limits itself to flashing the task bar button associated
with the window if the process owning the window to raise
is *not* the foreground process (for example when gtk_window_present
is called from a g_timeout_add callback function)