* gtk/gtkliststore.[ch] (gtk_list_store_set_vector_internal): new
function, factored out code iterating (columns, values) vectors from
gtk_list_store_new_with_valuesv to here,
(gtk_list_store_set_valuesv): new public function to set list store
values using (columns, values) vectors,
(gtk_list_store_new_with_valuesv): call new _set_vector_internal
instead.
Cody Russell [Mon, 4 Jun 2007 18:57:55 +0000 (18:57 +0000)]
gtk/gtklinkbutton.h Change function argument "link" to "link_" to fix
2007-06-04 Cody Russell <bratsche@gnome.org>
* gtk/gtklinkbutton.h
* gtk/gtkaboutdialog.h: Change function argument "link"
to "link_" to fix warnings for applications compiling
with -Wshadow. (#379213)
Cody Russell [Mon, 4 Jun 2007 18:17:14 +0000 (18:17 +0000)]
Check if down_button is NULL. This happens when the pathbar button for the
2007-06-04 Cody Russell <bratsche@gnome.org>
* gtk/gtkpathbar.c (gtk_path_bar_scroll_down): Check
if down_button is NULL. This happens when the pathbar button
for the current directory is too large to fit in the
space, e.g. on Windows for directories named something like
"My Documents and Settings".
Move "move-focus" signals from several widgets to GtkWidget to enable more
2007-06-04 Michael Natterer <mitch@imendio.com>
Move "move-focus" signals from several widgets to GtkWidget to
enable more flexible costomization of keyboard navigation via
bindings. Fixes bug #414947.
* gtk/gtkwidget.c: add "move-focus" binding signal, default to
calling the toplevel GtkWindow's "move-focus" vfunc.
* gtk/gtktextview.[ch]
* gtk/gtkwindow.[ch]: remove "move-focus" signals and add compat
code that makes sure that both emitting the signal on the widget
and overriding the virtual functions keeps working as before.
* gtk/gtktoolbar.c: remove "move-focus" signal here too and use
GtkWidget's signal. This change slightly changes keyboard
navigation in toolbars. I'll fix the behavior if somebody can
explain me if and how exactly the new behavior is broken.
Matthias Clasen [Mon, 4 Jun 2007 14:39:56 +0000 (14:39 +0000)]
Add a create-window signal that allows to override the global
2007-06-04 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkmarshalers.list:
* gtk/gtknotebook.[hc]: Add a create-window signal that allows
to override the global create-window-hook on a per-notebook
basis. The default handler falls back to the global hook.
(#386935, Christian Hammond)
Emmanuele Bassi [Sun, 3 Jun 2007 23:39:43 +0000 (23:39 +0000)]
Add gtk_radio_button_set_value(), gtk_radio_button_get_current_value() and
2007-06-04 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkradiobutton.h:
* gtk/gtkradiobutton.c:
* gtk/gtk.symbols: Add gtk_radio_button_set_value(),
gtk_radio_button_get_current_value() and gtk_radio_button_get_value().
Use these functions to set and get an arbitrary integer associated to
a GtkRadioButton in a group, like the value associated to a
GtkRadioAction.
* tests/testgtk.c:
(create_radio_buttons), (radio_toggled_cb): Exercise the new API.
Initialize unthemed_icon to NULL to avoid accessing uninitialized memory
* gtk/gtkicontheme.c (choose_icon): Initialize unthemed_icon to NULL
to avoid accessing uninitialized memory when
gtk_icon_theme_choose_icon() is called with an empty names list.
Richard Hult [Sun, 3 Jun 2007 18:48:47 +0000 (18:48 +0000)]
Make pointer grab emulation work a bit better:
2007-06-03 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkevents-quartz.c: Make pointer grab emulation work a bit
better:
(gdk_display_pointer_is_grabbed): Do what the docs say and don't
consider implicit grabs here.
(gdk_pointer_grab): Overriding a grab by the same app should always be
succesful.
(gdk_event_translate): Implicit grabs should not be owner events.
Richard Hult [Fri, 1 Jun 2007 21:46:45 +0000 (21:46 +0000)]
Fix the coordinates in crossing events so they are relative to the right
2007-06-01 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkevents-quartz.c:
(get_converted_window_coordinates), (create_crossing_event): Fix the
coordinates in crossing events so they are relative to the right
window.
don't switch submenu opening direction for overlapping reasons if there is
2007-06-01 Michael Natterer <mitch@imendio.com>
* gtk/gtkmenuitem.c (gtk_menu_item_position_menu): don't switch
submenu opening direction for overlapping reasons if there is even
less space on the other side (bug #441863, Tommi Komulainen).
Yevgen Muntyan [Fri, 1 Jun 2007 06:25:43 +0000 (06:25 +0000)]
Avoid recreating pangolayouts in GtkTextView on cursor movement (#435405,
2007-06-01 Yevgen Muntyan <muntyan@tamu.edu>
Avoid recreating pangolayouts in GtkTextView on cursor movement
(#435405, Behdad Esfahbod).
* gtk/gtktextlayout.c:
* gtk/gtktextlayout.h: new GtkTextLayout method invalidate_cursors(),
and functions gtk_text_layout_invalidate_cursors() and
gtk_text_layout_cursors_changed(), to use when invalidation is due
to moved marks or changed selection.
* gtk/gtktextbtree.c:
* gtk/gtktextbtree.h: use what's appropriate when invalidating layout.
* gtk/gtk.symbols: add new functions.
* README.in: added a note about changed GtkTextLayout API.
Yevgen Muntyan [Fri, 1 Jun 2007 05:02:05 +0000 (05:02 +0000)]
use text colors from widget style to draw cursor instead of hardcoded
2007-05-31 Yevgen Muntyan <muntyan@tamu.edu>
* gtk/gtkstyle.c (get_insertion_cursor_gc): use text colors from
widget style to draw cursor instead of hardcoded black and grey
(#79585, comment #30).
Tor Lillqvist [Wed, 30 May 2007 15:44:28 +0000 (15:44 +0000)]
Subtract the multi-monitor offset from x and y before setting up the
2007-05-30 Tor Lillqvist <tml@novell.com>
* gdk/win32/gdkevents-win32.c (gdk_pointer_grab): Subtract the
multi-monitor offset from x and y before setting up the rectangle
for ClipCursor(). Fixes #442326.
Emmanuele Bassi [Wed, 30 May 2007 12:27:47 +0000 (12:27 +0000)]
Fix to update the file chooser entry
Return after setting the file chooser entry instead of falling through. Also
remove the handling for the search and recent files operation modes, since
they don't have a location entry to update.
Richard Hult [Mon, 28 May 2007 21:11:55 +0000 (21:11 +0000)]
Break out code that was repeated into separate functions and call them
2007-05-28 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkevents-quartz.c (get_child_coordinates_from_ancestor)
(get_ancestor_coordinates_from_child): Break out code that was
repeated into separate functions and call them instead.
(find_window_for_mouse_nsevent): Break out this from
find_window_for_nsevent to make the code clearer.
(find_window_for_nsevent): Use the above and fix the returned
coordinates in the process so that they are always relative the
found window, both for the normal case and during grabs. Still
needs fixing for the case where we get nsevents for a window other
than than grab window during grabs.
Richard Hult [Mon, 28 May 2007 20:51:11 +0000 (20:51 +0000)]
Reset all the grab state, to help debugging. (gdk_event_translate): Use
2007-05-28 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkevents-quartz.c (pointer_ungrab_internal): Reset
all the grab state, to help debugging.
(gdk_event_translate): Use pointer_ungrab_internal instead of
duplicating the code here.
Richard Hult [Mon, 28 May 2007 20:42:51 +0000 (20:42 +0000)]
Refactored version of _gdk_quartz_window_find_child_by_point, that doesn't
2007-05-28 Richard Hult <richard@imendio.com>
* gdk/quartz/gdkprivate-quartz.h:
* gdk/quartz/gdkwindow-quartz.c (find_child_window_helper)
(_gdk_quartz_window_find_child): Refactored version of
_gdk_quartz_window_find_child_by_point, that doesn't return any
coordinates as the users of this function already have the
coordinates and need to translate them differently.
(_gdk_windowing_window_get_pointer): Fixup coordinate translation.
(_gdk_windowing_window_at_pointer): Likewise.
Tor Lillqvist [Sun, 27 May 2007 18:45:09 +0000 (18:45 +0000)]
Drop bogus -user32 switch. Was supposed to be -luser32, but he "l" was
2007-05-27 Tor Lillqvist <tml@novell.com>
* configure.in (GDK_EXTRA_LISB): Drop bogus -user32 switch. Was
supposed to be -luser32, but he "l" was missing. But nobody has
noticed, so presumably unnecessary.
Matthias Clasen [Sat, 26 May 2007 06:59:36 +0000 (06:59 +0000)]
Require gtk-doc 1.6, for signal and property links.
2007-05-26 Matthias Clasen <mclasen@redhat.com>
* configure.in: Require gtk-doc 1.6, for signal and property links.
* gtk/gtkbox.c:
* gtk/gtkbutton.c:
* gtk/gtkcontainer.c:
* gtk/gtkdialog.c:
* gtk/gtkentry.c:
* gtk/gtkimage.c:
* gtk/gtklabel.c:
* gtk/gtkmisc.c:
* gtk/gtksettings.c:
* gtk/gtkwidget.c: Documentation improvements, link signals
and properties where it makes sense.