]> Pileus Git - ~andy/gtk/log
~andy/gtk
12 years agodocs: fix building for libgail-util
Rico Tzschichholz [Thu, 7 Jul 2011 07:05:19 +0000 (09:05 +0200)]
docs: fix building for libgail-util

12 years agoasd
Javier Jardón [Wed, 6 Jul 2011 16:08:34 +0000 (17:08 +0100)]
asd

12 years agoDrop gail_misc_buffer_get_run_attributes
Matthias Clasen [Thu, 7 Jul 2011 03:19:40 +0000 (23:19 -0400)]
Drop gail_misc_buffer_get_run_attributes

Instead fold the code into the sole caller and get rid
of gailmisc usage in the text view accessible altogether.

12 years agoDrop an unneeded include
Matthias Clasen [Thu, 7 Jul 2011 03:18:52 +0000 (23:18 -0400)]
Drop an unneeded include

One step close to dropping gailmisc.

12 years agogtkpango: Count letters properly
Benjamin Otte [Thu, 7 Jul 2011 01:37:52 +0000 (03:37 +0200)]
gtkpango: Count letters properly

The code was using the wrong variable and that then caused assertions

12 years agoa11y: Make submenu code handle non-existing submenus
Benjamin Otte [Wed, 6 Jul 2011 18:55:11 +0000 (20:55 +0200)]
a11y: Make submenu code handle non-existing submenus

As we're going to merge the two accessibles for submenus, we need to
make sure the code that insisted on submenus can handle the case where
no submenu exists.

12 years agoa11y: Fix leaking of state sets
Benjamin Otte [Wed, 6 Jul 2011 18:48:35 +0000 (20:48 +0200)]
a11y: Fix leaking of state sets

12 years agostyleproperty: Fix leak
Benjamin Otte [Wed, 6 Jul 2011 18:41:31 +0000 (20:41 +0200)]
styleproperty: Fix leak

12 years agomenuitems: Use submenuitem accessible exclusively
Benjamin Otte [Wed, 6 Jul 2011 16:43:07 +0000 (18:43 +0200)]
menuitems: Use submenuitem accessible exclusively

Submenus can come and go, so we cannot use an accessible that doesn't
allow for that.

Also, this fixes a rather large refleak.

12 years agoassistant: Use gtk_widget_class_set_accessible_type()
Benjamin Otte [Wed, 6 Jul 2011 16:34:50 +0000 (18:34 +0200)]
assistant: Use gtk_widget_class_set_accessible_type()

Less code and no leaks!

12 years agoUse AM_CPPFLAGS instead the obsolete INCLUDES
Javier Jardón [Mon, 16 May 2011 11:47:17 +0000 (12:47 +0100)]
Use AM_CPPFLAGS instead the obsolete INCLUDES

12 years agoa11y: Redo TextView cursor/selection signal handling
Benjamin Otte [Tue, 5 Jul 2011 21:43:07 +0000 (23:43 +0200)]
a11y: Redo TextView cursor/selection signal handling

As part of the removal of idles, redo how we emit signals on the
accessible. Should work as good or better than before, but with a lot
less code.

12 years agotests: Update text test for textview
Benjamin Otte [Tue, 5 Jul 2011 21:34:13 +0000 (23:34 +0200)]
tests: Update text test for textview

1) Allow inserting text to move the cursor to after the inserted text
2) Implement selecting text for GtkTextView. Also assert if it's an
   unsupported widget type.
3) Select an inside part of the widget, not the end.

12 years agomodules: Blacklist gail
Benjamin Otte [Tue, 5 Jul 2011 20:33:22 +0000 (22:33 +0200)]
modules: Blacklist gail

And print a message when somebody has it enabled that indicates that
something is wrong but doesn't sound too scary.

12 years agoa11y: Use the canonical way to connect to signals
Benjamin Otte [Tue, 5 Jul 2011 15:34:55 +0000 (17:34 +0200)]
a11y: Use the canonical way to connect to signals

No functional changes at all, the generated code should in fact be
identical.

12 years agoa11y: Simplify code
Benjamin Otte [Tue, 5 Jul 2011 15:31:00 +0000 (17:31 +0200)]
a11y: Simplify code

12 years agoa11y: Remove idle handler for switch action handling
Benjamin Otte [Tue, 5 Jul 2011 12:39:12 +0000 (14:39 +0200)]
a11y: Remove idle handler for switch action handling

12 years agoa11y: Remove set_description handling from GtkSwitch
Benjamin Otte [Tue, 5 Jul 2011 12:36:39 +0000 (14:36 +0200)]
a11y: Remove set_description handling from GtkSwitch

The function is unused in AT-SPI.

12 years agorange: Do not use idles to trigger actions
Benjamin Otte [Tue, 5 Jul 2011 12:34:10 +0000 (14:34 +0200)]
range: Do not use idles to trigger actions

12 years agoa11y: Don't use an idle handler for entry actions
Benjamin Otte [Tue, 5 Jul 2011 12:30:49 +0000 (14:30 +0200)]
a11y: Don't use an idle handler for entry actions

12 years agoFix two typos in Makefiles
Rico Tzschichholz [Wed, 6 Jul 2011 14:24:46 +0000 (16:24 +0200)]
Fix two typos in Makefiles

12 years agogtktreeviewaccessible: free the string in the correct position
Javier Jardon [Wed, 6 Jul 2011 13:36:29 +0000 (14:36 +0100)]
gtktreeviewaccessible: free the string in the correct position

12 years agoDo not initialize the priv pointer before check type
Javier Jardon [Wed, 6 Jul 2011 13:25:06 +0000 (14:25 +0100)]
Do not initialize the priv pointer before check type

12 years agoFix few typos in the migration docs
Javier Jardon [Wed, 6 Jul 2011 10:59:56 +0000 (11:59 +0100)]
Fix few typos in the migration docs

gdk_pixbuf_get_from_surface() don't take 8 args but 5

12 years agoFix the build
Matthias Clasen [Tue, 5 Jul 2011 20:57:46 +0000 (16:57 -0400)]
Fix the build

I didn't pay enough attention when merging, it seems.

12 years agoUpdate assistant tests
Matthias Clasen [Tue, 5 Jul 2011 11:19:38 +0000 (07:19 -0400)]
Update assistant tests

12 years agoDrop the factory from the icon view accessible
Matthias Clasen [Mon, 4 Jul 2011 01:46:50 +0000 (21:46 -0400)]
Drop the factory from the icon view accessible

12 years agoDrop the factory from GtkAssistantAccessible
Matthias Clasen [Mon, 4 Jul 2011 01:34:54 +0000 (21:34 -0400)]
Drop the factory from GtkAssistantAccessible

12 years agoUpdate expected test output
Matthias Clasen [Sun, 3 Jul 2011 20:53:41 +0000 (16:53 -0400)]
Update expected test output

The recent change to notebook page parent handling is showing
up in the output of the notebook.ui test.

12 years agoGtkSeparatorMenuItem: Drop the accessible factory
Matthias Clasen [Sun, 3 Jul 2011 20:24:55 +0000 (16:24 -0400)]
GtkSeparatorMenuItem: Drop the accessible factory

12 years agoAdd api for setting the layer
Matthias Clasen [Sun, 3 Jul 2011 19:34:06 +0000 (15:34 -0400)]
Add api for setting the layer

Add api for setting the component layer, instead of open-coding
the object data key, and use it.

12 years agoSilence compiler warnings
Matthias Clasen [Sun, 3 Jul 2011 19:33:27 +0000 (15:33 -0400)]
Silence compiler warnings

12 years agoSet accessible parents of notebook children
Matthias Clasen [Sun, 3 Jul 2011 19:06:44 +0000 (15:06 -0400)]
Set accessible parents of notebook children

Explicitly set the notebook page object as the accessible parent
of the page, otherwise, AtkObject follows the widget parents chain
and makes the notebook accessible the parent.

12 years agoVerify that notify::accessible parent is emitted
Matthias Clasen [Sun, 3 Jul 2011 19:06:11 +0000 (15:06 -0400)]
Verify that notify::accessible parent is emitted

12 years agoDrop use of factories for cell accessibles
Matthias Clasen [Sun, 3 Jul 2011 16:40:40 +0000 (12:40 -0400)]
Drop use of factories for cell accessibles

12 years agoAdd an initial focus handling test
Matthias Clasen [Sun, 3 Jul 2011 16:16:43 +0000 (12:16 -0400)]
Add an initial focus handling test

This is failing currently, since focus handling is all
in defer-to-idle country.

12 years agoChange the toolkit name in GailUtil to 'gtk', too
Matthias Clasen [Sun, 3 Jul 2011 03:49:28 +0000 (23:49 -0400)]
Change the toolkit name in GailUtil to 'gtk', too

12 years agoChange the toolkit attribute from gail to gtk
Matthias Clasen [Sat, 2 Jul 2011 22:44:12 +0000 (18:44 -0400)]
Change the toolkit attribute from gail to gtk

Update test results to match.

12 years agoMove GtkSwitchAccessible to a11y/
Matthias Clasen [Sat, 2 Jul 2011 22:46:04 +0000 (18:46 -0400)]
Move GtkSwitchAccessible to a11y/

12 years agoMove GtkSpinnerAccessible to a11y/
Matthias Clasen [Sat, 2 Jul 2011 19:48:55 +0000 (15:48 -0400)]
Move GtkSpinnerAccessible to a11y/

12 years agoDrop the atk_component_add/remove_focus_handler implementation
Matthias Clasen [Sat, 2 Jul 2011 19:33:32 +0000 (15:33 -0400)]
Drop the atk_component_add/remove_focus_handler implementation

Instead, just connect to focus-event directly.

12 years agoInitial conversion of GailWidget to GtkWidgetAccessible
Matthias Clasen [Sat, 2 Jul 2011 19:23:52 +0000 (15:23 -0400)]
Initial conversion of GailWidget to GtkWidgetAccessible

12 years agoConvert GailContainer to GtkContainerAccessible
Matthias Clasen [Sat, 2 Jul 2011 03:29:06 +0000 (23:29 -0400)]
Convert GailContainer to GtkContainerAccessible

12 years agoConvert GailMenuShell to GtkMenuShellAccessible
Matthias Clasen [Sat, 2 Jul 2011 02:42:25 +0000 (22:42 -0400)]
Convert GailMenuShell to GtkMenuShellAccessible

12 years agoConvert GailMenu to GtkMenuAccessible
Matthias Clasen [Sat, 2 Jul 2011 02:30:54 +0000 (22:30 -0400)]
Convert GailMenu to GtkMenuAccessible

12 years agoConvert GailWindow to GtkWindowAccessible
Matthias Clasen [Sat, 2 Jul 2011 02:10:27 +0000 (22:10 -0400)]
Convert GailWindow to GtkWindowAccessible

While doing this, drop the get_mdi_zorder implementation
that really should come from the window manager side. Dropping
this saves some 500 lines.

12 years agoConvert GailButton to GtkButtonAccessible
Matthias Clasen [Sat, 2 Jul 2011 01:25:53 +0000 (21:25 -0400)]
Convert GailButton to GtkButtonAccessible

This drops the AtkText implementation, and also strips handling
of children out. Instead of listening for enter/leave/press/released,
just listen for state changes on the widget.

12 years agoDrop unneeded includes of gdkkeysyms.h
Matthias Clasen [Fri, 1 Jul 2011 21:08:30 +0000 (17:08 -0400)]
Drop unneeded includes of gdkkeysyms.h

Just a minor cleanup; gtk.h includes this header in GTK+ 3.

12 years agoDrop unneeded includes gailtextutil.h
Matthias Clasen [Fri, 1 Jul 2011 21:05:43 +0000 (17:05 -0400)]
Drop unneeded includes gailtextutil.h

Almost done with getting rid of GailTextUtil.

12 years agoConvert Gail(Sub)MenuItem to GtkAccessible classes
Matthias Clasen [Fri, 1 Jul 2011 20:59:46 +0000 (16:59 -0400)]
Convert Gail(Sub)MenuItem to GtkAccessible classes

This is along the same lines as the previous commit,
with the same caveat.

12 years agoConvert GailCheck(Sub)MenuItem to GtkAccessible classes
Matthias Clasen [Fri, 1 Jul 2011 16:38:39 +0000 (12:38 -0400)]
Convert GailCheck(Sub)MenuItem to GtkAccessible classes

This is along the same lines as the previous commit,
with the same caveat.

12 years agoConvert GailRadio(Sub)MenuItem to GtkAccessible classes
Matthias Clasen [Fri, 1 Jul 2011 15:41:45 +0000 (11:41 -0400)]
Convert GailRadio(Sub)MenuItem to GtkAccessible classes

The way submenus are handled here isn't really right, since
they can come and go at runtime, but I've left it like this
for now. A side-effect is that we can't use
gtk_widget_class_set_accessible_type here, but have to
override get_accessible.

12 years agoAdd a test for menus
Matthias Clasen [Fri, 1 Jul 2011 23:18:18 +0000 (19:18 -0400)]
Add a test for menus

12 years agoConvert GailExpander to GtkExpanderAccessible
Matthias Clasen [Fri, 1 Jul 2011 14:15:36 +0000 (10:15 -0400)]
Convert GailExpander to GtkExpanderAccessible

At the same time, drop the AtkText implementation.
Also, reintroduce a GtkBoxAccessible, since the previous
way of setting the role in get_accessible was affecting
GtkBox subclasses negatively.

Adjust expected test output to match.

12 years agoAdd a placeholder-text test
Matthias Clasen [Fri, 1 Jul 2011 04:51:56 +0000 (00:51 -0400)]
Add a placeholder-text test

Contributed by Joanmarie Diggs.

12 years agoConvert GailStatusbar to GtkStatusbarAccessible
Matthias Clasen [Fri, 1 Jul 2011 04:47:41 +0000 (00:47 -0400)]
Convert GailStatusbar to GtkStatusbarAccessible

And drop the AtkText implementation at the same time.
Update test results to match.

12 years agoConvert GailNotebookPage to GtkNotebookPageAccessible
Matthias Clasen [Fri, 1 Jul 2011 04:10:39 +0000 (00:10 -0400)]
Convert GailNotebookPage to GtkNotebookPageAccessible

At the same time, drop the AtkText implementation, and simplify
accordingly. Test output has been updated to match.

12 years agoDon't overwrite roles
Matthias Clasen [Fri, 1 Jul 2011 04:48:25 +0000 (00:48 -0400)]
Don't overwrite roles

Otherwise, every GtkBox subclass will have to override
get_accessible just to keep their roles.

12 years agoAvoid excessive child_changed::added emissions
Matthias Clasen [Fri, 1 Jul 2011 02:12:31 +0000 (22:12 -0400)]
Avoid excessive child_changed::added emissions

We are listening to page-added and emit child_changed::added
in response to that, so don't let the add_gtk handler add
extraneous extra signal emissions. This fixes the child-handling
test for GtkNotebook.

12 years agoConvert GailNotebook to GtkNotebookAccessible
Matthias Clasen [Fri, 1 Jul 2011 02:11:13 +0000 (22:11 -0400)]
Convert GailNotebook to GtkNotebookAccessible

12 years agoConvert GailTreeView to GtkTreeViewAccessible
Matthias Clasen [Thu, 30 Jun 2011 00:50:50 +0000 (20:50 -0400)]
Convert GailTreeView to GtkTreeViewAccessible

Mostly code rearrangement and cleanup, but also a memory
leak fix in gtk_tree_view_accessible_get_column_description().

12 years agoAdd more children tests
Matthias Clasen [Thu, 30 Jun 2011 02:22:19 +0000 (22:22 -0400)]
Add more children tests

12 years agoConvert GailComboBox to GtkComboBoxAccessible
Matthias Clasen [Wed, 29 Jun 2011 21:31:09 +0000 (17:31 -0400)]
Convert GailComboBox to GtkComboBoxAccessible

12 years agotests: Don't print selection count
Benjamin Otte [Wed, 29 Jun 2011 16:16:23 +0000 (18:16 +0200)]
tests: Don't print selection count

Selection count is tested via assertions and can be inferred from
looking at the number of selected children.

And I'd like to reduce the output of the tests. We're outputting way too
much anyway.

12 years agotests: Make accessibility-dump output selected children by name
Benjamin Otte [Wed, 29 Jun 2011 16:11:07 +0000 (18:11 +0200)]
tests: Make accessibility-dump output selected children by name

And put one child in every row to make diffing easier.

12 years agotests: Fix compiler warnings
Benjamin Otte [Wed, 29 Jun 2011 16:00:37 +0000 (18:00 +0200)]
tests: Fix compiler warnings

12 years agotests: Add assert to accessibility-dump
Benjamin Otte [Wed, 29 Jun 2011 15:34:50 +0000 (17:34 +0200)]
tests: Add assert to accessibility-dump

Check that number of selected children == number of children that
actually are selected. If that's not the case, assert, to avoid people
being careless about adding tests.

12 years agoSilence compiler warnings
Matthias Clasen [Wed, 29 Jun 2011 15:52:12 +0000 (11:52 -0400)]
Silence compiler warnings

12 years agoa11y: Make notebookpage emit child-added signal sync
Benjamin Otte [Wed, 29 Jun 2011 00:15:18 +0000 (02:15 +0200)]
a11y: Make notebookpage emit child-added signal sync

Don't use an idle handler

12 years agoa11y: Keep the gail notebook in the notebook page
Benjamin Otte [Wed, 29 Jun 2011 14:17:07 +0000 (16:17 +0200)]
a11y: Keep the gail notebook in the notebook page

We used to keep the GtkNotebook, but that causes issues at creation time
of the GailNotebook, when the GtkNotebook does not yet have an
accessible set and so it can't be queried.

12 years agoa11y: Redo notebook page management
Benjamin Otte [Wed, 29 Jun 2011 13:23:06 +0000 (15:23 +0200)]
a11y: Redo notebook page management

Previously, the code tried to track the indexes of the pages and keep
them up to date in a list and tracking the index in the
GtkNotebookPage. Now, we store the widget we are tracking in the
GailNotebookPage and keep a hash table of widget=>GailNotebookPage in the
GailNotebook. This frees us from the burden of tracking page changes.

12 years agoa11y: Redo notebok page lifetime management
Benjamin Otte [Wed, 29 Jun 2011 12:42:16 +0000 (14:42 +0200)]
a11y: Redo notebok page lifetime management

It is now done by the GailNotebook. Previously it tried to do it itself.
Also, we now use GtkNotebook::page-removed to track the removal, as
opposed to child::parent-set.

12 years agoa11y: Remove idle handler from menuitem action
Benjamin Otte [Wed, 29 Jun 2011 00:10:28 +0000 (02:10 +0200)]
a11y: Remove idle handler from menuitem action

12 years agoa11y: Remove idle handler for expander actions
Benjamin Otte [Tue, 28 Jun 2011 18:03:35 +0000 (20:03 +0200)]
a11y: Remove idle handler for expander actions

12 years agoa11y: Remove idle handler for combo box action
Benjamin Otte [Tue, 28 Jun 2011 18:02:06 +0000 (20:02 +0200)]
a11y: Remove idle handler for combo box action

12 years agoa11y: Remove idle handler from GailButton
Benjamin Otte [Tue, 28 Jun 2011 17:26:10 +0000 (19:26 +0200)]
a11y: Remove idle handler from GailButton

12 years agoa11y: Use gtk_button_clicked() to click a button.
Benjamin Otte [Tue, 28 Jun 2011 17:21:19 +0000 (19:21 +0200)]
a11y: Use gtk_button_clicked() to click a button.

Don't fiddle with events.

12 years agoa11y: Remove "press" and "release" actions from buttons
Benjamin Otte [Tue, 28 Jun 2011 17:13:43 +0000 (19:13 +0200)]
a11y: Remove "press" and "release" actions from buttons

http://mail.gnome.org/archives/gnome-accessibility-devel/2011-June/msg00020.html
has some details about this.
The main problem is that the internal button states get fiddled with and
that is not a good idea to do from an AT.

Also update tests to reflect that.

12 years agoa11y: Do actions on cells immediately
Benjamin Otte [Tue, 28 Jun 2011 16:34:50 +0000 (18:34 +0200)]
a11y: Do actions on cells immediately

No idle handlers, please.

12 years agoa11y: Use simple code for window name change tracking
Benjamin Otte [Tue, 28 Jun 2011 16:31:32 +0000 (18:31 +0200)]
a11y: Use simple code for window name change tracking

Remove idle handler and omit checking if the name really was changed.
ATs will either have to live with the name not really changoing or we
should check in GtkWindow.

12 years agoAdd more child-handling related tests
Matthias Clasen [Wed, 29 Jun 2011 04:35:24 +0000 (00:35 -0400)]
Add more child-handling related tests

12 years agoEmit the same changed_children details as everybody else
Matthias Clasen [Wed, 29 Jun 2011 03:58:31 +0000 (23:58 -0400)]
Emit the same changed_children details as everybody else

...if any of this was documented...

12 years agoDrop gail-private-macros.h
Matthias Clasen [Wed, 29 Jun 2011 03:42:50 +0000 (23:42 -0400)]
Drop gail-private-macros.h

Nothing like obfuscating an early return behind a macro.

12 years agoAdd a test for scrolled window child count
Matthias Clasen [Wed, 29 Jun 2011 03:24:27 +0000 (23:24 -0400)]
Add a test for scrolled window child count

12 years agoConvert GailScrolledWindow to GtkScrolledWindowAccessible
Matthias Clasen [Wed, 29 Jun 2011 03:13:27 +0000 (23:13 -0400)]
Convert GailScrolledWindow to GtkScrolledWindowAccessible

12 years agoDrop use of gail_return_if_fail
Matthias Clasen [Wed, 29 Jun 2011 02:48:37 +0000 (22:48 -0400)]
Drop use of gail_return_if_fail

12 years agoFix a test crash
Matthias Clasen [Wed, 29 Jun 2011 02:47:21 +0000 (22:47 -0400)]
Fix a test crash

12 years agoRemove old files
Matthias Clasen [Wed, 29 Jun 2011 02:46:40 +0000 (22:46 -0400)]
Remove old files

12 years agoConvert GailScaleButton to GtkScaleButtonAccessible
Matthias Clasen [Wed, 29 Jun 2011 02:45:42 +0000 (22:45 -0400)]
Convert GailScaleButton to GtkScaleButtonAccessible

12 years agoDrop another unused include
Matthias Clasen [Tue, 28 Jun 2011 05:00:00 +0000 (01:00 -0400)]
Drop another unused include

12 years agoConvert GailToggleButton to GtkToggleButtonAccessible
Matthias Clasen [Tue, 28 Jun 2011 04:53:22 +0000 (00:53 -0400)]
Convert GailToggleButton to GtkToggleButtonAccessible

12 years agoNuke GailAdjustment
Matthias Clasen [Tue, 28 Jun 2011 04:39:27 +0000 (00:39 -0400)]
Nuke GailAdjustment

This was a fairly trivial wrapper around GtkAdjustment with
no particularly important reason for existence.

12 years agoGtkAdjustment: add an auxiliary function
Matthias Clasen [Tue, 28 Jun 2011 04:38:20 +0000 (00:38 -0400)]
GtkAdjustment: add an auxiliary function

This is going to be used in AtkValue implementations.

12 years agoDrop an unneeded include
Matthias Clasen [Tue, 28 Jun 2011 03:26:23 +0000 (23:26 -0400)]
Drop an unneeded include

12 years agoConvert GailRadioButton to GtkRadioButtonAccessible
Matthias Clasen [Tue, 28 Jun 2011 03:24:22 +0000 (23:24 -0400)]
Convert GailRadioButton to GtkRadioButtonAccessible

12 years agoGtkLabelAccessible: drop an unneeded include
Matthias Clasen [Tue, 28 Jun 2011 03:00:59 +0000 (23:00 -0400)]
GtkLabelAccessible: drop an unneeded include

We eventually want to get rid of gailmisc, so this is progress.

12 years agoConvert GailPaned to GtkPanedAccessible
Matthias Clasen [Tue, 28 Jun 2011 02:55:54 +0000 (22:55 -0400)]
Convert GailPaned to GtkPanedAccessible

12 years agoConvert GailRange to GtkRangeAccessible
Matthias Clasen [Tue, 28 Jun 2011 02:39:43 +0000 (22:39 -0400)]
Convert GailRange to GtkRangeAccessible

12 years agoGtkTextViewAccessible: get rid of GailTextUtil usage
Matthias Clasen [Mon, 27 Jun 2011 04:52:43 +0000 (00:52 -0400)]
GtkTextViewAccessible: get rid of GailTextUtil usage

Instead, use the newly added GtkTextBuffer functions.

12 years agoGtkTextBuffer: Add accessible api
Matthias Clasen [Mon, 27 Jun 2011 04:51:03 +0000 (00:51 -0400)]
GtkTextBuffer: Add accessible api

These functions match closely to the AtkText interface;
they will be used in the GtkTextView accessible implementation.
Keep them private for now.