Sun Nov 3 21:26:20 2002 Kristian Rietveld <kris@gtk.org>
Bah, and of course I broke something ...
* gtk/gtktreeselection.c (gtk_tree_selection_selected_foreach): fix
up the mess I caused with my commit of Oct 23 fixing #50263, things
should be fine now.
Owen Taylor [Sun, 3 Nov 2002 18:17:53 +0000 (18:17 +0000)]
Remove check for winsock.h since it might show up on Linux+Wine. Instead
Sun Nov 3 13:03:29 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c configure.in: Remove check for
winsock.h since it might show up on Linux+Wine.
Instead just conditionalize of G_OS_WIN32.
(#97396, Gaute Lindkvist)
remove the second ref command on the child_model, we only have to ref it
Sat Nov 2 23:48:52 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreemodelsort.c (gtk_tree_model_sort_set_model): remove
the second ref command on the child_model, we only have to ref it
once here. (#96851, reported by Jorn Baayen).
Owen Taylor [Sat, 2 Nov 2002 18:18:50 +0000 (18:18 +0000)]
Remove rules for generation of version.xml, which was causing make to
Sat Nov 2 12:46:16 2002 Owen Taylor <otaylor@redhat.com>
* gdk-pixbuf/Makefile.am: Remove rules for generation
of version.xml, which was causing make to always
rebuild the HTML file, and didn't seem to be used.
Owen Taylor [Sat, 2 Nov 2002 05:37:04 +0000 (05:37 +0000)]
Add startup notification hooks - mostly based on patch by Havoc Pennington
Sat Nov 2 00:22:33 2002 Owen Taylor <otaylor@redhat.com>
Add startup notification hooks - mostly based on patch
by Havoc Pennington in #96772.
* gdk/gdk.h gdk/x11/gdkdisplay-x11.c
gdk/{win32,linux-fb}/gdkmain-*.c: (gdk_notify_startup_complete):
new function that indicates an application has finished starting
up.
* gdk/x11/gdkmain-x11.c gdk/x11/gdkdisplay-x11.c
(_gdk_windowing_set_default_display): store value of
DESKTOP_STARTUP_ID on the default screen, and clear it from the
environment.
* gdk/x11/gdkdisplay-x11.c:
Set _NET_STARTUP_ID hint on display's group leader window.
* gtk/gtkwindow.c (gtk_window_set_auto_startup_notification):
function to toggle whether we automatically broadcast that we've
started up, after mapping the first toplevel window.
(gtk_window_map): call gdk_screen_notify_startup_complete() by
default, unless enabled by above.
* gtk/gtkmain.c gtk/gtkcombo.c gtk/gtktoolbar.c:
Couple of warning fixes.
Matthias Clasen [Fri, 1 Nov 2002 00:02:05 +0000 (00:02 +0000)]
The label is "Folders" now, not "Directories". (#97224, Vitaly Tishkov)
* gtk/tmpl/gtkfilesel.sgml: The label is "Folders" now, not
"Directories". (#97224, Vitaly Tishkov)
* gtk/tmpl/gtkrc.sgml: Fix a link. Add (minimal) docs for setting
style properties from rc files. More needed !!
Owen Taylor [Thu, 31 Oct 2002 21:12:23 +0000 (21:12 +0000)]
Add a --screen option for setting the default screen. (Based on a patch
Thu Oct 31 12:40:39 2002 Owen Taylor <otaylor@redhat.com>
* gdk/gdk.[ch] gdk/gdkglobals.c gdk/gdkinternals.h
gdk/{x11,win32,linux-fb}/gdkscreen-{x11,win32,linux-fb}.c:
Add a --screen option for setting the default screen.
(Based on a patch from Balamurali Viswanathan, #81145)
* gdk/gdk.c gdkdisplay.h gtk/gtkmain.c: Add
gdk_display_open_default_libgtk_only(), so gtk_init_check()
and gdk_init_check() can share the same behavior w.r.t.
--screen.
* gdk/gdk.[ch]: Make gdk_get_display_arg_name() G_CONST_RETURN.
* gdk/x11/gdkselection-x11.c (gdk_selection_property_get):
Suppress a spurious warning.
* tests/testgtkrc: Remove someleft-over commented out
includes that could be confusing.
Tor Lillqvist [Mon, 28 Oct 2002 20:48:40 +0000 (20:48 +0000)]
Don't call GetWindowLong for GWL_EXSTYLE, the extended window style wasn't
2002-10-28 Tor Lillqvist <tml@iki.fi>
* gdk/win32/gdkwindow-win32.c (gdk_window_set_decorations,
gdk_window_set_functions): Don't call GetWindowLong for
GWL_EXSTYLE, the extended window style wasn't used or
changed. After setting the window style with SetWindowLong, call
SetWindowPos with the SWP_FRAMECHANGED flag for the window to
actually be updated, as Platform SDK docs say one should. (#95812,
huzheng)
This fixes a scrolling bug. Shouldn't cause problems, but you never know
Sun Oct 27 15:58:30 2002 Kristian Rietveld <kris@gtk.org>
This fixes a scrolling bug. Shouldn't cause problems, but you
never know ... (#81627, testcase by Timo Sirainen).
* gtk/gtktreeview.c (validate_visible_area): add a temporary
implemention for non use_align, always update dy and ->top_row
if we scroll here,
(gtk_tree_view_clamp_node_visible): reimplement using
_scroll_to_cell (#73895).
Owen Taylor [Fri, 25 Oct 2002 19:59:41 +0000 (19:59 +0000)]
Fix sensitivity of file operation buttons and buttons inside fileop
Fri Oct 25 14:51:34 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c: Fix sensitivity of file operation
buttons and buttons inside fileop dialogs to update
properly based on the contents of the entries.
(#74267, based on part of a patch from Muktha
Narayan)
* gtk/gtkitemfactory.c (gtk_item_factory_create_item):
Warn if loading <ImageItem> image fails.
* tests/testgtk.c: Fix data for "apple" inline pixbuf
to be valid.
Owen Taylor [Fri, 25 Oct 2002 19:57:48 +0000 (19:57 +0000)]
Fix sensitivity of file operation buttons and buttons inside fileop
Fri Oct 25 14:51:34 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c: Fix sensitivity of file operation
buttons and buttons inside fileop dialogs to update
properly based on the contents of the entries.
(#74267, based on part of a patch from Muktha
Narayan)
Soeren Sandmann [Fri, 25 Oct 2002 16:28:14 +0000 (16:28 +0000)]
New GtkPaned keyboard navigation. (Shift-)F8 now cycles the available
Fri Oct 25 18:17:39 2002 Soeren Sandmann <sandmann@daimi.au.dk>
* gtk/gtkpaned.[ch]: New GtkPaned keyboard navigation. (Shift-)F8
now cycles the available handles instead of toggling focus on and
off. Fixes #87160, reported by Calum Benson.
Owen Taylor [Wed, 23 Oct 2002 00:45:18 +0000 (00:45 +0000)]
When popping up the list without any selected items, hack the focus on the
Tue Oct 22 20:02:22 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcombo.c: When popping up the list without
any selected items, hack the focus on the list to
avoid triggering a bug in GtkList when clicking
on focused-but-not-selected items (#86700,
Zimler Attila, Matthias Clasen) and to keep
GtkWindow from selecting the first item.
* tests/testgtk.c (create_list): Make the initial
setting of the selection mode correspond to the option
menu.
Another feature to create truly ugly TreeViews!: style properties for the
Wed Oct 23 01:03:43 2002 Kristian Rietveld <kris@gtk.org>
Another feature to create truly ugly TreeViews!: style properties
for the even/odd colors used for row hinting. (#71595, reported
by Owen Taylor).
* gtk/gtktreeview.c (gtk_tree_view_class_init): add even_row_color
and odd_row_color style properties.
* gtk/gtkstyle.c (get_darkened_gc): support darken_count == 0 case,
(gtk_default_draw_flat_box): rework cell coloring code to support
user-provided even/odd row colors.
Wed Oct 23 01:01:52 2002 Kristian Rietveld <kris@gtk.org>
Cache signal IDs to speed up signal emission. This is a good speedup
because GtkTreeModel emits a big number of signals.
* gtk/gtktreemodel.c (gtk_tree_model_base_init): save IDs returned
by g_signal_new,
(gtk_tree_model_row_changed): use g_signal_emit instead of
g_signal_emit_by_name,
(gtk_tree_model_row_inserted): ditto,
(gtk_tree_model_row_has_child_toggled): ditto,
(gtk_tree_model_row_deleted): ditto,
(gtk_tree_model_rows_reordered): ditto.
Wed Oct 23 00:56:15 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeselection.c (model_changed): new function,
(gtk_tree_selection_selected_foreach): monitor changes in the model,
bail out if the model has been changed from the foreach func.
(#50263, reported by Havoc Pennington).
* gtk/gtktreeselection.c (_gtk_tree_selection_internal_select_node):
free anchor if applicable (#94868, reported and testcase provided by
Daniel Elstner).
Owen Taylor [Tue, 22 Oct 2002 20:00:31 +0000 (20:00 +0000)]
Fix handling of getting the default style/icon size from the correct
Tue Oct 22 15:55:08 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtktoolbar.c: Fix handling of getting the
default style/icon size from the correct
GtkSettings. (#82184, reported by Vitaly Tishkov,
help from Soeren Sandmann)
Matthias Clasen [Tue, 22 Oct 2002 18:04:44 +0000 (18:04 +0000)]
It is called GtkStatusbar, not GtkStatusBar. This was changed accidentally
* gtk/gtkstatusbar.c (gtk_statusbar_get_type):
(gtk_statusbar_class_init): It is called GtkStatusbar, not
GtkStatusBar. This was changed accidentally during deprecation
cleanup and caused links in the API docs to break. (#96390)
Owen Taylor [Mon, 21 Oct 2002 19:04:18 +0000 (19:04 +0000)]
Return "" for entry->invisible_char == 0, otherwise N copies of
Mon Oct 21 14:04:39 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkentry.c (gtk_entry_get_public_chars): Return
"" for entry->invisible_char == 0, otherwise N copies
of entry->invisible_char. (#95486, Vitaly Tishkov)
* gtk/gtkentry.c: Fix a bunch of places where entry->text
instead of layout->text was being used for computation
of offsets/indices in the layout. Using layout->text
is necessary because when the entry is invisible, it
doesn't correspond to entry->text.
- make the delay before submenus appear below menu bars a
GtkSetting
- make the delay before submenus pops up a GtkSetting
- make the stay up triangle slightly larger
- don't pop up the first submenu immediately.
- make the default delay for submenus 225 ms, and 0 for menubars.
- make the default delay before popping down inside the stay-up
triangle 1000 ms
Owen Taylor [Fri, 18 Oct 2002 19:26:43 +0000 (19:26 +0000)]
Fix use of uninitialized variable.
Thu Oct 17 17:17:05 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcheckbutton.c (gtk_check_button_size_request):
Fix use of uninitialized variable.
Thu Oct 17 14:38:37 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkaccellabel.c (gtk_accel_label_expose_event):
Align the baseline of the accelerator label with the
first baseline of the main label of the menu item. (#76593)
Wed Oct 16 18:25:24 2002 Owen Taylor <otaylor@redhat.com>
* gdk/x11/gdkevents-x11.c (translate_key_event):
Use gdk_keymap_translate_keyboard_state() rather than
XLookupString() to get the keysymbol, since XLookupString
can confuse the input method handling. (#93575)
* gdk/x11/gdkkeys-x11.c: Rewrite the handling of
key translation for the non-XKB case to properly
handle Shift_Lock, Caps_Lock, Num_Lock according
to the Xlib spec. (#67066)
Havoc Pennington [Thu, 17 Oct 2002 20:24:03 +0000 (20:24 +0000)]
add g_return_if_fail for monitor number <= 0
2002-10-16 Havoc Pennington <hp@redhat.com>
* gdk/x11/gdkscreen-x11.c (gdk_screen_get_monitor_geometry): add
g_return_if_fail for monitor number <= 0
* gtk/gtkmenu.c (gtk_menu_position): handle case where pointer
is outside the screen.
* gtk/gtkwindow.c (get_monitor_center): factor out
the code to position a window in center
(gtk_window_compute_configure_request): use here
(gtk_window_constrain_position): use here, the
code here wasn't multihead-aware
* gdk/x11/gdkevents-x11.c (get_real_window): function to
return the window the event describes, rather than the window
that received the event.
(gdk_event_translate): use result of that function for
filling in GdkEvent::window, which only matters for
MapNotify/UnmapNotify and ConfigureNotify, in practice.
Unbreaks various things using SubstructureNotifyMask.
Owen Taylor [Thu, 17 Oct 2002 20:20:52 +0000 (20:20 +0000)]
Make the widgets work reasonably when they don't have children -- draw the
Thu Oct 17 16:13:28 2002 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcheckbutton.c gtk/gtkradiobutton.c: Make
the widgets work reasonably when they don't have
children -- draw the focus around the indicator,
and position the indicator symmetrically.
(#74830, Dave Camp)
* tests/testgtk.c: Add no-child portions to check and radio
button tests.
Behaviour change, apply changes if the entry of the editable gets a focus
Tue Oct 15 00:53:14 2002 Kristian Rietveld <kris@gtk.org>
Behaviour change, apply changes if the entry of the editable gets
a focus out event (#82405).
* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_focus_out_event):
new function,
(gtk_cell_renderer_text_start_editing): stop editing and apply
changes on focus-out.
Tue Oct 15 00:47:35 2002 Kristian Rietveld <kris@gtk.org>
Fixes an *evil* GtkTreeModelSort bug, #93629.
* gtk/gtktreemodel.c (release_row_references): return if the
refs->list is NULL.
* gtk/gtktreemodelsort.c (gtk_tree_model_sort_row_changed): if we
are swapping two rows (re-insertion on row_changed), also *emit*
a rows_reordered signal. oops.
Tue Oct 15 00:45:03 2002 Kristian Rietveld <kris@gtk.org>
* gtk/gtkliststore.c (gtk_list_store_remove_silently): free
the actual link after the node has been removed (#92014).
* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_column_finalize):
free the cell_list and the child if the exists (#92014).
Tue Oct 15 00:40:25 2002 Kristian Rietveld <kris@gtk.org>
Don't accept drops if the model has been sorted, #93758)
* gtk/gtkliststore.c (gtk_list_store_row_drop_possible): return
FALSE if the list has been sorted.
* gtk/gtktreestore.c (gtk_tree_store_row_drop_possible): check
if drag_dest is a TreeStore, return FALSE if the tree has been
sorted.
Tue Oct 15 00:33:59 2002 Kristian Rietveld <kris@gtk.org>
Owen Taylor [Mon, 14 Oct 2002 19:19:08 +0000 (19:19 +0000)]
- Make GtkXIMInfo structures per-screen (they were a mix between
Mon Oct 14 15:10:34 2002 Owen Taylor <otaylor@redhat.com>
* modules/input/gtkimcontextxim.c:
- Make GtkXIMInfo structures per-screen (they were
a mix between per-display and per-context before)
- Make signal connections info->settings one-per-info
- Handle a GdkDisplay being closed, by destroying
all XIC, calling XCloseIM on the XIM. (#87482)
Manish Singh [Sat, 12 Oct 2002 22:45:08 +0000 (22:45 +0000)]
use GTK_IS_RADIO_MENU_ITEM instead of comparing the type directly. This
Sat Oct 12 15:44:29 2002 Manish Singh <yosh@gimp.org>
* gtk/gtkitemfactory.c: use GTK_IS_RADIO_MENU_ITEM instead
of comparing the type directly. This handles possible subclasses
too. (Recommended by Tim Janik)