Michael Natterer [Sat, 15 Sep 2007 16:48:56 +0000 (16:48 +0000)]
don't simply crash if any of the pointer args are NULL. Instead,
2007-09-15 Michael Natterer <mitch@imendio.com>
* gtk/gtkselection.c (gtk_target_list_find): don't simply crash if
any of the pointer args are NULL. Instead, g_return_if_fail() on
"list != NULL" and allow to pass NULL as return location for "info".
the tooltip-column property getter needs to set an integer, not a boolean.
2007-09-14 Kristian Rietveld <kris@gtk.org>
* gtk/gtktreeview.c (gtk_tree_view_get_property): the tooltip-column
property getter needs to set an integer, not a boolean. (#476689,
spotted and patch by Christian Persch).
if cell is set, always pass in path to gtk_tree_view_get_cell_area()
2007-09-13 Kristian Rietveld <kris@imendio.com>
* gtk/gtktreeview.c (gtk_tree_view_set_toooltip_cell): if cell
is set, always pass in path to gtk_tree_view_get_cell_area() whether
it is NULL or set. Added explanatory comment and added this
side case to the API documentation.
Use the "document-open-recent" icon for the the Recently Used shortcut in
2007-09-12 Emmanuele Bassi <ebassi@gnome.org>
* gtk/gtkfilechooserdefault.c (render_recent_icon): Use the
"document-open-recent" icon for the the Recently Used shortcut
in the file chooser. (#306445)
* gtk/Makefile.am:
* gtk/stock-icons/16/document-open-recent.png:
* gtk/stock-icons/16/document-open-recent.svg:
* gtk/stock-icons/24/document-open-recent.png:
* gtk/stock-icons/24/document-open-recent.svg: Add the
"document-open-recent" icon to the builtin theme we provide
as a fallback.
* gdk/gdk.symbols:
* gdk/gdkwindow.[ch]
(gdk_window_freeze_toplevel_updates_libgtk_only),
(gdk_window_thaw_toplevel_updates_libgtk_only): new functions
to freeze a toplevel window and all its descendants. To be made
public in 2.14,
(gdk_window_schedule_update): return if toplevel is frozen,
(gdk_window_process_all_updates): defer processing updates if toplevel
is frozen.
* gtk/gtkwindow.c (gtk_window_configure_event): directly size
allocate for override redirect windows, freeze toplevel and
descendants otherwise and wait until resizing is done.
Michael Natterer [Tue, 11 Sep 2007 18:54:00 +0000 (18:54 +0000)]
remove useless member "has_title" from the private struct and simply set
2007-09-11 Michael Natterer <mitch@imendio.com>
* gtk/gtkfilechooserbutton.c: remove useless member "has_title"
from the private struct and simply set the default title in
constructor() whenever we create a dialog or the supplied one has
no title. Also accept RESPONSE_ACCEPT *and* RESPONSE_OK as
affirmative responses and document that accordingly. Fixes bug
#436576. Fixed all compiler warnings in the file.
Michael Natterer [Tue, 11 Sep 2007 17:38:12 +0000 (17:38 +0000)]
Make sure menu_shell->button gets reset to 0 when we bail out early here
2007-09-11 Michael Natterer <mitch@imendio.com>
* gtk/gtkmenu.c (gtk_menu_button_release): Make sure
menu_shell->button gets reset to 0 when we bail out early here
instead of chaining up, so it is in a consistent state for the
next press/release in GtkMenuShell. Fixes bug #449371.
when creating a new box, be sure to transfer a possible tooltip from the
2007-09-10 Kristian Rietveld <kris@imendio.com>
* gtk/gtkmenutoolbutton.c (gtk_menu_tool_button_construct_contents):
when creating a new box, be sure to transfer a possible tooltip from
the old to the new box. (Fixes #458283, reported by Christian Persch).
Add a bounding box test that will avoid getting the individual cell boxes
2007-09-09 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkiconview.c (gtk_icon_view_item_hit_test): Add a
bounding box test that will avoid getting the individual cell
boxes if they haven't been calculated yet. (#404541)
Update the documentation to mark the optional constructors parameters. The
2007-09-09 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkaction.c:
* gtk/gtkradioaction.c:
* gtk/gtkrecentaction.c:
* gtk/gtktoggleaction.c: Update the documentation to mark
the optional constructors parameters. The GtkAction::name
property is required, instead, as it is used by GtkUIManager
to find the action object from the XML. (#450032, Murray Cumming,
patch by Emmanuele Bassi)
Remove trailing commas from enumerations, since some compilers don't like
2007-09-09 Matthias Clasen <mclasen@redhat.com>
* gtk/gtklinkbutton.c:
* gtk/gtkrecentfilter.c:
* gtk/gtkprinteroptionwidget.c: Remove trailing commas from
enumerations, since some compilers don't like them. (#467717)
Don't assume that a path of depth 0 has no indices. (#467324, Szilard
2007-09-09 Matthias Clasen <mclasen@redhat.com>
* gtk/gtktreemodelfilter.c (gtk_tree_model_filter_rows_reordered):
* gtk/gtktreemodelsort.c (gtk_tree_model_sort_rows_reordered): Don't
assume that a path of depth 0 has no indices. (#467324, Szilard
Pfeiffer)
* gtk/gtktreeview.c (gtk_tree_view_class_init): change left/right
keybindings to collapse/expand rows instead of moving the focus
cursor. (#105895, Brian Bober and others).
Revert the clamping of cursor coordinates, since it causes really ugly
2007-09-08 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkstyle.c (draw_insertion_cursor): Revert the clamping
of cursor coordinates, since it causes really ugly drawing
artifacts with horizontal scrolling. (#471215, Yevgen Muntyan)
Apply a number of patches by Xan Lopez to improve the interaction between
2007-09-08 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkentrycompletion.c:
* gtk/gtkentry.c: Apply a number of patches by Xan Lopez
to improve the interaction between actions and inline
selection. (#471132)
Add an internal child name for the notebook, so that GtkBuilder can be
2007-09-07 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkprintunixdialog.c: Add an internal child name for
the notebook, so that GtkBuilder can be used to add custom tabs.
(#472951, Christian Persch)
Initialize error to NULL before calling g_set_error(). Should fix #473954,
2007-09-06 Matthias Clasen <mclasen@redhat.com>
* gtk/gtkfilechooserdefault.c (shortcuts_drop_uris): Initialize
error to NULL before calling g_set_error(). Should fix #473954,
reported by Sebastien Bacher.