* gtk/gtkhandlebox.c: Grab on widget->window,
not on handlebox->bin_window. This means we don't
have to worry about ungrabbing while reparenting.
Don't make a GTK+ grab - that wasn't necessary.
* gtk/gtkhandlebox.c: Only compute the root -> desk
offset once, when starting the drag, instead
of continuously. This should solve the *Bad Window*
errors that were occurring because of race conditions
with the WM.
* gtk/gtkhandlebox.c: Completely reworked the
the logic of reattachment. We introduce the
concept of the "snap edge", which is an edge
that needs to be aligned for reattachmed.
We set a reasonable default from
handlebox->handle_position, but an application
might want to change this in some circumstances.
If the focus widget is the same, but does not currently
have the focus, call gtk_window_set_focus(). This is needed
so that click focusing with GtkPlug works correctly.
Tim Janik [Wed, 10 Feb 1999 16:37:09 +0000 (16:37 +0000)]
applied patch from Paolo Molaro to fix GTK_TYPE_POINTER args of
Wed Feb 10 15:49:16 1999 Tim Janik <timj@gtk.org>
* gtk/gtkwindow.c (gtk_window_class_init):
* gtk/gtkctree.c (gtk_ctree_class_init): applied patch from Paolo
Molaro to fix GTK_TYPE_POINTER args of ::tree_collapse and
::set_focus signals.
* docs/gtk_tut.sgml: s/menufactory/itemfactory, minor fixups
to the item factory example.
Tim Janik [Wed, 10 Feb 1999 08:06:30 +0000 (08:06 +0000)]
asure that ->value_buf always points to an allocated area.
Wed Feb 10 08:35:36 1999 Tim Janik <timj@gtk.org>
* gtk/gtkcolorsel.c (gtk_color_selection_draw_value_bar): asure that
->value_buf always points to an allocated area.
(gtk_color_selection_drag_end): new function hooked up to drag_end to
destroy the drag_window.
* gtk/gtkdnd.c: some coding style fixups.
Wed Feb 10 06:47:17 1999 Tim Janik <timj@gtk.org>
* gdk/gdkwindow.c: various indentation fixes.
* gdk/gdkevents.c: coding style fixups.
NULL initialize event_func, event_notify and event_chunk.
(expose_predicate): made this function static.
(gdk_event_handler_set): perform destroy notification even if no
event_func is set.
Owen Taylor [Wed, 10 Feb 1999 02:35:09 +0000 (02:35 +0000)]
Fixed some bugs with set_default_size.
Sun Feb 7 19:49:21 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwindow.c (gtk_window_move_resize): Fixed some
bugs with set_default_size.
Sat Feb 6 13:23:51 1999 Owen Taylor <otaylor@redhat.com>
* docs/Changes-1.2.txt: Added information about
the change to gtk_widget_size_request().
* gtk/gtkentry.c: Call gtk_widget_get_child_requisition
explicitely since we differentiate between the usize
set by the user and what we got. (Ugh)
* gtk/gtkwidget.[ch] (gtk_widget_get_child_requisition):
New function to return the effective size of a widget
as it looks to its parent.
* gtk/gtkwidget.c (gtk_widget_size_request): Leave
widget->requisition set to exactly what the widget
asked for, and then make a copy of that into
the requisition argument. Allow a NULL requisition
argument, and, if G_ENABLE_DEBUG, warn if
requisition == &widget->requisition.
Lars Hamann [Mon, 8 Feb 1999 21:03:54 +0000 (21:03 +0000)]
changed to 64 (gtk_clist_draw_focus) (hadjustment_value_changed)
Mon Feb 8 21:00:20 1999 Lars Hamann <lars@gtk.org>
* gtk/gtkclist.c (CLIST_OPTIMUM_SIZE): changed to 64
(gtk_clist_draw_focus) (hadjustment_value_changed) (draw_row):
few fixes to respect GTK_CAN_FOCUS flag.
Owen Taylor [Fri, 5 Feb 1999 18:40:14 +0000 (18:40 +0000)]
Adjust saved positions of children when resizing a guffaw_gravity = TRUE
Fri Feb 5 13:23:50 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_move_resize): Adjust
saved positions of children when resizing a
guffaw_gravity = TRUE window.
* gtk/gtkdnd.c (gtk_drag_highlight): Rework the
highlighting so that it is done in callbacks for
draw and expose. This should solve problems with
multiple highlights for the same GdkWindow.
* gtk/gtkdnd.c (gtk_drag_highlight): Fix bug where
the highlight was being drawn with an incorrect
width/height for !NO_WINDOW widgets.
Owen Taylor [Fri, 5 Feb 1999 15:48:25 +0000 (15:48 +0000)]
Don't assume any more that the gtkwidget.c code will queue a redraw on us
1999-02-05 Owen Taylor <otaylor@gtk.org>
* gtk/gtk[hv]paned.c (gtk_[hv]paned_size_allocate):
Don't assume any more that the gtkwidget.c code
will queue a redraw on us during a size_allocate -
queue clear/draws as appropriate for our groove.
Owen Taylor [Tue, 2 Feb 1999 18:40:47 +0000 (18:40 +0000)]
Make sure we set the icon window position before it is shown to prevent
Tue Feb 2 12:39:42 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkdnd.c: Make sure we set the icon window position
before it is shown to prevent annoying flicking to 0,0.
Make it consistent that info->cur_x/y do not include
info->hot_x/y displacement.
Owen Taylor [Mon, 1 Feb 1999 21:05:32 +0000 (21:05 +0000)]
Cast uints to ints in geometry calculations. This should prevent FP
Mon Feb 1 14:54:28 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtklabel.c (gtk_label_expose): Cast uints
to ints in geometry calculations. This should
prevent FP exceptions on FreeBSD when quantities
become negative. [ Actually, this is probably
a workaround with a gcc bug with handling of
bitfields, according to Ben Jackson <ben@ben.com> ]
- New sections on the Fixed and Frame containers - Rearrange the
Fri Jan 29 09:18:41 GMT 1999 Tony Gale <gale@gtk.org>
* docs/gtk_tut.sgml:
- New sections on the Fixed and Frame containers
- Rearrange the Containers section so the easier ones
are first
- Move the List widget section to an appendix
- Replace all uses of deprecated functions. - Replace menufactory example
Thu Jan 28 10:16:28 GMT 1999 Tony Gale <gale@gtk.org>
* docs/gtk_tut.sgml:
- Replace all uses of deprecated functions.
- Replace menufactory example with itemfactory example
from Nick Scott <mendigo@geocities.com>
- Minor bug fixes in the examples.
Owen Taylor [Thu, 28 Jan 1999 04:12:58 +0000 (04:12 +0000)]
Move gravity_works back to a static global variable, since it is a global
Wed Jan 27 23:05:55 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtklayout.[ch] (gtk_layout_realize): Move
gravity_works back to a static global variable,
since it is a global constant, and this way we
keep structure sizes uniform.
CV: ---------------------------------------------------------------------- CVS: Enter Log. Lines beginning with `CVS: ' are removed automatically
Owen Taylor [Thu, 28 Jan 1999 03:38:58 +0000 (03:38 +0000)]
[ patch from Takashi Matsuda <matsu@arch.comp.kyutech.ac.jp> ]
Wed Jan 27 21:56:07 1999 Owen Taylor <otaylor@redhat.com>
[ patch from Takashi Matsuda <matsu@arch.comp.kyutech.ac.jp> ]
* acconfig.h configure.in gdk/gdkim.c: Add configure
flag for disabling XRegisterIMInstantiateCallback(), default
it to off for Solaris. Always try to open the
input method immediately, and only if that fails,
register than instantiate callback.
* gdk/gdkentry.c: Some tweaks to make sure that we
only get and set the IC attributes when appropriate.
Owen Taylor [Thu, 28 Jan 1999 01:04:38 +0000 (01:04 +0000)]
Patch from Sebastian Wilhelmi <wilhelmi@ira.uka.de> to use
Wed Jan 27 20:08:54 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkfilesel.c (open_user_dir): Patch from
Sebastian Wilhelmi <wilhelmi@ira.uka.de> to
use g_get_home_dir() instead of calling getpwuid()
ourselves.
Owen Taylor [Thu, 28 Jan 1999 01:03:15 +0000 (01:03 +0000)]
Change signatures for gdk_drag_begin() and gdk_drag_motion() so that the
Wed Jan 27 18:57:57 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdk.h gdk/gdkdnd.c: Change signatures for
gdk_drag_begin() and gdk_drag_motion() so that the set
of possible actions is passed on each motion, not just at
the beginning of the drag. We do this so that
we can restrict the set of possible drag events
when the user presses a modifier key during a
drag.
* gdk/gdkdnd.c: Send a motif Operation-changed
message when the set of possible actions change,
as well as when the suggested action change.
* gdk/gdkdnd.c: Change the XdndActionList whenever
the set of actions change.
* gdk/gdkdnd.c: Add a filter to catch changes to
the XdndActionList property for the source widget.
* gtk/gtkdnd.c: Change the set of possible actions
when the user presses Control, Shift, or Control-Shift,
to only include the corresponding action.
* gtk/gtkdnd.c (gtk_drag_button_release_cb):
Disconnect button signals before we possibly
free info structure.
Owen Taylor [Thu, 28 Jan 1999 00:57:18 +0000 (00:57 +0000)]
Hack scrollwheel support into the eventloop, by treating button 4-5
Wed Jan 27 18:40:50 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkmain.c (gtk_main_do_event): Hack scrollwheel
support into the eventloop, by treating button 4-5
presses on scrolled windows and scrollbars specially.
Put it here to keep the ugliness small and confined.
(We need to intercept the normal propagation in any case
to have this work reliably right now, since some
subwidgets will trap the button presses)
* gtk/gtkviewport.c (gtk_viewport_realize): Select for
BUTTON_PRESS to support the above hack.
Owen Taylor [Wed, 27 Jan 1999 23:49:34 +0000 (23:49 +0000)]
Remove TimJ's checks for already being mapped or hidden. See the ICCCM's
Tue Jan 26 14:02:50 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's
checks for already being mapped or hidden. See
the ICCCM's section on state changes for why this
is a bad idea.
Owen Taylor [Wed, 27 Jan 1999 22:08:46 +0000 (22:08 +0000)]
Separate out GLIB_LIBS and GLIB_DEPLIBS. This may fix the --with-glib
Wed Jan 27 17:05:40 1999 Owen Taylor <otaylor@redhat.com>
* Separate out GLIB_LIBS and GLIB_DEPLIBS. This
may fix the --with-glib option. GLIB_LIBS are
the libs to link example programs against, while
GLIB_DEPLIBS are dependency libraries.
Owen Taylor [Wed, 27 Jan 1999 18:21:20 +0000 (18:21 +0000)]
Use floor() instead of truncating to integer values so we get translation
Wed Jan 20 11:19:00 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtklabel.c: Use floor() instead of truncating
to integer values so we get translation invariance.
* gtk/gtklayout.c (gtk_layout_size_allocate): Set upper
and lower values for adjustments in size_allocate().
* gdk/gdkwindow.c gdk/gdk.h gdk/gdkprivate.h: New
function gdk_window_set_static_gravities() to set
up a window for guffaw scrolling.
* gdk/gdkwindow.c (gdk_window_internal_destroy): Set flags
indicating destroyed state before cleanup.
* gtk/gtkprivate.h gtk/gtkwidget.c: Add a new
private flag IS_OFFSCREEN. If set, this indicates
to GTK+ that the widget is not to be considered
viewable regardless of its map state. Queued draws
on offscreen widgets are suppressed.
Added new function static gtk_widget_is_offscreen() to
check this flag on a widget and its ancestors.
* gtk/gtklayout.[ch]: Major revisions.
- Use gdk_window_set_static_gravities to set static gravity
on all child windows, and thus avoid having to create a window
for NO_WINDOW children.
- Adjust allocations of children as we scroll them
so queued draws work correctly.
- Don't allocate our children directly in a put()
or move(); just queue a resize() like every other
widget.
* gtk/testgtk.c: Make the arrows on the scrollbars
work, create a larger and more demanding test.
Owen Taylor [Tue, 26 Jan 1999 01:18:13 +0000 (01:18 +0000)]
New functions to set the colormap or visual of an existing widget. These
Mon Jan 25 20:05:22 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwidget.c (gtk_widget_set_{visual,colormap}):
New functions to set the colormap or visual
of an existing widget. These functions should not
be called on a widget that has previosly been
realized.
Owen Taylor [Tue, 26 Jan 1999 01:15:47 +0000 (01:15 +0000)]
New functions to set the colormap or visual of an existing widget. These
Mon Jan 25 20:05:22 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkwidget.c (gtk_widget_set_{visual,colormap}):
New functions to set the colormap or visual
of an existing widget. These functions should not
be called on a widget that has previosly been
realized.
* gtk/gtkcolorsel.c (gtk_color_selection_dialog_init):
Set the visual and colormap on the toplevel dialog,
then push them for the child widgets. As opposed
to push/pop in _new(), this way, things will work
properly with gtk_widget_new().
Owen Taylor [Tue, 26 Jan 1999 00:28:13 +0000 (00:28 +0000)]
Back out the last solution to updating problem. And try a different one
Mon Jan 25 19:00:13 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcolorsel.c (gtk_color_selection_value_events):
Back out the last solution to updating problem. And
try a different one that is less dependent on
the state of the widget. Just redraw the value_marker
when it gets mapped. Somebody needs to analyze
this widget more carefully and figure out
Owen Taylor [Mon, 25 Jan 1999 21:11:13 +0000 (21:11 +0000)]
Don't define ENABLE_NLS unless we have a working NLS. (This should keep
Mon Jan 25 15:47:46 1999 Owen Taylor <otaylor@redhat.com>
* acinclude.m4 (ac_result): Don't define ENABLE_NLS
unless we have a working NLS. (This should keep
libintl.h from being included when it doesn't
exist).
George Lebl [Mon, 25 Jan 1999 19:05:58 +0000 (19:05 +0000)]
set RECEIVES_DEFAULT on init, and a button press on the widget doesn't
Mon Jan 25 11:05:10 1999 George Lebl <jirka@5z.com>
* gtk/gtkbutton.c: set RECEIVES_DEFAULT on init, and a
button press on the widget doesn't grab default anymore
* gtk/gtkcheckbutton.c,gtk/gtkoptionmenu.c,gtk/gtkradiobutton.c:
unset RECEIVES_DEFAULT on init
* gtk/gtkwidget.[ch]: add a RECEIVES_DEFAULT flag to widget
flags
* gtk/gtkwindow.c,gtk/gtkplug.c: on pressing <enter>, activate
the focused widget if it is a RECEIVES_DEFAULT widget,
no matter what the current default_widget is
* gtk/gtkwindow.c: on focus change, migrate the HAS_DEFAULT
flag to CAN_DEFAULT widgets if they RECEIVE_DEFAULT as well
or migrate it back to the default_widget if the focus widget
doesn't "RECEIVE_DEFAULT"
Owen Taylor [Sun, 24 Jan 1999 17:19:21 +0000 (17:19 +0000)]
Fix reversed assertion. (Pointed out by Austin Donnelly
Sun Jan 24 12:17:39 1999 Owen Taylor <otaylor@redhat.com>
* gdk/gdkcolor.c (gdk_colormap_real_destroy): Fix
reversed assertion.
(Pointed out by Austin Donnelly <austin@greenend.org.uk>)
* gtk/gtkruler.c (gtk_ruler_expose): Remove unecessary
and harmful call to gtk_paint_box(). We are going
to paint onto the backing store later anyways.
Owen Taylor [Sat, 23 Jan 1999 20:32:20 +0000 (20:32 +0000)]
X expects longs, not uint32 for XChangeProperty, when format == 32.
Sat Jan 23 11:15:39 1999 Owen Taylor <otaylor@gtk.org>
* gdk/gdkdnd.c (gdk_window_register_dnd): X expects
longs, not uint32 for XChangeProperty, when
format == 32.
* gdk/gdkdnd.c (motif_read_initiator_info): Byte-swap
the MotifInitiatorInfo structure if necessary.
* gdk/gdkdnd.c: When extracting and constructing
Motif DND messages, don't use data.s[], data.l[]
since on 64bit architectures, these won't necessarily
be in the same place with data.b[].
* gtk/testdnd.c (target_drag_drop): Return TRUE for
drag_drop within the drop zone.
* gtk/gtkdnd.c (gtk_drag_dest_handle_event): Only send
a XmTRANSFER_FAILURE if no drop site is found, not
on every drop!
Owen Taylor [Sat, 23 Jan 1999 20:31:42 +0000 (20:31 +0000)]
Add flags field to GtkTargetEntry table.
Fri Jan 22 19:22:39 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkeditable.c: Add flags field to
GtkTargetEntry table.
* gdk/gdkwindow.c (gdk_window_is_viewable): Treat foreign
windows as always viewable, since we can't track their
map-state reliably without speed problems. (Fixes
problem where updating didn't occur properly within
GtkPlug)
Tim Janik [Fri, 22 Jan 1999 08:12:00 +0000 (08:12 +0000)]
take value_spacing into account for GTK_POS_LEFT.
Fri Jan 22 07:33:44 1999 Tim Janik <timj@gtk.org>
* gtk/gtkvscale.c (gtk_vscale_pos_trough): take value_spacing into
account for GTK_POS_LEFT.
* gtk/gtkradiobutton.c (gtk_radio_button_set_group): use
gtk_toggle_button_set_active () to set the new state.
(gtk_radio_button_new): only _set_group if group != NULL.
(gtk_radio_button_clicked): reference the widget.
(gtk_radio_button_init): make radio buttons active upon
startup.
Jeff Garzik [Thu, 21 Jan 1999 22:29:58 +0000 (22:29 +0000)]
Check args for NULL. (gtk_selection_default_handler): Replace manual list
Thu Jan 21 17:13:12 1999 Jeff Garzik <jgarzik@pobox.com>
* gtk/gtkselection.c:
(gtk_selection_property_notify): Check args for NULL.
(gtk_selection_default_handler):
Replace manual list count with call to g_list_length.
Remove signedness of temp var 'count' to agree with usage.
Slight spacing adjustment for readability.
* gtk/gtkbox.c, gtk/gtklayout.c, gtk/gtkselection.c:
Init a few ptrs to NULL, to quiet warnings.
Owen Taylor [Thu, 21 Jan 1999 21:09:03 +0000 (21:09 +0000)]
[ Tried to commit wrong file last time ]
Thu Jan 21 16:03:02 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtktreeitem.c: Add a paint routine, fix up bugs
in drawing where if the expose area was contained
completely in the right side of the tree the background
wasn't redraw, etc.
* gtk/gtktree.c: Add a paint routine, fix up bugs
in drawing where if the expose area was contained
completely in the right side of the tree the background
wasn't redraw, etc.
* gtk/gtkwidget.c (gtk_widget_clip_rect): Fix a bug
in clipping draw regions while propagating them
upwards.
Owen Taylor [Thu, 21 Jan 1999 17:27:23 +0000 (17:27 +0000)]
Pushing and popping the visual/cmap in the init() function does no good,
Thu Jan 21 12:20:51 1999 Owen Taylor <otaylor@redhat.com>
* gtk/gtkcolorsel.c (gtk_color_selection_dialog_new):
Pushing and popping the visual/cmap in the init()
function does no good, because the window itself needs
to be create with that visual/cmap.
So do it in the new() function instead.
This will require people doing gtk_widget_new() to do
the push/pop themselves, but I don't see any way around
it other than digging in and tweaking the window
widget's colormap and visual ourselves, which
is highly non-kosher, but would be safe...
Timur Bakeyev [Thu, 21 Jan 1999 13:26:35 +0000 (13:26 +0000)]
It was reported by Owen Taylor <otaylor@redhat.com>, that LC_ALL produce
Thu Jan 21 16:04:35 1999 Timur Bakeyev <mc@bat.ru>
* gtk/gtkrc.c (gtk_rc_init): It was reported by Owen Taylor
<otaylor@redhat.com>, that LC_ALL produce unparsable garbage
on some glibc'ed systems and HP/UX. So, falling to LC_CTYPE.
Owen Taylor [Thu, 21 Jan 1999 07:08:25 +0000 (07:08 +0000)]
Set and read the XdndActionList property defined in the Xdnd spec. We do
Thu Jan 21 02:11:44 1999 Owen Taylor <otaylor@redhat.com>
* Set and read the XdndActionList property defined
in the Xdnd spec. We do this always, not just for
XdndActionAsk like the spec says, but if we don't
find it, we fall back to actions = suggested_action,
which is compatible with the language of the spec.
Jeff Garzik [Thu, 21 Jan 1999 06:24:09 +0000 (06:24 +0000)]
Move not-null assertion before pointer de-ref.
* gdk/gdkdnd.c (gdk_drag_context_unref):
Move not-null assertion before pointer de-ref.
* gdk/gdkevents.c (gdk_event_queue_find_first):
Fix infinite loop bug. Someone should look at this further to
make sure the events_pending tests are correct.
projects / ~andy / gtk / log