From: Tim Janik Date: Tue, 11 Jul 2000 06:08:24 +0000 (+0000) Subject: eek, i've never seen a bug here, never been here and never fixed anything X-Git-Url: http://pileus.org/git/?a=commitdiff_plain;h=fc5ee9256d7b16abf0ec49319daeca59752d1cb2;p=~andy%2Fgtk eek, i've never seen a bug here, never been here and never fixed anything Tue Jul 11 08:04:58 2000 Tim Janik * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen a bug here, never been here and never fixed anything ;( (don't segfault if tree->root_tree is NULL, which happens prior to widget realization, but puke instead). --- diff --git a/ChangeLog b/ChangeLog index cce9c6d10..c2eda145a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Tue Jul 11 08:04:58 2000 Tim Janik + + * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen + a bug here, never been here and never fixed anything ;( + (don't segfault if tree->root_tree is NULL, which happens prior + to widget realization, but puke instead). + Tue Jul 11 06:38:42 2000 Tim Janik * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0 index cce9c6d10..c2eda145a 100644 --- a/ChangeLog.pre-2-0 +++ b/ChangeLog.pre-2-0 @@ -1,3 +1,10 @@ +Tue Jul 11 08:04:58 2000 Tim Janik + + * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen + a bug here, never been here and never fixed anything ;( + (don't segfault if tree->root_tree is NULL, which happens prior + to widget realization, but puke instead). + Tue Jul 11 06:38:42 2000 Tim Janik * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index cce9c6d10..c2eda145a 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,10 @@ +Tue Jul 11 08:04:58 2000 Tim Janik + + * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen + a bug here, never been here and never fixed anything ;( + (don't segfault if tree->root_tree is NULL, which happens prior + to widget realization, but puke instead). + Tue Jul 11 06:38:42 2000 Tim Janik * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index cce9c6d10..c2eda145a 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,10 @@ +Tue Jul 11 08:04:58 2000 Tim Janik + + * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen + a bug here, never been here and never fixed anything ;( + (don't segfault if tree->root_tree is NULL, which happens prior + to widget realization, but puke instead). + Tue Jul 11 06:38:42 2000 Tim Janik * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index cce9c6d10..c2eda145a 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,10 @@ +Tue Jul 11 08:04:58 2000 Tim Janik + + * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen + a bug here, never been here and never fixed anything ;( + (don't segfault if tree->root_tree is NULL, which happens prior + to widget realization, but puke instead). + Tue Jul 11 06:38:42 2000 Tim Janik * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index cce9c6d10..c2eda145a 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,10 @@ +Tue Jul 11 08:04:58 2000 Tim Janik + + * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen + a bug here, never been here and never fixed anything ;( + (don't segfault if tree->root_tree is NULL, which happens prior + to widget realization, but puke instead). + Tue Jul 11 06:38:42 2000 Tim Janik * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index cce9c6d10..c2eda145a 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,10 @@ +Tue Jul 11 08:04:58 2000 Tim Janik + + * gtk/gtktree.c (gtk_real_tree_select_child): eek, i've never seen + a bug here, never been here and never fixed anything ;( + (don't segfault if tree->root_tree is NULL, which happens prior + to widget realization, but puke instead). + Tue Jul 11 06:38:42 2000 Tim Janik * gtk/gtkrc.h: add xthickness and ythickness to GtkRcStyle and diff --git a/gtk/gtktree.c b/gtk/gtktree.c index 40c9fd79e..a549e0e41 100644 --- a/gtk/gtktree.c +++ b/gtk/gtktree.c @@ -1057,6 +1057,12 @@ gtk_real_tree_select_child (GtkTree *tree, g_return_if_fail (GTK_IS_TREE (tree)); g_return_if_fail (child != NULL); g_return_if_fail (GTK_IS_TREE_ITEM (child)); + + if (!tree->root_tree) + { + g_warning (G_STRLOC ": unable to select a child in a tree prior to realization"); + return; + } root_selection = tree->root_tree->selection;