From: Thomas Meyer <thomas@m3y3r.de>
Date: Mon, 16 Sep 2013 21:19:54 +0000 (+0200)
Subject: drm/msm: Odd PTR_ERR usage
X-Git-Tag: v3.12-rc3~7^2^2~3
X-Git-Url: http://pileus.org/git/?a=commitdiff_plain;h=e4826a94c7444698725572f3def3686fb3f38d6d;p=~andy%2Flinux

drm/msm: Odd PTR_ERR usage

The variable priv->kms is not initialized yet.

Found by "scripts/coccinelle/tests/odd_ptr_err.cocci".
PTR_ERR should access the value just tested by IS_ERR.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 008d772384c..fe03f9c2609 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -199,7 +199,7 @@ static int msm_load(struct drm_device *dev, unsigned long flags)
 		 * imx drm driver on iMX5
 		 */
 		dev_err(dev->dev, "failed to load kms\n");
-		ret = PTR_ERR(priv->kms);
+		ret = PTR_ERR(kms);
 		goto fail;
 	}