From: Anton Vorontsov Date: Fri, 25 Jun 2010 12:20:53 +0000 (+0400) Subject: ahci_platform: Remove unneeded ahci_driver.probe assignment X-Git-Tag: v2.6.36-rc1~535^2~14 X-Git-Url: http://pileus.org/git/?a=commitdiff_plain;h=da10a2002cf25a11f18fa1b5e327b9ed717f819c;p=~andy%2Flinux ahci_platform: Remove unneeded ahci_driver.probe assignment The driver is using platform_driver_probe() during initialization, so ahci_driver.probe hook is never used. But it causes the following (harmless, luckily) section mismatch: WARNING: vmlinux.o(.data+0x2fb20): Section mismatch in reference from the variable ahci_driver to the function .init.text:ahci_probe() This patch removes the ahci_driver.probe assignment, thus fixes the warning. p.s. Note that there's another patch[1] from Rene Bolldorf that tried to solve the same issue by __refdata annotation. __refdata says that this reference is actually OK, but in fact it is not OK, because dereferencing .probe() will cause problems. So the proper fix is to remove the assignment. [1] http://kerneltrap.org/mailarchive/linux-kernel/2010/3/18/4549547 Signed-off-by: Anton Vorontsov Signed-off-by: Jeff Garzik --- diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index 68ef6b563b7..4e97f33cca4 100644 --- a/drivers/ata/ahci_platform.c +++ b/drivers/ata/ahci_platform.c @@ -171,7 +171,6 @@ static int __devexit ahci_remove(struct platform_device *pdev) } static struct platform_driver ahci_driver = { - .probe = ahci_probe, .remove = __devexit_p(ahci_remove), .driver = { .name = "ahci",