From: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Date: Tue, 14 Nov 2006 15:19:45 +0000 (-0200)
Subject: [DCCP] ACKVEC: Optimization - Do not traverse records if none will be found
X-Git-Tag: v2.6.20-rc2~6^2~13^2~382
X-Git-Url: http://pileus.org/git/?a=commitdiff_plain;h=d23ca15a21804631d8f787a0cc5646df81b9c2ea;p=~andy%2Flinux

[DCCP] ACKVEC: Optimization - Do not traverse records if none will be found

Do not traverse the list of ack vector records [proportional to window size]
when we know we will not find what we are looking for.  This is especially
useful because ack vectors are checked twice:
1) Upon parsing of options.
2) Upon notification of a new ack.

All of the work will occur during check #1.  Therefore, when check #2 is
performed, no new work will be done.  This is now "detected" and there is no
performance hit when doing #2.

Signed-off-by: Andrea Bittau <a.bittau@cs.ucl.ac.uk>
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
---

diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c
index 0c54b89a4e9..bd20a2c55e2 100644
--- a/net/dccp/ackvec.c
+++ b/net/dccp/ackvec.c
@@ -383,7 +383,8 @@ void dccp_ackvec_check_rcv_ackno(struct dccp_ackvec *av, struct sock *sk,
 				      (unsigned long long)avr->dccpavr_ack_ackno);
 			dccp_ackvec_throw_record(av, avr);
 			break;
-		}
+		} else if (avr->dccpavr_ack_seqno > ackno)
+			break; /* old news */
 	}
 }