From: Carlos Garnacho <carlosg@gnome.org>
Date: Mon, 30 May 2011 17:04:22 +0000 (+0200)
Subject: gtkcssprovider: Use g_slice_dup() to copy GValues around
X-Git-Url: http://pileus.org/git/?a=commitdiff_plain;h=747dc65c2c8ac1b3ec21e254af2291cfdbb0074e;p=~andy%2Fgtk

gtkcssprovider: Use g_slice_dup() to copy GValues around

GValues stored in GtkCssRulesets are gslice managed, so don't
g_memdup() GValues from shorthand properties. This fixes
memory corruptions when reloading contents in a GtkCssProvider.
---

diff --git a/gtk/gtkcssprovider.c b/gtk/gtkcssprovider.c
index d43357338..4fe675921 100644
--- a/gtk/gtkcssprovider.c
+++ b/gtk/gtkcssprovider.c
@@ -1086,9 +1086,9 @@ gtk_css_ruleset_add (GtkCssRuleset          *ruleset,
         {
           const GtkStyleProperty *child;
           GValue *value;
-          
+
           child = _gtk_style_property_lookup (parameters[i].name);
-          value = g_memdup (&parameters[i].value, sizeof (GValue));
+          value = g_slice_dup (GValue, &parameters[i].value);
           gtk_css_ruleset_add (ruleset, child, value);
         }
       g_free (parameters);